René's URL Explorer Experiment


Title: src: fix invalid windowBits=8 gzip segfault by bnoordhuis · Pull Request #33045 · nodejs/node · GitHub

Open Graph Title: src: fix invalid windowBits=8 gzip segfault by bnoordhuis · Pull Request #33045 · nodejs/node

X Title: src: fix invalid windowBits=8 gzip segfault by bnoordhuis · Pull Request #33045 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: { windowBits: 8 } is legal for deflate streams but not gzip streams. Fix a nullptr dereference when formatting the error message. Bug introduced in commit c34eae5 ("zlib: refactor zlib interna...

X Description: { windowBits: 8 } is legal for deflate streams but not gzip streams. Fix a nullptr dereference when formatting the error message. Bug introduced in commit c34eae5 ("zlib: refactor zlib int...

Opengraph URL: https://github.com/nodejs/node/pull/33045

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:249e6a7e-931c-aa25-9684-2528ba98bda0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCB72:3C4A99:3E6C62:511277:6AED2042
html-safe-nonce1435a2eba4729a880cf145aa846dc54e0421f1be01d6b986165a075b657d76d4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjcyOjNDNEE5OTozRTZDNjI6NTExMjc3OjZBRUQyMDQyIiwidmlzaXRvcl9pZCI6IjM3ODgzODg5MjMyNzY1OTkzNjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0b3adc7a66ddcfc4480fcbc7c5683280149d7a25f0771c1dcfccc583dc2a431b
hovercard-subject-tagpull_request:408720690
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33045/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5c4a5b143c8273d9a3456273a704c90b3d900b2864415b82f1893c2162dedde9/nodejs/node/pull/33045
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5c4a5b143c8273d9a3456273a704c90b3d900b2864415b82f1893c2162dedde9/nodejs/node/pull/33045
og:image:alt{ windowBits: 8 } is legal for deflate streams but not gzip streams. Fix a nullptr dereference when formatting the error message. Bug introduced in commit c34eae5 ("zlib: refactor zlib interna...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33045#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33045
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33045
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33045
Reloadhttps://github.com/nodejs/node/pull/33045
Reloadhttps://github.com/nodejs/node/pull/33045
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix-gzip-windowbits-segfaulthttps://github.com/bnoordhuis/io.js/tree/fix-gzip-windowbits-segfault
Conversationhttps://github.com/nodejs/node/pull/33045
Commits5 (5)https://github.com/nodejs/node/pull/33045/commits
Checkshttps://github.com/nodejs/node/pull/33045/checks
Files changedhttps://github.com/nodejs/node/pull/33045/files
src: fix invalid windowBits=8 gzip segfaulthttps://github.com/nodejs/node/pull/33045#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix-gzip-windowbits-segfaulthttps://github.com/bnoordhuis/io.js/tree/fix-gzip-windowbits-segfault
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Apr 24, 2020https://github.com/nodejs/node/pull/33045#issue-606526439
c34eae5https://github.com/nodejs/node/commit/c34eae5f882c8bb4d58b492caf97cdb08b1dbbcb
Please reload this pagehttps://github.com/nodejs/node/pull/33045
bnoordhuishttps://github.com/bnoordhuis
April 24, 2020 21:12https://github.com/nodejs/node/pull/33045#commits-pushed-9436534
https://github.com/bnoordhuis
src: fix invalid windowBits=8 gzip segfaulthttps://github.com/nodejs/node/pull/33045/commits/9436534e334c4f85e470669019e89b55a36dec7d
9436534https://github.com/nodejs/node/pull/33045/commits/9436534e334c4f85e470669019e89b55a36dec7d
c34eae5https://github.com/bnoordhuis/io.js/commit/c34eae5f882c8bb4d58b492caf97cdb08b1dbbcb
https://github.com/bnoordhuis
zlib: reject windowBits=8 when mode=GZIPhttps://github.com/nodejs/node/pull/33045/commits/1cec86e9622c8cc5e27e986981a5b2dd51b65a2e
1cec86ehttps://github.com/nodejs/node/pull/33045/commits/1cec86e9622c8cc5e27e986981a5b2dd51b65a2e
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
zlib https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Azlib
Apr 24, 2020https://github.com/nodejs/node/pull/33045#event-3270706958
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 24, 2020 https://github.com/nodejs/node/pull/33045#pullrequestreview-400250017
View reviewed changes https://github.com/nodejs/node/pull/33045/files/1cec86e9622c8cc5e27e986981a5b2dd51b65a2e
lib/zlib.jshttps://github.com/nodejs/node/pull/33045/files/1cec86e9622c8cc5e27e986981a5b2dd51b65a2e#diff-2386e2eaad6fb3c2f1de21d9594a6411b12910fc17e4b4f12d37e87ab3f547a4
Please reload this pagehttps://github.com/nodejs/node/pull/33045
src/node_zlib.cchttps://github.com/nodejs/node/pull/33045/files/1cec86e9622c8cc5e27e986981a5b2dd51b65a2e#diff-55807528c167d8a7fc7f345ce23dc5c5e4d4e2635caaf21b90f6153044b4aa39
Please reload this pagehttps://github.com/nodejs/node/pull/33045
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Apr 24, 2020 https://github.com/nodejs/node/pull/33045#pullrequestreview-400259611
View reviewed changes https://github.com/nodejs/node/pull/33045/files/1cec86e9622c8cc5e27e986981a5b2dd51b65a2e
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Apr 24, 2020 https://github.com/nodejs/node/pull/33045#pullrequestreview-400275337
View reviewed changes https://github.com/nodejs/node/pull/33045/files/1cec86e9622c8cc5e27e986981a5b2dd51b65a2e
addaleaxhttps://github.com/addaleax
May 8, 2020 01:39https://github.com/nodejs/node/pull/33045#commits-pushed-4de03b1
https://github.com/addaleax
fixup! zlib: reject windowBits=8 when mode=GZIPhttps://github.com/nodejs/node/pull/33045/commits/4de03b171788dd68a475fc72c7e9d56a688c22cf
4de03b1https://github.com/nodejs/node/pull/33045/commits/4de03b171788dd68a475fc72c7e9d56a688c22cf
https://github.com/addaleax
fixup! src: fix invalid windowBits=8 gzip segfaulthttps://github.com/nodejs/node/pull/33045/commits/40da66df3a89ed13f702cb3d38d4a3e07ba1ab29
40da66dhttps://github.com/nodejs/node/pull/33045/commits/40da66df3a89ed13f702cb3d38d4a3e07ba1ab29
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 7, 2020https://github.com/nodejs/node/pull/33045#event-3315030904
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 7, 2020https://github.com/nodejs/node/pull/33045#issuecomment-625550634
https://ci.nodejs.org/job/node-test-pull-request/31226/https://ci.nodejs.org/job/node-test-pull-request/31226/
Please reload this pagehttps://github.com/nodejs/node/pull/33045
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
May 8, 2020 https://github.com/nodejs/node/pull/33045#pullrequestreview-407943879
View reviewed changes https://github.com/nodejs/node/pull/33045/files/40da66df3a89ed13f702cb3d38d4a3e07ba1ab29
lib/zlib.jshttps://github.com/nodejs/node/pull/33045/files/40da66df3a89ed13f702cb3d38d4a3e07ba1ab29#diff-2386e2eaad6fb3c2f1de21d9594a6411b12910fc17e4b4f12d37e87ab3f547a4
Please reload this pagehttps://github.com/nodejs/node/pull/33045
https://github.com/addaleax
https://github.com/gengjiawen
fixup! zlib: reject windowBits=8 when mode=GZIPhttps://github.com/nodejs/node/pull/33045/commits/61b08c3293e0c4b0c87067722b129ccbdd8884ed
61b08c3https://github.com/nodejs/node/pull/33045/commits/61b08c3293e0c4b0c87067722b129ccbdd8884ed
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 8, 2020https://github.com/nodejs/node/pull/33045#issuecomment-625582790
https://ci.nodejs.org/job/node-test-pull-request/31229/https://ci.nodejs.org/job/node-test-pull-request/31229/
Please reload this pagehttps://github.com/nodejs/node/pull/33045
addaleaxhttps://github.com/addaleax
May 9, 2020 https://github.com/nodejs/node/pull/33045#ref-commit-b8ed2a0
https://github.com/bnoordhuis
https://github.com/addaleax
src: fix invalid windowBits=8 gzip segfaulthttps://github.com/nodejs/node/commit/b8ed2a07d39785880647c2f4adfb95a7322600cb
b8ed2a0https://github.com/nodejs/node/commit/b8ed2a07d39785880647c2f4adfb95a7322600cb
c34eae5https://github.com/nodejs/node/commit/c34eae5f882c8bb4d58b492caf97cdb08b1dbbcb
#33045https://github.com/nodejs/node/pull/33045
addaleaxhttps://github.com/addaleax
May 9, 2020 https://github.com/nodejs/node/pull/33045#ref-commit-d8a380e
https://github.com/bnoordhuis
https://github.com/addaleax
zlib: reject windowBits=8 when mode=GZIPhttps://github.com/nodejs/node/commit/d8a380e13665ef06ffbfa220cb3a7aaaaa17c9fd
d8a380ehttps://github.com/nodejs/node/commit/d8a380e13665ef06ffbfa220cb3a7aaaaa17c9fd
#33045https://github.com/nodejs/node/pull/33045
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 9, 2020https://github.com/nodejs/node/pull/33045#issuecomment-626111530
3226731...d8a380ehttps://github.com/nodejs/node/compare/3226731dec5a82fc2276b571e8c4024b6154de1e...d8a380e13665ef06ffbfa220cb3a7aaaaa17c9fd
Please reload this pagehttps://github.com/nodejs/node/pull/33045
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 9, 2020https://github.com/nodejs/node/pull/33045#event-3319037947
codebyterehttps://github.com/codebytere
May 11, 2020 https://github.com/nodejs/node/pull/33045#ref-commit-ef25033
https://github.com/bnoordhuis
https://github.com/codebytere
src: fix invalid windowBits=8 gzip segfaulthttps://github.com/nodejs/node/commit/ef2503375b7fd48bd544524e4c6365b33d7a42de
ef25033https://github.com/nodejs/node/commit/ef2503375b7fd48bd544524e4c6365b33d7a42de
c34eae5https://github.com/nodejs/node/commit/c34eae5f882c8bb4d58b492caf97cdb08b1dbbcb
#33045https://github.com/nodejs/node/pull/33045
codebyterehttps://github.com/codebytere
May 11, 2020 https://github.com/nodejs/node/pull/33045#ref-commit-736ca65
https://github.com/bnoordhuis
https://github.com/codebytere
zlib: reject windowBits=8 when mode=GZIPhttps://github.com/nodejs/node/commit/736ca65c2ccd7ef8cb0363afed0db50171602745
736ca65https://github.com/nodejs/node/commit/736ca65c2ccd7ef8cb0363afed0db50171602745
#33045https://github.com/nodejs/node/pull/33045
https://github.com/codebytere
codebyterehttps://github.com/codebytere
May 18, 2020 https://github.com/nodejs/node/pull/33045#ref-pullrequest-619852653
v14.3.0 proposal #33452 https://github.com/nodejs/node/pull/33452
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33045#ref-commit-642f813
https://github.com/bnoordhuis
https://github.com/codebytere
src: fix invalid windowBits=8 gzip segfaulthttps://github.com/nodejs/node/commit/642f81317e1091e2cc13bcad8526b2bd73be5e03
642f813https://github.com/nodejs/node/commit/642f81317e1091e2cc13bcad8526b2bd73be5e03
c34eae5https://github.com/nodejs/node/commit/c34eae5f882c8bb4d58b492caf97cdb08b1dbbcb
#33045https://github.com/nodejs/node/pull/33045
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33045#ref-commit-631e433
https://github.com/bnoordhuis
https://github.com/codebytere
zlib: reject windowBits=8 when mode=GZIPhttps://github.com/nodejs/node/commit/631e433cf5f7707612f7f5de4352bd697af47ac1
631e433https://github.com/nodejs/node/commit/631e433cf5f7707612f7f5de4352bd697af47ac1
#33045https://github.com/nodejs/node/pull/33045
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33045#ref-pullrequest-635542822
v12.18.1 proposal #33811 https://github.com/nodejs/node/pull/33811
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33045
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/33045/files/40da66df3a89ed13f702cb3d38d4a3e07ba1ab29
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/33045/files/1cec86e9622c8cc5e27e986981a5b2dd51b65a2e
https://github.com/Flarna
Flarna https://github.com/Flarna
https://github.com/nodejs/node/pull/33045/files/1cec86e9622c8cc5e27e986981a5b2dd51b65a2e
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/33045/files/1cec86e9622c8cc5e27e986981a5b2dd51b65a2e
Please reload this pagehttps://github.com/nodejs/node/pull/33045
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
zlib https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Azlib
Please reload this pagehttps://github.com/nodejs/node/pull/33045
https://github.com/bnoordhuis
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/gengjiawen
https://github.com/devnexen
https://github.com/Flarna
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.