René's URL Explorer Experiment


Title: buffer: don't abort on prototype getters by trevnorris · Pull Request #3302 · nodejs/node · GitHub

Open Graph Title: buffer: don't abort on prototype getters by trevnorris · Pull Request #3302 · nodejs/node

X Title: buffer: don't abort on prototype getters by trevnorris · Pull Request #3302 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Accessing prototype properties directly on a typed array will throw. So do an extra check in Buffer's own getters to verify it is being called on an instance. Fixes: #3297 R=@Fishrock123 ? CI: ...

X Description: Accessing prototype properties directly on a typed array will throw. So do an extra check in Buffer's own getters to verify it is being called on an instance. Fixes: #3297 R=@Fishrock123 ? ...

Opengraph URL: https://github.com/nodejs/node/pull/3302

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7235f3cf-b429-e9a0-6f19-235e5ed5cb2c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D3C:11231F:12D9CC:196283:6A4D8406
html-safe-nonceee165243886233ab3ad1f8e3015b53da6c24654a94c542dbd52c619ad61b1bab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDNDOjExMjMxRjoxMkQ5Q0M6MTk2MjgzOjZBNEQ4NDA2IiwidmlzaXRvcl9pZCI6IjIxMDczNTc0NzU0Mzg5NTM0NzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5796051425a4ccd89085fffaebc2352a098666a997a5a5ffdfaf3a8106c94f0c
hovercard-subject-tagpull_request:47315933
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/3302/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1550c95a560d3eb970e0d7fb58fe4511a993d23aec0d5d786b7cdfe5ce5bf106/nodejs/node/pull/3302
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1550c95a560d3eb970e0d7fb58fe4511a993d23aec0d5d786b7cdfe5ce5bf106/nodejs/node/pull/3302
og:image:altAccessing prototype properties directly on a typed array will throw. So do an extra check in Buffer's own getters to verify it is being called on an instance. Fixes: #3297 R=@Fishrock123 ? CI: ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrevnorris
hostnamegithub.com
expected-hostnamegithub.com
Nonec6bf61c909482ec3072ef5d7a5a28f2a9d214788c9a44793eca1960048cb05ae
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6702a58b419a792226bd21ef0fb1bcb318bbcaa3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/3302#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3302
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3302
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/3302
Reloadhttps://github.com/nodejs/node/pull/3302
Reloadhttps://github.com/nodejs/node/pull/3302
Please reload this pagehttps://github.com/nodejs/node/pull/3302
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/3302
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
trevnorrishttps://github.com/trevnorris
nodejs:masterhttps://github.com/nodejs/node/tree/master
trevnorris:invalid-buf-prop-accesshttps://github.com/trevnorris/node/tree/invalid-buf-prop-access
Conversationhttps://github.com/nodejs/node/pull/3302
Commits1 (1)https://github.com/nodejs/node/pull/3302/commits
Checkshttps://github.com/nodejs/node/pull/3302/checks
Files changedhttps://github.com/nodejs/node/pull/3302/files
buffer: don't abort on prototype gettershttps://github.com/nodejs/node/pull/3302#top
trevnorrishttps://github.com/trevnorris
nodejs:masterhttps://github.com/nodejs/node/tree/master
trevnorris:invalid-buf-prop-accesshttps://github.com/trevnorris/node/tree/invalid-buf-prop-access
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 9, 2015https://github.com/nodejs/node/pull/3302#issue-110730091
#3297https://github.com/nodejs/node/issues/3297
@Fishrock123https://github.com/Fishrock123
https://ci.nodejs.org/job/node-test-pull-request/468/https://ci.nodejs.org/job/node-test-pull-request/468/
Please reload this pagehttps://github.com/nodejs/node/pull/3302
https://github.com/trevnorris
buffer: don't abort on prototype gettershttps://github.com/nodejs/node/pull/3302/commits/63aaab12a2160c39e088aa39e92ca6ac68f3b4fd
63aaab1https://github.com/nodejs/node/pull/3302/commits/63aaab12a2160c39e088aa39e92ca6ac68f3b4fd
nodejs#3297https://github.com/nodejs/node/issues/3297
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
Oct 9, 2015https://github.com/nodejs/node/pull/3302#event-431804468
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 9, 2015https://github.com/nodejs/node/pull/3302#issuecomment-146979668
Please reload this pagehttps://github.com/nodejs/node/pull/3302
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Oct 9, 2015https://github.com/nodejs/node/pull/3302#issuecomment-146987899
Please reload this pagehttps://github.com/nodejs/node/pull/3302
trevnorrishttps://github.com/trevnorris
Oct 9, 2015 https://github.com/nodejs/node/pull/3302#ref-commit-e97dae5
https://github.com/trevnorris
buffer: don't abort on prototype gettershttps://github.com/nodejs/node/commit/e97dae573c11ae6db072aa41d00e4422d38f68c7
https://github.com/nodejs/node/commit/e97dae573c11ae6db072aa41d00e4422d38f68c7#comments
e97dae5https://github.com/nodejs/node/commit/e97dae573c11ae6db072aa41d00e4422d38f68c7
#3297https://github.com/nodejs/node/issues/3297
#3302https://github.com/nodejs/node/pull/3302
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 9, 2015https://github.com/nodejs/node/pull/3302#issuecomment-146992455
e97dae5https://github.com/nodejs/node/commit/e97dae573c11ae6db072aa41d00e4422d38f68c7
Please reload this pagehttps://github.com/nodejs/node/pull/3302
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 9, 2015https://github.com/nodejs/node/pull/3302#event-431864146
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 10, 2015https://github.com/nodejs/node/pull/3302#issuecomment-147095054
Please reload this pagehttps://github.com/nodejs/node/pull/3302
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 10, 2015https://github.com/nodejs/node/pull/3302#issuecomment-147110590
@thefourtheyehttps://github.com/thefourtheye
Please reload this pagehttps://github.com/nodejs/node/pull/3302
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 10, 2015https://github.com/nodejs/node/pull/3302#issuecomment-147110717
Please reload this pagehttps://github.com/nodejs/node/pull/3302
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 10, 2015https://github.com/nodejs/node/pull/3302#issuecomment-147111541
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/3302
https://github.com/jasnell
jasnellhttps://github.com/jasnell
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
Oct 10, 2015https://github.com/nodejs/node/pull/3302#event-432163090
trevnorrishttps://github.com/trevnorris
Oct 10, 2015 https://github.com/nodejs/node/pull/3302#ref-commit-5479562
https://github.com/trevnorris
https://github.com/jasnell
buffer: don't abort on prototype gettershttps://github.com/nodejs/node/commit/54795620f652271840b400b6f6d7581d128d5628
5479562https://github.com/nodejs/node/commit/54795620f652271840b400b6f6d7581d128d5628
#3297https://github.com/nodejs/node/issues/3297
#3302https://github.com/nodejs/node/pull/3302
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 10, 2015https://github.com/nodejs/node/pull/3302#issuecomment-147112800
Please reload this pagehttps://github.com/nodejs/node/pull/3302
https://github.com/jasnell
jasnellhttps://github.com/jasnell
lts-landed-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-landed-on-v4.x
Oct 10, 2015https://github.com/nodejs/node/pull/3302#event-432163527
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 10, 2015 https://github.com/nodejs/node/pull/3302#ref-pullrequest-110375513
Release proposal: v4.2.0 'Argon' (LTS) #3258 https://github.com/nodejs/node/pull/3258
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 11, 2015https://github.com/nodejs/node/pull/3302#issuecomment-147179660
Please reload this pagehttps://github.com/nodejs/node/pull/3302
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
Nov 17, 2015https://github.com/nodejs/node/pull/3302#event-466128075
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
March 28, 2016 22:25https://github.com/nodejs/node/pull/3302#event-605851949
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Apr 24, 2023 https://github.com/nodejs/node/pull/3302#ref-pullrequest-1681760868
[Snyk] Security upgrade lerna from 3.22.1 to 5.5.2 aliscco/alisco-node#102 https://github.com/aliscco/alisco-node/pull/102
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3302
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
Please reload this pagehttps://github.com/nodejs/node/pull/3302
https://github.com/trevnorris
https://github.com/bnoordhuis
https://github.com/Fishrock123
https://github.com/thefourtheye
https://github.com/jasnell
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.