| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6b90e598-93a1-832f-f499-6ec658aa46a6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9A1E:166568:46A5B:5F3C8:6AED311F |
| html-safe-nonce | 661e19668f6ae973acf6aefc67fab86f7dc9ac71afe8a133d0fc12e1f5afa2e7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTFFOjE2NjU2ODo0NkE1Qjo1RjNDODo2QUVEMzExRiIsInZpc2l0b3JfaWQiOiIyODEwMTEyNjA4Njc1MTE1Mjk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 29e83900cb52510e51d98628dbfa053d35eeed30256af048fc675098c0634c27 |
| hovercard-subject-tag | pull_request:407669947 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33014/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b1055260b26985e9a200400656bd259cc488ef4390400c7cbe9cf425312eccb2/nodejs/node/pull/33014 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b1055260b26985e9a200400656bd259cc488ef4390400c7cbe9cf425312eccb2/nodejs/node/pull/33014 |
| og:image:alt | Currently, the following compiler warnings are generated:
../src/node_http2.cc: In static member function
‘static int node::http2::Http2Session::OnStreamClose(nghttp2_session*,
int32_t, uint32_... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | danbev |
| hostname | github.com |
| expected-hostname | github.com |
| None | e51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ebb7b901cc154ecc179a44f266fcf69f343b30 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/33014#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33014 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33014 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/33014 |
| Reload | https://github.com/nodejs/node/pull/33014 |
| Reload | https://github.com/nodejs/node/pull/33014 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues656 (656) | https://github.com/nodejs/node/issues |
| Pull requests666 (666) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/pulse |
| https://github.com/nodejs/node |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:http2-compiler-warnings | https://github.com/danbev/node/tree/http2-compiler-warnings |
| Conversation | https://github.com/nodejs/node/pull/33014 |
| Commits1 (1) | https://github.com/nodejs/node/pull/33014/commits |
| Checks | https://github.com/nodejs/node/pull/33014/checks |
| Files changed | https://github.com/nodejs/node/pull/33014/files |
| src: fix compiler warnings in node_http2.cc | https://github.com/nodejs/node/pull/33014#top |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:http2-compiler-warnings | https://github.com/danbev/node/tree/http2-compiler-warnings |
|
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Apr 23, 2020 | https://github.com/nodejs/node/pull/33014#issue-605226083 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/33014 |
|
| https://github.com/danbev |
| src: fix compiler warnings in node_http2.cc | https://github.com/nodejs/node/pull/33014/commits/7046c59a0312dfe990be36314f65f2cf59fd4d2f |
| 7046c59 | https://github.com/nodejs/node/pull/33014/commits/7046c59a0312dfe990be36314f65f2cf59fd4d2f |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
http2
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2 |
| Apr 23, 2020 | https://github.com/nodejs/node/pull/33014#event-3263304916 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
|
Apr 23, 2020
| https://github.com/nodejs/node/pull/33014#pullrequestreview-398763722 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33014/files/7046c59a0312dfe990be36314f65f2cf59fd4d2f |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 23, 2020 | https://github.com/nodejs/node/pull/33014#issuecomment-618182086 |
| https://ci.nodejs.org/job/node-test-pull-request/30917/ | https://ci.nodejs.org/job/node-test-pull-request/30917/ |
| Please reload this page | https://github.com/nodejs/node/pull/33014 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Apr 23, 2020
| https://github.com/nodejs/node/pull/33014#pullrequestreview-398890717 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33014/files/7046c59a0312dfe990be36314f65f2cf59fd4d2f |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
Apr 23, 2020
| https://github.com/nodejs/node/pull/33014#pullrequestreview-399135112 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33014/files/7046c59a0312dfe990be36314f65f2cf59fd4d2f |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Apr 23, 2020
| https://github.com/nodejs/node/pull/33014#pullrequestreview-399136230 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33014/files/7046c59a0312dfe990be36314f65f2cf59fd4d2f |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 23, 2020
| https://github.com/nodejs/node/pull/33014#pullrequestreview-399267294 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33014/files/7046c59a0312dfe990be36314f65f2cf59fd4d2f |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/33014#pullrequestreview-399267294 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/33014 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 23, 2020 | https://github.com/nodejs/node/pull/33014#issuecomment-618497534 |
| Please reload this page | https://github.com/nodejs/node/pull/33014 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Apr 23, 2020 | https://github.com/nodejs/node/pull/33014#event-3265794265 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Apr 23, 2020
| https://github.com/nodejs/node/pull/33014#pullrequestreview-399335200 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33014/files/7046c59a0312dfe990be36314f65f2cf59fd4d2f |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 23, 2020 | https://github.com/nodejs/node/pull/33014#issuecomment-618571925 |
| https://ci.nodejs.org/job/node-test-pull-request/30934/ | https://ci.nodejs.org/job/node-test-pull-request/30934/ |
| Please reload this page | https://github.com/nodejs/node/pull/33014 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 23, 2020 | https://github.com/nodejs/node/pull/33014#issuecomment-618572015 |
| Please reload this page | https://github.com/nodejs/node/pull/33014 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 23, 2020 | https://github.com/nodejs/node/pull/33014#issuecomment-618598202 |
| https://ci.nodejs.org/job/node-test-pull-request/30936/ | https://ci.nodejs.org/job/node-test-pull-request/30936/ |
| Please reload this page | https://github.com/nodejs/node/pull/33014 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Apr 24, 2020 | https://github.com/nodejs/node/pull/33014#issuecomment-618846656 |
| #32685 | https://github.com/nodejs/node/pull/32685 |
| Please reload this page | https://github.com/nodejs/node/pull/33014 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 24, 2020 | https://github.com/nodejs/node/pull/33014#issuecomment-618847756 |
| https://ci.nodejs.org/job/node-test-pull-request/30943/ | https://ci.nodejs.org/job/node-test-pull-request/30943/ |
| Please reload this page | https://github.com/nodejs/node/pull/33014 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Apr 24, 2020
| https://github.com/nodejs/node/pull/33014#ref-pullrequest-595076972 |
|
build: turn warnings into errors for node sources
#32685
| https://github.com/nodejs/node/pull/32685 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Apr 24, 2020 | https://github.com/nodejs/node/pull/33014#event-3270287959 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 24, 2020 | https://github.com/nodejs/node/pull/33014#issuecomment-619134676 |
| https://ci.nodejs.org/job/node-test-pull-request/30954/ | https://ci.nodejs.org/job/node-test-pull-request/30954/ |
| Please reload this page | https://github.com/nodejs/node/pull/33014 |
| jasnell | https://github.com/jasnell |
|
Apr 24, 2020
| https://github.com/nodejs/node/pull/33014#ref-commit-654c0ac |
|
| https://github.com/danbev |
|
| https://github.com/jasnell |
| src: fix compiler warnings in node_http2.cc | https://github.com/nodejs/node/commit/654c0ace7b44da722b313bae2e7cb0ae6a9341a4 |
| 654c0ac | https://github.com/nodejs/node/commit/654c0ace7b44da722b313bae2e7cb0ae6a9341a4 |
| #33014 | https://github.com/nodejs/node/pull/33014 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 24, 2020 | https://github.com/nodejs/node/pull/33014#issuecomment-619166560 |
| 654c0ac | https://github.com/nodejs/node/commit/654c0ace7b44da722b313bae2e7cb0ae6a9341a4 |
| Please reload this page | https://github.com/nodejs/node/pull/33014 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 24, 2020 | https://github.com/nodejs/node/pull/33014#event-3270503397 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 27, 2020
| https://github.com/nodejs/node/pull/33014#ref-commit-14f8864 |
|
| https://github.com/danbev |
|
| https://github.com/BethGriggs |
| src: fix compiler warnings in node_http2.cc | https://github.com/nodejs/node/commit/14f886497631c8ec33fad5b17f079770866aec1d |
| 14f8864 | https://github.com/nodejs/node/commit/14f886497631c8ec33fad5b17f079770866aec1d |
| #33014 | https://github.com/nodejs/node/pull/33014 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 27, 2020
| https://github.com/nodejs/node/pull/33014#ref-pullrequest-607819306 |
|
v14.1.0 proposal
#33103
| https://github.com/nodejs/node/pull/33103 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
dont-land-on-v13.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v13.x |
| Apr 28, 2020 | https://github.com/nodejs/node/pull/33014#event-3279670137 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Apr 28, 2020 | https://github.com/nodejs/node/pull/33014#issuecomment-620524635 |
| Please reload this page | https://github.com/nodejs/node/pull/33014 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/33014#ref-commit-bc755fc |
|
| https://github.com/danbev |
|
| https://github.com/BethGriggs |
| src: fix compiler warnings in node_http2.cc | https://github.com/nodejs/node/commit/bc755fc4c25c64b10f647cf48950d4e067a20d99 |
| bc755fc | https://github.com/nodejs/node/commit/bc755fc4c25c64b10f647cf48950d4e067a20d99 |
| #33014 | https://github.com/nodejs/node/pull/33014 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backport-blocked-v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v12.x |
| Apr 29, 2020 | https://github.com/nodejs/node/pull/33014#event-3286273773 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Jun 8, 2020
| https://github.com/nodejs/node/pull/33014#ref-pullrequest-608802418 |
|
src: retrieve binding data from the context
#33139
| https://github.com/nodejs/node/pull/33139 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33014 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/33014/files/7046c59a0312dfe990be36314f65f2cf59fd4d2f |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/33014/files/7046c59a0312dfe990be36314f65f2cf59fd4d2f |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/33014/files/7046c59a0312dfe990be36314f65f2cf59fd4d2f |
|
| https://github.com/himself65 |
|
himself65
| https://github.com/himself65 |
|
| https://github.com/nodejs/node/pull/33014/files/7046c59a0312dfe990be36314f65f2cf59fd4d2f |
|
| https://github.com/juanarbol |
|
juanarbol
| https://github.com/juanarbol |
|
| https://github.com/nodejs/node/pull/33014/files/7046c59a0312dfe990be36314f65f2cf59fd4d2f |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/33014/files/7046c59a0312dfe990be36314f65f2cf59fd4d2f |
| Please reload this page | https://github.com/nodejs/node/pull/33014 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
http2
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2 |
| Please reload this page | https://github.com/nodejs/node/pull/33014 |
|
| https://github.com/danbev |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/BridgeAR |
|
| https://github.com/sam-github |
|
| https://github.com/cjihrig |
|
| https://github.com/richardlau |
|
| https://github.com/himself65 |
|
| https://github.com/juanarbol |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |