| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c8302c04-1318-c755-e6ce-8ae5b155e4c8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AE24:268E8A:973F50:D4D250:696A5C37 |
| html-safe-nonce | f159564ac93c2f94fe3e5adef93e908f0ca1346e60b3202c9ef63a19d53f7bc8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTI0OjI2OEU4QTo5NzNGNTA6RDREMjUwOjY5NkE1QzM3IiwidmlzaXRvcl9pZCI6Ijg0MDgyODk2Mzc4NjI4OTA1NTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d4ab6a79b49ef88ae082e31655ea4c5be43e438ea651c10e83ed205d0a6959e0 |
| hovercard-subject-tag | pull_request:407145635 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32997/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3f20fe4f0167233e28fda664f76e6b8bb460e2bd2b37c995fee1f21a9479920f/nodejs/node/pull/32997 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3f20fe4f0167233e28fda664f76e6b8bb460e2bd2b37c995fee1f21a9479920f/nodejs/node/pull/32997 |
| og:image:alt | uv_idle_init(), uv_idle_start() and uv_idle_stop() always succeed.
Remove the superfluous error handling.
Refs: libuv/libuv#2803 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bnoordhuis |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63c426b30d262aba269ef14c40e3c817b384cd61 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/32997#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32997 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32997 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/32997 |
| Reload | https://github.com/nodejs/node/pull/32997 |
| Reload | https://github.com/nodejs/node/pull/32997 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/32997 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/32997 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/32997#issue-comment-box |
| bnoordhuis | https://github.com/bnoordhuis |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| bnoordhuis:napi-idle-simple | https://github.com/bnoordhuis/io.js/tree/napi-idle-simple |
|
n-api: simplify uv_idle wrangling
| https://github.com/nodejs/node/pull/32997#top |
| bnoordhuis | https://github.com/bnoordhuis |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| bnoordhuis:napi-idle-simple | https://github.com/bnoordhuis/io.js/tree/napi-idle-simple |
|
Conversation
2
| https://github.com/nodejs/node/pull/32997 |
|
Commits
1
| https://github.com/nodejs/node/pull/32997/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/32997/checks |
|
Files changed
| https://github.com/nodejs/node/pull/32997/files |
| Please reload this page | https://github.com/nodejs/node/pull/32997 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Apr 22, 2020 | https://github.com/nodejs/node/pull/32997#issue-604578286 |
| libuv/libuv#2803 | https://github.com/libuv/libuv/pull/2803 |
| Please reload this page | https://github.com/nodejs/node/pull/32997 |
|
| https://github.com/bnoordhuis |
| n-api: simplify uv_idle wrangling | https://github.com/nodejs/node/pull/32997/commits/abcd8571c1bc47bccee4a22e54d76e0bc4764dd9 |
| abcd857 | https://github.com/nodejs/node/pull/32997/commits/abcd8571c1bc47bccee4a22e54d76e0bc4764dd9 |
| libuv/libuv#2803 | https://github.com/libuv/libuv/pull/2803 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| gabrielschulhof | https://github.com/gabrielschulhof |
| April 22, 2020 08:53 | https://github.com/nodejs/node/pull/32997#event-3259546930 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Apr 22, 2020 | https://github.com/nodejs/node/pull/32997#event-3259547239 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Apr 22, 2020
| https://github.com/nodejs/node/pull/32997#pullrequestreview-398167974 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32997/files/abcd8571c1bc47bccee4a22e54d76e0bc4764dd9 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
|
Apr 22, 2020
| https://github.com/nodejs/node/pull/32997#pullrequestreview-398391206 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32997/files/abcd8571c1bc47bccee4a22e54d76e0bc4764dd9 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
|
Apr 22, 2020
| https://github.com/nodejs/node/pull/32997#pullrequestreview-398395804 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32997/files/abcd8571c1bc47bccee4a22e54d76e0bc4764dd9 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
Apr 23, 2020
| https://github.com/nodejs/node/pull/32997#pullrequestreview-399136101 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32997/files/abcd8571c1bc47bccee4a22e54d76e0bc4764dd9 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 23, 2020
| https://github.com/nodejs/node/pull/32997#pullrequestreview-399264265 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32997/files/abcd8571c1bc47bccee4a22e54d76e0bc4764dd9 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Apr 27, 2020 | https://github.com/nodejs/node/pull/32997#event-3277844241 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 28, 2020 | https://github.com/nodejs/node/pull/32997#issuecomment-620314125 |
| Please reload this page | https://github.com/nodejs/node/pull/32997 |
| https://ci.nodejs.org/job/node-test-pull-request/31033/ | https://ci.nodejs.org/job/node-test-pull-request/31033/ |
| Please reload this page | https://github.com/nodejs/node/pull/32997 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Apr 29, 2020 | https://github.com/nodejs/node/pull/32997#issuecomment-620946378 |
| eebf52d | https://github.com/nodejs/node/commit/eebf52d27950afc271ede949b2ea055c83e1867f |
| Please reload this page | https://github.com/nodejs/node/pull/32997 |
| addaleax | https://github.com/addaleax |
|
Apr 29, 2020
| https://github.com/nodejs/node/pull/32997#ref-commit-eebf52d |
|
| https://github.com/bnoordhuis |
|
| https://github.com/addaleax |
| n-api: simplify uv_idle wrangling | https://github.com/nodejs/node/commit/eebf52d27950afc271ede949b2ea055c83e1867f |
| eebf52d | https://github.com/nodejs/node/commit/eebf52d27950afc271ede949b2ea055c83e1867f |
| libuv/libuv#2803 | https://github.com/libuv/libuv/pull/2803 |
| #32997 | https://github.com/nodejs/node/pull/32997 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Apr 29, 2020 | https://github.com/nodejs/node/pull/32997#event-3282739817 |
| targos | https://github.com/targos |
|
May 4, 2020
| https://github.com/nodejs/node/pull/32997#ref-commit-466213d |
|
| https://github.com/bnoordhuis |
|
| https://github.com/targos |
| n-api: simplify uv_idle wrangling | https://github.com/nodejs/node/commit/466213d726409a3376b3f183578383e442e4b3fb |
| 466213d | https://github.com/nodejs/node/commit/466213d726409a3376b3f183578383e442e4b3fb |
| libuv/libuv#2803 | https://github.com/libuv/libuv/pull/2803 |
| #32997 | https://github.com/nodejs/node/pull/32997 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 4, 2020
| https://github.com/nodejs/node/pull/32997#ref-pullrequest-611881566 |
|
v14.2.0 release proposal
#33232
| https://github.com/nodejs/node/pull/33232 |
| targos | https://github.com/targos |
|
May 7, 2020
| https://github.com/nodejs/node/pull/32997#ref-commit-72bca64 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/targos |
| n-api: simplify uv_idle wrangling | https://github.com/nodejs/node/commit/72bca64f466baa8528f149309a5e594260a0e502 |
| 72bca64 | https://github.com/nodejs/node/commit/72bca64f466baa8528f149309a5e594260a0e502 |
| libuv/libuv#2803 | https://github.com/libuv/libuv/pull/2803 |
| #32997 | https://github.com/nodejs/node/pull/32997 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 7, 2020
| https://github.com/nodejs/node/pull/32997#ref-pullrequest-610737650 |
|
v12.17.0 release proposal
#33197
| https://github.com/nodejs/node/pull/33197 |
| targos | https://github.com/targos |
|
May 13, 2020
| https://github.com/nodejs/node/pull/32997#ref-commit-4d7f986 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/targos |
| n-api: simplify uv_idle wrangling | https://github.com/nodejs/node/commit/4d7f9869f3b85b5dcd0c88166672276355798ca8 |
| 4d7f986 | https://github.com/nodejs/node/commit/4d7f9869f3b85b5dcd0c88166672276355798ca8 |
| libuv/libuv#2803 | https://github.com/libuv/libuv/pull/2803 |
| #32997 | https://github.com/nodejs/node/pull/32997 |
|
doc: move ERR_NAPI_TSFN_START_IDLE_LOOP to legacy errors
aduh95/node#10
| https://github.com/aduh95/node/pull/10 |
|
doc: move ERR_NAPI_TSFN_START/STOP_IDLE_LOOP to legacy errors
#55248
| https://github.com/nodejs/node/pull/55248 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Oct 5, 2024
| https://github.com/nodejs/node/pull/32997#ref-commit-a301596 |
|
| https://github.com/aduh95 |
| doc: move ERR_NAPI_TSFN_START/STOP_IDLE_LOOP to legacy errors | https://github.com/nodejs/node/commit/a301596c41c29bcea0b9803f41750f741f9f49be |
| a301596 | https://github.com/nodejs/node/commit/a301596c41c29bcea0b9803f41750f741f9f49be |
| #55248 | https://github.com/nodejs/node/pull/55248 |
| #17887 | https://github.com/nodejs/node/pull/17887 |
| #32997 | https://github.com/nodejs/node/pull/32997 |
| targos | https://github.com/targos |
|
Oct 5, 2024
| https://github.com/nodejs/node/pull/32997#ref-commit-195df65 |
|
| https://github.com/aduh95 |
|
| https://github.com/targos |
| doc: move ERR_NAPI_TSFN_START/STOP_IDLE_LOOP to legacy errors | https://github.com/nodejs/node/commit/195df659e9143635c78e124ca8a09cf87dbc4b3e |
| 195df65 | https://github.com/nodejs/node/commit/195df659e9143635c78e124ca8a09cf87dbc4b3e |
| #55248 | https://github.com/nodejs/node/pull/55248 |
| #17887 | https://github.com/nodejs/node/pull/17887 |
| #32997 | https://github.com/nodejs/node/pull/32997 |
| louwers | https://github.com/louwers |
|
Nov 2, 2024
| https://github.com/nodejs/node/pull/32997#ref-commit-87452ba |
|
| https://github.com/aduh95 |
|
| https://github.com/louwers |
| doc: move ERR_NAPI_TSFN_START/STOP_IDLE_LOOP to legacy errors | https://github.com/louwers/node/commit/87452bac8e9613b3f2209f1f2d29926d479972f7 |
| 87452ba | https://github.com/louwers/node/commit/87452bac8e9613b3f2209f1f2d29926d479972f7 |
| nodejs#55248 | https://github.com/nodejs/node/pull/55248 |
| nodejs#17887 | https://github.com/nodejs/node/pull/17887 |
| nodejs#32997 | https://github.com/nodejs/node/pull/32997 |
| tpoisseau | https://github.com/tpoisseau |
|
Nov 21, 2024
| https://github.com/nodejs/node/pull/32997#ref-commit-7614609 |
|
| https://github.com/aduh95 |
|
| https://github.com/tpoisseau |
| doc: move ERR_NAPI_TSFN_START/STOP_IDLE_LOOP to legacy errors | https://github.com/tpoisseau/node/commit/76146096a0c935a4b75780adc551c650a1277c64 |
| 7614609 | https://github.com/tpoisseau/node/commit/76146096a0c935a4b75780adc551c650a1277c64 |
| nodejs#55248 | https://github.com/nodejs/node/pull/55248 |
| nodejs#17887 | https://github.com/nodejs/node/pull/17887 |
| nodejs#32997 | https://github.com/nodejs/node/pull/32997 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32997 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/32997/files/abcd8571c1bc47bccee4a22e54d76e0bc4764dd9 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/32997/files/abcd8571c1bc47bccee4a22e54d76e0bc4764dd9 |
|
| https://github.com/juanarbol |
|
juanarbol
| https://github.com/juanarbol |
|
| https://github.com/nodejs/node/pull/32997/files/abcd8571c1bc47bccee4a22e54d76e0bc4764dd9 |
|
| https://github.com/gabrielschulhof |
|
gabrielschulhof
| https://github.com/gabrielschulhof |
|
| https://github.com/devnexen |
|
devnexen
| https://github.com/devnexen |
|
| https://github.com/nodejs/node/pull/32997/files/abcd8571c1bc47bccee4a22e54d76e0bc4764dd9 |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/nodejs/node/pull/32997/files/abcd8571c1bc47bccee4a22e54d76e0bc4764dd9 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Please reload this page | https://github.com/nodejs/node/pull/32997 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/devnexen |
|
| https://github.com/devsnek |
|
| https://github.com/juanarbol |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |