René's URL Explorer Experiment


Title: [v13.x backport] stream: pipeline should only destroy un-finished streams. by ronag · Pull Request #32980 · nodejs/node · GitHub

Open Graph Title: [v13.x backport] stream: pipeline should only destroy un-finished streams. by ronag · Pull Request #32980 · nodejs/node

X Title: [v13.x backport] stream: pipeline should only destroy un-finished streams. by ronag · Pull Request #32980 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: PR-URL: #32968 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

X Description: PR-URL: #32968 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/32980

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d42d7e39-2769-0d75-6177-9938985c5a91
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9962:36E597:4E888C:6A767B:6A4EB995
html-safe-noncec1ecf9557e83a89f8d9e16044d056a9626a9c84c05cc73d398bd11e754d6b0a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTYyOjM2RTU5Nzo0RTg4OEM6NkE3NjdCOjZBNEVCOTk1IiwidmlzaXRvcl9pZCI6Ijg4Mjg4Nzg5Nzg5NjgxMDc0MTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf036dd1dcd5b9e0da4a37a64b3c956628c80b9292628ea614f5aea1707e3ed42
hovercard-subject-tagpull_request:406838042
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32980/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/153af88bc616c56d01402ae8ebe9087c23df4d74332b4f9f1411c5f32c9c9cc4/nodejs/node/pull/32980
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/153af88bc616c56d01402ae8ebe9087c23df4d74332b4f9f1411c5f32c9c9cc4/nodejs/node/pull/32980
og:image:altPR-URL: #32968 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/32980#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32980
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32980
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/32980
Reloadhttps://github.com/nodejs/node/pull/32980
Reloadhttps://github.com/nodejs/node/pull/32980
Please reload this pagehttps://github.com/nodejs/node/pull/32980
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/32980
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:v13.x-staginghttps://github.com/nodejs/node/tree/v13.x-staging
nxtedition:backport-32968-to-v13.xhttps://github.com/nxtedition/node/tree/backport-32968-to-v13.x
Conversationhttps://github.com/nodejs/node/pull/32980
Commits2 (2)https://github.com/nodejs/node/pull/32980/commits
Checkshttps://github.com/nodejs/node/pull/32980/checks
Files changedhttps://github.com/nodejs/node/pull/32980/files
[v13.x backport] stream: pipeline should only destroy un-finished streams.https://github.com/nodejs/node/pull/32980#top
ronaghttps://github.com/ronag
nodejs:v13.x-staginghttps://github.com/nodejs/node/tree/v13.x-staging
nxtedition:backport-32968-to-v13.xhttps://github.com/nxtedition/node/tree/backport-32968-to-v13.x
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 21, 2020https://github.com/nodejs/node/pull/32980#issue-604199677
Please reload this pagehttps://github.com/nodejs/node/pull/32980
#32968https://github.com/nodejs/node/pull/32968
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/32980
https://github.com/ronag
ronaghttps://github.com/ronag
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
v13.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av13.x
Apr 21, 2020https://github.com/nodejs/node/pull/32980#event-3257403797
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/41c7678c5f982ea06013c19ab131ba4ec6a3449b..1e7ce981cfd1176a1d66772403878069548e8bca
41c7678https://github.com/nodejs/node/commit/41c7678c5f982ea06013c19ab131ba4ec6a3449b
1e7ce98https://github.com/nodejs/node/commit/1e7ce981cfd1176a1d66772403878069548e8bca
Compare https://github.com/nodejs/node/compare/41c7678c5f982ea06013c19ab131ba4ec6a3449b..1e7ce981cfd1176a1d66772403878069548e8bca
April 21, 2020 18:40https://github.com/nodejs/node/pull/32980#event-3257407408
https://github.com/ronag
ronaghttps://github.com/ronag
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Apr 21, 2020https://github.com/nodejs/node/pull/32980#event-3257408273
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 21, 2020https://github.com/nodejs/node/pull/32980#issuecomment-617343307
Please reload this pagehttps://github.com/nodejs/node/pull/32980
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/1e7ce981cfd1176a1d66772403878069548e8bca..8ed8fb69a12f32fbea5b239d9a9a0510821e2407
1e7ce98https://github.com/nodejs/node/commit/1e7ce981cfd1176a1d66772403878069548e8bca
8ed8fb6https://github.com/nodejs/node/commit/8ed8fb69a12f32fbea5b239d9a9a0510821e2407
Compare https://github.com/nodejs/node/compare/1e7ce981cfd1176a1d66772403878069548e8bca..8ed8fb69a12f32fbea5b239d9a9a0510821e2407
April 23, 2020 18:00https://github.com/nodejs/node/pull/32980#event-3266185312
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 23, 2020https://github.com/nodejs/node/pull/32980#issuecomment-618554358
https://ci.nodejs.org/job/node-test-pull-request/30933/https://ci.nodejs.org/job/node-test-pull-request/30933/
Please reload this pagehttps://github.com/nodejs/node/pull/32980
https://github.com/ronag
stream: pipeline should only destroy un-finished streamshttps://github.com/nodejs/node/pull/32980/commits/9e7f255e854e93b17ca4cf618862cc88681d603f
9e7f255https://github.com/nodejs/node/pull/32980/commits/9e7f255e854e93b17ca4cf618862cc88681d603f
nodejs#31940https://github.com/nodejs/node/pull/31940
nodejs#31940https://github.com/nodejs/node/pull/31940
nodejs#32954https://github.com/nodejs/node/issues/32954
nodejs#32955https://github.com/nodejs/node/issues/32955
nodejs#32968https://github.com/nodejs/node/pull/32968
nodejs#32980https://github.com/nodejs/node/pull/32980
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/8ed8fb69a12f32fbea5b239d9a9a0510821e2407..9e7f255e854e93b17ca4cf618862cc88681d603f
8ed8fb6https://github.com/nodejs/node/commit/8ed8fb69a12f32fbea5b239d9a9a0510821e2407
9e7f255https://github.com/nodejs/node/commit/9e7f255e854e93b17ca4cf618862cc88681d603f
Compare https://github.com/nodejs/node/compare/8ed8fb69a12f32fbea5b239d9a9a0510821e2407..9e7f255e854e93b17ca4cf618862cc88681d603f
April 23, 2020 18:01https://github.com/nodejs/node/pull/32980#event-3266192218
https://github.com/ronag
ronaghttps://github.com/ronag
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Apr 23, 2020https://github.com/nodejs/node/pull/32980#event-3266192241
https://github.com/ronag
ronaghttps://github.com/ronag
mcollinahttps://github.com/mcollina
April 23, 2020 18:01https://github.com/nodejs/node/pull/32980#event-3266192922
https://github.com/ronag
fixuphttps://github.com/nodejs/node/pull/32980/commits/3f5f8cca9015f1eef65cbbd6ccc30c2928644e09
3f5f8cchttps://github.com/nodejs/node/pull/32980/commits/3f5f8cca9015f1eef65cbbd6ccc30c2928644e09
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 23, 2020https://github.com/nodejs/node/pull/32980#issuecomment-618580402
https://ci.nodejs.org/job/node-test-pull-request/30935/https://ci.nodejs.org/job/node-test-pull-request/30935/
Please reload this pagehttps://github.com/nodejs/node/pull/32980
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 23, 2020https://github.com/nodejs/node/pull/32980#issuecomment-618699149
https://ci.nodejs.org/job/node-test-pull-request/30940/https://ci.nodejs.org/job/node-test-pull-request/30940/
Please reload this pagehttps://github.com/nodejs/node/pull/32980
https://github.com/ronag
ronaghttps://github.com/ronag
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Apr 23, 2020https://github.com/nodejs/node/pull/32980#event-3267106297
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 28, 2020https://github.com/nodejs/node/pull/32980#issuecomment-620317896
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/32980
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 28, 2020https://github.com/nodejs/node/pull/32980#issuecomment-620444364
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/32980
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 28, 2020https://github.com/nodejs/node/pull/32980#issuecomment-620624935
@targoshttps://github.com/targos
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/32980
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Apr 28, 2020https://github.com/nodejs/node/pull/32980#issuecomment-620625457
Please reload this pagehttps://github.com/nodejs/node/pull/32980
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 28, 2020https://github.com/nodejs/node/pull/32980#event-3280470851
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32980
https://github.com/mcollina
mcollina https://github.com/mcollina
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Please reload this pagehttps://github.com/nodejs/node/pull/32980
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/BridgeAR
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.