René's URL Explorer Experiment


Title: src: convert BE-utf16-string to LE before search by skomski · Pull Request #3295 · nodejs/node · GitHub

Open Graph Title: src: convert BE-utf16-string to LE before search by skomski · Pull Request #3295 · nodejs/node

X Title: src: convert BE-utf16-string to LE before search by skomski · Pull Request #3295 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: On Big Endian platforms v8 strings are need to converted to Little Endian before searching in utf16le buffer Fixes #3283

X Description: On Big Endian platforms v8 strings are need to converted to Little Endian before searching in utf16le buffer Fixes #3283

Opengraph URL: https://github.com/nodejs/node/pull/3295

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3b49c7e4-e912-75cc-6f68-7affa75f098f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB8B4:2B6D8B:125108:18AD97:6A4D83F5
html-safe-nonce905c1d59e6defb2343b283add836ef85a4c744adaa8004730b0e71e959bae86b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEI0OjJCNkQ4QjoxMjUxMDg6MThBRDk3OjZBNEQ4M0Y1IiwidmlzaXRvcl9pZCI6IjEyNjMzMzYwODY0MjA1MzEwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8153b7615ba57b64f3673a0ce70ef88f5566432f76f1402cc9268ab4d95d5c7e
hovercard-subject-tagpull_request:47291311
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/3295/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/56f96211af1dd4c4bdffdd680b1d74f761cf8a95aed9d7631f5cd55262ab0c8f/nodejs/node/pull/3295
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/56f96211af1dd4c4bdffdd680b1d74f761cf8a95aed9d7631f5cd55262ab0c8f/nodejs/node/pull/3295
og:image:altOn Big Endian platforms v8 strings are need to converted to Little Endian before searching in utf16le buffer Fixes #3283
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameskomski
hostnamegithub.com
expected-hostnamegithub.com
Nonec6bf61c909482ec3072ef5d7a5a28f2a9d214788c9a44793eca1960048cb05ae
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6702a58b419a792226bd21ef0fb1bcb318bbcaa3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/3295#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3295
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3295
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/3295
Reloadhttps://github.com/nodejs/node/pull/3295
Reloadhttps://github.com/nodejs/node/pull/3295
Please reload this pagehttps://github.com/nodejs/node/pull/3295
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/3295
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
skomskihttps://github.com/skomski
nodejs:masterhttps://github.com/nodejs/node/tree/master
skomski:fix-big-endian-string-searchhttps://github.com/skomski/node/tree/fix-big-endian-string-search
Conversationhttps://github.com/nodejs/node/pull/3295
Commits1 (1)https://github.com/nodejs/node/pull/3295/commits
Checkshttps://github.com/nodejs/node/pull/3295/checks
Files changedhttps://github.com/nodejs/node/pull/3295/files
src: convert BE-utf16-string to LE before searchhttps://github.com/nodejs/node/pull/3295#top
skomskihttps://github.com/skomski
nodejs:masterhttps://github.com/nodejs/node/tree/master
skomski:fix-big-endian-string-searchhttps://github.com/skomski/node/tree/fix-big-endian-string-search
https://github.com/skomski
skomskihttps://github.com/skomski
Oct 9, 2015https://github.com/nodejs/node/pull/3295#issue-110691250
#3283https://github.com/nodejs/node/issues/3283
Please reload this pagehttps://github.com/nodejs/node/pull/3295
https://github.com/skomski
src: convert BE-utf16-string to LE before searchhttps://github.com/nodejs/node/pull/3295/commits/4c3655ec05c30f90297edf9274526f62c57b4afd
4c3655ehttps://github.com/nodejs/node/pull/3295/commits/4c3655ec05c30f90297edf9274526f62c57b4afd
https://github.com/skomski
skomskihttps://github.com/skomski
force-pushedhttps://github.com/nodejs/node/compare/34cf018b5f0b4c683546b16f9d6de1f9e70b2454..4c3655ec05c30f90297edf9274526f62c57b4afd
34cf018https://github.com/nodejs/node/commit/34cf018b5f0b4c683546b16f9d6de1f9e70b2454
4c3655ehttps://github.com/nodejs/node/commit/4c3655ec05c30f90297edf9274526f62c57b4afd
Compare https://github.com/nodejs/node/compare/34cf018b5f0b4c683546b16f9d6de1f9e70b2454..4c3655ec05c30f90297edf9274526f62c57b4afd
October 9, 2015 16:26https://github.com/nodejs/node/pull/3295#event-431593203
https://github.com/silverwind
silverwindhttps://github.com/silverwind
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
Oct 9, 2015https://github.com/nodejs/node/pull/3295#event-431596523
https://github.com/skomski
skomskihttps://github.com/skomski
Oct 9, 2015 https://github.com/nodejs/node/pull/3295#ref-pullrequest-103037917
src: replace naive search with naive + BMH in Buffer::IndexOf #2539 https://github.com/nodejs/node/pull/2539
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 9, 2015https://github.com/nodejs/node/pull/3295#issuecomment-146929083
https://ci.nodejs.org/job/node-test-pull-request/464/https://ci.nodejs.org/job/node-test-pull-request/464/
Please reload this pagehttps://github.com/nodejs/node/pull/3295
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 9, 2015https://github.com/nodejs/node/pull/3295#issuecomment-146973547
https://ci.nodejs.org/job/node-test-commit-plinux/4/https://ci.nodejs.org/job/node-test-commit-plinux/4/
Please reload this pagehttps://github.com/nodejs/node/pull/3295
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 9, 2015https://github.com/nodejs/node/pull/3295#issuecomment-146975430
Please reload this pagehttps://github.com/nodejs/node/pull/3295
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
Oct 9, 2015https://github.com/nodejs/node/pull/3295#event-431845209
jasnellhttps://github.com/jasnell
Oct 10, 2015 https://github.com/nodejs/node/pull/3295#ref-commit-9148114
https://github.com/skomski
https://github.com/jasnell
src: convert BE-utf16-string to LE before searchhttps://github.com/nodejs/node/commit/9148114c93861359a502801499d4c26d0b761174
9148114https://github.com/nodejs/node/commit/9148114c93861359a502801499d4c26d0b761174
#3283https://github.com/nodejs/node/issues/3283
#3295https://github.com/nodejs/node/pull/3295
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 10, 2015https://github.com/nodejs/node/pull/3295#issuecomment-147111030
Please reload this pagehttps://github.com/nodejs/node/pull/3295
jasnellhttps://github.com/jasnell
Oct 10, 2015 https://github.com/nodejs/node/pull/3295#ref-commit-589287b
https://github.com/skomski
https://github.com/jasnell
src: convert BE-utf16-string to LE before searchhttps://github.com/nodejs/node/commit/589287b2e380653c6781f9530f102e17cd6327e4
589287bhttps://github.com/nodejs/node/commit/589287b2e380653c6781f9530f102e17cd6327e4
#3283https://github.com/nodejs/node/issues/3283
#3295https://github.com/nodejs/node/pull/3295
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 10, 2015https://github.com/nodejs/node/pull/3295#issuecomment-147111307
Please reload this pagehttps://github.com/nodejs/node/pull/3295
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 10, 2015https://github.com/nodejs/node/pull/3295#event-432158263
https://github.com/jasnell
jasnellhttps://github.com/jasnell
lts-landed-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-landed-on-v4.x
Oct 10, 2015https://github.com/nodejs/node/pull/3295#event-432158272
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 10, 2015 https://github.com/nodejs/node/pull/3295#ref-pullrequest-110375513
Release proposal: v4.2.0 'Argon' (LTS) #3258 https://github.com/nodejs/node/pull/3258
Trotthttps://github.com/Trott
Oct 12, 2015 https://github.com/nodejs/node/pull/3295#ref-commit-dfe6788
https://github.com/skomski
https://github.com/Trott
src: convert BE-utf16-string to LE before searchhttps://github.com/Trott/io.js/commit/dfe6788b882eb322723105bcf233246d03972d8f
dfe6788https://github.com/Trott/io.js/commit/dfe6788b882eb322723105bcf233246d03972d8f
nodejs#3283https://github.com/nodejs/node/issues/3283
nodejs#3295https://github.com/nodejs/node/pull/3295
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
Nov 17, 2015https://github.com/nodejs/node/pull/3295#event-466127994
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3295
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
Please reload this pagehttps://github.com/nodejs/node/pull/3295
https://github.com/skomski
https://github.com/trevnorris
https://github.com/mhdawson
https://github.com/jasnell
https://github.com/silverwind
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.