| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:50664868-6b02-d9b9-3f7a-29eca36dad4a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AA12:366857:4763EA6:636C2AD:6A4F7409 |
| html-safe-nonce | ba2ac8a8895b2ac820a94e458718c8d99addbcc92c59731cc47cd5477c5091d0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTEyOjM2Njg1Nzo0NzYzRUE2OjYzNkMyQUQ6NkE0Rjc0MDkiLCJ2aXNpdG9yX2lkIjoiMzY0NDE1NDMyMjIxNDY3OTU2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7b936d0c120357cf9c5ca8e5fa91444271150567fb0e342ce2a646966c3ca249 |
| hovercard-subject-tag | pull_request:405563366 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32921/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/433822b9a873e22b7109e6bfe49f2f1a9ff0f55911208d8421681fbf352c8bba/nodejs/node/pull/32921 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/433822b9a873e22b7109e6bfe49f2f1a9ff0f55911208d8421681fbf352c8bba/nodejs/node/pull/32921 |
| og:image:alt | Setting an environment variable with an empty name on Windows resulted in an assertion failure, because it was checked for an '=' sign at the beginning without verifying the length was grea... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bl-ue |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/32921#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32921 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32921 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/32921 |
| Reload | https://github.com/nodejs/node/pull/32921 |
| Reload | https://github.com/nodejs/node/pull/32921 |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
973
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| bl-ue | https://github.com/bl-ue |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/32921 |
| Commits5 (5) | https://github.com/nodejs/node/pull/32921/commits |
| Checks | https://github.com/nodejs/node/pull/32921/checks |
| Files changed | https://github.com/nodejs/node/pull/32921/files |
| src: fix empty-named env var assertion failure | https://github.com/nodejs/node/pull/32921#top |
| bl-ue | https://github.com/bl-ue |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
| https://github.com/bl-ue |
| bl-ue | https://github.com/bl-ue |
| Apr 18, 2020 | https://github.com/nodejs/node/pull/32921#issue-602556795 |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
| #32920 | https://github.com/nodejs/node/issues/32920 |
| #27310 | https://github.com/nodejs/node/pull/27310 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Apr 18, 2020 | https://github.com/nodejs/node/pull/32921#event-3248414797 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Apr 18, 2020
| https://github.com/nodejs/node/pull/32921#pullrequestreview-395955141 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32921/files |
| src/node_env_var.cc | https://github.com/nodejs/node/pull/32921/files#diff-fa77c1cbb142941037575ffb9c0016a158b2708ff891c50b032b090d269d6087 |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
|
Apr 19, 2020
| https://github.com/nodejs/node/pull/32921#pullrequestreview-396043566 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32921/files |
| bl-ue | https://github.com/bl-ue |
| April 19, 2020 14:31 | https://github.com/nodejs/node/pull/32921#commits-pushed-15a7f4c |
|
| https://github.com/bl-ue |
| src: fix empty-named env var assertion failure | https://github.com/nodejs/node/pull/32921/commits/15a7f4cbc0bc9eba041cd3a9b7fe62dfeb714847 |
| 15a7f4c | https://github.com/nodejs/node/pull/32921/commits/15a7f4cbc0bc9eba041cd3a9b7fe62dfeb714847 |
| #32920 | https://github.com/nodejs/node/issues/32920 |
| #27310 | https://github.com/nodejs/node/pull/27310 |
|
| https://github.com/bl-ue |
| src: relax assertion in operator[] of MaybeStackBuffer | https://github.com/nodejs/node/pull/32921/commits/afd02b2579235dd743946f00028c3bf17c189e84 |
| afd02b2 | https://github.com/nodejs/node/pull/32921/commits/afd02b2579235dd743946f00028c3bf17c189e84 |
|
| https://github.com/bl-ue |
| src: do not compare against wide characters | https://github.com/nodejs/node/pull/32921/commits/101780635cb02bcc5a0256bc09e02b781ce14b8b |
| 1017806 | https://github.com/nodejs/node/pull/32921/commits/101780635cb02bcc5a0256bc09e02b781ce14b8b |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 19, 2020
| https://github.com/nodejs/node/pull/32921#pullrequestreview-396058908 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32921/files/101780635cb02bcc5a0256bc09e02b781ce14b8b |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Apr 20, 2020
| https://github.com/nodejs/node/pull/32921#pullrequestreview-396378572 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32921/files/101780635cb02bcc5a0256bc09e02b781ce14b8b |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/32921#pullrequestreview-396378572 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| addaleax | https://github.com/addaleax |
| April 20, 2020 11:46 | https://github.com/nodejs/node/pull/32921#event-3251375362 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 20, 2020 | https://github.com/nodejs/node/pull/32921#issuecomment-616500200 |
| https://ci.nodejs.org/job/node-test-pull-request/30858/ | https://ci.nodejs.org/job/node-test-pull-request/30858/ |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Apr 20, 2020 | https://github.com/nodejs/node/pull/32921#issuecomment-616580548 |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
| 15a7f4c | https://github.com/nodejs/node/commit/15a7f4cbc0bc9eba041cd3a9b7fe62dfeb714847 |
| 1017806 | https://github.com/nodejs/node/commit/101780635cb02bcc5a0256bc09e02b781ce14b8b |
| std::string::at() | https://en.cppreference.com/w/cpp/string/basic_string/at |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
|
| https://github.com/bl-ue |
| Revert "src: relax assertion in operator[] of MaybeStackBuffer" | https://github.com/nodejs/node/pull/32921/commits/f181bc8f85b469bc487c6c50ecd3ee3101a712f5 |
| f181bc8 | https://github.com/nodejs/node/pull/32921/commits/f181bc8f85b469bc487c6c50ecd3ee3101a712f5 |
| afd02b2 | https://github.com/nodejs/node/commit/afd02b2579235dd743946f00028c3bf17c189e84 |
| https://github.com/bl-ue |
| bl-ue | https://github.com/bl-ue |
| Apr 20, 2020 | https://github.com/nodejs/node/pull/32921#issuecomment-616632683 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
|
Apr 21, 2020
| https://github.com/nodejs/node/pull/32921#pullrequestreview-397435412 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32921/files/f181bc8f85b469bc487c6c50ecd3ee3101a712f5 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
|
Apr 23, 2020
| https://github.com/nodejs/node/pull/32921#pullrequestreview-398763214 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32921/files/f181bc8f85b469bc487c6c50ecd3ee3101a712f5 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 23, 2020 | https://github.com/nodejs/node/pull/32921#issuecomment-618181781 |
| https://ci.nodejs.org/job/node-test-pull-request/30916/ | https://ci.nodejs.org/job/node-test-pull-request/30916/ |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 23, 2020 | https://github.com/nodejs/node/pull/32921#issuecomment-618493504 |
| https://ci.nodejs.org/job/node-test-pull-request/30928/ | https://ci.nodejs.org/job/node-test-pull-request/30928/ |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Apr 25, 2020
| https://github.com/nodejs/node/pull/32921#pullrequestreview-400337998 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32921/files/f181bc8f85b469bc487c6c50ecd3ee3101a712f5 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 25, 2020 | https://github.com/nodejs/node/pull/32921#issuecomment-619293486 |
| https://ci.nodejs.org/job/node-test-pull-request/30967/ | https://ci.nodejs.org/job/node-test-pull-request/30967/ |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
lts-watch-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x |
| Apr 25, 2020 | https://github.com/nodejs/node/pull/32921#event-3271420948 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
Apr 26, 2020
| https://github.com/nodejs/node/pull/32921#pullrequestreview-400538605 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32921/files/f181bc8f85b469bc487c6c50ecd3ee3101a712f5 |
| juanarbol | https://github.com/juanarbol |
| https://github.com/nodejs/node/pull/32921#pullrequestreview-400538605 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Apr 26, 2020 | https://github.com/nodejs/node/pull/32921#event-3273302423 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Apr 26, 2020 | https://github.com/nodejs/node/pull/32921#issuecomment-619615358 |
| @bl-ue | https://github.com/bl-ue |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
|
| https://github.com/bl-ue |
| src: fix env var empty key access in Worker thread | https://github.com/nodejs/node/pull/32921/commits/446a07a3dd2492e9482b4648efeec3f8801bf91a |
| 446a07a | https://github.com/nodejs/node/pull/32921/commits/446a07a3dd2492e9482b4648efeec3f8801bf91a |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Apr 26, 2020 | https://github.com/nodejs/node/pull/32921#event-3273451947 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 26, 2020 | https://github.com/nodejs/node/pull/32921#issuecomment-619635389 |
| https://ci.nodejs.org/job/node-test-pull-request/30994/ | https://ci.nodejs.org/job/node-test-pull-request/30994/ |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
| https://github.com/bl-ue |
| bl-ue | https://github.com/bl-ue |
| Apr 26, 2020 | https://github.com/nodejs/node/pull/32921#issuecomment-619635757 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
| https://github.com/bl-ue |
| bl-ue | https://github.com/bl-ue |
| addaleax | https://github.com/addaleax |
| April 27, 2020 02:21 | https://github.com/nodejs/node/pull/32921#event-3273706906 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 27, 2020
| https://github.com/nodejs/node/pull/32921#ref-pullrequest-607819306 |
|
v14.1.0 proposal
#33103
| https://github.com/nodejs/node/pull/33103 |
| BridgeAR | https://github.com/BridgeAR |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-f14916f |
|
| https://github.com/bl-ue |
|
| https://github.com/BridgeAR |
| worker: fix process.env var empty key access | https://github.com/nodejs/node/commit/f14916ffc9e9cd4b990aab5ae4a85216458fe18a |
| f14916f | https://github.com/nodejs/node/commit/f14916ffc9e9cd4b990aab5ae4a85216458fe18a |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| BridgeAR | https://github.com/BridgeAR |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-02653b8 |
|
| https://github.com/bl-ue |
|
| https://github.com/BridgeAR |
| src: fix empty-named env var assertion failure | https://github.com/nodejs/node/commit/02653b8310d99353ab59b2821c99e7b3cae74695 |
| 02653b8 | https://github.com/nodejs/node/commit/02653b8310d99353ab59b2821c99e7b3cae74695 |
| #32920 | https://github.com/nodejs/node/issues/32920 |
| #27310 | https://github.com/nodejs/node/pull/27310 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| BridgeAR | https://github.com/BridgeAR |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-44a5b73 |
|
| https://github.com/bl-ue |
|
| https://github.com/BridgeAR |
| src: do not compare against wide characters | https://github.com/nodejs/node/commit/44a5b734211559ed5a32626737a801cdc8a69147 |
| 44a5b73 | https://github.com/nodejs/node/commit/44a5b734211559ed5a32626737a801cdc8a69147 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| BridgeAR | https://github.com/BridgeAR |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-428fca1 |
|
| https://github.com/bl-ue |
|
| https://github.com/BridgeAR |
| worker: fix process.env var empty key access | https://github.com/nodejs/node/commit/428fca1fc930b89a7dbca8e5114c5fc352bc3990 |
| 428fca1 | https://github.com/nodejs/node/commit/428fca1fc930b89a7dbca8e5114c5fc352bc3990 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| BridgeAR | https://github.com/BridgeAR |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-018de28 |
|
| https://github.com/bl-ue |
|
| https://github.com/BridgeAR |
| src: fix empty-named env var assertion failure | https://github.com/nodejs/node/commit/018de28bf3aa57b03b23d80b81e0208045926148 |
| 018de28 | https://github.com/nodejs/node/commit/018de28bf3aa57b03b23d80b81e0208045926148 |
| #32920 | https://github.com/nodejs/node/issues/32920 |
| #27310 | https://github.com/nodejs/node/pull/27310 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| BridgeAR | https://github.com/BridgeAR |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-14cf904 |
|
| https://github.com/bl-ue |
|
| https://github.com/BridgeAR |
| src: do not compare against wide characters | https://github.com/nodejs/node/commit/14cf9043e57efc430699576e483a4f1772335f5a |
| 14cf904 | https://github.com/nodejs/node/commit/14cf9043e57efc430699576e483a4f1772335f5a |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/32921#ref-pullrequest-608268983 |
|
v13.14.0 proposal
#33122
| https://github.com/nodejs/node/pull/33122 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-03fce45 |
|
| https://github.com/bl-ue |
|
| https://github.com/BethGriggs |
| worker: fix process.env var empty key access | https://github.com/nodejs/node/commit/03fce4576e756f882bbe26abf2beea76c5e09ba1 |
| 03fce45 | https://github.com/nodejs/node/commit/03fce4576e756f882bbe26abf2beea76c5e09ba1 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-23aba12 |
|
| https://github.com/bl-ue |
|
| https://github.com/BethGriggs |
| src: fix empty-named env var assertion failure | https://github.com/nodejs/node/commit/23aba1267960c70e21c3d261883c90863a5943cf |
| 23aba12 | https://github.com/nodejs/node/commit/23aba1267960c70e21c3d261883c90863a5943cf |
| #32920 | https://github.com/nodejs/node/issues/32920 |
| #27310 | https://github.com/nodejs/node/pull/27310 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-cc5c347 |
|
| https://github.com/bl-ue |
|
| https://github.com/BethGriggs |
| src: do not compare against wide characters | https://github.com/nodejs/node/commit/cc5c347fbd3adac0ab8768e8d59ba63741b06dce |
| cc5c347 | https://github.com/nodejs/node/commit/cc5c347fbd3adac0ab8768e8d59ba63741b06dce |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-c84d802 |
|
| https://github.com/bl-ue |
|
| https://github.com/BethGriggs |
| worker: fix process.env var empty key access | https://github.com/nodejs/node/commit/c84d802449f8b1082052ca46678861d17e06602e |
| c84d802 | https://github.com/nodejs/node/commit/c84d802449f8b1082052ca46678861d17e06602e |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-d10c2c6 |
|
| https://github.com/bl-ue |
|
| https://github.com/BethGriggs |
| src: fix empty-named env var assertion failure | https://github.com/nodejs/node/commit/d10c2c69686d774a1e654f00fd05f8f6126d476a |
| d10c2c6 | https://github.com/nodejs/node/commit/d10c2c69686d774a1e654f00fd05f8f6126d476a |
| #32920 | https://github.com/nodejs/node/issues/32920 |
| #27310 | https://github.com/nodejs/node/pull/27310 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-23eda41 |
|
| https://github.com/bl-ue |
|
| https://github.com/BethGriggs |
| src: do not compare against wide characters | https://github.com/nodejs/node/commit/23eda417b66a671ad9c50378c9063345e69794ee |
| 23eda41 | https://github.com/nodejs/node/commit/23eda417b66a671ad9c50378c9063345e69794ee |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| targos | https://github.com/targos |
|
Apr 30, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-0da2114 |
|
| https://github.com/bl-ue |
|
| https://github.com/targos |
| worker: fix process.env var empty key access | https://github.com/nodejs/node/commit/0da211480fa290d0598d5f89902ef56d3f8bba85 |
| 0da2114 | https://github.com/nodejs/node/commit/0da211480fa290d0598d5f89902ef56d3f8bba85 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| targos | https://github.com/targos |
|
Apr 30, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-c4e5950 |
|
| https://github.com/bl-ue |
|
| https://github.com/targos |
| src: fix empty-named env var assertion failure | https://github.com/nodejs/node/commit/c4e5950651ed358a0b387d6d5f90a27df69294cc |
| c4e5950 | https://github.com/nodejs/node/commit/c4e5950651ed358a0b387d6d5f90a27df69294cc |
| #32920 | https://github.com/nodejs/node/issues/32920 |
| #27310 | https://github.com/nodejs/node/pull/27310 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| targos | https://github.com/targos |
|
Apr 30, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-892a0ba |
|
| https://github.com/bl-ue |
|
| https://github.com/targos |
| src: do not compare against wide characters | https://github.com/nodejs/node/commit/892a0ba0a8828b45d0d775d3a7e410758ff7185b |
| 892a0ba | https://github.com/nodejs/node/commit/892a0ba0a8828b45d0d775d3a7e410758ff7185b |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 2, 2020
| https://github.com/nodejs/node/pull/32921#ref-pullrequest-610737650 |
|
v12.17.0 release proposal
#33197
| https://github.com/nodejs/node/pull/33197 |
| targos | https://github.com/targos |
|
May 13, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-9ce6e36 |
|
| https://github.com/bl-ue |
|
| https://github.com/targos |
| worker: fix process.env var empty key access | https://github.com/nodejs/node/commit/9ce6e363f40708c2474082c72de22f0234dd9d16 |
| 9ce6e36 | https://github.com/nodejs/node/commit/9ce6e363f40708c2474082c72de22f0234dd9d16 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| targos | https://github.com/targos |
|
May 13, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-60db9af |
|
| https://github.com/bl-ue |
|
| https://github.com/targos |
| src: fix empty-named env var assertion failure | https://github.com/nodejs/node/commit/60db9afde51c23966549ec6e5a91c283abaa9356 |
| 60db9af | https://github.com/nodejs/node/commit/60db9afde51c23966549ec6e5a91c283abaa9356 |
| #32920 | https://github.com/nodejs/node/issues/32920 |
| #27310 | https://github.com/nodejs/node/pull/27310 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| targos | https://github.com/targos |
|
May 13, 2020
| https://github.com/nodejs/node/pull/32921#ref-commit-08b66f2 |
|
| https://github.com/bl-ue |
|
| https://github.com/targos |
| src: do not compare against wide characters | https://github.com/nodejs/node/commit/08b66f223d37a8794ab0b2c5a73d872df52d8e17 |
| 08b66f2 | https://github.com/nodejs/node/commit/08b66f223d37a8794ab0b2c5a73d872df52d8e17 |
| #32921 | https://github.com/nodejs/node/pull/32921 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
backported-to-v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v12.x |
|
lts-watch-v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v12.x |
| Jul 1, 2020 | https://github.com/nodejs/node/pull/32921#event-3503205376 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Jul 2, 2020 | https://github.com/nodejs/node/pull/32921#issuecomment-653026445 |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
| #25067 | https://github.com/nodejs/node/pull/25067 |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
backport-requested-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x |
| Jul 2, 2020 | https://github.com/nodejs/node/pull/32921#event-3507276639 |
| https://github.com/bl-ue |
| bl-ue | https://github.com/bl-ue |
| Feb 5, 2021 | https://github.com/nodejs/node/pull/32921#issuecomment-773997468 |
| @richardlau | https://github.com/richardlau |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
lts-watch-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x |
| Feb 5, 2021 | https://github.com/nodejs/node/pull/32921#event-4295885043 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32921 |
|
| https://github.com/fhinkel |
|
fhinkel
| https://github.com/fhinkel |
|
| https://github.com/nodejs/node/pull/32921/files/f181bc8f85b469bc487c6c50ecd3ee3101a712f5 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/32921/files/101780635cb02bcc5a0256bc09e02b781ce14b8b |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/32921/files/101780635cb02bcc5a0256bc09e02b781ce14b8b |
|
| https://github.com/himself65 |
|
himself65
| https://github.com/himself65 |
|
| https://github.com/nodejs/node/pull/32921/files/f181bc8f85b469bc487c6c50ecd3ee3101a712f5 |
|
| https://github.com/juanarbol |
|
juanarbol
| https://github.com/juanarbol |
|
| https://github.com/nodejs/node/pull/32921/files/f181bc8f85b469bc487c6c50ecd3ee3101a712f5 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/devnexen |
|
devnexen
| https://github.com/devnexen |
|
| https://github.com/nodejs/node/pull/32921/files/7997ae406bdf2356022ced443e575f59a2c7e58c |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
Setting environment variable with empty name on Windows causes assertion failure
| https://github.com/nodejs/node/issues/32920 |
| Please reload this page | https://github.com/nodejs/node/pull/32921 |
|
| https://github.com/bl-ue |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/richardlau |
|
| https://github.com/fhinkel |
|
| https://github.com/bnoordhuis |
|
| https://github.com/jasnell |
|
| https://github.com/devnexen |
|
| https://github.com/himself65 |
|
| https://github.com/juanarbol |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |