René's URL Explorer Experiment


Title: js_stream: prevent abort if isalive doesn't exist by trevnorris · Pull Request #3282 · nodejs/node · GitHub

Open Graph Title: js_stream: prevent abort if isalive doesn't exist by trevnorris · Pull Request #3282 · nodejs/node

X Title: js_stream: prevent abort if isalive doesn't exist by trevnorris · Pull Request #3282 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Attempting to check IsAlive() on a JSStream before the isAlive() callback can be set in JS causes a CHECK to fail in MakeCallback. Instead return false if the callback hasn't been set. R=@indut...

X Description: Attempting to check IsAlive() on a JSStream before the isAlive() callback can be set in JS causes a CHECK to fail in MakeCallback. Instead return false if the callback hasn't been set. R=@i...

Opengraph URL: https://github.com/nodejs/node/pull/3282

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:acbdb5a6-0435-7c90-5eb7-2a352ee0f3b6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC2B8:2F2307:134552:19DF0A:6A4D83F8
html-safe-nonce5b767ec693de444743b9a7b9f4548fd0c0f486e7ba300a0ddfafd16ca7a979ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkI4OjJGMjMwNzoxMzQ1NTI6MTlERjBBOjZBNEQ4M0Y4IiwidmlzaXRvcl9pZCI6Ijg2NTE4MTQxNzkzNTMwNzc2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5ab5860e015aa902cc8ad31ce5e7edbefff9b28ae23094dfe8cb7e12fe40892c
hovercard-subject-tagpull_request:47179519
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/3282/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3967ad048a2e84ff1426998aa8cf8c9b09d928661820fbde6021e59d5775202c/nodejs/node/pull/3282
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3967ad048a2e84ff1426998aa8cf8c9b09d928661820fbde6021e59d5775202c/nodejs/node/pull/3282
og:image:altAttempting to check IsAlive() on a JSStream before the isAlive() callback can be set in JS causes a CHECK to fail in MakeCallback. Instead return false if the callback hasn't been set. R=@indut...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrevnorris
hostnamegithub.com
expected-hostnamegithub.com
Nonec6bf61c909482ec3072ef5d7a5a28f2a9d214788c9a44793eca1960048cb05ae
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6702a58b419a792226bd21ef0fb1bcb318bbcaa3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/3282#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3282
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3282
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/3282
Reloadhttps://github.com/nodejs/node/pull/3282
Reloadhttps://github.com/nodejs/node/pull/3282
Please reload this pagehttps://github.com/nodejs/node/pull/3282
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/3282
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
trevnorrishttps://github.com/trevnorris
nodejs:masterhttps://github.com/nodejs/node/tree/master
trevnorris:no-abort-wo-cbhttps://github.com/trevnorris/node/tree/no-abort-wo-cb
Conversationhttps://github.com/nodejs/node/pull/3282
Commits1 (1)https://github.com/nodejs/node/pull/3282/commits
Checkshttps://github.com/nodejs/node/pull/3282/checks
Files changedhttps://github.com/nodejs/node/pull/3282/files
js_stream: prevent abort if isalive doesn't existhttps://github.com/nodejs/node/pull/3282#top
trevnorrishttps://github.com/trevnorris
nodejs:masterhttps://github.com/nodejs/node/tree/master
trevnorris:no-abort-wo-cbhttps://github.com/trevnorris/node/tree/no-abort-wo-cb
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 8, 2015https://github.com/nodejs/node/pull/3282#issue-110499498
@indutnyhttps://github.com/indutny
https://ci.nodejs.org/job/node-test-pull-request/455/https://ci.nodejs.org/job/node-test-pull-request/455/
Please reload this pagehttps://github.com/nodejs/node/pull/3282
https://github.com/trevnorris
js_stream: prevent abort if isalive doesn't existhttps://github.com/nodejs/node/pull/3282/commits/0e539e39f0483a7493f1a6cb84b6d075334330c2
0e539e3https://github.com/nodejs/node/pull/3282/commits/0e539e39f0483a7493f1a6cb84b6d075334330c2
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Oct 8, 2015https://github.com/nodejs/node/pull/3282#event-430562049
https://github.com/indutny
indutnyhttps://github.com/indutny
Oct 8, 2015https://github.com/nodejs/node/pull/3282#issuecomment-146629635
Please reload this pagehttps://github.com/nodejs/node/pull/3282
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 8, 2015 https://github.com/nodejs/node/pull/3282#ref-issue-109083810
Using JSStream and querying persistents crashes in async_wrap nodesource/persistents-with-classid#3 https://github.com/nodesource/persistents-with-classid/issues/3
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 8, 2015https://github.com/nodejs/node/pull/3282#issuecomment-146632913
Please reload this pagehttps://github.com/nodejs/node/pull/3282
trevnorrishttps://github.com/trevnorris
Oct 8, 2015 https://github.com/nodejs/node/pull/3282#ref-commit-178ac33
https://github.com/trevnorris
js_stream: prevent abort if isalive doesn't existhttps://github.com/nodejs/node/commit/178ac3367f8ec21e69034e9d1bda39ddfe549b6d
178ac33https://github.com/nodejs/node/commit/178ac3367f8ec21e69034e9d1bda39ddfe549b6d
#3282https://github.com/nodejs/node/pull/3282
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 8, 2015https://github.com/nodejs/node/pull/3282#issuecomment-146634430
178ac33https://github.com/nodejs/node/commit/178ac3367f8ec21e69034e9d1bda39ddfe549b6d
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/3282
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
Oct 8, 2015https://github.com/nodejs/node/pull/3282#event-430596574
trevnorrishttps://github.com/trevnorris
Oct 8, 2015 https://github.com/nodejs/node/pull/3282#ref-commit-1850879
https://github.com/trevnorris
js_stream: prevent abort if isalive doesn't existhttps://github.com/nodejs/node/commit/1850879b0e6d5e1e52e35790ab448c4c6dee34f0
1850879https://github.com/nodejs/node/commit/1850879b0e6d5e1e52e35790ab448c4c6dee34f0
#3282https://github.com/nodejs/node/pull/3282
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 8, 2015https://github.com/nodejs/node/pull/3282#issuecomment-146637407
1850879https://github.com/nodejs/node/commit/1850879b0e6d5e1e52e35790ab448c4c6dee34f0
Please reload this pagehttps://github.com/nodejs/node/pull/3282
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
lts-landed-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-landed-on-v4.x
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
Oct 8, 2015https://github.com/nodejs/node/pull/3282#event-430609784
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 8, 2015 https://github.com/nodejs/node/pull/3282#ref-pullrequest-110375513
Release proposal: v4.2.0 'Argon' (LTS) #3258 https://github.com/nodejs/node/pull/3258
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 9, 2015https://github.com/nodejs/node/pull/3282#event-431013915
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
March 28, 2016 22:25https://github.com/nodejs/node/pull/3282#event-605851616
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3282
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/3282
https://github.com/trevnorris
https://github.com/indutny
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.