| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f69b404c-d11e-cb5f-0fc2-b8430954748a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 808C:296AF5:20B8479:2CED7FA:696ABA4B |
| html-safe-nonce | 5c1e744c6c1bfa0954e9a0bd2bc1971c10e784256030b24bd5a059ef49c93a23 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDhDOjI5NkFGNToyMEI4NDc5OjJDRUQ3RkE6Njk2QUJBNEIiLCJ2aXNpdG9yX2lkIjoiOTIwMDE3NTM3NTUyNDIxNTM3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5984bfd26f94e53113b38e002f6170b9eab777f1a541f9a156d467d755bd2f0b |
| hovercard-subject-tag | pull_request:402176579 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32780/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fbc26940d4f0b3c658efbbdb41beaba61fce0726d15a8e364b0ab1da38630d46/nodejs/node/pull/32780 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fbc26940d4f0b3c658efbbdb41beaba61fce0726d15a8e364b0ab1da38630d46/nodejs/node/pull/32780 |
| og:image:alt | This PR fixes a few different things:
The timing of 'prefinish' depends on whether or not
_final is defined. In one case the event is emitted
synchronously with end() and otherwise asynchro... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ronag |
| hostname | github.com |
| expected-hostname | github.com |
| None | 46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 30300f30bb3949de255e84a146706a3bdb5c19c9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/32780#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/32780 |
| Reload | https://github.com/nodejs/node/pull/32780 |
| Reload | https://github.com/nodejs/node/pull/32780 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/32780#issue-comment-box |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:stream-finish | https://github.com/nxtedition/node/tree/stream-finish |
|
stream: fix _final and 'prefinish' timing
| https://github.com/nodejs/node/pull/32780#top |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:stream-finish | https://github.com/nxtedition/node/tree/stream-finish |
|
Conversation
65
| https://github.com/nodejs/node/pull/32780 |
|
Commits
3
| https://github.com/nodejs/node/pull/32780/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/32780/checks |
|
Files changed
| https://github.com/nodejs/node/pull/32780/files |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Apr 11, 2020 | https://github.com/nodejs/node/pull/32780#issue-598246082 |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| #31401 | https://github.com/nodejs/node/issues/31401 |
| #32763 (comment) | https://github.com/nodejs/node/pull/32763#discussion_r407041983 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Apr 11, 2020 | https://github.com/nodejs/node/pull/32780#event-3223957301 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| mcollina | https://github.com/mcollina |
| April 11, 2020 11:21 | https://github.com/nodejs/node/pull/32780#event-3223957303 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Apr 11, 2020
| https://github.com/nodejs/node/pull/32780#pullrequestreview-391768976 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32780/files |
| test/parallel/test-fs-write-stream-end.js | https://github.com/nodejs/node/pull/32780/files#diff-af2529f54d9bf30677c0f14003480a39d64c756b3d68f034fdf5935183950f5d |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Apr 11, 2020
| https://github.com/nodejs/node/pull/32780#pullrequestreview-391770073 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32780/files |
| lib/internal/fs/streams.js | https://github.com/nodejs/node/pull/32780/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/52ad4476565a3df8dcc8afc7650f163dfb1b0d61..15142097716cbc14da6cb039bed2b652756c3e25 |
| 52ad447 | https://github.com/nodejs/node/commit/52ad4476565a3df8dcc8afc7650f163dfb1b0d61 |
| 1514209 | https://github.com/nodejs/node/commit/15142097716cbc14da6cb039bed2b652756c3e25 |
|
Compare
| https://github.com/nodejs/node/compare/52ad4476565a3df8dcc8afc7650f163dfb1b0d61..15142097716cbc14da6cb039bed2b652756c3e25 |
| April 11, 2020 14:31 | https://github.com/nodejs/node/pull/32780#event-3224118859 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Apr 11, 2020
| https://github.com/nodejs/node/pull/32780#pullrequestreview-391772812 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32780/files |
| lib/_stream_writable.js | https://github.com/nodejs/node/pull/32780/files#diff-a7fdfe149712099064db4e7b80a1b39e28515b4efb3fab2f4b9499ce3b7c51c3 |
| ronag | https://github.com/ronag |
| Apr 11, 2020 | https://github.com/nodejs/node/pull/32780#discussion_r407072920 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Apr 11, 2020
| https://github.com/nodejs/node/pull/32780#pullrequestreview-391772896 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32780/files |
| test/parallel/test-http2-client-rststream-before-connect.js | https://github.com/nodejs/node/pull/32780/files#diff-c2925273f2dba27cf14f3d4ac336d18b59890f1666da60272f63db75be79e4a8 |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/d0b3e8e45918dc819be774fd0ca873facdc2243a..8155782c73823e830e5055e9534e95858cf73da5 |
| d0b3e8e | https://github.com/nodejs/node/commit/d0b3e8e45918dc819be774fd0ca873facdc2243a |
| 8155782 | https://github.com/nodejs/node/commit/8155782c73823e830e5055e9534e95858cf73da5 |
|
Compare
| https://github.com/nodejs/node/compare/d0b3e8e45918dc819be774fd0ca873facdc2243a..8155782c73823e830e5055e9534e95858cf73da5 |
| April 11, 2020 19:40 | https://github.com/nodejs/node/pull/32780#event-3224418372 |
| https://github.com/ronag |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/c38dca7b9f4e151e771fa45427e7ae0f3db8e39b..5a6c161582fe93b5d95b9bf377e1a08978e53dc5 |
| c38dca7 | https://github.com/nodejs/node/commit/c38dca7b9f4e151e771fa45427e7ae0f3db8e39b |
| 5a6c161 | https://github.com/nodejs/node/commit/5a6c161582fe93b5d95b9bf377e1a08978e53dc5 |
|
Compare
| https://github.com/nodejs/node/compare/c38dca7b9f4e151e771fa45427e7ae0f3db8e39b..5a6c161582fe93b5d95b9bf377e1a08978e53dc5 |
| April 11, 2020 20:01 | https://github.com/nodejs/node/pull/32780#event-3224436951 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780 |
| https://github.com/ronag |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/2d89c91628d87051848e56da804e6a51d437d6b4..7a7d831dcdc832154d315c16f72ba9ca4dc28252 |
| 2d89c91 | https://github.com/nodejs/node/commit/2d89c91628d87051848e56da804e6a51d437d6b4 |
| 7a7d831 | https://github.com/nodejs/node/commit/7a7d831dcdc832154d315c16f72ba9ca4dc28252 |
|
Compare
| https://github.com/nodejs/node/compare/2d89c91628d87051848e56da804e6a51d437d6b4..7a7d831dcdc832154d315c16f72ba9ca4dc28252 |
| April 11, 2020 20:27 | https://github.com/nodejs/node/pull/32780#event-3224459456 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/73a08ce1eb9535bade50ffc9f363ea054320ad2a..0c7a5e869ff3447f7f4f99c37a234baa178eac7e |
| 73a08ce | https://github.com/nodejs/node/commit/73a08ce1eb9535bade50ffc9f363ea054320ad2a |
| 0c7a5e8 | https://github.com/nodejs/node/commit/0c7a5e869ff3447f7f4f99c37a234baa178eac7e |
|
Compare
| https://github.com/nodejs/node/compare/73a08ce1eb9535bade50ffc9f363ea054320ad2a..0c7a5e869ff3447f7f4f99c37a234baa178eac7e |
| April 11, 2020 20:53 | https://github.com/nodejs/node/pull/32780#event-3224482454 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 11, 2020 | https://github.com/nodejs/node/pull/32780#issuecomment-612511803 |
| https://ci.nodejs.org/job/node-test-pull-request/30648/ | https://ci.nodejs.org/job/node-test-pull-request/30648/ |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Apr 11, 2020
| https://github.com/nodejs/node/pull/32780#pullrequestreview-391800230 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32780/files |
| lib/internal/http2/core.js | https://github.com/nodejs/node/pull/32780/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639 |
| ronag | https://github.com/ronag |
| Apr 11, 2020 | https://github.com/nodejs/node/pull/32780#discussion_r407110482 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Apr 11, 2020
| https://github.com/nodejs/node/pull/32780#pullrequestreview-391800268 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32780/files |
| lib/_stream_writable.js | https://github.com/nodejs/node/pull/32780/files#diff-a7fdfe149712099064db4e7b80a1b39e28515b4efb3fab2f4b9499ce3b7c51c3 |
| ronag | https://github.com/ronag |
| Apr 11, 2020 | https://github.com/nodejs/node/pull/32780#discussion_r407110524 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| ronag | https://github.com/ronag |
| Apr 11, 2020 | https://github.com/nodejs/node/pull/32780#discussion_r407110668 |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Apr 11, 2020
| https://github.com/nodejs/node/pull/32780#pullrequestreview-391800307 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32780/files |
| lib/_stream_writable.js | https://github.com/nodejs/node/pull/32780/files#diff-a7fdfe149712099064db4e7b80a1b39e28515b4efb3fab2f4b9499ce3b7c51c3 |
| ronag | https://github.com/ronag |
| Apr 11, 2020 | https://github.com/nodejs/node/pull/32780#discussion_r407110566 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Apr 11, 2020 | https://github.com/nodejs/node/pull/32780#issuecomment-612515180 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Apr 11, 2020 | https://github.com/nodejs/node/pull/32780#issuecomment-612518838 |
| @vweevers | https://github.com/vweevers |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
|
| https://github.com/ronag |
| stream: fix _final and 'prefinish' timing | https://github.com/nodejs/node/pull/32780/commits/be9f7264c9fd643e8378449616b0abc4e6b45099 |
| be9f726 | https://github.com/nodejs/node/pull/32780/commits/be9f7264c9fd643e8378449616b0abc4e6b45099 |
| nodejs#31401 | https://github.com/nodejs/node/issues/31401 |
| nodejs#32763 (comment) | https://github.com/nodejs/node/pull/32763#discussion_r407041983 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/30761543baac1256d37aec17b59d5ddf1cdd0db4..be9f7264c9fd643e8378449616b0abc4e6b45099 |
| 3076154 | https://github.com/nodejs/node/commit/30761543baac1256d37aec17b59d5ddf1cdd0db4 |
| be9f726 | https://github.com/nodejs/node/commit/be9f7264c9fd643e8378449616b0abc4e6b45099 |
|
Compare
| https://github.com/nodejs/node/compare/30761543baac1256d37aec17b59d5ddf1cdd0db4..be9f7264c9fd643e8378449616b0abc4e6b45099 |
| April 15, 2020 19:39 | https://github.com/nodejs/node/pull/32780#event-3236998648 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Apr 15, 2020 | https://github.com/nodejs/node/pull/32780#issuecomment-614241252 |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 15, 2020 | https://github.com/nodejs/node/pull/32780#issuecomment-614241399 |
| https://ci.nodejs.org/job/node-test-pull-request/30773/ | https://ci.nodejs.org/job/node-test-pull-request/30773/ |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| ronag | https://github.com/ronag |
| April 15, 2020 21:47 | https://github.com/nodejs/node/pull/32780#commits-pushed-469766e |
|
| https://github.com/ronag |
| fixup: comments | https://github.com/nodejs/node/pull/32780/commits/469766e1b9f69c6f0cf6cc73d925c29cdce4394e |
| 469766e | https://github.com/nodejs/node/pull/32780/commits/469766e1b9f69c6f0cf6cc73d925c29cdce4394e |
|
| https://github.com/ronag |
| fixup: missing needFinish | https://github.com/nodejs/node/pull/32780/commits/571eb8893763991da627834bf7260f702ab60edf |
| 571eb88 | https://github.com/nodejs/node/pull/32780/commits/571eb8893763991da627834bf7260f702ab60edf |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 15, 2020 | https://github.com/nodejs/node/pull/32780#issuecomment-614247483 |
| https://ci.nodejs.org/job/node-test-pull-request/30774/ | https://ci.nodejs.org/job/node-test-pull-request/30774/ |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 16, 2020 | https://github.com/nodejs/node/pull/32780#issuecomment-614463329 |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://ci.nodejs.org/job/node-test-pull-request/30777/ | https://ci.nodejs.org/job/node-test-pull-request/30777/ |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Apr 18, 2020
| https://github.com/nodejs/node/pull/32780#ref-pullrequest-601406318 |
|
stream: avoid drain for sync streams
#32887
| https://github.com/nodejs/node/pull/32887 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| jasnell | https://github.com/jasnell |
| April 18, 2020 19:08 | https://github.com/nodejs/node/pull/32780#event-3248302341 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Apr 19, 2020 | https://github.com/nodejs/node/pull/32780#issuecomment-616123968 |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| @lpinca | https://github.com/lpinca |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Apr 19, 2020 | https://github.com/nodejs/node/pull/32780#issuecomment-616182520 |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Apr 22, 2020
| https://github.com/nodejs/node/pull/32780#pullrequestreview-397802908 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32780/files/571eb8893763991da627834bf7260f702ab60edf |
| ronag | https://github.com/ronag |
|
Apr 22, 2020
| https://github.com/nodejs/node/pull/32780#ref-commit-ea87809 |
|
| https://github.com/ronag |
| stream: fix _final and 'prefinish' timing | https://github.com/nodejs/node/commit/ea87809bb6696e2c1ec5d470031f137e18641183 |
| ea87809 | https://github.com/nodejs/node/commit/ea87809bb6696e2c1ec5d470031f137e18641183 |
| #31401 | https://github.com/nodejs/node/issues/31401 |
| #32763 (comment) | https://github.com/nodejs/node/pull/32763#discussion_r407041983 |
| #32780 | https://github.com/nodejs/node/pull/32780 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Apr 22, 2020 | https://github.com/nodejs/node/pull/32780#issuecomment-617608958 |
| ea87809 | https://github.com/nodejs/node/commit/ea87809bb6696e2c1ec5d470031f137e18641183 |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Apr 22, 2020 | https://github.com/nodejs/node/pull/32780#event-3259264473 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Apr 22, 2020 | https://github.com/nodejs/node/pull/32780#issuecomment-617609016 |
| @lpinca | https://github.com/lpinca |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| lpinca | https://github.com/lpinca |
|
Apr 22, 2020
| https://github.com/nodejs/node/pull/32780#ref-commit-651d662 |
|
| https://github.com/lpinca |
| [fix] Call the _final() callback before destroying the stream | https://github.com/websockets/ws/commit/651d6627f7825026d80f45569880b0f3a817340d |
| 651d662 | https://github.com/websockets/ws/commit/651d6627f7825026d80f45569880b0f3a817340d |
| nodejs/node#32780 | https://github.com/nodejs/node/pull/32780 |
| lpinca | https://github.com/lpinca |
|
Apr 22, 2020
| https://github.com/nodejs/node/pull/32780#ref-commit-3730467 |
|
| https://github.com/lpinca |
| [test] Do not call duplex.end() prematurely | https://github.com/websockets/ws/commit/373046710b80716d55058f418f3f9925d4b3a842 |
| 3730467 | https://github.com/websockets/ws/commit/373046710b80716d55058f418f3f9925d4b3a842 |
| nodejs/node#32780 | https://github.com/nodejs/node/pull/32780 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Apr 22, 2020 | https://github.com/nodejs/node/pull/32780#issuecomment-617632262 |
| websockets/ws#1736 | https://github.com/websockets/ws/pull/1736 |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Apr 22, 2020 | https://github.com/nodejs/node/pull/32780#issuecomment-617912887 |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| #32887 | https://github.com/nodejs/node/pull/32887 |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Apr 22, 2020 | https://github.com/nodejs/node/pull/32780#issuecomment-617914782 |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| @MylesBorins | https://github.com/MylesBorins |
| @lpinca | https://github.com/lpinca |
| see above | https://github.com/nodejs/node/pull/32780#issuecomment-617912887 |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Apr 22, 2020 | https://github.com/nodejs/node/pull/32780#issuecomment-617918959 |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Sep 1, 2020
| https://github.com/nodejs/node/pull/32780#ref-pullrequest-690440226 |
|
2020-10-20, Version 15.0.0 (Current)
#35014
| https://github.com/nodejs/node/pull/35014 |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 19, 2020
| https://github.com/nodejs/node/pull/32780#ref-commit-782053e |
|
| https://github.com/BethGriggs |
| 2020-10-20, Version 15.0.0 (Current) | https://github.com/nodejs/node/commit/782053ea417ae77aae80c7dda7ff3cb0cfb7fce8 |
| 782053e | https://github.com/nodejs/node/commit/782053ea417ae77aae80c7dda7ff3cb0cfb7fce8 |
| #27576 | https://github.com/nodejs/node/pull/27576 |
| #33694 | https://github.com/nodejs/node/pull/33694 |
| #35316 | https://github.com/nodejs/node/pull/35316 |
| #35562 | https://github.com/nodejs/node/pull/35562 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #33647 | https://github.com/nodejs/node/pull/33647 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33648 | https://github.com/nodejs/node/pull/33648 |
| #33950 | https://github.com/nodejs/node/pull/33950 |
| #32744 | https://github.com/nodejs/node/pull/32744 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #33021 | https://github.com/nodejs/node/pull/33021 |
| #32379 | https://github.com/nodejs/node/pull/32379 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #34001 | https://github.com/nodejs/node/pull/34001 |
| #32953 | https://github.com/nodejs/node/pull/32953 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #34664 | https://github.com/nodejs/node/pull/34664 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #31806 | https://github.com/nodejs/node/pull/31806 |
| #33874 | https://github.com/nodejs/node/pull/33874 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34001 | https://github.com/nodejs/node/pull/34001 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #27576 | https://github.com/nodejs/node/pull/27576 |
| #33694 | https://github.com/nodejs/node/pull/33694 |
| #35093 | https://github.com/nodejs/node/pull/35093 |
| #35093 | https://github.com/nodejs/node/pull/35093 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #35474 | https://github.com/nodejs/node/pull/35474 |
| #33600 | https://github.com/nodejs/node/pull/33600 |
| #32953 | https://github.com/nodejs/node/pull/32953 |
| #35316 | https://github.com/nodejs/node/pull/35316 |
| #35022 | https://github.com/nodejs/node/pull/35022 |
| #35562 | https://github.com/nodejs/node/pull/35562 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #33405 | https://github.com/nodejs/node/pull/33405 |
| #33172 | https://github.com/nodejs/node/pull/33172 |
| #31818 | https://github.com/nodejs/node/pull/31818 |
| #34664 | https://github.com/nodejs/node/pull/34664 |
| #33161 | https://github.com/nodejs/node/pull/33161 |
| #33535 | https://github.com/nodejs/node/pull/33535 |
| #33193 | https://github.com/nodejs/node/pull/33193 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34682 | https://github.com/nodejs/node/pull/34682 |
| #34022 | https://github.com/nodejs/node/pull/34022 |
| #33857 | https://github.com/nodejs/node/pull/33857 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #34022 | https://github.com/nodejs/node/pull/34022 |
| #33647 | https://github.com/nodejs/node/pull/33647 |
| #31806 | https://github.com/nodejs/node/pull/31806 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #33021 | https://github.com/nodejs/node/pull/33021 |
| #33600 | https://github.com/nodejs/node/pull/33600 |
| #32312 | https://github.com/nodejs/node/pull/32312 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #34762 | https://github.com/nodejs/node/pull/34762 |
| #35498 | https://github.com/nodejs/node/pull/35498 |
| #35033 | https://github.com/nodejs/node/pull/35033 |
| #33579 | https://github.com/nodejs/node/pull/33579 |
| #33874 | https://github.com/nodejs/node/pull/33874 |
| #33971 | https://github.com/nodejs/node/pull/33971 |
| #33648 | https://github.com/nodejs/node/pull/33648 |
| #32859 | https://github.com/nodejs/node/pull/32859 |
| #34314 | https://github.com/nodejs/node/pull/34314 |
| #34204 | https://github.com/nodejs/node/pull/34204 |
| #33991 | https://github.com/nodejs/node/pull/33991 |
| #34101 | https://github.com/nodejs/node/pull/34101 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #33075 | https://github.com/nodejs/node/pull/33075 |
| #32780 | https://github.com/nodejs/node/pull/32780 |
| #32763 | https://github.com/nodejs/node/pull/32763 |
| #29179 | https://github.com/nodejs/node/pull/29179 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #35474 | https://github.com/nodejs/node/pull/35474 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33950 | https://github.com/nodejs/node/pull/33950 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35477 | https://github.com/nodejs/node/pull/35477 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33325 | https://github.com/nodejs/node/pull/33325 |
| #33328 | https://github.com/nodejs/node/pull/33328 |
| #32744 | https://github.com/nodejs/node/pull/32744 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35210 | https://github.com/nodejs/node/pull/35210 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34394 | https://github.com/nodejs/node/pull/34394 |
| #33872 | https://github.com/nodejs/node/pull/33872 |
| #35014 | https://github.com/nodejs/node/pull/35014 |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 20, 2020
| https://github.com/nodejs/node/pull/32780#ref-commit-d683e3d |
|
| https://github.com/BethGriggs |
| 2020-10-20, Version 15.0.0 (Current) | https://github.com/nodejs/node/commit/d683e3dda09b6b3cc6cad6fd2c106e3061a48f0d |
| d683e3d | https://github.com/nodejs/node/commit/d683e3dda09b6b3cc6cad6fd2c106e3061a48f0d |
| #27576 | https://github.com/nodejs/node/pull/27576 |
| #33694 | https://github.com/nodejs/node/pull/33694 |
| #35316 | https://github.com/nodejs/node/pull/35316 |
| #35562 | https://github.com/nodejs/node/pull/35562 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #33647 | https://github.com/nodejs/node/pull/33647 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33648 | https://github.com/nodejs/node/pull/33648 |
| #33950 | https://github.com/nodejs/node/pull/33950 |
| #32744 | https://github.com/nodejs/node/pull/32744 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #33021 | https://github.com/nodejs/node/pull/33021 |
| #32379 | https://github.com/nodejs/node/pull/32379 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #34001 | https://github.com/nodejs/node/pull/34001 |
| #32953 | https://github.com/nodejs/node/pull/32953 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #34664 | https://github.com/nodejs/node/pull/34664 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #31806 | https://github.com/nodejs/node/pull/31806 |
| #33874 | https://github.com/nodejs/node/pull/33874 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34001 | https://github.com/nodejs/node/pull/34001 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #27576 | https://github.com/nodejs/node/pull/27576 |
| #33694 | https://github.com/nodejs/node/pull/33694 |
| #35093 | https://github.com/nodejs/node/pull/35093 |
| #35093 | https://github.com/nodejs/node/pull/35093 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #35474 | https://github.com/nodejs/node/pull/35474 |
| #33600 | https://github.com/nodejs/node/pull/33600 |
| #32953 | https://github.com/nodejs/node/pull/32953 |
| #35316 | https://github.com/nodejs/node/pull/35316 |
| #35022 | https://github.com/nodejs/node/pull/35022 |
| #35562 | https://github.com/nodejs/node/pull/35562 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #33405 | https://github.com/nodejs/node/pull/33405 |
| #33172 | https://github.com/nodejs/node/pull/33172 |
| #31818 | https://github.com/nodejs/node/pull/31818 |
| #34664 | https://github.com/nodejs/node/pull/34664 |
| #33161 | https://github.com/nodejs/node/pull/33161 |
| #33535 | https://github.com/nodejs/node/pull/33535 |
| #33193 | https://github.com/nodejs/node/pull/33193 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34682 | https://github.com/nodejs/node/pull/34682 |
| #34022 | https://github.com/nodejs/node/pull/34022 |
| #33857 | https://github.com/nodejs/node/pull/33857 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #34022 | https://github.com/nodejs/node/pull/34022 |
| #33647 | https://github.com/nodejs/node/pull/33647 |
| #31806 | https://github.com/nodejs/node/pull/31806 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #33021 | https://github.com/nodejs/node/pull/33021 |
| #33600 | https://github.com/nodejs/node/pull/33600 |
| #32312 | https://github.com/nodejs/node/pull/32312 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #34762 | https://github.com/nodejs/node/pull/34762 |
| #35498 | https://github.com/nodejs/node/pull/35498 |
| #35033 | https://github.com/nodejs/node/pull/35033 |
| #33579 | https://github.com/nodejs/node/pull/33579 |
| #33874 | https://github.com/nodejs/node/pull/33874 |
| #33971 | https://github.com/nodejs/node/pull/33971 |
| #33648 | https://github.com/nodejs/node/pull/33648 |
| #32859 | https://github.com/nodejs/node/pull/32859 |
| #34314 | https://github.com/nodejs/node/pull/34314 |
| #34204 | https://github.com/nodejs/node/pull/34204 |
| #33991 | https://github.com/nodejs/node/pull/33991 |
| #34101 | https://github.com/nodejs/node/pull/34101 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #33075 | https://github.com/nodejs/node/pull/33075 |
| #32780 | https://github.com/nodejs/node/pull/32780 |
| #32763 | https://github.com/nodejs/node/pull/32763 |
| #29179 | https://github.com/nodejs/node/pull/29179 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #35474 | https://github.com/nodejs/node/pull/35474 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33950 | https://github.com/nodejs/node/pull/33950 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35477 | https://github.com/nodejs/node/pull/35477 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33325 | https://github.com/nodejs/node/pull/33325 |
| #33328 | https://github.com/nodejs/node/pull/33328 |
| #32744 | https://github.com/nodejs/node/pull/32744 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35210 | https://github.com/nodejs/node/pull/35210 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34394 | https://github.com/nodejs/node/pull/34394 |
| #33872 | https://github.com/nodejs/node/pull/33872 |
| #35014 | https://github.com/nodejs/node/pull/35014 |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 20, 2020
| https://github.com/nodejs/node/pull/32780#ref-commit-57613f8 |
|
| https://github.com/BethGriggs |
| 2020-10-20, Version 15.0.0 (Current) | https://github.com/nodejs/node/commit/57613f8c564982494c5af8070816d675544386bb |
| 57613f8 | https://github.com/nodejs/node/commit/57613f8c564982494c5af8070816d675544386bb |
| #27576 | https://github.com/nodejs/node/pull/27576 |
| #33694 | https://github.com/nodejs/node/pull/33694 |
| #35316 | https://github.com/nodejs/node/pull/35316 |
| #35562 | https://github.com/nodejs/node/pull/35562 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #33647 | https://github.com/nodejs/node/pull/33647 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33648 | https://github.com/nodejs/node/pull/33648 |
| #33950 | https://github.com/nodejs/node/pull/33950 |
| #32744 | https://github.com/nodejs/node/pull/32744 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #33021 | https://github.com/nodejs/node/pull/33021 |
| #32379 | https://github.com/nodejs/node/pull/32379 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #34001 | https://github.com/nodejs/node/pull/34001 |
| #32953 | https://github.com/nodejs/node/pull/32953 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #34664 | https://github.com/nodejs/node/pull/34664 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #31806 | https://github.com/nodejs/node/pull/31806 |
| #33874 | https://github.com/nodejs/node/pull/33874 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34001 | https://github.com/nodejs/node/pull/34001 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #27576 | https://github.com/nodejs/node/pull/27576 |
| #33694 | https://github.com/nodejs/node/pull/33694 |
| #35093 | https://github.com/nodejs/node/pull/35093 |
| #35093 | https://github.com/nodejs/node/pull/35093 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #35474 | https://github.com/nodejs/node/pull/35474 |
| #33600 | https://github.com/nodejs/node/pull/33600 |
| #32953 | https://github.com/nodejs/node/pull/32953 |
| #35316 | https://github.com/nodejs/node/pull/35316 |
| #35022 | https://github.com/nodejs/node/pull/35022 |
| #35562 | https://github.com/nodejs/node/pull/35562 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #33405 | https://github.com/nodejs/node/pull/33405 |
| #33172 | https://github.com/nodejs/node/pull/33172 |
| #31818 | https://github.com/nodejs/node/pull/31818 |
| #34664 | https://github.com/nodejs/node/pull/34664 |
| #33161 | https://github.com/nodejs/node/pull/33161 |
| #33535 | https://github.com/nodejs/node/pull/33535 |
| #33193 | https://github.com/nodejs/node/pull/33193 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34682 | https://github.com/nodejs/node/pull/34682 |
| #34022 | https://github.com/nodejs/node/pull/34022 |
| #33857 | https://github.com/nodejs/node/pull/33857 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #34022 | https://github.com/nodejs/node/pull/34022 |
| #33647 | https://github.com/nodejs/node/pull/33647 |
| #31806 | https://github.com/nodejs/node/pull/31806 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #33021 | https://github.com/nodejs/node/pull/33021 |
| #33600 | https://github.com/nodejs/node/pull/33600 |
| #32312 | https://github.com/nodejs/node/pull/32312 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #34762 | https://github.com/nodejs/node/pull/34762 |
| #35498 | https://github.com/nodejs/node/pull/35498 |
| #35033 | https://github.com/nodejs/node/pull/35033 |
| #33579 | https://github.com/nodejs/node/pull/33579 |
| #33874 | https://github.com/nodejs/node/pull/33874 |
| #33971 | https://github.com/nodejs/node/pull/33971 |
| #33648 | https://github.com/nodejs/node/pull/33648 |
| #32859 | https://github.com/nodejs/node/pull/32859 |
| #34314 | https://github.com/nodejs/node/pull/34314 |
| #34204 | https://github.com/nodejs/node/pull/34204 |
| #33991 | https://github.com/nodejs/node/pull/33991 |
| #34101 | https://github.com/nodejs/node/pull/34101 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #33075 | https://github.com/nodejs/node/pull/33075 |
| #32780 | https://github.com/nodejs/node/pull/32780 |
| #32763 | https://github.com/nodejs/node/pull/32763 |
| #29179 | https://github.com/nodejs/node/pull/29179 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #35474 | https://github.com/nodejs/node/pull/35474 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33950 | https://github.com/nodejs/node/pull/33950 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35477 | https://github.com/nodejs/node/pull/35477 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33325 | https://github.com/nodejs/node/pull/33325 |
| #33328 | https://github.com/nodejs/node/pull/33328 |
| #32744 | https://github.com/nodejs/node/pull/32744 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35210 | https://github.com/nodejs/node/pull/35210 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34394 | https://github.com/nodejs/node/pull/34394 |
| #33872 | https://github.com/nodejs/node/pull/33872 |
| #35014 | https://github.com/nodejs/node/pull/35014 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/32780/files/30761543baac1256d37aec17b59d5ddf1cdd0db4 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/32780/files/571eb8893763991da627834bf7260f702ab60edf |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Please reload this page | https://github.com/nodejs/node/pull/32780 |
|
| https://github.com/ronag |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mcollina |
|
| https://github.com/lpinca |
|
| https://github.com/Trott |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |