René's URL Explorer Experiment


Title: stream: fix _final and 'prefinish' timing by ronag · Pull Request #32780 · nodejs/node · GitHub

Open Graph Title: stream: fix _final and 'prefinish' timing by ronag · Pull Request #32780 · nodejs/node

X Title: stream: fix _final and 'prefinish' timing by ronag · Pull Request #32780 · nodejs/node

Description: This PR fixes a few different things: The timing of 'prefinish' depends on whether or not _final is defined. In one case the event is emitted synchronously with end() and otherwise asynchronously. ...

Open Graph Description: This PR fixes a few different things: The timing of 'prefinish' depends on whether or not _final is defined. In one case the event is emitted synchronously with end() and otherwise asynchro...

X Description: This PR fixes a few different things: The timing of 'prefinish' depends on whether or not _final is defined. In one case the event is emitted synchronously with end() and otherwise ...

Opengraph URL: https://github.com/nodejs/node/pull/32780

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f69b404c-d11e-cb5f-0fc2-b8430954748a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id808C:296AF5:20B8479:2CED7FA:696ABA4B
html-safe-nonce5c1e744c6c1bfa0954e9a0bd2bc1971c10e784256030b24bd5a059ef49c93a23
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDhDOjI5NkFGNToyMEI4NDc5OjJDRUQ3RkE6Njk2QUJBNEIiLCJ2aXNpdG9yX2lkIjoiOTIwMDE3NTM3NTUyNDIxNTM3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5984bfd26f94e53113b38e002f6170b9eab777f1a541f9a156d467d755bd2f0b
hovercard-subject-tagpull_request:402176579
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32780/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fbc26940d4f0b3c658efbbdb41beaba61fce0726d15a8e364b0ab1da38630d46/nodejs/node/pull/32780
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fbc26940d4f0b3c658efbbdb41beaba61fce0726d15a8e364b0ab1da38630d46/nodejs/node/pull/32780
og:image:altThis PR fixes a few different things: The timing of 'prefinish' depends on whether or not _final is defined. In one case the event is emitted synchronously with end() and otherwise asynchro...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/32780#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/32780
Reloadhttps://github.com/nodejs/node/pull/32780
Reloadhttps://github.com/nodejs/node/pull/32780
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/32780
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/32780
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/32780#issue-comment-box
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-finishhttps://github.com/nxtedition/node/tree/stream-finish
stream: fix _final and 'prefinish' timing https://github.com/nodejs/node/pull/32780#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-finishhttps://github.com/nxtedition/node/tree/stream-finish
Conversation 65 https://github.com/nodejs/node/pull/32780
Commits 3 https://github.com/nodejs/node/pull/32780/commits
Checks 0 https://github.com/nodejs/node/pull/32780/checks
Files changed https://github.com/nodejs/node/pull/32780/files
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 11, 2020https://github.com/nodejs/node/pull/32780#issue-598246082
Please reload this pagehttps://github.com/nodejs/node/pull/32780
#31401https://github.com/nodejs/node/issues/31401
#32763 (comment)https://github.com/nodejs/node/pull/32763#discussion_r407041983
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/ronag
ronaghttps://github.com/ronag
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Apr 11, 2020https://github.com/nodejs/node/pull/32780#event-3223957301
https://github.com/ronag
ronaghttps://github.com/ronag
mcollinahttps://github.com/mcollina
April 11, 2020 11:21https://github.com/nodejs/node/pull/32780#event-3223957303
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Apr 11, 2020 https://github.com/nodejs/node/pull/32780#pullrequestreview-391768976
View reviewed changes https://github.com/nodejs/node/pull/32780/files
test/parallel/test-fs-write-stream-end.jshttps://github.com/nodejs/node/pull/32780/files#diff-af2529f54d9bf30677c0f14003480a39d64c756b3d68f034fdf5935183950f5d
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 11, 2020 https://github.com/nodejs/node/pull/32780#pullrequestreview-391770073
View reviewed changes https://github.com/nodejs/node/pull/32780/files
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/32780/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/52ad4476565a3df8dcc8afc7650f163dfb1b0d61..15142097716cbc14da6cb039bed2b652756c3e25
52ad447https://github.com/nodejs/node/commit/52ad4476565a3df8dcc8afc7650f163dfb1b0d61
1514209https://github.com/nodejs/node/commit/15142097716cbc14da6cb039bed2b652756c3e25
Compare https://github.com/nodejs/node/compare/52ad4476565a3df8dcc8afc7650f163dfb1b0d61..15142097716cbc14da6cb039bed2b652756c3e25
April 11, 2020 14:31https://github.com/nodejs/node/pull/32780#event-3224118859
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 11, 2020 https://github.com/nodejs/node/pull/32780#pullrequestreview-391772812
View reviewed changes https://github.com/nodejs/node/pull/32780/files
lib/_stream_writable.jshttps://github.com/nodejs/node/pull/32780/files#diff-a7fdfe149712099064db4e7b80a1b39e28515b4efb3fab2f4b9499ce3b7c51c3
ronaghttps://github.com/ronag
Apr 11, 2020https://github.com/nodejs/node/pull/32780#discussion_r407072920
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 11, 2020 https://github.com/nodejs/node/pull/32780#pullrequestreview-391772896
View reviewed changes https://github.com/nodejs/node/pull/32780/files
test/parallel/test-http2-client-rststream-before-connect.jshttps://github.com/nodejs/node/pull/32780/files#diff-c2925273f2dba27cf14f3d4ac336d18b59890f1666da60272f63db75be79e4a8
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/d0b3e8e45918dc819be774fd0ca873facdc2243a..8155782c73823e830e5055e9534e95858cf73da5
d0b3e8ehttps://github.com/nodejs/node/commit/d0b3e8e45918dc819be774fd0ca873facdc2243a
8155782https://github.com/nodejs/node/commit/8155782c73823e830e5055e9534e95858cf73da5
Compare https://github.com/nodejs/node/compare/d0b3e8e45918dc819be774fd0ca873facdc2243a..8155782c73823e830e5055e9534e95858cf73da5
April 11, 2020 19:40https://github.com/nodejs/node/pull/32780#event-3224418372
https://github.com/ronag
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/c38dca7b9f4e151e771fa45427e7ae0f3db8e39b..5a6c161582fe93b5d95b9bf377e1a08978e53dc5
c38dca7https://github.com/nodejs/node/commit/c38dca7b9f4e151e771fa45427e7ae0f3db8e39b
5a6c161https://github.com/nodejs/node/commit/5a6c161582fe93b5d95b9bf377e1a08978e53dc5
Compare https://github.com/nodejs/node/compare/c38dca7b9f4e151e771fa45427e7ae0f3db8e39b..5a6c161582fe93b5d95b9bf377e1a08978e53dc5
April 11, 2020 20:01https://github.com/nodejs/node/pull/32780#event-3224436951
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780
https://github.com/ronag
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/2d89c91628d87051848e56da804e6a51d437d6b4..7a7d831dcdc832154d315c16f72ba9ca4dc28252
2d89c91https://github.com/nodejs/node/commit/2d89c91628d87051848e56da804e6a51d437d6b4
7a7d831https://github.com/nodejs/node/commit/7a7d831dcdc832154d315c16f72ba9ca4dc28252
Compare https://github.com/nodejs/node/compare/2d89c91628d87051848e56da804e6a51d437d6b4..7a7d831dcdc832154d315c16f72ba9ca4dc28252
April 11, 2020 20:27https://github.com/nodejs/node/pull/32780#event-3224459456
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/73a08ce1eb9535bade50ffc9f363ea054320ad2a..0c7a5e869ff3447f7f4f99c37a234baa178eac7e
73a08cehttps://github.com/nodejs/node/commit/73a08ce1eb9535bade50ffc9f363ea054320ad2a
0c7a5e8https://github.com/nodejs/node/commit/0c7a5e869ff3447f7f4f99c37a234baa178eac7e
Compare https://github.com/nodejs/node/compare/73a08ce1eb9535bade50ffc9f363ea054320ad2a..0c7a5e869ff3447f7f4f99c37a234baa178eac7e
April 11, 2020 20:53https://github.com/nodejs/node/pull/32780#event-3224482454
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 11, 2020https://github.com/nodejs/node/pull/32780#issuecomment-612511803
https://ci.nodejs.org/job/node-test-pull-request/30648/https://ci.nodejs.org/job/node-test-pull-request/30648/
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 11, 2020 https://github.com/nodejs/node/pull/32780#pullrequestreview-391800230
View reviewed changes https://github.com/nodejs/node/pull/32780/files
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/32780/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
ronaghttps://github.com/ronag
Apr 11, 2020https://github.com/nodejs/node/pull/32780#discussion_r407110482
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 11, 2020 https://github.com/nodejs/node/pull/32780#pullrequestreview-391800268
View reviewed changes https://github.com/nodejs/node/pull/32780/files
lib/_stream_writable.jshttps://github.com/nodejs/node/pull/32780/files#diff-a7fdfe149712099064db4e7b80a1b39e28515b4efb3fab2f4b9499ce3b7c51c3
ronaghttps://github.com/ronag
Apr 11, 2020https://github.com/nodejs/node/pull/32780#discussion_r407110524
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32780
ronaghttps://github.com/ronag
Apr 11, 2020https://github.com/nodejs/node/pull/32780#discussion_r407110668
Please reload this pagehttps://github.com/nodejs/node/pull/32780
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 11, 2020 https://github.com/nodejs/node/pull/32780#pullrequestreview-391800307
View reviewed changes https://github.com/nodejs/node/pull/32780/files
lib/_stream_writable.jshttps://github.com/nodejs/node/pull/32780/files#diff-a7fdfe149712099064db4e7b80a1b39e28515b4efb3fab2f4b9499ce3b7c51c3
ronaghttps://github.com/ronag
Apr 11, 2020https://github.com/nodejs/node/pull/32780#discussion_r407110566
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 11, 2020https://github.com/nodejs/node/pull/32780#issuecomment-612515180
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 11, 2020https://github.com/nodejs/node/pull/32780#issuecomment-612518838
@vweevershttps://github.com/vweevers
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/ronag
stream: fix _final and 'prefinish' timinghttps://github.com/nodejs/node/pull/32780/commits/be9f7264c9fd643e8378449616b0abc4e6b45099
be9f726https://github.com/nodejs/node/pull/32780/commits/be9f7264c9fd643e8378449616b0abc4e6b45099
nodejs#31401https://github.com/nodejs/node/issues/31401
nodejs#32763 (comment)https://github.com/nodejs/node/pull/32763#discussion_r407041983
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/30761543baac1256d37aec17b59d5ddf1cdd0db4..be9f7264c9fd643e8378449616b0abc4e6b45099
3076154https://github.com/nodejs/node/commit/30761543baac1256d37aec17b59d5ddf1cdd0db4
be9f726https://github.com/nodejs/node/commit/be9f7264c9fd643e8378449616b0abc4e6b45099
Compare https://github.com/nodejs/node/compare/30761543baac1256d37aec17b59d5ddf1cdd0db4..be9f7264c9fd643e8378449616b0abc4e6b45099
April 15, 2020 19:39https://github.com/nodejs/node/pull/32780#event-3236998648
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 15, 2020https://github.com/nodejs/node/pull/32780#issuecomment-614241252
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 15, 2020https://github.com/nodejs/node/pull/32780#issuecomment-614241399
https://ci.nodejs.org/job/node-test-pull-request/30773/https://ci.nodejs.org/job/node-test-pull-request/30773/
Please reload this pagehttps://github.com/nodejs/node/pull/32780
ronaghttps://github.com/ronag
April 15, 2020 21:47https://github.com/nodejs/node/pull/32780#commits-pushed-469766e
https://github.com/ronag
fixup: commentshttps://github.com/nodejs/node/pull/32780/commits/469766e1b9f69c6f0cf6cc73d925c29cdce4394e
469766ehttps://github.com/nodejs/node/pull/32780/commits/469766e1b9f69c6f0cf6cc73d925c29cdce4394e
https://github.com/ronag
fixup: missing needFinishhttps://github.com/nodejs/node/pull/32780/commits/571eb8893763991da627834bf7260f702ab60edf
571eb88https://github.com/nodejs/node/pull/32780/commits/571eb8893763991da627834bf7260f702ab60edf
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 15, 2020https://github.com/nodejs/node/pull/32780#issuecomment-614247483
https://ci.nodejs.org/job/node-test-pull-request/30774/https://ci.nodejs.org/job/node-test-pull-request/30774/
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 16, 2020https://github.com/nodejs/node/pull/32780#issuecomment-614463329
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://ci.nodejs.org/job/node-test-pull-request/30777/https://ci.nodejs.org/job/node-test-pull-request/30777/
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/lpinca
lpincahttps://github.com/lpinca
Apr 18, 2020 https://github.com/nodejs/node/pull/32780#ref-pullrequest-601406318
stream: avoid drain for sync streams #32887 https://github.com/nodejs/node/pull/32887
https://github.com/ronag
ronaghttps://github.com/ronag
jasnellhttps://github.com/jasnell
April 18, 2020 19:08https://github.com/nodejs/node/pull/32780#event-3248302341
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 19, 2020https://github.com/nodejs/node/pull/32780#issuecomment-616123968
Please reload this pagehttps://github.com/nodejs/node/pull/32780
@lpincahttps://github.com/lpinca
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/lpinca
lpincahttps://github.com/lpinca
Apr 19, 2020https://github.com/nodejs/node/pull/32780#issuecomment-616182520
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 22, 2020 https://github.com/nodejs/node/pull/32780#pullrequestreview-397802908
View reviewed changes https://github.com/nodejs/node/pull/32780/files/571eb8893763991da627834bf7260f702ab60edf
ronaghttps://github.com/ronag
Apr 22, 2020 https://github.com/nodejs/node/pull/32780#ref-commit-ea87809
https://github.com/ronag
stream: fix _final and 'prefinish' timinghttps://github.com/nodejs/node/commit/ea87809bb6696e2c1ec5d470031f137e18641183
ea87809https://github.com/nodejs/node/commit/ea87809bb6696e2c1ec5d470031f137e18641183
#31401https://github.com/nodejs/node/issues/31401
#32763 (comment)https://github.com/nodejs/node/pull/32763#discussion_r407041983
#32780https://github.com/nodejs/node/pull/32780
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 22, 2020https://github.com/nodejs/node/pull/32780#issuecomment-617608958
ea87809https://github.com/nodejs/node/commit/ea87809bb6696e2c1ec5d470031f137e18641183
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 22, 2020https://github.com/nodejs/node/pull/32780#event-3259264473
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 22, 2020https://github.com/nodejs/node/pull/32780#issuecomment-617609016
@lpincahttps://github.com/lpinca
Please reload this pagehttps://github.com/nodejs/node/pull/32780
lpincahttps://github.com/lpinca
Apr 22, 2020 https://github.com/nodejs/node/pull/32780#ref-commit-651d662
https://github.com/lpinca
[fix] Call the _final() callback before destroying the streamhttps://github.com/websockets/ws/commit/651d6627f7825026d80f45569880b0f3a817340d
651d662https://github.com/websockets/ws/commit/651d6627f7825026d80f45569880b0f3a817340d
nodejs/node#32780https://github.com/nodejs/node/pull/32780
lpincahttps://github.com/lpinca
Apr 22, 2020 https://github.com/nodejs/node/pull/32780#ref-commit-3730467
https://github.com/lpinca
[test] Do not call duplex.end() prematurelyhttps://github.com/websockets/ws/commit/373046710b80716d55058f418f3f9925d4b3a842
3730467https://github.com/websockets/ws/commit/373046710b80716d55058f418f3f9925d4b3a842
nodejs/node#32780https://github.com/nodejs/node/pull/32780
https://github.com/lpinca
lpincahttps://github.com/lpinca
Apr 22, 2020https://github.com/nodejs/node/pull/32780#issuecomment-617632262
websockets/ws#1736https://github.com/websockets/ws/pull/1736
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/lpinca
lpincahttps://github.com/lpinca
Apr 22, 2020https://github.com/nodejs/node/pull/32780#issuecomment-617912887
Please reload this pagehttps://github.com/nodejs/node/pull/32780
#32887https://github.com/nodejs/node/pull/32887
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 22, 2020https://github.com/nodejs/node/pull/32780#issuecomment-617914782
Please reload this pagehttps://github.com/nodejs/node/pull/32780
@MylesBorinshttps://github.com/MylesBorins
@lpincahttps://github.com/lpinca
see abovehttps://github.com/nodejs/node/pull/32780#issuecomment-617912887
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/lpinca
lpincahttps://github.com/lpinca
Apr 22, 2020https://github.com/nodejs/node/pull/32780#issuecomment-617918959
Please reload this pagehttps://github.com/nodejs/node/pull/32780
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Sep 1, 2020 https://github.com/nodejs/node/pull/32780#ref-pullrequest-690440226
2020-10-20, Version 15.0.0 (Current) #35014 https://github.com/nodejs/node/pull/35014
BethGriggshttps://github.com/BethGriggs
Oct 19, 2020 https://github.com/nodejs/node/pull/32780#ref-commit-782053e
https://github.com/BethGriggs
2020-10-20, Version 15.0.0 (Current)https://github.com/nodejs/node/commit/782053ea417ae77aae80c7dda7ff3cb0cfb7fce8
782053ehttps://github.com/nodejs/node/commit/782053ea417ae77aae80c7dda7ff3cb0cfb7fce8
#27576https://github.com/nodejs/node/pull/27576
#33694https://github.com/nodejs/node/pull/33694
#35316https://github.com/nodejs/node/pull/35316
#35562https://github.com/nodejs/node/pull/35562
#35496https://github.com/nodejs/node/pull/35496
#33647https://github.com/nodejs/node/pull/33647
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33648https://github.com/nodejs/node/pull/33648
#33950https://github.com/nodejs/node/pull/33950
#32744https://github.com/nodejs/node/pull/32744
#35415https://github.com/nodejs/node/pull/35415
#35631https://github.com/nodejs/node/pull/35631
#33021https://github.com/nodejs/node/pull/33021
#32379https://github.com/nodejs/node/pull/32379
#35415https://github.com/nodejs/node/pull/35415
#34001https://github.com/nodejs/node/pull/34001
#32953https://github.com/nodejs/node/pull/32953
#29656https://github.com/nodejs/node/pull/29656
#34664https://github.com/nodejs/node/pull/34664
#35496https://github.com/nodejs/node/pull/35496
#33527https://github.com/nodejs/node/pull/33527
#33527https://github.com/nodejs/node/pull/33527
#31806https://github.com/nodejs/node/pull/31806
#33874https://github.com/nodejs/node/pull/33874
#29656https://github.com/nodejs/node/pull/29656
#35496https://github.com/nodejs/node/pull/35496
#34001https://github.com/nodejs/node/pull/34001
#35415https://github.com/nodejs/node/pull/35415
#27576https://github.com/nodejs/node/pull/27576
#33694https://github.com/nodejs/node/pull/33694
#35093https://github.com/nodejs/node/pull/35093
#35093https://github.com/nodejs/node/pull/35093
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35631https://github.com/nodejs/node/pull/35631
#35474https://github.com/nodejs/node/pull/35474
#33600https://github.com/nodejs/node/pull/33600
#32953https://github.com/nodejs/node/pull/32953
#35316https://github.com/nodejs/node/pull/35316
#35022https://github.com/nodejs/node/pull/35022
#35562https://github.com/nodejs/node/pull/35562
#29656https://github.com/nodejs/node/pull/29656
#33405https://github.com/nodejs/node/pull/33405
#33172https://github.com/nodejs/node/pull/33172
#31818https://github.com/nodejs/node/pull/31818
#34664https://github.com/nodejs/node/pull/34664
#33161https://github.com/nodejs/node/pull/33161
#33535https://github.com/nodejs/node/pull/33535
#33193https://github.com/nodejs/node/pull/33193
#35496https://github.com/nodejs/node/pull/35496
#34682https://github.com/nodejs/node/pull/34682
#34022https://github.com/nodejs/node/pull/34022
#33857https://github.com/nodejs/node/pull/33857
#33527https://github.com/nodejs/node/pull/33527
#33527https://github.com/nodejs/node/pull/33527
#34022https://github.com/nodejs/node/pull/34022
#33647https://github.com/nodejs/node/pull/33647
#31806https://github.com/nodejs/node/pull/31806
#35415https://github.com/nodejs/node/pull/35415
#33021https://github.com/nodejs/node/pull/33021
#33600https://github.com/nodejs/node/pull/33600
#32312https://github.com/nodejs/node/pull/32312
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#34762https://github.com/nodejs/node/pull/34762
#35498https://github.com/nodejs/node/pull/35498
#35033https://github.com/nodejs/node/pull/35033
#33579https://github.com/nodejs/node/pull/33579
#33874https://github.com/nodejs/node/pull/33874
#33971https://github.com/nodejs/node/pull/33971
#33648https://github.com/nodejs/node/pull/33648
#32859https://github.com/nodejs/node/pull/32859
#34314https://github.com/nodejs/node/pull/34314
#34204https://github.com/nodejs/node/pull/34204
#33991https://github.com/nodejs/node/pull/33991
#34101https://github.com/nodejs/node/pull/34101
#29656https://github.com/nodejs/node/pull/29656
#33075https://github.com/nodejs/node/pull/33075
#32780https://github.com/nodejs/node/pull/32780
#32763https://github.com/nodejs/node/pull/32763
#29179https://github.com/nodejs/node/pull/29179
#35415https://github.com/nodejs/node/pull/35415
#35631https://github.com/nodejs/node/pull/35631
#35474https://github.com/nodejs/node/pull/35474
#33770https://github.com/nodejs/node/pull/33770
#33950https://github.com/nodejs/node/pull/33950
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35477https://github.com/nodejs/node/pull/35477
#33770https://github.com/nodejs/node/pull/33770
#33770https://github.com/nodejs/node/pull/33770
#33325https://github.com/nodejs/node/pull/33325
#33328https://github.com/nodejs/node/pull/33328
#32744https://github.com/nodejs/node/pull/32744
#35415https://github.com/nodejs/node/pull/35415
#35210https://github.com/nodejs/node/pull/35210
#35496https://github.com/nodejs/node/pull/35496
#34394https://github.com/nodejs/node/pull/34394
#33872https://github.com/nodejs/node/pull/33872
#35014https://github.com/nodejs/node/pull/35014
BethGriggshttps://github.com/BethGriggs
Oct 20, 2020 https://github.com/nodejs/node/pull/32780#ref-commit-d683e3d
https://github.com/BethGriggs
2020-10-20, Version 15.0.0 (Current)https://github.com/nodejs/node/commit/d683e3dda09b6b3cc6cad6fd2c106e3061a48f0d
d683e3dhttps://github.com/nodejs/node/commit/d683e3dda09b6b3cc6cad6fd2c106e3061a48f0d
#27576https://github.com/nodejs/node/pull/27576
#33694https://github.com/nodejs/node/pull/33694
#35316https://github.com/nodejs/node/pull/35316
#35562https://github.com/nodejs/node/pull/35562
#35496https://github.com/nodejs/node/pull/35496
#33647https://github.com/nodejs/node/pull/33647
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33648https://github.com/nodejs/node/pull/33648
#33950https://github.com/nodejs/node/pull/33950
#32744https://github.com/nodejs/node/pull/32744
#35415https://github.com/nodejs/node/pull/35415
#35631https://github.com/nodejs/node/pull/35631
#33021https://github.com/nodejs/node/pull/33021
#32379https://github.com/nodejs/node/pull/32379
#35415https://github.com/nodejs/node/pull/35415
#34001https://github.com/nodejs/node/pull/34001
#32953https://github.com/nodejs/node/pull/32953
#29656https://github.com/nodejs/node/pull/29656
#34664https://github.com/nodejs/node/pull/34664
#35496https://github.com/nodejs/node/pull/35496
#33527https://github.com/nodejs/node/pull/33527
#33527https://github.com/nodejs/node/pull/33527
#31806https://github.com/nodejs/node/pull/31806
#33874https://github.com/nodejs/node/pull/33874
#29656https://github.com/nodejs/node/pull/29656
#35496https://github.com/nodejs/node/pull/35496
#34001https://github.com/nodejs/node/pull/34001
#35415https://github.com/nodejs/node/pull/35415
#27576https://github.com/nodejs/node/pull/27576
#33694https://github.com/nodejs/node/pull/33694
#35093https://github.com/nodejs/node/pull/35093
#35093https://github.com/nodejs/node/pull/35093
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35631https://github.com/nodejs/node/pull/35631
#35474https://github.com/nodejs/node/pull/35474
#33600https://github.com/nodejs/node/pull/33600
#32953https://github.com/nodejs/node/pull/32953
#35316https://github.com/nodejs/node/pull/35316
#35022https://github.com/nodejs/node/pull/35022
#35562https://github.com/nodejs/node/pull/35562
#29656https://github.com/nodejs/node/pull/29656
#33405https://github.com/nodejs/node/pull/33405
#33172https://github.com/nodejs/node/pull/33172
#31818https://github.com/nodejs/node/pull/31818
#34664https://github.com/nodejs/node/pull/34664
#33161https://github.com/nodejs/node/pull/33161
#33535https://github.com/nodejs/node/pull/33535
#33193https://github.com/nodejs/node/pull/33193
#35496https://github.com/nodejs/node/pull/35496
#34682https://github.com/nodejs/node/pull/34682
#34022https://github.com/nodejs/node/pull/34022
#33857https://github.com/nodejs/node/pull/33857
#33527https://github.com/nodejs/node/pull/33527
#33527https://github.com/nodejs/node/pull/33527
#34022https://github.com/nodejs/node/pull/34022
#33647https://github.com/nodejs/node/pull/33647
#31806https://github.com/nodejs/node/pull/31806
#35415https://github.com/nodejs/node/pull/35415
#33021https://github.com/nodejs/node/pull/33021
#33600https://github.com/nodejs/node/pull/33600
#32312https://github.com/nodejs/node/pull/32312
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#34762https://github.com/nodejs/node/pull/34762
#35498https://github.com/nodejs/node/pull/35498
#35033https://github.com/nodejs/node/pull/35033
#33579https://github.com/nodejs/node/pull/33579
#33874https://github.com/nodejs/node/pull/33874
#33971https://github.com/nodejs/node/pull/33971
#33648https://github.com/nodejs/node/pull/33648
#32859https://github.com/nodejs/node/pull/32859
#34314https://github.com/nodejs/node/pull/34314
#34204https://github.com/nodejs/node/pull/34204
#33991https://github.com/nodejs/node/pull/33991
#34101https://github.com/nodejs/node/pull/34101
#29656https://github.com/nodejs/node/pull/29656
#33075https://github.com/nodejs/node/pull/33075
#32780https://github.com/nodejs/node/pull/32780
#32763https://github.com/nodejs/node/pull/32763
#29179https://github.com/nodejs/node/pull/29179
#35415https://github.com/nodejs/node/pull/35415
#35631https://github.com/nodejs/node/pull/35631
#35474https://github.com/nodejs/node/pull/35474
#33770https://github.com/nodejs/node/pull/33770
#33950https://github.com/nodejs/node/pull/33950
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35477https://github.com/nodejs/node/pull/35477
#33770https://github.com/nodejs/node/pull/33770
#33770https://github.com/nodejs/node/pull/33770
#33325https://github.com/nodejs/node/pull/33325
#33328https://github.com/nodejs/node/pull/33328
#32744https://github.com/nodejs/node/pull/32744
#35415https://github.com/nodejs/node/pull/35415
#35210https://github.com/nodejs/node/pull/35210
#35496https://github.com/nodejs/node/pull/35496
#34394https://github.com/nodejs/node/pull/34394
#33872https://github.com/nodejs/node/pull/33872
#35014https://github.com/nodejs/node/pull/35014
BethGriggshttps://github.com/BethGriggs
Oct 20, 2020 https://github.com/nodejs/node/pull/32780#ref-commit-57613f8
https://github.com/BethGriggs
2020-10-20, Version 15.0.0 (Current)https://github.com/nodejs/node/commit/57613f8c564982494c5af8070816d675544386bb
57613f8https://github.com/nodejs/node/commit/57613f8c564982494c5af8070816d675544386bb
#27576https://github.com/nodejs/node/pull/27576
#33694https://github.com/nodejs/node/pull/33694
#35316https://github.com/nodejs/node/pull/35316
#35562https://github.com/nodejs/node/pull/35562
#35496https://github.com/nodejs/node/pull/35496
#33647https://github.com/nodejs/node/pull/33647
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33648https://github.com/nodejs/node/pull/33648
#33950https://github.com/nodejs/node/pull/33950
#32744https://github.com/nodejs/node/pull/32744
#35415https://github.com/nodejs/node/pull/35415
#35631https://github.com/nodejs/node/pull/35631
#33021https://github.com/nodejs/node/pull/33021
#32379https://github.com/nodejs/node/pull/32379
#35415https://github.com/nodejs/node/pull/35415
#34001https://github.com/nodejs/node/pull/34001
#32953https://github.com/nodejs/node/pull/32953
#29656https://github.com/nodejs/node/pull/29656
#34664https://github.com/nodejs/node/pull/34664
#35496https://github.com/nodejs/node/pull/35496
#33527https://github.com/nodejs/node/pull/33527
#33527https://github.com/nodejs/node/pull/33527
#31806https://github.com/nodejs/node/pull/31806
#33874https://github.com/nodejs/node/pull/33874
#29656https://github.com/nodejs/node/pull/29656
#35496https://github.com/nodejs/node/pull/35496
#34001https://github.com/nodejs/node/pull/34001
#35415https://github.com/nodejs/node/pull/35415
#27576https://github.com/nodejs/node/pull/27576
#33694https://github.com/nodejs/node/pull/33694
#35093https://github.com/nodejs/node/pull/35093
#35093https://github.com/nodejs/node/pull/35093
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35631https://github.com/nodejs/node/pull/35631
#35474https://github.com/nodejs/node/pull/35474
#33600https://github.com/nodejs/node/pull/33600
#32953https://github.com/nodejs/node/pull/32953
#35316https://github.com/nodejs/node/pull/35316
#35022https://github.com/nodejs/node/pull/35022
#35562https://github.com/nodejs/node/pull/35562
#29656https://github.com/nodejs/node/pull/29656
#33405https://github.com/nodejs/node/pull/33405
#33172https://github.com/nodejs/node/pull/33172
#31818https://github.com/nodejs/node/pull/31818
#34664https://github.com/nodejs/node/pull/34664
#33161https://github.com/nodejs/node/pull/33161
#33535https://github.com/nodejs/node/pull/33535
#33193https://github.com/nodejs/node/pull/33193
#35496https://github.com/nodejs/node/pull/35496
#34682https://github.com/nodejs/node/pull/34682
#34022https://github.com/nodejs/node/pull/34022
#33857https://github.com/nodejs/node/pull/33857
#33527https://github.com/nodejs/node/pull/33527
#33527https://github.com/nodejs/node/pull/33527
#34022https://github.com/nodejs/node/pull/34022
#33647https://github.com/nodejs/node/pull/33647
#31806https://github.com/nodejs/node/pull/31806
#35415https://github.com/nodejs/node/pull/35415
#33021https://github.com/nodejs/node/pull/33021
#33600https://github.com/nodejs/node/pull/33600
#32312https://github.com/nodejs/node/pull/32312
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#33286https://github.com/nodejs/node/pull/33286
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#34762https://github.com/nodejs/node/pull/34762
#35498https://github.com/nodejs/node/pull/35498
#35033https://github.com/nodejs/node/pull/35033
#33579https://github.com/nodejs/node/pull/33579
#33874https://github.com/nodejs/node/pull/33874
#33971https://github.com/nodejs/node/pull/33971
#33648https://github.com/nodejs/node/pull/33648
#32859https://github.com/nodejs/node/pull/32859
#34314https://github.com/nodejs/node/pull/34314
#34204https://github.com/nodejs/node/pull/34204
#33991https://github.com/nodejs/node/pull/33991
#34101https://github.com/nodejs/node/pull/34101
#29656https://github.com/nodejs/node/pull/29656
#33075https://github.com/nodejs/node/pull/33075
#32780https://github.com/nodejs/node/pull/32780
#32763https://github.com/nodejs/node/pull/32763
#29179https://github.com/nodejs/node/pull/29179
#35415https://github.com/nodejs/node/pull/35415
#35631https://github.com/nodejs/node/pull/35631
#35474https://github.com/nodejs/node/pull/35474
#33770https://github.com/nodejs/node/pull/33770
#33950https://github.com/nodejs/node/pull/33950
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35415https://github.com/nodejs/node/pull/35415
#35477https://github.com/nodejs/node/pull/35477
#33770https://github.com/nodejs/node/pull/33770
#33770https://github.com/nodejs/node/pull/33770
#33325https://github.com/nodejs/node/pull/33325
#33328https://github.com/nodejs/node/pull/33328
#32744https://github.com/nodejs/node/pull/32744
#35415https://github.com/nodejs/node/pull/35415
#35210https://github.com/nodejs/node/pull/35210
#35496https://github.com/nodejs/node/pull/35496
#34394https://github.com/nodejs/node/pull/34394
#33872https://github.com/nodejs/node/pull/33872
#35014https://github.com/nodejs/node/pull/35014
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32780
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/32780/files/30761543baac1256d37aec17b59d5ddf1cdd0db4
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/32780/files/571eb8893763991da627834bf7260f702ab60edf
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/jasnell
jasnell https://github.com/jasnell
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/32780
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/lpinca
https://github.com/Trott
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.