| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8d70c354-f58a-4aa3-7bc9-e39852f85fee |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ABB0:28B54B:C7B91:10F652:6AED3DC2 |
| html-safe-nonce | b79c9e288d5ccbd6459f298fca9ca578579cdcf60a20b0435e7b7eee99065af7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkIwOjI4QjU0QjpDN0I5MToxMEY2NTI6NkFFRDNEQzIiLCJ2aXNpdG9yX2lkIjoiNzg1ODY3NDA2NzU2NzM2MTQ3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | be42f68d854a5c0c152919a6230fe45249eefdae24e5bb37a9fefcdf4f4577da |
| hovercard-subject-tag | pull_request:400799895 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32716/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/dedaa24c0bb961d753af65d356bc1ff2188940521a9f9cc575a7f619696dec1f/nodejs/node/pull/32716 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dedaa24c0bb961d753af65d356bc1ff2188940521a9f9cc575a7f619696dec1f/nodejs/node/pull/32716 |
| og:image:alt | Note: this is target to branch canary-base
Original PR in: nodejs/node-v8#154.
V8 introduced this api in it's own.
See https://github.com/gengjiawen/node-v8/blob/f1add0594a838793871fc8d785fc7bf... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gengjiawen |
| hostname | github.com |
| expected-hostname | github.com |
| None | 26c92a9388ddfad3fa88d132b5d5f0b4747030233dcc4e5efb05f1cbae152184 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c629ad99c254d306375fc8354d04321c2c362236 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/32716#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32716 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32716 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/32716 |
| Reload | https://github.com/nodejs/node/pull/32716 |
| Reload | https://github.com/nodejs/node/pull/32716 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues656 (656) | https://github.com/nodejs/node/issues |
| Pull requests665 (665) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/pulse |
| https://github.com/nodejs/node |
| gengjiawen | https://github.com/gengjiawen |
| nodejs:canary-base | https://github.com/nodejs/node/tree/canary-base |
| gengjiawen:bugfix/buffer | https://github.com/gengjiawen/node/tree/bugfix/buffer |
| Conversation | https://github.com/nodejs/node/pull/32716 |
| Commits1 (1) | https://github.com/nodejs/node/pull/32716/commits |
| Checks | https://github.com/nodejs/node/pull/32716/checks |
| Files changed | https://github.com/nodejs/node/pull/32716/files |
| src: refactor Reallocate since it introduced in upstream v8 | https://github.com/nodejs/node/pull/32716#top |
| gengjiawen | https://github.com/gengjiawen |
| nodejs:canary-base | https://github.com/nodejs/node/tree/canary-base |
| gengjiawen:bugfix/buffer | https://github.com/gengjiawen/node/tree/bugfix/buffer |
|
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Apr 8, 2020 | https://github.com/nodejs/node/pull/32716#issue-596517429 |
| Please reload this page | https://github.com/nodejs/node/pull/32716 |
| nodejs/node-v8#154 | https://github.com/nodejs/node-v8/pull/154 |
| https://github.com/gengjiawen/node-v8/blob/f1add0594a838793871fc8d785fc7bf1cdf30441/deps/v8/include/v8.h#L5064 | https://github.com/gengjiawen/node-v8/blob/f1add0594a838793871fc8d785fc7bf1cdf30441/deps/v8/include/v8.h#L5064 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/32716 |
|
| https://github.com/gengjiawen |
| src: remove Reallocate since it introduced in upstream v8 | https://github.com/nodejs/node/pull/32716/commits/3aa66af837617d08eb63d75b2858ba4c7984adb0 |
| 3aa66af | https://github.com/nodejs/node/pull/32716/commits/3aa66af837617d08eb63d75b2858ba4c7984adb0 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| addaleax | https://github.com/addaleax |
| mmarchini | https://github.com/mmarchini |
| targos | https://github.com/targos |
| April 8, 2020 11:47 | https://github.com/nodejs/node/pull/32716#event-3213748336 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
dont-land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x |
| Apr 8, 2020 | https://github.com/nodejs/node/pull/32716#event-3213753114 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Apr 8, 2020 | https://github.com/nodejs/node/pull/32716#event-3213776246 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Apr 8, 2020 | https://github.com/nodejs/node/pull/32716#event-3213778217 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Apr 8, 2020
| https://github.com/nodejs/node/pull/32716#pullrequestreview-389954579 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32716/files/3aa66af837617d08eb63d75b2858ba4c7984adb0 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Apr 8, 2020
| https://github.com/nodejs/node/pull/32716#pullrequestreview-389960309 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32716/files/3aa66af837617d08eb63d75b2858ba4c7984adb0 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
|
Apr 9, 2020
| https://github.com/nodejs/node/pull/32716#pullrequestreview-390589690 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32716/files/3aa66af837617d08eb63d75b2858ba4c7984adb0 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Apr 10, 2020 | https://github.com/nodejs/node/pull/32716#issuecomment-611825599 |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/32716 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Apr 10, 2020 | https://github.com/nodejs/node/pull/32716#issuecomment-611889709 |
| Please reload this page | https://github.com/nodejs/node/pull/32716 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| 92af924 | https://github.com/nodejs/node/commit/92af9248d0e562f35bea31fbea8a17f89fe2895e |
| Apr 10, 2020 | https://github.com/nodejs/node/pull/32716#event-3220908998 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| April 10, 2020 06:22 | https://github.com/nodejs/node/pull/32716#event-3220909057 |
| mmarchini | https://github.com/mmarchini |
|
Apr 13, 2020
| https://github.com/nodejs/node/pull/32716#ref-commit-0ba96aa |
|
| https://github.com/gengjiawen |
|
| https://github.com/mmarchini |
| src: refactor Reallocate since it introduced in upstream v8 ( | https://github.com/nodejs/node/commit/0ba96aa3a7786a2950b5fe45df76a6cebc9938d4 |
| #32716 | https://github.com/nodejs/node/pull/32716 |
| ) | https://github.com/nodejs/node/commit/0ba96aa3a7786a2950b5fe45df76a6cebc9938d4 |
| 0ba96aa | https://github.com/nodejs/node/commit/0ba96aa3a7786a2950b5fe45df76a6cebc9938d4 |
| ryzokuken | https://github.com/ryzokuken |
|
Apr 17, 2020
| https://github.com/nodejs/node/pull/32716#ref-commit-abba88d |
|
| https://github.com/gengjiawen |
|
| https://github.com/ryzokuken |
| src: refactor Reallocate since it introduced in upstream v8 ( | https://github.com/nodejs/node/commit/abba88de92263535e4ce69278bbfa17852f44aae |
| #32716 | https://github.com/nodejs/node/pull/32716 |
| ) | https://github.com/nodejs/node/commit/abba88de92263535e4ce69278bbfa17852f44aae |
| abba88d | https://github.com/nodejs/node/commit/abba88de92263535e4ce69278bbfa17852f44aae |
| ryzokuken | https://github.com/ryzokuken |
|
Apr 21, 2020
| https://github.com/nodejs/node/pull/32716#ref-commit-032ea8d |
|
| https://github.com/gengjiawen |
|
| https://github.com/ryzokuken |
| src: refactor Reallocate since it introduced in upstream v8 ( | https://github.com/nodejs/node/commit/032ea8d0a57e3c8d013a22d3b1673411eedffa8f |
| #32716 | https://github.com/nodejs/node/pull/32716 |
| ) | https://github.com/nodejs/node/commit/032ea8d0a57e3c8d013a22d3b1673411eedffa8f |
| 032ea8d | https://github.com/nodejs/node/commit/032ea8d0a57e3c8d013a22d3b1673411eedffa8f |
| targos | https://github.com/targos |
|
Apr 25, 2020
| https://github.com/nodejs/node/pull/32716#ref-commit-d4d99bc |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: refactor Reallocate since it introduced in upstream v8 ( | https://github.com/nodejs/node/commit/d4d99bc38aecb8552216b5dcf359043acc95e917 |
| #32716 | https://github.com/nodejs/node/pull/32716 |
| ) | https://github.com/nodejs/node/commit/d4d99bc38aecb8552216b5dcf359043acc95e917 |
| d4d99bc | https://github.com/nodejs/node/commit/d4d99bc38aecb8552216b5dcf359043acc95e917 |
| ryzokuken | https://github.com/ryzokuken |
|
May 2, 2020
| https://github.com/nodejs/node/pull/32716#ref-commit-7e1dfda |
|
| https://github.com/gengjiawen |
|
| https://github.com/ryzokuken |
| src: refactor Reallocate since it introduced in upstream v8 ( | https://github.com/nodejs/node/commit/7e1dfda14868c62fa3d77ac8ee63937c6b84b181 |
| #32716 | https://github.com/nodejs/node/pull/32716 |
| ) | https://github.com/nodejs/node/commit/7e1dfda14868c62fa3d77ac8ee63937c6b84b181 |
| 7e1dfda | https://github.com/nodejs/node/commit/7e1dfda14868c62fa3d77ac8ee63937c6b84b181 |
| targos | https://github.com/targos |
|
May 9, 2020
| https://github.com/nodejs/node/pull/32716#ref-commit-bf48179 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: refactor Reallocate since it introduced in upstream v8 ( | https://github.com/nodejs/node/commit/bf481793e28acd466d860dadb5b35ed231fe7749 |
| #32716 | https://github.com/nodejs/node/pull/32716 |
| ) | https://github.com/nodejs/node/commit/bf481793e28acd466d860dadb5b35ed231fe7749 |
| bf48179 | https://github.com/nodejs/node/commit/bf481793e28acd466d860dadb5b35ed231fe7749 |
| ryzokuken | https://github.com/ryzokuken |
|
May 12, 2020
| https://github.com/nodejs/node/pull/32716#ref-commit-eff511b |
|
| https://github.com/gengjiawen |
|
| https://github.com/ryzokuken |
| src: refactor Reallocate since it introduced in upstream v8 ( | https://github.com/nodejs/node/commit/eff511b3adc6c6a090acf9e2d0d606f83651043c |
| #32716 | https://github.com/nodejs/node/pull/32716 |
| ) | https://github.com/nodejs/node/commit/eff511b3adc6c6a090acf9e2d0d606f83651043c |
| eff511b | https://github.com/nodejs/node/commit/eff511b3adc6c6a090acf9e2d0d606f83651043c |
| targos | https://github.com/targos |
|
May 13, 2020
| https://github.com/nodejs/node/pull/32716#ref-commit-3a0ea14 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: refactor Reallocate since it introduced in upstream v8 ( | https://github.com/nodejs/node/commit/3a0ea14d61911e0ebab96eb64b99e4e7dd0d8fad |
| #32716 | https://github.com/nodejs/node/pull/32716 |
| ) | https://github.com/nodejs/node/commit/3a0ea14d61911e0ebab96eb64b99e4e7dd0d8fad |
| 3a0ea14 | https://github.com/nodejs/node/commit/3a0ea14d61911e0ebab96eb64b99e4e7dd0d8fad |
| targos | https://github.com/targos |
|
May 14, 2020
| https://github.com/nodejs/node/pull/32716#ref-commit-deee7ad |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
| src: refactor Reallocate since it introduced in upstream v8 ( | https://github.com/nodejs/node/commit/deee7ad8a24909f4f86be58e88f5d496b3d85312 |
| #32716 | https://github.com/nodejs/node/pull/32716 |
| ) | https://github.com/nodejs/node/commit/deee7ad8a24909f4f86be58e88f5d496b3d85312 |
| deee7ad | https://github.com/nodejs/node/commit/deee7ad8a24909f4f86be58e88f5d496b3d85312 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
May 14, 2020
| https://github.com/nodejs/node/pull/32716#ref-issue-618113690 |
|
MacOS build fails
#33401
| https://github.com/nodejs/node/issues/33401 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32716 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/32716/files/3aa66af837617d08eb63d75b2858ba4c7984adb0 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/32716/files/3aa66af837617d08eb63d75b2858ba4c7984adb0 |
|
| https://github.com/Flarna |
|
Flarna
| https://github.com/Flarna |
|
| https://github.com/nodejs/node/pull/32716/files/3aa66af837617d08eb63d75b2858ba4c7984adb0 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/mmarchini |
|
mmarchini
| https://github.com/mmarchini |
| Please reload this page | https://github.com/nodejs/node/pull/32716 |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/32716 |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/Flarna |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |