René's URL Explorer Experiment


Title: stream: cleanup pipeline destroyer by ronag · Pull Request #32690 · nodejs/node · GitHub

Open Graph Title: stream: cleanup pipeline destroyer by ronag · Pull Request #32690 · nodejs/node

X Title: stream: cleanup pipeline destroyer by ronag · Pull Request #32690 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Slightly cleans up the destroyer logic. Make readable and writable use similar logic. i.e. if (!err && reading && !writing && stream.writable) { return callback();...

X Description: Slightly cleans up the destroyer logic. Make readable and writable use similar logic. i.e. if (!err && reading && !writing && stream.writable) { ...

Opengraph URL: https://github.com/nodejs/node/pull/32690

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:93b57051-548b-bbaa-5d1b-8d28d22c5b91
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id967C:230CED:238BD3:333160:6A50F39A
html-safe-nonce6044b1c5f5373be7fe39765cd5e055119bdebbff5604e792ca5607f33e2eaed7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjdDOjIzMENFRDoyMzhCRDM6MzMzMTYwOjZBNTBGMzlBIiwidmlzaXRvcl9pZCI6Ijg3MzE4Mjg4MDcwMjYxNDQxNTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac48aa55f1ae0cac0e8af740eef7fc5e2a287b15aa1bcb532fa9a086f2462cfeb9
hovercard-subject-tagpull_request:399817863
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32690/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cacd1305c8459ab5857220e5e7ea07bf8b09e13cfcc7debf9ae0b4cbe2b5444e/nodejs/node/pull/32690
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cacd1305c8459ab5857220e5e7ea07bf8b09e13cfcc7debf9ae0b4cbe2b5444e/nodejs/node/pull/32690
og:image:altSlightly cleans up the destroyer logic. Make readable and writable use similar logic. i.e. if (!err && reading && !writing && stream.writable) { return callback();...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None5266e58c17a510c403505cc811606465e90a881d2007ee7df1c4800d5c659838
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5ec60191a48933536a90c8a19f47142fcd0d4739
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/32690#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32690
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32690
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/32690
Reloadhttps://github.com/nodejs/node/pull/32690
Reloadhttps://github.com/nodejs/node/pull/32690
Please reload this pagehttps://github.com/nodejs/node/pull/32690
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/32690
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 978 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:pipeline-cleanuphttps://github.com/nxtedition/node/tree/pipeline-cleanup
Conversationhttps://github.com/nodejs/node/pull/32690
Commits1 (1)https://github.com/nodejs/node/pull/32690/commits
Checkshttps://github.com/nodejs/node/pull/32690/checks
Files changedhttps://github.com/nodejs/node/pull/32690/files
stream: cleanup pipeline destroyerhttps://github.com/nodejs/node/pull/32690#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:pipeline-cleanuphttps://github.com/nxtedition/node/tree/pipeline-cleanup
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 6, 2020https://github.com/nodejs/node/pull/32690#issue-595322332
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/32690
https://github.com/ronag
stream: cleanup pipeline destroyerhttps://github.com/nodejs/node/pull/32690/commits/a273dacb03bd674dc66d444435a67d220db4819f
a273dachttps://github.com/nodejs/node/pull/32690/commits/a273dacb03bd674dc66d444435a67d220db4819f
https://github.com/ronag
ronaghttps://github.com/ronag
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Apr 6, 2020https://github.com/nodejs/node/pull/32690#event-3206614569
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 6, 2020https://github.com/nodejs/node/pull/32690#issuecomment-609954353
https://ci.nodejs.org/job/node-test-pull-request/30508/https://ci.nodejs.org/job/node-test-pull-request/30508/
Please reload this pagehttps://github.com/nodejs/node/pull/32690
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Apr 8, 2020 https://github.com/nodejs/node/pull/32690#pullrequestreview-390063128
View reviewed changes https://github.com/nodejs/node/pull/32690/files/a273dacb03bd674dc66d444435a67d220db4819f
lib/internal/streams/pipeline.jshttps://github.com/nodejs/node/pull/32690/files/a273dacb03bd674dc66d444435a67d220db4819f#diff-95c23fb6674af85f6f23a374851af6cccf58fb4617d73897df5078ba537a862c
rickyeshttps://github.com/rickyes
Apr 8, 2020https://github.com/nodejs/node/pull/32690#discussion_r405595034
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32690
ronaghttps://github.com/ronag
Apr 8, 2020https://github.com/nodejs/node/pull/32690#discussion_r405595769
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32690
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 10, 2020https://github.com/nodejs/node/pull/32690#issuecomment-612065461
https://ci.nodejs.org/job/node-test-pull-request/30616/https://ci.nodejs.org/job/node-test-pull-request/30616/
Please reload this pagehttps://github.com/nodejs/node/pull/32690
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 13, 2020https://github.com/nodejs/node/pull/32690#issuecomment-612812083
Please reload this pagehttps://github.com/nodejs/node/pull/32690
https://ci.nodejs.org/job/node-test-pull-request/30677/https://ci.nodejs.org/job/node-test-pull-request/30677/
Please reload this pagehttps://github.com/nodejs/node/pull/32690
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 20, 2020 https://github.com/nodejs/node/pull/32690#ref-pullrequest-570192668
stream: ensure pipeline always destroys streams #31940 https://github.com/nodejs/node/pull/31940
https://github.com/ronag
ronaghttps://github.com/ronag
lpincahttps://github.com/lpinca
mcollinahttps://github.com/mcollina
April 20, 2020 20:31https://github.com/nodejs/node/pull/32690#event-3253466714
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Apr 20, 2020 https://github.com/nodejs/node/pull/32690#pullrequestreview-396824310
View reviewed changes https://github.com/nodejs/node/pull/32690/files/a273dacb03bd674dc66d444435a67d220db4819f
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/32690#pullrequestreview-396824310
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32690
https://github.com/ronag
ronaghttps://github.com/ronag
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 20, 2020https://github.com/nodejs/node/pull/32690#event-3253676115
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 20, 2020 https://github.com/nodejs/node/pull/32690#pullrequestreview-396890007
View reviewed changes https://github.com/nodejs/node/pull/32690/files/a273dacb03bd674dc66d444435a67d220db4819f
lib/internal/streams/pipeline.jshttps://github.com/nodejs/node/pull/32690/files/a273dacb03bd674dc66d444435a67d220db4819f#diff-95c23fb6674af85f6f23a374851af6cccf58fb4617d73897df5078ba537a862c
BridgeARhttps://github.com/BridgeAR
Apr 20, 2020https://github.com/nodejs/node/pull/32690#discussion_r411762416
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32690
ronaghttps://github.com/ronag
Apr 21, 2020https://github.com/nodejs/node/pull/32690#discussion_r411930931
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32690
https://github.com/ronag
ronaghttps://github.com/ronag
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 21, 2020https://github.com/nodejs/node/pull/32690#event-3255667189
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 21, 2020https://github.com/nodejs/node/pull/32690#issuecomment-617103778
#32966https://github.com/nodejs/node/pull/32966
Please reload this pagehttps://github.com/nodejs/node/pull/32690
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 21, 2020https://github.com/nodejs/node/pull/32690#issuecomment-617279773
#32968https://github.com/nodejs/node/pull/32968
Please reload this pagehttps://github.com/nodejs/node/pull/32690
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 21, 2020https://github.com/nodejs/node/pull/32690#event-3256960267
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32690
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/32690/files/a273dacb03bd674dc66d444435a67d220db4819f
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/32690/files/a273dacb03bd674dc66d444435a67d220db4819f
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/rickyes
rickyes https://github.com/rickyes
https://github.com/nodejs/node/pull/32690/files/a273dacb03bd674dc66d444435a67d220db4819f
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/32690
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/BridgeAR
https://github.com/rickyes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.