René's URL Explorer Experiment


Title: build: turn warnings into errors for node sources by danbev · Pull Request #32685 · nodejs/node · GitHub

Open Graph Title: build: turn warnings into errors for node sources by danbev · Pull Request #32685 · nodejs/node

X Title: build: turn warnings into errors for node sources by danbev · Pull Request #32685 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This pr attempts to turn compilation warnings into errors for node's source code. The motivation for this is to enable these errors to be reported by CI runs on pull requests and be able to fix...

X Description: This pr attempts to turn compilation warnings into errors for node's source code. The motivation for this is to enable these errors to be reported by CI runs on pull requests and be able to...

Opengraph URL: https://github.com/nodejs/node/pull/32685

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8c898e6b-31c2-da50-c0cb-cbff3843fc6a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE9C0:2AB324:75EE78:A023CA:6AED2CED
html-safe-noncebb86df493b45e2142d44d175b3543806d94b0a7a4afef5be19d5c9f167664f27
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUMwOjJBQjMyNDo3NUVFNzg6QTAyM0NBOjZBRUQyQ0VEIiwidmlzaXRvcl9pZCI6IjExNzg3NTQyNzQzOTczMzQ3NjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac831c0642f8e072069a6a81d9bbfaef1a9dcc1732578cd6d863837fcd3a4ca8a5
hovercard-subject-tagpull_request:399612922
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32685/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d693aadb651178f5d5e462679c1d3ac7c39eabb6e5e3e98dbc993e2db91140b1/nodejs/node/pull/32685
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d693aadb651178f5d5e462679c1d3ac7c39eabb6e5e3e98dbc993e2db91140b1/nodejs/node/pull/32685
og:image:altThis pr attempts to turn compilation warnings into errors for node's source code. The motivation for this is to enable these errors to be reported by CI runs on pull requests and be able to fix...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanbev
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/32685#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32685
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32685
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/32685
Reloadhttps://github.com/nodejs/node/pull/32685
Reloadhttps://github.com/nodejs/node/pull/32685
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:warnings-as-errorshttps://github.com/danbev/node/tree/warnings-as-errors
Conversationhttps://github.com/nodejs/node/pull/32685
Commits5 (5)https://github.com/nodejs/node/pull/32685/commits
Checkshttps://github.com/nodejs/node/pull/32685/checks
Files changedhttps://github.com/nodejs/node/pull/32685/files
build: turn warnings into errors for node sourceshttps://github.com/nodejs/node/pull/32685#top
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:warnings-as-errorshttps://github.com/danbev/node/tree/warnings-as-errors
https://github.com/danbev
danbevhttps://github.com/danbev
Apr 6, 2020https://github.com/nodejs/node/pull/32685#issue-595076972
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Apr 6, 2020https://github.com/nodejs/node/pull/32685#event-3205131008
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 6, 2020https://github.com/nodejs/node/pull/32685#issuecomment-609765817
https://ci.nodejs.org/job/node-test-pull-request/30494/https://ci.nodejs.org/job/node-test-pull-request/30494/
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Apr 6, 2020https://github.com/nodejs/node/pull/32685#issuecomment-609807931
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 6, 2020https://github.com/nodejs/node/pull/32685#issuecomment-609831585
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/danbev
danbevhttps://github.com/danbev
Apr 7, 2020https://github.com/nodejs/node/pull/32685#issuecomment-610162408
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/danbev
danbevhttps://github.com/danbev
Apr 7, 2020https://github.com/nodejs/node/pull/32685#issuecomment-610163772
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Apr 7, 2020https://github.com/nodejs/node/pull/32685#issuecomment-610180095
Please reload this pagehttps://github.com/nodejs/node/pull/32685
danbevhttps://github.com/danbev
April 17, 2020 08:04https://github.com/nodejs/node/pull/32685#commits-pushed-5e3988d
https://github.com/danbev
build: turn warnings into errors for node sourceshttps://github.com/nodejs/node/pull/32685/commits/5e3988dda006c3a9b6bfc32481798800fb0c8ed6
5e3988dhttps://github.com/nodejs/node/pull/32685/commits/5e3988dda006c3a9b6bfc32481798800fb0c8ed6
https://github.com/danbev
tools: fix redundant-move warning in inspectorhttps://github.com/nodejs/node/pull/32685/commits/237951615498b8ea3c51856e81611be85f80412f
2379516https://github.com/nodejs/node/pull/32685/commits/237951615498b8ea3c51856e81611be85f80412f
https://github.com/danbev
build: add --error-on-warn configure flaghttps://github.com/nodejs/node/pull/32685/commits/b9fa8f3cade7c45fd8091142b8e55711a369c89d
b9fa8f3https://github.com/nodejs/node/pull/32685/commits/b9fa8f3cade7c45fd8091142b8e55711a369c89d
https://github.com/danbev
danbevhttps://github.com/danbev
force-pushedhttps://github.com/nodejs/node/compare/a3b474e6dbd738f61dab35c2a3fada9a14c978de..b9fa8f3cade7c45fd8091142b8e55711a369c89d
a3b474ehttps://github.com/nodejs/node/commit/a3b474e6dbd738f61dab35c2a3fada9a14c978de
b9fa8f3https://github.com/nodejs/node/commit/b9fa8f3cade7c45fd8091142b8e55711a369c89d
Compare https://github.com/nodejs/node/compare/a3b474e6dbd738f61dab35c2a3fada9a14c978de..b9fa8f3cade7c45fd8091142b8e55711a369c89d
April 17, 2020 07:02https://github.com/nodejs/node/pull/32685#event-3243088484
https://github.com/danbev
danbevhttps://github.com/danbev
Apr 17, 2020https://github.com/nodejs/node/pull/32685#issuecomment-615081108
Please reload this pagehttps://github.com/nodejs/node/pull/32685
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 17, 2020 https://github.com/nodejs/node/pull/32685#pullrequestreview-395360959
View reviewed changes https://github.com/nodejs/node/pull/32685/files/b9fa8f3cade7c45fd8091142b8e55711a369c89d
common.gypihttps://github.com/nodejs/node/pull/32685/files/b9fa8f3cade7c45fd8091142b8e55711a369c89d#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 17, 2020https://github.com/nodejs/node/pull/32685#issuecomment-615185364
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/danbev
squash: remove -Werror when error_on_warn is falsehttps://github.com/nodejs/node/pull/32685/commits/1d0456c6b35fe6be4960246cdb4d16b008518cc0
1d0456chttps://github.com/nodejs/node/pull/32685/commits/1d0456c6b35fe6be4960246cdb4d16b008518cc0
https://github.com/danbev
danbevhttps://github.com/danbev
Apr 24, 2020 https://github.com/nodejs/node/pull/32685#ref-pullrequest-605226083
src: fix compiler warnings in node_http2.cc #33014 https://github.com/nodejs/node/pull/33014
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 24, 2020 https://github.com/nodejs/node/pull/32685#pullrequestreview-399780105
View reviewed changes https://github.com/nodejs/node/pull/32685/files/1d0456c6b35fe6be4960246cdb4d16b008518cc0
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 24, 2020https://github.com/nodejs/node/pull/32685#issuecomment-618903499
https://ci.nodejs.org/job/node-test-pull-request/30945/https://ci.nodejs.org/job/node-test-pull-request/30945/
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 24, 2020https://github.com/nodejs/node/pull/32685#issuecomment-618907953
https://ci.nodejs.org/job/node-test-commit-linux/https://ci.nodejs.org/job/node-test-commit-linux/
src: fix compiler warnings in node_http2.cc #33014https://github.com/nodejs/node/pull/33014
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/danbev
danbevhttps://github.com/danbev
Apr 24, 2020https://github.com/nodejs/node/pull/32685#issuecomment-618934529
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Apr 24, 2020 https://github.com/nodejs/node/pull/32685#pullrequestreview-399837091
View reviewed changes https://github.com/nodejs/node/pull/32685/files/1d0456c6b35fe6be4960246cdb4d16b008518cc0
common.gypihttps://github.com/nodejs/node/pull/32685/files/1d0456c6b35fe6be4960246cdb4d16b008518cc0#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Apr 24, 2020 https://github.com/nodejs/node/pull/32685#pullrequestreview-399837658
View reviewed changes https://github.com/nodejs/node/pull/32685/files/1d0456c6b35fe6be4960246cdb4d16b008518cc0
node.gyphttps://github.com/nodejs/node/pull/32685/files/1d0456c6b35fe6be4960246cdb4d16b008518cc0#diff-9f1d0716c75f4df39d9e88499ac205b50301c0c672b816ce54d5339be4c2238c
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/danbev
squash: set error_on_warn to false instead of 0https://github.com/nodejs/node/pull/32685/commits/9890e675fdb28bb7c0626745e5585b52f6b6469e
9890e67https://github.com/nodejs/node/pull/32685/commits/9890e675fdb28bb7c0626745e5585b52f6b6469e
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 24, 2020 https://github.com/nodejs/node/pull/32685#pullrequestreview-400047882
View reviewed changes https://github.com/nodejs/node/pull/32685/files/9890e675fdb28bb7c0626745e5585b52f6b6469e
configure.pyhttps://github.com/nodejs/node/pull/32685/files/9890e675fdb28bb7c0626745e5585b52f6b6469e#diff-4d5f3192809ec1b9add6b33007e0c50031ad9a0a2f3f55a481b506468824db2c
jasnellhttps://github.com/jasnell
Apr 24, 2020https://github.com/nodejs/node/pull/32685#discussion_r414663352
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32685
danbevhttps://github.com/danbev
Apr 27, 2020https://github.com/nodejs/node/pull/32685#discussion_r415805282
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 27, 2020 https://github.com/nodejs/node/pull/32685#pullrequestreview-401379502
View reviewed changes https://github.com/nodejs/node/pull/32685/files/9890e675fdb28bb7c0626745e5585b52f6b6469e
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Apr 27, 2020 https://github.com/nodejs/node/pull/32685#pullrequestreview-401402424
View reviewed changes https://github.com/nodejs/node/pull/32685/files/9890e675fdb28bb7c0626745e5585b52f6b6469e
mmarchinihttps://github.com/mmarchini
https://github.com/nodejs/node/pull/32685#pullrequestreview-401402424
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32685
danbevhttps://github.com/danbev
Apr 30, 2020 https://github.com/nodejs/node/pull/32685#ref-commit-a7ae7aa
https://github.com/danbev
build: add --error-on-warn configure flaghttps://github.com/nodejs/node/commit/a7ae7aab597a874cb0087e8e333e8f7765ded88c
a7ae7aahttps://github.com/nodejs/node/commit/a7ae7aab597a874cb0087e8e333e8f7765ded88c
#32685https://github.com/nodejs/node/pull/32685
danbevhttps://github.com/danbev
Apr 30, 2020 https://github.com/nodejs/node/pull/32685#ref-commit-2e441e1
https://github.com/danbev
tools: fix redundant-move warning in inspectorhttps://github.com/nodejs/node/commit/2e441e152fdda36a8ae9d97e2a312e024494456f
2e441e1https://github.com/nodejs/node/commit/2e441e152fdda36a8ae9d97e2a312e024494456f
#32685https://github.com/nodejs/node/pull/32685
https://github.com/danbev
danbevhttps://github.com/danbev
Apr 30, 2020https://github.com/nodejs/node/pull/32685#issuecomment-621602973
2e441e1https://github.com/nodejs/node/commit/2e441e152fdda36a8ae9d97e2a312e024494456f
a7ae7aahttps://github.com/nodejs/node/commit/a7ae7aab597a874cb0087e8e333e8f7765ded88c
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/danbev
danbevhttps://github.com/danbev
Apr 30, 2020https://github.com/nodejs/node/pull/32685#event-3287460549
https://github.com/danbev
danbevhttps://github.com/danbev
April 30, 2020 04:19https://github.com/nodejs/node/pull/32685#event-3287461047
https://github.com/danbev
danbevhttps://github.com/danbev
Apr 30, 2020 https://github.com/nodejs/node/pull/32685#ref-issue-609619560
Add --error-on-warn to vcbuild.bat #33158 https://github.com/nodejs/node/issues/33158
targoshttps://github.com/targos
May 4, 2020 https://github.com/nodejs/node/pull/32685#ref-commit-f62d92b
https://github.com/danbev
https://github.com/targos
build: add --error-on-warn configure flaghttps://github.com/nodejs/node/commit/f62d92b900eac7d8603817ea65e95e08678ff840
f62d92bhttps://github.com/nodejs/node/commit/f62d92b900eac7d8603817ea65e95e08678ff840
#32685https://github.com/nodejs/node/pull/32685
targoshttps://github.com/targos
May 4, 2020 https://github.com/nodejs/node/pull/32685#ref-commit-a87d371
https://github.com/danbev
https://github.com/targos
tools: fix redundant-move warning in inspectorhttps://github.com/nodejs/node/commit/a87d3710148c0d1128e5372a1a8b90edd174a65d
a87d371https://github.com/nodejs/node/commit/a87d3710148c0d1128e5372a1a8b90edd174a65d
#32685https://github.com/nodejs/node/pull/32685
https://github.com/targos
targoshttps://github.com/targos
May 4, 2020 https://github.com/nodejs/node/pull/32685#ref-pullrequest-611881566
v14.2.0 release proposal #33232 https://github.com/nodejs/node/pull/33232
targoshttps://github.com/targos
May 7, 2020 https://github.com/nodejs/node/pull/32685#ref-commit-6a6d58b
https://github.com/danbev
https://github.com/targos
build: add --error-on-warn configure flaghttps://github.com/nodejs/node/commit/6a6d58bd7f0c295c821f006e9e440ee594f3a368
6a6d58bhttps://github.com/nodejs/node/commit/6a6d58bd7f0c295c821f006e9e440ee594f3a368
#32685https://github.com/nodejs/node/pull/32685
targoshttps://github.com/targos
May 7, 2020 https://github.com/nodejs/node/pull/32685#ref-commit-8970d22
https://github.com/danbev
https://github.com/targos
tools: fix redundant-move warning in inspectorhttps://github.com/nodejs/node/commit/8970d22cccaecfa6f0cf83f7c4ca61efec236266
8970d22https://github.com/nodejs/node/commit/8970d22cccaecfa6f0cf83f7c4ca61efec236266
#32685https://github.com/nodejs/node/pull/32685
https://github.com/targos
targoshttps://github.com/targos
May 7, 2020 https://github.com/nodejs/node/pull/32685#ref-pullrequest-610737650
v12.17.0 release proposal #33197 https://github.com/nodejs/node/pull/33197
richardlauhttps://github.com/richardlau
May 11, 2020 https://github.com/nodejs/node/pull/32685#ref-commit-0744547
https://github.com/danbev
https://github.com/richardlau
build: add --error-on-warn configure flaghttps://github.com/nodejs/node/commit/0744547abb08e14dee2291872ff79adb0d50ccb6
0744547https://github.com/nodejs/node/commit/0744547abb08e14dee2291872ff79adb0d50ccb6
#32685https://github.com/nodejs/node/pull/32685
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 11, 2020https://github.com/nodejs/node/pull/32685#issuecomment-626689909
a7ae7aahttps://github.com/nodejs/node/commit/a7ae7aab597a874cb0087e8e333e8f7765ded88c
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 11, 2020 https://github.com/nodejs/node/pull/32685#ref-pullrequest-615996839
build: enable --error-on-warn for POSIX workflows #33357 https://github.com/nodejs/node/pull/33357
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
May 13, 2020https://github.com/nodejs/node/pull/32685#event-3332742089
richardlauhttps://github.com/richardlau
May 13, 2020 https://github.com/nodejs/node/pull/32685#ref-commit-3aa5152
https://github.com/richardlau
build: fix --error-on-warn for macOShttps://github.com/richardlau/node-1/commit/3aa515210afaefcf99b3f4ad49239fc5738ef58d
3aa5152https://github.com/richardlau/node-1/commit/3aa515210afaefcf99b3f4ad49239fc5738ef58d
nodejs#33357https://github.com/nodejs/node/pull/33357
nodejs#32685https://github.com/nodejs/node/pull/32685
richardlauhttps://github.com/richardlau
May 13, 2020 https://github.com/nodejs/node/pull/32685#ref-commit-fcc183c
https://github.com/richardlau
build: enable --error-on-warn for POSIX workflowshttps://github.com/richardlau/node-1/commit/fcc183c99413750b1b965e45cb42a1af73da47ab
fcc183chttps://github.com/richardlau/node-1/commit/fcc183c99413750b1b965e45cb42a1af73da47ab
nodejs#33357https://github.com/nodejs/node/pull/33357
nodejs#32685https://github.com/nodejs/node/pull/32685
codebyterehttps://github.com/codebytere
May 16, 2020 https://github.com/nodejs/node/pull/32685#ref-commit-7d4db35
https://github.com/richardlau
https://github.com/codebytere
build: fix --error-on-warn for macOShttps://github.com/nodejs/node/commit/7d4db35f8482e5324e6c44a62a06d5e83658e874
7d4db35https://github.com/nodejs/node/commit/7d4db35f8482e5324e6c44a62a06d5e83658e874
#33357https://github.com/nodejs/node/pull/33357
#32685https://github.com/nodejs/node/pull/32685
codebyterehttps://github.com/codebytere
May 16, 2020 https://github.com/nodejs/node/pull/32685#ref-commit-34e7400
https://github.com/richardlau
https://github.com/codebytere
build: enable --error-on-warn for POSIX workflowshttps://github.com/nodejs/node/commit/34e7400fc1269f7db08efb3ac87724ac32a0a724
34e7400https://github.com/nodejs/node/commit/34e7400fc1269f7db08efb3ac87724ac32a0a724
#33357https://github.com/nodejs/node/pull/33357
#32685https://github.com/nodejs/node/pull/32685
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/32685#ref-commit-1a154d1
https://github.com/richardlau
https://github.com/codebytere
build: enable --error-on-warn for POSIX workflowshttps://github.com/nodejs/node/commit/1a154d1e3bb5e3a5dd5eaddef3aa3c1fd51cf25c
1a154d1https://github.com/nodejs/node/commit/1a154d1e3bb5e3a5dd5eaddef3aa3c1fd51cf25c
#33357https://github.com/nodejs/node/pull/33357
#32685https://github.com/nodejs/node/pull/32685
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 22, 2022 https://github.com/nodejs/node/pull/32685#ref-issue-1419175542
Reduce the number of patches we float on V8 #45118 https://github.com/nodejs/node/issues/45118
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32685
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/32685/files/9890e675fdb28bb7c0626745e5585b52f6b6469e
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/32685/files/9890e675fdb28bb7c0626745e5585b52f6b6469e
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/32685/files/1d0456c6b35fe6be4960246cdb4d16b008518cc0
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/32685/files/1d0456c6b35fe6be4960246cdb4d16b008518cc0
https://github.com/mmarchini
mmarchini https://github.com/mmarchini
https://github.com/nodejs/node/pull/32685/files/9890e675fdb28bb7c0626745e5585b52f6b6469e
Please reload this pagehttps://github.com/nodejs/node/pull/32685
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/32685
https://github.com/danbev
https://github.com/nodejs-github-bot
https://github.com/mscdex
https://github.com/addaleax
https://github.com/sam-github
https://github.com/richardlau
https://github.com/jasnell
https://github.com/mmarchini
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.