René's URL Explorer Experiment


Title: lib: remove unnecesary else block by ddazal · Pull Request #32644 · nodejs/node · GitHub

Open Graph Title: lib: remove unnecesary else block by ddazal · Pull Request #32644 · nodejs/node

X Title: lib: remove unnecesary else block by ddazal · Pull Request #32644 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The if statement inside the _writeHostObject function returns an expression which makes the else block unnecessary Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or b...

X Description: The if statement inside the _writeHostObject function returns an expression which makes the else block unnecessary Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or b...

Opengraph URL: https://github.com/nodejs/node/pull/32644

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:99f7d43b-d288-527f-1d3d-2187870469d6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA43A:14D25F:47CF87:5DAF96:6AED23F6
html-safe-nonce7865ee6f211f1cd57ea6a4973e17038742a2ffc12ee35c3baf9b13d5250a30ae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDNBOjE0RDI1Rjo0N0NGODc6NURBRjk2OjZBRUQyM0Y2IiwidmlzaXRvcl9pZCI6IjUxNjk2MTk4NDI2ODI5MjE5NzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7ee98f07d7b17bd544870c2bde49ede2120aaebe8d435fdcf073ce73e3668460
hovercard-subject-tagpull_request:398310537
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32644/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d5373e749e56fe1ea1a0469de7973c9d561056e74c43a0b35a0235d7dbf76d61/nodejs/node/pull/32644
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d5373e749e56fe1ea1a0469de7973c9d561056e74c43a0b35a0235d7dbf76d61/nodejs/node/pull/32644
og:image:altThe if statement inside the _writeHostObject function returns an expression which makes the else block unnecessary Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or b...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameddazal
hostnamegithub.com
expected-hostnamegithub.com
None9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release98b41fa4b5635ceb45a4c54320fced73817ff290
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/32644#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32644
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32644
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/32644
Reloadhttps://github.com/nodejs/node/pull/32644
Reloadhttps://github.com/nodejs/node/pull/32644
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
ddazalhttps://github.com/ddazal
nodejs:masterhttps://github.com/nodejs/node/tree/master
ddazal:ddazal/child-process-serialization-early-returnhttps://github.com/ddazal/node/tree/ddazal/child-process-serialization-early-return
Conversationhttps://github.com/nodejs/node/pull/32644
Commits1 (1)https://github.com/nodejs/node/pull/32644/commits
Checkshttps://github.com/nodejs/node/pull/32644/checks
Files changedhttps://github.com/nodejs/node/pull/32644/files
lib: remove unnecesary else blockhttps://github.com/nodejs/node/pull/32644#top
ddazalhttps://github.com/ddazal
nodejs:masterhttps://github.com/nodejs/node/tree/master
ddazal:ddazal/child-process-serialization-early-returnhttps://github.com/ddazal/node/tree/ddazal/child-process-serialization-early-return
https://github.com/ddazal
ddazalhttps://github.com/ddazal
Apr 3, 2020https://github.com/nodejs/node/pull/32644#issue-593548805
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/32644
https://github.com/ddazal
lib: remove unnecesary else blockhttps://github.com/nodejs/node/pull/32644/commits/bc549d00b685b208072a19308bdd128a418a67ce
bc549d0https://github.com/nodejs/node/pull/32644/commits/bc549d00b685b208072a19308bdd128a418a67ce
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
Apr 3, 2020https://github.com/nodejs/node/pull/32644#event-3197445126
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 3, 2020 https://github.com/nodejs/node/pull/32644#pullrequestreview-387469768
View reviewed changes https://github.com/nodejs/node/pull/32644/files/bc549d00b685b208072a19308bdd128a418a67ce
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 3, 2020 https://github.com/nodejs/node/pull/32644#pullrequestreview-387514430
View reviewed changes https://github.com/nodejs/node/pull/32644/files/bc549d00b685b208072a19308bdd128a418a67ce
https://github.com/awibox
awiboxhttps://github.com/awibox
Apr 3, 2020 https://github.com/nodejs/node/pull/32644#pullrequestreview-387520575
View reviewed changes https://github.com/nodejs/node/pull/32644/files/bc549d00b685b208072a19308bdd128a418a67ce
https://github.com/lpinca
lpincahttps://github.com/lpinca
Apr 4, 2020 https://github.com/nodejs/node/pull/32644#pullrequestreview-387669617
View reviewed changes https://github.com/nodejs/node/pull/32644/files/bc549d00b685b208072a19308bdd128a418a67ce
https://github.com/lpinca
lpincahttps://github.com/lpinca
Apr 5, 2020 https://github.com/nodejs/node/pull/32644#ref-pullrequest-594376971
tools: enable no-else-return lint rule #32667 https://github.com/nodejs/node/pull/32667
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 17, 2020 https://github.com/nodejs/node/pull/32644#pullrequestreview-395816971
View reviewed changes https://github.com/nodejs/node/pull/32644/files/bc549d00b685b208072a19308bdd128a418a67ce
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 18, 2020 https://github.com/nodejs/node/pull/32644#pullrequestreview-395880798
View reviewed changes https://github.com/nodejs/node/pull/32644/files/bc549d00b685b208072a19308bdd128a418a67ce
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Apr 18, 2020 https://github.com/nodejs/node/pull/32644#pullrequestreview-395950862
View reviewed changes https://github.com/nodejs/node/pull/32644/files/bc549d00b685b208072a19308bdd128a418a67ce
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 18, 2020https://github.com/nodejs/node/pull/32644#event-3248395005
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 18, 2020https://github.com/nodejs/node/pull/32644#issuecomment-615949619
https://ci.nodejs.org/job/node-test-pull-request/30836/https://ci.nodejs.org/job/node-test-pull-request/30836/
Please reload this pagehttps://github.com/nodejs/node/pull/32644
juanarbolhttps://github.com/juanarbol
Apr 18, 2020 https://github.com/nodejs/node/pull/32644#ref-commit-83f7bb4
https://github.com/ddazal
https://github.com/juanarbol
lib: remove unnecesary else blockhttps://github.com/nodejs/node/commit/83f7bb441fb647ccac88f4787ac0c308ebb146ab
83f7bb4https://github.com/nodejs/node/commit/83f7bb441fb647ccac88f4787ac0c308ebb146ab
#32644https://github.com/nodejs/node/pull/32644
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Apr 18, 2020https://github.com/nodejs/node/pull/32644#issuecomment-615953734
83f7bb4https://github.com/nodejs/node/commit/83f7bb441fb647ccac88f4787ac0c308ebb146ab
Please reload this pagehttps://github.com/nodejs/node/pull/32644
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Apr 18, 2020https://github.com/nodejs/node/pull/32644#event-3248416315
https://github.com/ddazal
ddazalhttps://github.com/ddazal
April 18, 2020 22:05https://github.com/nodejs/node/pull/32644#event-3248437045
BethGriggshttps://github.com/BethGriggs
Apr 27, 2020 https://github.com/nodejs/node/pull/32644#ref-commit-b957895
https://github.com/ddazal
https://github.com/BethGriggs
lib: remove unnecesary else blockhttps://github.com/nodejs/node/commit/b957895ff73f574b29e3ce49ed1dbb4a31124158
b957895https://github.com/nodejs/node/commit/b957895ff73f574b29e3ce49ed1dbb4a31124158
#32644https://github.com/nodejs/node/pull/32644
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Apr 27, 2020 https://github.com/nodejs/node/pull/32644#ref-pullrequest-607819306
v14.1.0 proposal #33103 https://github.com/nodejs/node/pull/33103
BridgeARhttps://github.com/BridgeAR
Apr 28, 2020 https://github.com/nodejs/node/pull/32644#ref-commit-8a85afa
https://github.com/ddazal
https://github.com/BridgeAR
lib: remove unnecesary else blockhttps://github.com/nodejs/node/commit/8a85afabba5ffe8ecd62b3c50389e79cff1f5355
8a85afahttps://github.com/nodejs/node/commit/8a85afabba5ffe8ecd62b3c50389e79cff1f5355
#32644https://github.com/nodejs/node/pull/32644
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 28, 2020 https://github.com/nodejs/node/pull/32644#ref-pullrequest-608268983
v13.14.0 proposal #33122 https://github.com/nodejs/node/pull/33122
targoshttps://github.com/targos
Apr 30, 2020 https://github.com/nodejs/node/pull/32644#ref-commit-84571ce
https://github.com/ddazal
https://github.com/targos
lib: remove unnecesary else blockhttps://github.com/nodejs/node/commit/84571cec7eee64caedd4251b6fa56a5b0f12be96
84571cehttps://github.com/nodejs/node/commit/84571cec7eee64caedd4251b6fa56a5b0f12be96
#32644https://github.com/nodejs/node/pull/32644
https://github.com/targos
targoshttps://github.com/targos
May 2, 2020 https://github.com/nodejs/node/pull/32644#ref-pullrequest-610737650
v12.17.0 release proposal #33197 https://github.com/nodejs/node/pull/33197
lpincahttps://github.com/lpinca
May 15, 2020 https://github.com/nodejs/node/pull/32644#ref-commit-af70a1c
https://github.com/lpinca
tools: enable no-else-return lint rulehttps://github.com/lpinca/node/commit/af70a1c7a109cb8a5b78cd7cab60518631351c22
af70a1chttps://github.com/lpinca/node/commit/af70a1c7a109cb8a5b78cd7cab60518631351c22
nodejs#32644https://github.com/nodejs/node/pull/32644
nodejs#32662https://github.com/nodejs/node/pull/32662
lpincahttps://github.com/lpinca
May 16, 2020 https://github.com/nodejs/node/pull/32644#ref-commit-b533fb3
https://github.com/lpinca
tools: enable no-else-return lint rulehttps://github.com/nodejs/node/commit/b533fb3508009e5f567cc776daba8fbf665386a6
b533fb3https://github.com/nodejs/node/commit/b533fb3508009e5f567cc776daba8fbf665386a6
#32644https://github.com/nodejs/node/pull/32644
#32662https://github.com/nodejs/node/pull/32662
#32667https://github.com/nodejs/node/pull/32667
codebyterehttps://github.com/codebytere
May 16, 2020 https://github.com/nodejs/node/pull/32644#ref-commit-9119344
https://github.com/lpinca
https://github.com/codebytere
tools: enable no-else-return lint rulehttps://github.com/nodejs/node/commit/91193447fbca4f01fdc7cbb41ce771c3fd928bcf
9119344https://github.com/nodejs/node/commit/91193447fbca4f01fdc7cbb41ce771c3fd928bcf
#32644https://github.com/nodejs/node/pull/32644
#32662https://github.com/nodejs/node/pull/32662
#32667https://github.com/nodejs/node/pull/32667
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 9, 2020 https://github.com/nodejs/node/pull/32644#ref-pullrequest-653977001
[v12.x backport] tools: enable no-else-return lint rule #34275 https://github.com/nodejs/node/pull/34275
lpincahttps://github.com/lpinca
Jul 9, 2020 https://github.com/nodejs/node/pull/32644#ref-commit-441e6d9
https://github.com/lpinca
tools: enable no-else-return lint rulehttps://github.com/lpinca/node/commit/441e6d9ebe81aba52139e90e1bcf6f1c2f8db677
441e6d9https://github.com/lpinca/node/commit/441e6d9ebe81aba52139e90e1bcf6f1c2f8db677
nodejs#32644https://github.com/nodejs/node/pull/32644
nodejs#32662https://github.com/nodejs/node/pull/32662
nodejs#32667https://github.com/nodejs/node/pull/32667
nodejs#34275https://github.com/nodejs/node/pull/34275
codebyterehttps://github.com/codebytere
Jul 13, 2020 https://github.com/nodejs/node/pull/32644#ref-commit-a131c72
https://github.com/lpinca
https://github.com/codebytere
tools: enable no-else-return lint rulehttps://github.com/nodejs/node/commit/a131c72586c76f58848f9d25d01430b7f0c560d1
a131c72https://github.com/nodejs/node/commit/a131c72586c76f58848f9d25d01430b7f0c560d1
#32644https://github.com/nodejs/node/pull/32644
#32662https://github.com/nodejs/node/pull/32662
#32667https://github.com/nodejs/node/pull/32667
#34275https://github.com/nodejs/node/pull/34275
codebyterehttps://github.com/codebytere
Jul 14, 2020 https://github.com/nodejs/node/pull/32644#ref-commit-248f9af
https://github.com/lpinca
https://github.com/codebytere
tools: enable no-else-return lint rulehttps://github.com/nodejs/node/commit/248f9af41194e672220be237af2eb6b4510b1080
248f9afhttps://github.com/nodejs/node/commit/248f9af41194e672220be237af2eb6b4510b1080
#32644https://github.com/nodejs/node/pull/32644
#32662https://github.com/nodejs/node/pull/32662
#32667https://github.com/nodejs/node/pull/32667
#34275https://github.com/nodejs/node/pull/34275
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32644
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/32644/files/bc549d00b685b208072a19308bdd128a418a67ce
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/32644/files/bc549d00b685b208072a19308bdd128a418a67ce
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/32644/files/bc549d00b685b208072a19308bdd128a418a67ce
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/32644/files/bc549d00b685b208072a19308bdd128a418a67ce
https://github.com/juanarbol
juanarbol https://github.com/juanarbol
https://github.com/nodejs/node/pull/32644/files/bc549d00b685b208072a19308bdd128a418a67ce
https://github.com/awibox
awibox https://github.com/awibox
https://github.com/nodejs/node/pull/32644/files/bc549d00b685b208072a19308bdd128a418a67ce
Please reload this pagehttps://github.com/nodejs/node/pull/32644
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
Please reload this pagehttps://github.com/nodejs/node/pull/32644
https://github.com/ddazal
https://github.com/nodejs-github-bot
https://github.com/juanarbol
https://github.com/jasnell
https://github.com/addaleax
https://github.com/lpinca
https://github.com/awibox
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.