René's URL Explorer Experiment


Title: esm: resolve main from package.json when importing from directory by lingsamuel · Pull Request #32612 · nodejs/node · GitHub

Open Graph Title: esm: resolve main from package.json when importing from directory by lingsamuel · Pull Request #32612 · nodejs/node

X Title: esm: resolve main from package.json when importing from directory by lingsamuel · Pull Request #32612 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Fixes #32103 Ref: My issue comment

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Fixes #32103 Ref: My issue comment

Opengraph URL: https://github.com/nodejs/node/pull/32612

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4e203ee7-95df-b1eb-ab22-5e72118fe6ab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC402:50FD4:27F74F0:36DB3B2:6A4EF585
html-safe-noncea9a144ee6b55334f900e3284162eb2e618362520352cc308efafdf5b9de6bfd5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDAyOjUwRkQ0OjI3Rjc0RjA6MzZEQjNCMjo2QTRFRjU4NSIsInZpc2l0b3JfaWQiOiI5NTk3NjY4NjI3NjUxNTk4MTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac964b2b44d58bf5e21d38683348a850dff9493b41f95e337b3db5c42094dcdd29
hovercard-subject-tagpull_request:397380033
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32612/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7bae490b0eb8292d223ecf977c4dbb54c68d0cae489663e342a8c6cf18b4dd93/nodejs/node/pull/32612
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7bae490b0eb8292d223ecf977c4dbb54c68d0cae489663e342a8c6cf18b4dd93/nodejs/node/pull/32612
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Fixes #32103 Ref: My issue comment
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelingsamuel
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/32612#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32612
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32612
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/32612
Reloadhttps://github.com/nodejs/node/pull/32612
Reloadhttps://github.com/nodejs/node/pull/32612
Please reload this pagehttps://github.com/nodejs/node/pull/32612
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/32612
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
lingsamuelhttps://github.com/lingsamuel
nodejs:masterhttps://github.com/nodejs/node/tree/master
lingsamuel:fix-experimental-specifier-resolution-import-dirhttps://github.com/lingsamuel/node/tree/fix-experimental-specifier-resolution-import-dir
Conversationhttps://github.com/nodejs/node/pull/32612
Commits3 (3)https://github.com/nodejs/node/pull/32612/commits
Checkshttps://github.com/nodejs/node/pull/32612/checks
Files changedhttps://github.com/nodejs/node/pull/32612/files
esm: resolve main from package.json when importing from directoryhttps://github.com/nodejs/node/pull/32612#top
lingsamuelhttps://github.com/lingsamuel
nodejs:masterhttps://github.com/nodejs/node/tree/master
lingsamuel:fix-experimental-specifier-resolution-import-dirhttps://github.com/lingsamuel/node/tree/fix-experimental-specifier-resolution-import-dir
https://github.com/lingsamuel
lingsamuelhttps://github.com/lingsamuel
Apr 2, 2020https://github.com/nodejs/node/pull/32612#issue-592387587
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
#32103https://github.com/nodejs/node/issues/32103
My issue commenthttps://github.com/nodejs/node/issues/32103#issuecomment-607203279
Please reload this pagehttps://github.com/nodejs/node/pull/32612
https://github.com/lingsamuel
esm: resolve main from package.json when importing from directoryhttps://github.com/nodejs/node/pull/32612/commits/22292f3ba4d2b23a65de9527a88b0442f1c689f2
22292f3https://github.com/nodejs/node/pull/32612/commits/22292f3ba4d2b23a65de9527a88b0442f1c689f2
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
Apr 2, 2020https://github.com/nodejs/node/pull/32612#event-3190730546
https://github.com/himself65
himself65https://github.com/himself65
Apr 2, 2020 https://github.com/nodejs/node/pull/32612#pullrequestreview-386144981
View reviewed changes https://github.com/nodejs/node/pull/32612/files/22292f3ba4d2b23a65de9527a88b0442f1c689f2
test/fixtures/es-module-specifiers/package-with-exports/exports_main.jshttps://github.com/nodejs/node/pull/32612/files/22292f3ba4d2b23a65de9527a88b0442f1c689f2#diff-8059ee189024a352ef8a69e4dc635c3ba6ec891b1a901aea813544902fe8d043
Please reload this pagehttps://github.com/nodejs/node/pull/32612
https://github.com/himself65
himself65https://github.com/himself65
Apr 2, 2020 https://github.com/nodejs/node/pull/32612#pullrequestreview-386147519
View reviewed changes https://github.com/nodejs/node/pull/32612/files/22292f3ba4d2b23a65de9527a88b0442f1c689f2
lib/internal/modules/esm/resolve.jshttps://github.com/nodejs/node/pull/32612/files/22292f3ba4d2b23a65de9527a88b0442f1c689f2#diff-b4c24f634e3741e5ad9e8c29864a48f2bd284a9d66d8fed3d077ccee0c44087b
Please reload this pagehttps://github.com/nodejs/node/pull/32612
lingsamuelhttps://github.com/lingsamuel
April 2, 2020 14:52https://github.com/nodejs/node/pull/32612#commits-pushed-fc5a30d
https://github.com/lingsamuel
test: remove console.loghttps://github.com/nodejs/node/pull/32612/commits/fc5a30d8612d98c81bfc1b92bbc9ce96a374f92a
fc5a30dhttps://github.com/nodejs/node/pull/32612/commits/fc5a30d8612d98c81bfc1b92bbc9ce96a374f92a
https://github.com/lingsamuel
esm: fix a redundant new callhttps://github.com/nodejs/node/pull/32612/commits/7f8fcbbbe4a12a82cb1488c82b2346faa70a37f0
7f8fcbbhttps://github.com/nodejs/node/pull/32612/commits/7f8fcbbbe4a12a82cb1488c82b2346faa70a37f0
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Apr 2, 2020 https://github.com/nodejs/node/pull/32612#pullrequestreview-386640945
View reviewed changes https://github.com/nodejs/node/pull/32612/files/7f8fcbbbe4a12a82cb1488c82b2346faa70a37f0
guybedfordhttps://github.com/guybedford
https://github.com/nodejs/node/pull/32612#pullrequestreview-386640945
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://nodejs.org/dist/latest-v13.x/docs/api/esm.html#esm_differences_between_es_modules_and_commonjshttps://nodejs.org/dist/latest-v13.x/docs/api/esm.html#esm_differences_between_es_modules_and_commonjs
Please reload this pagehttps://github.com/nodejs/node/pull/32612
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 3, 2020https://github.com/nodejs/node/pull/32612#issuecomment-608291989
@guybedfordhttps://github.com/guybedford
Please reload this pagehttps://github.com/nodejs/node/pull/32612
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Apr 3, 2020 https://github.com/nodejs/node/pull/32612#pullrequestreview-387586117
View reviewed changes https://github.com/nodejs/node/pull/32612/files/7f8fcbbbe4a12a82cb1488c82b2346faa70a37f0
guybedfordhttps://github.com/guybedford
https://github.com/nodejs/node/pull/32612#pullrequestreview-387586117
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@lingsamuelhttps://github.com/lingsamuel
https://nodejs.org/dist/latest-v12.x/docs/api/modules.html#modules_all_togetherhttps://nodejs.org/dist/latest-v12.x/docs/api/modules.html#modules_all_together
Please reload this pagehttps://github.com/nodejs/node/pull/32612
lib/internal/modules/esm/resolve.jshttps://github.com/nodejs/node/pull/32612/files/7f8fcbbbe4a12a82cb1488c82b2346faa70a37f0#diff-b4c24f634e3741e5ad9e8c29864a48f2bd284a9d66d8fed3d077ccee0c44087b
guybedfordhttps://github.com/guybedford
Apr 3, 2020https://github.com/nodejs/node/pull/32612#discussion_r403340432
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32612
lingsamuelhttps://github.com/lingsamuel
Apr 8, 2020https://github.com/nodejs/node/pull/32612#discussion_r405220724
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32612
guybedfordhttps://github.com/guybedford
Apr 8, 2020https://github.com/nodejs/node/pull/32612#discussion_r405225998
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32612
lingsamuelhttps://github.com/lingsamuel
Apr 13, 2020https://github.com/nodejs/node/pull/32612#discussion_r407297130
Please reload this pagehttps://github.com/nodejs/node/pull/32612
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32612
guybedfordhttps://github.com/guybedford
Apr 13, 2020https://github.com/nodejs/node/pull/32612#discussion_r407583174
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@lingsamuelhttps://github.com/lingsamuel
Please reload this pagehttps://github.com/nodejs/node/pull/32612
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5
8ae28ffhttps://github.com/nodejs/node/commit/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda
2935f72https://github.com/nodejs/node/commit/2935f72ae1b991c64118031dec12e7d7db7714a5
Compare https://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5
May 31, 2020 12:18https://github.com/nodejs/node/pull/32612#event-3390558761
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jun 29, 2020 https://github.com/nodejs/node/pull/32612#ref-issue-576146335
"Cannot find module" when main file not index.js with experimental-specifier-resolution=node #32103 https://github.com/nodejs/node/issues/32103
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04..8e46568b1e12fe00581b1292bd6c2b01373f17bd
dc5a5dahttps://github.com/nodejs/node/commit/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04
8e46568https://github.com/nodejs/node/commit/8e46568b1e12fe00581b1292bd6c2b01373f17bd
Compare https://github.com/nodejs/node/compare/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04..8e46568b1e12fe00581b1292bd6c2b01373f17bd
March 29, 2021 21:33https://github.com/nodejs/node/pull/32612#event-4523995910
https://github.com/aduh95
aduh95https://github.com/aduh95
Jun 13, 2021https://github.com/nodejs/node/pull/32612#issuecomment-860219440
#38979https://github.com/nodejs/node/pull/38979
Please reload this pagehttps://github.com/nodejs/node/pull/32612
https://github.com/aduh95
aduh95https://github.com/aduh95
Jun 13, 2021https://github.com/nodejs/node/pull/32612#event-4882337004
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32612
https://github.com/guybedford
guybedford https://github.com/guybedford
https://github.com/nodejs/node/pull/32612/files/7f8fcbbbe4a12a82cb1488c82b2346faa70a37f0
https://github.com/himself65
himself65 https://github.com/himself65
https://github.com/nodejs/node/pull/32612/files/22292f3ba4d2b23a65de9527a88b0442f1c689f2
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
"Cannot find module" when main file not index.js with experimental-specifier-resolution=node https://github.com/nodejs/node/issues/32103
Please reload this pagehttps://github.com/nodejs/node/pull/32612
https://github.com/lingsamuel
https://github.com/MylesBorins
https://github.com/aduh95
https://github.com/guybedford
https://github.com/himself65
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.