| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:32e99f88-03ed-1a63-f76d-911b633f6f9a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C804:7E20E:F65F43:1527EA3:696A912B |
| html-safe-nonce | 814ab0d54d153cc928764e23ec5d2b8d949bffafb01d90b0a1f821e9f6d914ec |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODA0OjdFMjBFOkY2NUY0MzoxNTI3RUEzOjY5NkE5MTJCIiwidmlzaXRvcl9pZCI6IjcyNDcyNDg0NjE5NjA2ODY1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 02905bb99b698282d246958f7f7dec935176f3a63bd4cec9a46b8def302ec2c4 |
| hovercard-subject-tag | pull_request:391986986 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32422/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/78e9a02cd7f273a525a7fa7421f622c65d621a51925f08f39ffec3b745fc6dc8/nodejs/node/pull/32422 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/78e9a02cd7f273a525a7fa7421f622c65d621a51925f08f39ffec3b745fc6dc8/nodejs/node/pull/32422 |
| og:image:alt | This un-breaks testing in the case of ./configure --debug-node.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows co... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | addaleax |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/32422#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32422 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32422 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/32422 |
| Reload | https://github.com/nodejs/node/pull/32422 |
| Reload | https://github.com/nodejs/node/pull/32422 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/32422 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/32422 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/32422#issue-comment-box |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:embedding-buildtype | https://github.com/addaleax/node/tree/embedding-buildtype |
|
test: use common.buildType in embedding test
| https://github.com/nodejs/node/pull/32422#top |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:embedding-buildtype | https://github.com/addaleax/node/tree/embedding-buildtype |
|
Conversation
4
| https://github.com/nodejs/node/pull/32422 |
|
Commits
1
| https://github.com/nodejs/node/pull/32422/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/32422/checks |
|
Files changed
| https://github.com/nodejs/node/pull/32422/files |
| Please reload this page | https://github.com/nodejs/node/pull/32422 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Mar 22, 2020 | https://github.com/nodejs/node/pull/32422#issue-585691017 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/32422 |
|
| https://github.com/addaleax |
| test: use common.buildType in embedding test | https://github.com/nodejs/node/pull/32422/commits/7a4d967069820a6e7ec8dbb7adfd202c002b6a94 |
| 7a4d967 | https://github.com/nodejs/node/pull/32422/commits/7a4d967069820a6e7ec8dbb7adfd202c002b6a94 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Mar 22, 2020 | https://github.com/nodejs/node/pull/32422#event-3152545742 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Mar 22, 2020
| https://github.com/nodejs/node/pull/32422#pullrequestreview-378995758 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32422/files/7a4d967069820a6e7ec8dbb7adfd202c002b6a94 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Mar 22, 2020
| https://github.com/nodejs/node/pull/32422#pullrequestreview-379001208 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32422/files/7a4d967069820a6e7ec8dbb7adfd202c002b6a94 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Mar 22, 2020
| https://github.com/nodejs/node/pull/32422#pullrequestreview-379042144 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32422/files/7a4d967069820a6e7ec8dbb7adfd202c002b6a94 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Mar 22, 2020 | https://github.com/nodejs/node/pull/32422#event-3153028003 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 22, 2020 | https://github.com/nodejs/node/pull/32422#issuecomment-602264511 |
| https://ci.nodejs.org/job/node-test-pull-request/29980/ | https://ci.nodejs.org/job/node-test-pull-request/29980/ |
| Please reload this page | https://github.com/nodejs/node/pull/32422 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Mar 22, 2020
| https://github.com/nodejs/node/pull/32422#pullrequestreview-379043017 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32422/files/7a4d967069820a6e7ec8dbb7adfd202c002b6a94 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 26, 2020 | https://github.com/nodejs/node/pull/32422#issuecomment-604459344 |
| https://ci.nodejs.org/job/node-test-pull-request/30090/ | https://ci.nodejs.org/job/node-test-pull-request/30090/ |
| Please reload this page | https://github.com/nodejs/node/pull/32422 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 27, 2020 | https://github.com/nodejs/node/pull/32422#issuecomment-605049380 |
| https://ci.nodejs.org/job/node-test-pull-request/30122/ | https://ci.nodejs.org/job/node-test-pull-request/30122/ |
| Please reload this page | https://github.com/nodejs/node/pull/32422 |
| addaleax | https://github.com/addaleax |
|
Mar 27, 2020
| https://github.com/nodejs/node/pull/32422#ref-commit-c3204a8 |
|
| https://github.com/addaleax |
| test: use common.buildType in embedding test | https://github.com/nodejs/node/commit/c3204a8787452e3c3727353ab397de7ee407e5cb |
| c3204a8 | https://github.com/nodejs/node/commit/c3204a8787452e3c3727353ab397de7ee407e5cb |
| #32422 | https://github.com/nodejs/node/pull/32422 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Mar 27, 2020 | https://github.com/nodejs/node/pull/32422#issuecomment-605095868 |
| c3204a8 | https://github.com/nodejs/node/commit/c3204a8787452e3c3727353ab397de7ee407e5cb |
| Please reload this page | https://github.com/nodejs/node/pull/32422 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Mar 27, 2020 | https://github.com/nodejs/node/pull/32422#event-3173144266 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| March 27, 2020 16:30 | https://github.com/nodejs/node/pull/32422#event-3173144615 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Mar 30, 2020
| https://github.com/nodejs/node/pull/32422#ref-pullrequest-522317642 |
|
src: improve embedder API
#30467
| https://github.com/nodejs/node/pull/30467 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
backport-requested-v13.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v13.x |
| Mar 30, 2020 | https://github.com/nodejs/node/pull/32422#event-3179414480 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 14, 2020
| https://github.com/nodejs/node/pull/32422#ref-pullrequest-578760228 |
|
2020-04-21, Version 14.0.0 (Current)
#32181
| https://github.com/nodejs/node/pull/32181 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backport-requested-v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v12.x |
| Apr 25, 2020 | https://github.com/nodejs/node/pull/32422#event-3272330767 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 17, 2020
| https://github.com/nodejs/node/pull/32422#ref-pullrequest-703672718 |
|
[v12.x backport] src: improve embedder API
#35241
| https://github.com/nodejs/node/pull/35241 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
backport-open-v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v12.x |
|
backport-requested-v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v12.x |
| Sep 17, 2020 | https://github.com/nodejs/node/pull/32422#event-3778501809 |
| addaleax | https://github.com/addaleax |
|
Sep 23, 2020
| https://github.com/nodejs/node/pull/32422#ref-commit-b931e68 |
|
| https://github.com/addaleax |
| test: use common.buildType in embedding test | https://github.com/addaleax/node/commit/b931e686bb0977ebc4cbba302914d5cc11db93df |
| b931e68 | https://github.com/addaleax/node/commit/b931e686bb0977ebc4cbba302914d5cc11db93df |
| nodejs#32422 | https://github.com/nodejs/node/pull/32422 |
| addaleax | https://github.com/addaleax |
|
Sep 23, 2020
| https://github.com/nodejs/node/pull/32422#ref-commit-bd71cdf |
|
| https://github.com/addaleax |
| test: use common.buildType in embedding test | https://github.com/nodejs/node/commit/bd71cdf1534135be01ed432d4ca3bff2237372a2 |
| bd71cdf | https://github.com/nodejs/node/commit/bd71cdf1534135be01ed432d4ca3bff2237372a2 |
| #35241 | https://github.com/nodejs/node/pull/35241 |
| #32422 | https://github.com/nodejs/node/pull/32422 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
backported-to-v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v12.x |
|
backport-open-v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v12.x |
| Sep 23, 2020 | https://github.com/nodejs/node/pull/32422#event-3799535193 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/32422#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32422 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/32422/files/7a4d967069820a6e7ec8dbb7adfd202c002b6a94 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/32422/files/7a4d967069820a6e7ec8dbb7adfd202c002b6a94 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/32422/files/7a4d967069820a6e7ec8dbb7adfd202c002b6a94 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/32422/files/7a4d967069820a6e7ec8dbb7adfd202c002b6a94 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/32422 |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/richardlau |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |