René's URL Explorer Experiment


Title: stream: fix pipeline with dest in objectMode by ronag · Pull Request #32414 · nodejs/node · GitHub

Open Graph Title: stream: fix pipeline with dest in objectMode by ronag · Pull Request #32414 · nodejs/node

X Title: stream: fix pipeline with dest in objectMode by ronag · Pull Request #32414 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: pipeline did not support destination which is generator that does not return strings or buffers. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are inc...

X Description: pipeline did not support destination which is generator that does not return strings or buffers. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are inc...

Opengraph URL: https://github.com/nodejs/node/pull/32414

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5a9c3bf6-dd57-38f6-f43f-b30f5d0f7910
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA63A:19A064:6F7EF0:94D21E:6AED23CF
html-safe-noncee3037f42268d27788c99ae6c3ebb3b2e3c134de9d9c119ca69cc7c056f872791
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjNBOjE5QTA2NDo2RjdFRjA6OTREMjFFOjZBRUQyM0NGIiwidmlzaXRvcl9pZCI6Ijg3Njk0OTYxMDQwMTM5OTcwMDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacca34292b369a94dccfc8bbe56e48bb2e1235c08358fb364df1c3e96921d507b8
hovercard-subject-tagpull_request:391917690
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32414/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/87ea7d809341fe75d1e231ff757ebdca8abba6d130f5dd8bdda83bc3898cb493/nodejs/node/pull/32414
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/87ea7d809341fe75d1e231ff757ebdca8abba6d130f5dd8bdda83bc3898cb493/nodejs/node/pull/32414
og:image:altpipeline did not support destination which is generator that does not return strings or buffers. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are inc...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/32414#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32414
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32414
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/32414
Reloadhttps://github.com/nodejs/node/pull/32414
Reloadhttps://github.com/nodejs/node/pull/32414
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-pipeline-dest-objectmodehttps://github.com/nxtedition/node/tree/stream-pipeline-dest-objectmode
Conversationhttps://github.com/nodejs/node/pull/32414
Commits1 (1)https://github.com/nodejs/node/pull/32414/commits
Checkshttps://github.com/nodejs/node/pull/32414/checks
Files changedhttps://github.com/nodejs/node/pull/32414/files
stream: fix pipeline with dest in objectModehttps://github.com/nodejs/node/pull/32414#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-pipeline-dest-objectmodehttps://github.com/nxtedition/node/tree/stream-pipeline-dest-objectmode
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 21, 2020https://github.com/nodejs/node/pull/32414#issue-585586698
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/32414
https://github.com/ronag
ronaghttps://github.com/ronag
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Mar 21, 2020https://github.com/nodejs/node/pull/32414#event-3152107469
https://github.com/ronag
ronaghttps://github.com/ronag
mcollinahttps://github.com/mcollina
Mar 21, 2020https://github.com/nodejs/node/pull/32414#event-3152107476
https://github.com/ronag
ronaghttps://github.com/ronag
mcollinahttps://github.com/mcollina
March 21, 2020 21:25https://github.com/nodejs/node/pull/32414#event-3152113100
https://github.com/ronag
ronaghttps://github.com/ronag
mcollinahttps://github.com/mcollina
Mar 21, 2020https://github.com/nodejs/node/pull/32414#event-3152150683
https://github.com/ronag
ronaghttps://github.com/ronag
lpincahttps://github.com/lpinca
March 21, 2020 22:22https://github.com/nodejs/node/pull/32414#event-3152150730
https://github.com/lpinca
lpincahttps://github.com/lpinca
Mar 23, 2020 https://github.com/nodejs/node/pull/32414#pullrequestreview-379799778
View reviewed changes https://github.com/nodejs/node/pull/32414/files
lib/internal/streams/pipeline.jshttps://github.com/nodejs/node/pull/32414/files#diff-95c23fb6674af85f6f23a374851af6cccf58fb4617d73897df5078ba537a862c
Please reload this pagehttps://github.com/nodejs/node/pull/32414
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 24, 2020 https://github.com/nodejs/node/pull/32414#pullrequestreview-380086026
View reviewed changes https://github.com/nodejs/node/pull/32414/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/32414#pullrequestreview-380086026
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32414
https://github.com/lpinca
lpincahttps://github.com/lpinca
Mar 24, 2020 https://github.com/nodejs/node/pull/32414#pullrequestreview-380090402
View reviewed changes https://github.com/nodejs/node/pull/32414/files
https://github.com/ronag
ronaghttps://github.com/ronag
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 24, 2020https://github.com/nodejs/node/pull/32414#event-3158627737
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 24, 2020https://github.com/nodejs/node/pull/32414#issuecomment-603106760
https://ci.nodejs.org/job/node-test-pull-request/30012/https://ci.nodejs.org/job/node-test-pull-request/30012/
Please reload this pagehttps://github.com/nodejs/node/pull/32414
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 24, 2020 https://github.com/nodejs/node/pull/32414#pullrequestreview-380425461
View reviewed changes https://github.com/nodejs/node/pull/32414/files
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Mar 24, 2020 https://github.com/nodejs/node/pull/32414#pullrequestreview-380439451
View reviewed changes https://github.com/nodejs/node/pull/32414/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 24, 2020https://github.com/nodejs/node/pull/32414#issuecomment-603322572
https://ci.nodejs.org/job/node-test-pull-request/30019/https://ci.nodejs.org/job/node-test-pull-request/30019/
Please reload this pagehttps://github.com/nodejs/node/pull/32414
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 24, 2020https://github.com/nodejs/node/pull/32414#issuecomment-603344330
Please reload this pagehttps://github.com/nodejs/node/pull/32414
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 24, 2020https://github.com/nodejs/node/pull/32414#issuecomment-603353246
#31061https://github.com/nodejs/node/issues/31061
Please reload this pagehttps://github.com/nodejs/node/pull/32414
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 24, 2020https://github.com/nodejs/node/pull/32414#issuecomment-603367117
https://ci.nodejs.org/job/node-test-pull-request/30025/https://ci.nodejs.org/job/node-test-pull-request/30025/
Please reload this pagehttps://github.com/nodejs/node/pull/32414
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 24, 2020 https://github.com/nodejs/node/pull/32414#ref-issue-587156992
Check failed: result.second #32463 https://github.com/nodejs/node/issues/32463
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 24, 2020https://github.com/nodejs/node/pull/32414#issuecomment-603437003
https://ci.nodejs.org/job/node-test-pull-request/30029/https://ci.nodejs.org/job/node-test-pull-request/30029/
Please reload this pagehttps://github.com/nodejs/node/pull/32414
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 24, 2020https://github.com/nodejs/node/pull/32414#issuecomment-603479939
https://ci.nodejs.org/job/node-test-pull-request/30031/https://ci.nodejs.org/job/node-test-pull-request/30031/
Please reload this pagehttps://github.com/nodejs/node/pull/32414
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 25, 2020https://github.com/nodejs/node/pull/32414#issuecomment-603766174
https://ci.nodejs.org/job/node-test-pull-request/30044/https://ci.nodejs.org/job/node-test-pull-request/30044/
Please reload this pagehttps://github.com/nodejs/node/pull/32414
https://github.com/ronag
stream: fix pipeline with dest in objectModehttps://github.com/nodejs/node/pull/32414/commits/ee3aa343ad675d8ce39eb5a210f745d0331b11a2
ee3aa34https://github.com/nodejs/node/pull/32414/commits/ee3aa343ad675d8ce39eb5a210f745d0331b11a2
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/965e6e1979d30801ccec14f4a68aa0f735abfe43..ee3aa343ad675d8ce39eb5a210f745d0331b11a2
965e6e1https://github.com/nodejs/node/commit/965e6e1979d30801ccec14f4a68aa0f735abfe43
ee3aa34https://github.com/nodejs/node/commit/ee3aa343ad675d8ce39eb5a210f745d0331b11a2
Compare https://github.com/nodejs/node/compare/965e6e1979d30801ccec14f4a68aa0f735abfe43..ee3aa343ad675d8ce39eb5a210f745d0331b11a2
March 25, 2020 12:35https://github.com/nodejs/node/pull/32414#event-3163773252
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 25, 2020https://github.com/nodejs/node/pull/32414#issuecomment-603814888
https://ci.nodejs.org/job/node-test-pull-request/30047/https://ci.nodejs.org/job/node-test-pull-request/30047/
Please reload this pagehttps://github.com/nodejs/node/pull/32414
https://github.com/awibox
awiboxhttps://github.com/awibox
Mar 25, 2020 https://github.com/nodejs/node/pull/32414#pullrequestreview-381142137
View reviewed changes https://github.com/nodejs/node/pull/32414/files/ee3aa343ad675d8ce39eb5a210f745d0331b11a2
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 25, 2020https://github.com/nodejs/node/pull/32414#issuecomment-603848482
05f1df5https://github.com/nodejs/node/commit/05f1df520064475a255d8956f9e1b6f4bf4c8543
Please reload this pagehttps://github.com/nodejs/node/pull/32414
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 25, 2020https://github.com/nodejs/node/pull/32414#event-3164035957
ronaghttps://github.com/ronag
Mar 25, 2020 https://github.com/nodejs/node/pull/32414#ref-commit-05f1df5
https://github.com/ronag
stream: fix pipeline with dest in objectModehttps://github.com/nodejs/node/commit/05f1df520064475a255d8956f9e1b6f4bf4c8543
05f1df5https://github.com/nodejs/node/commit/05f1df520064475a255d8956f9e1b6f4bf4c8543
#32414https://github.com/nodejs/node/pull/32414
MylesBorinshttps://github.com/MylesBorins
Mar 25, 2020 https://github.com/nodejs/node/pull/32414#ref-commit-b7a8878
https://github.com/ronag
https://github.com/MylesBorins
stream: fix pipeline with dest in objectModehttps://github.com/nodejs/node/commit/b7a8878f0ca31b6968228b33c625cfb0656a809a
b7a8878https://github.com/nodejs/node/commit/b7a8878f0ca31b6968228b33c625cfb0656a809a
#32414https://github.com/nodejs/node/pull/32414
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 25, 2020 https://github.com/nodejs/node/pull/32414#ref-pullrequest-584728971
v13.12.0 proposal #32376 https://github.com/nodejs/node/pull/32376
https://github.com/targos
targoshttps://github.com/targos
backport-blocked-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v12.x
Apr 22, 2020https://github.com/nodejs/node/pull/32414#event-3261384776
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32414
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/32414/files/965e6e1979d30801ccec14f4a68aa0f735abfe43
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/32414/files/965e6e1979d30801ccec14f4a68aa0f735abfe43
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/32414/files/965e6e1979d30801ccec14f4a68aa0f735abfe43
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/32414/files/965e6e1979d30801ccec14f4a68aa0f735abfe43
https://github.com/awibox
awibox https://github.com/awibox
https://github.com/nodejs/node/pull/32414/files/ee3aa343ad675d8ce39eb5a210f745d0331b11a2
Please reload this pagehttps://github.com/nodejs/node/pull/32414
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/32414
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/richardlau
https://github.com/mcollina
https://github.com/jasnell
https://github.com/lpinca
https://github.com/awibox
https://github.com/trivikr
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.