René's URL Explorer Experiment


Title: src: delete CallbackInfo when cleared from cleanup hook by addaleax · Pull Request #32405 · nodejs/node · GitHub

Open Graph Title: src: delete CallbackInfo when cleared from cleanup hook by addaleax · Pull Request #32405 · nodejs/node

X Title: src: delete CallbackInfo when cleared from cleanup hook by addaleax · Pull Request #32405 · nodejs/node

Description: Fixes: #32400 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Open Graph Description: Fixes: #32400 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: Fixes: #32400 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/32405

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7fa6d6ae-10a1-7fa9-ff9e-3d1f687a9f3f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9886:3A4B81:662E3:84B74:696ACF0B
html-safe-nonce83e8497ffdb091ff02e34b388f5ff495515161e8885bbfd10520168edcf9035e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODg2OjNBNEI4MTo2NjJFMzo4NEI3NDo2OTZBQ0YwQiIsInZpc2l0b3JfaWQiOiI0NDY5NTg2Mzc0MzcyODA2NDEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0ea6183cc0024e261fe7bcff29addcc1a8a74a555bf5ce68c45fee5eaf6c9747
hovercard-subject-tagpull_request:391835438
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32405/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/52b648eba1402d859e1f513dd910a0c910e209b4041e355339c3fe556865c9eb/nodejs/node/pull/32405
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/52b648eba1402d859e1f513dd910a0c910e209b4041e355339c3fe556865c9eb/nodejs/node/pull/32405
og:image:altFixes: #32400 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Nonec785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec718a376fcf780eb22089171adb84a543f660bf7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/32405#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32405
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32405
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/32405
Reloadhttps://github.com/nodejs/node/pull/32405
Reloadhttps://github.com/nodejs/node/pull/32405
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/32405
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/32405
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/32405#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:buffer-callbackhttps://github.com/addaleax/node/tree/buffer-callback
src: delete CallbackInfo when cleared from cleanup hook https://github.com/nodejs/node/pull/32405#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:buffer-callbackhttps://github.com/addaleax/node/tree/buffer-callback
Conversation 4 https://github.com/nodejs/node/pull/32405
Commits 1 https://github.com/nodejs/node/pull/32405/commits
Checks 0 https://github.com/nodejs/node/pull/32405/checks
Files changed https://github.com/nodejs/node/pull/32405/files
Please reload this pagehttps://github.com/nodejs/node/pull/32405
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 21, 2020https://github.com/nodejs/node/pull/32405#issue-585461444
#32400https://github.com/nodejs/node/issues/32400
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/32405
https://github.com/addaleax
src: delete CallbackInfo when cleared from cleanup hookhttps://github.com/nodejs/node/pull/32405/commits/70b6263270e1b4487b5aed578057d8bb50659a4e
70b6263https://github.com/nodejs/node/pull/32405/commits/70b6263270e1b4487b5aed578057d8bb50659a4e
nodejs#32400https://github.com/nodejs/node/issues/32400
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Mar 21, 2020https://github.com/nodejs/node/pull/32405#event-3151580347
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 21, 2020 https://github.com/nodejs/node/pull/32405#ref-issue-585446435
Possible undefined behavior on buffer's CallbackInfo #32400 https://github.com/nodejs/node/issues/32400
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Mar 21, 2020 https://github.com/nodejs/node/pull/32405#pullrequestreview-378904726
View reviewed changes https://github.com/nodejs/node/pull/32405/files/70b6263270e1b4487b5aed578057d8bb50659a4e
mmarchinihttps://github.com/mmarchini
https://github.com/nodejs/node/pull/32405#pullrequestreview-378904726
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32405
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 21, 2020https://github.com/nodejs/node/pull/32405#issuecomment-602017980
@mmarchinihttps://github.com/mmarchini
Please reload this pagehttps://github.com/nodejs/node/pull/32405
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Mar 21, 2020 https://github.com/nodejs/node/pull/32405#pullrequestreview-378905211
View reviewed changes https://github.com/nodejs/node/pull/32405/files/70b6263270e1b4487b5aed578057d8bb50659a4e
https://github.com/targos
targoshttps://github.com/targos
Mar 21, 2020 https://github.com/nodejs/node/pull/32405#pullrequestreview-378910976
View reviewed changes https://github.com/nodejs/node/pull/32405/files/70b6263270e1b4487b5aed578057d8bb50659a4e
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 21, 2020 https://github.com/nodejs/node/pull/32405#ref-pullrequest-585471458
test: use InitializeNodeWithArgs in cctest #32406 https://github.com/nodejs/node/pull/32406
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 21, 2020 https://github.com/nodejs/node/pull/32405#pullrequestreview-378917761
View reviewed changes https://github.com/nodejs/node/pull/32405/files/70b6263270e1b4487b5aed578057d8bb50659a4e
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 21, 2020https://github.com/nodejs/node/pull/32405#event-3151983074
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 21, 2020https://github.com/nodejs/node/pull/32405#issuecomment-602085059
https://ci.nodejs.org/job/node-test-pull-request/29968/https://ci.nodejs.org/job/node-test-pull-request/29968/
Please reload this pagehttps://github.com/nodejs/node/pull/32405
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 22, 2020 https://github.com/nodejs/node/pull/32405#pullrequestreview-379043892
View reviewed changes https://github.com/nodejs/node/pull/32405/files/70b6263270e1b4487b5aed578057d8bb50659a4e
mmarchinihttps://github.com/mmarchini
Mar 23, 2020 https://github.com/nodejs/node/pull/32405#ref-commit-678e1be
https://github.com/addaleax
https://github.com/mmarchini
src: delete CallbackInfo when cleared from cleanup hookhttps://github.com/nodejs/node/commit/678e1be6aa145b99397342bb4a00440ba4bf4999
678e1behttps://github.com/nodejs/node/commit/678e1be6aa145b99397342bb4a00440ba4bf4999
#32400https://github.com/nodejs/node/issues/32400
#32405https://github.com/nodejs/node/pull/32405
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Mar 23, 2020https://github.com/nodejs/node/pull/32405#issuecomment-602764478
678e1behttps://github.com/nodejs/node/commit/678e1be6aa145b99397342bb4a00440ba4bf4999
Please reload this pagehttps://github.com/nodejs/node/pull/32405
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Mar 23, 2020https://github.com/nodejs/node/pull/32405#event-3156425419
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
March 23, 2020 18:11https://github.com/nodejs/node/pull/32405#event-3156458815
MylesBorinshttps://github.com/MylesBorins
Mar 24, 2020 https://github.com/nodejs/node/pull/32405#ref-commit-bd998bc
https://github.com/addaleax
https://github.com/MylesBorins
src: delete CallbackInfo when cleared from cleanup hookhttps://github.com/nodejs/node/commit/bd998bc654a5552815a9aff2671afb2dd4ec0eec
bd998bchttps://github.com/nodejs/node/commit/bd998bc654a5552815a9aff2671afb2dd4ec0eec
#32400https://github.com/nodejs/node/issues/32400
#32405https://github.com/nodejs/node/pull/32405
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 24, 2020 https://github.com/nodejs/node/pull/32405#ref-pullrequest-584728971
v13.12.0 proposal #32376 https://github.com/nodejs/node/pull/32376
MylesBorinshttps://github.com/MylesBorins
Mar 24, 2020 https://github.com/nodejs/node/pull/32405#ref-commit-2fe351f
https://github.com/addaleax
https://github.com/MylesBorins
src: delete CallbackInfo when cleared from cleanup hookhttps://github.com/nodejs/node/commit/2fe351f6c3fab6b64567fa8a79291f1f96893ae6
2fe351fhttps://github.com/nodejs/node/commit/2fe351f6c3fab6b64567fa8a79291f1f96893ae6
#32400https://github.com/nodejs/node/issues/32400
#32405https://github.com/nodejs/node/pull/32405
targoshttps://github.com/targos
Apr 22, 2020 https://github.com/nodejs/node/pull/32405#ref-commit-7aa2ee2
https://github.com/addaleax
https://github.com/targos
src: delete CallbackInfo when cleared from cleanup hookhttps://github.com/nodejs/node/commit/7aa2ee2bd8b8a5db9c298e1f6bd2783b86085c97
7aa2ee2https://github.com/nodejs/node/commit/7aa2ee2bd8b8a5db9c298e1f6bd2783b86085c97
#32400https://github.com/nodejs/node/issues/32400
#32405https://github.com/nodejs/node/pull/32405
https://github.com/targos
targoshttps://github.com/targos
Apr 22, 2020 https://github.com/nodejs/node/pull/32405#ref-pullrequest-604998404
v12.16.3 release proposal #33009 https://github.com/nodejs/node/pull/33009
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32405
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/32405/files/70b6263270e1b4487b5aed578057d8bb50659a4e
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/32405/files/70b6263270e1b4487b5aed578057d8bb50659a4e
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/32405/files/70b6263270e1b4487b5aed578057d8bb50659a4e
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/32405/files/70b6263270e1b4487b5aed578057d8bb50659a4e
https://github.com/mmarchini
mmarchini https://github.com/mmarchini
https://github.com/nodejs/node/pull/32405/files/70b6263270e1b4487b5aed578057d8bb50659a4e
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Possible undefined behavior on buffer's CallbackInfo https://github.com/nodejs/node/issues/32400
Please reload this pagehttps://github.com/nodejs/node/pull/32405
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/mmarchini
https://github.com/jasnell
https://github.com/targos
https://github.com/cjihrig
https://github.com/gengjiawen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.