| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1d016d55-555c-15ed-f6c4-3b46552da3c7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8F1C:6AD77:2F102F:3D9A91:6AED1D29 |
| html-safe-nonce | bad333b0f5f3b385b5440dcede582b7e8350ae4512cba7cba3257a92bd44017e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjFDOjZBRDc3OjJGMTAyRjozRDlBOTE6NkFFRDFEMjkiLCJ2aXNpdG9yX2lkIjoiNTM4MDI0MjYyODM2NzU1NzUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 297ddf58f637e2e473ce216ea33f0213a8a9a7e36be390a9a8c40a0a4b16ccf0 |
| hovercard-subject-tag | pull_request:391807887 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32398/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5ac2878945177e5fb448754bc2789fc63195a1d77c912f823a9e6c06a65d6ab7/nodejs/node/pull/32398 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5ac2878945177e5fb448754bc2789fc63195a1d77c912f823a9e6c06a65d6ab7/nodejs/node/pull/32398 |
| og:image:alt | Missed this one in #32381. Use Array instead of Map, use Promise.all() instead of countdown.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guid... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | e3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 707a24b346ac8a82878b9c084efaa38a997660cb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/32398#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32398 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32398 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/32398 |
| Reload | https://github.com/nodejs/node/pull/32398 |
| Reload | https://github.com/nodejs/node/pull/32398 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues655 (655) | https://github.com/nodejs/node/issues |
| Pull requests666 (666) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/pulse |
| https://github.com/nodejs/node |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:par-cluster | https://github.com/Trott/io.js/tree/par-cluster |
| Conversation | https://github.com/nodejs/node/pull/32398 |
| Commits2 (2) | https://github.com/nodejs/node/pull/32398/commits |
| Checks | https://github.com/nodejs/node/pull/32398/checks |
| Files changed | https://github.com/nodejs/node/pull/32398/files |
| test: improve test-cluster-net-listen-ipv6only-false | https://github.com/nodejs/node/pull/32398#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:par-cluster | https://github.com/Trott/io.js/tree/par-cluster |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 21, 2020 | https://github.com/nodejs/node/pull/32398#issue-585418632 |
| #32381 | https://github.com/nodejs/node/pull/32381 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/32398 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/b42a5cd432c8a82c29c21afa8804fef99b3a21d9..97433268b5ebd930fa2c7b5839fa1026704737e8 |
| b42a5cd | https://github.com/nodejs/node/commit/b42a5cd432c8a82c29c21afa8804fef99b3a21d9 |
| 9743326 | https://github.com/nodejs/node/commit/97433268b5ebd930fa2c7b5839fa1026704737e8 |
|
Compare
| https://github.com/nodejs/node/compare/b42a5cd432c8a82c29c21afa8804fef99b3a21d9..97433268b5ebd930fa2c7b5839fa1026704737e8 |
| March 21, 2020 03:16 | https://github.com/nodejs/node/pull/32398#event-3151398601 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Mar 21, 2020 | https://github.com/nodejs/node/pull/32398#event-3151398610 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 21, 2020 | https://github.com/nodejs/node/pull/32398#issuecomment-601985462 |
| Please reload this page | https://github.com/nodejs/node/pull/32398 |
| https://ci.nodejs.org/job/node-test-pull-request/29963/ | https://ci.nodejs.org/job/node-test-pull-request/29963/ |
| Please reload this page | https://github.com/nodejs/node/pull/32398 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Mar 21, 2020
| https://github.com/nodejs/node/pull/32398#pullrequestreview-378953040 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32398/files |
| test/parallel/test-cluster-net-listen-ipv6only-false.js | https://github.com/nodejs/node/pull/32398/files#diff-fc7dbffa085e74a74890759d42773495b7223f98bce8450961506ebb55fc490f |
| Please reload this page | https://github.com/nodejs/node/pull/32398 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Mar 23, 2020 | https://github.com/nodejs/node/pull/32398#event-3153349139 |
| Trott | https://github.com/Trott |
| March 27, 2020 23:16 | https://github.com/nodejs/node/pull/32398#commits-pushed-a1686e0 |
|
| https://github.com/Trott |
| test: replace Map with Array in test-cluster-net-listen-ipv6only-false | https://github.com/nodejs/node/pull/32398/commits/a1686e00ab726f70d83241fbea53d577b94ee3a7 |
| a1686e0 | https://github.com/nodejs/node/pull/32398/commits/a1686e00ab726f70d83241fbea53d577b94ee3a7 |
| nodejs#32398 | https://github.com/nodejs/node/pull/32398 |
|
| https://github.com/Trott |
| test: use Promise.all() in test-cluster-net-listen-ipv6only-false | https://github.com/nodejs/node/pull/32398/commits/2565442ac0215cbea398d7f0dc1faa49e9632a93 |
| 2565442 | https://github.com/nodejs/node/pull/32398/commits/2565442ac0215cbea398d7f0dc1faa49e9632a93 |
| nodejs#32398 | https://github.com/nodejs/node/pull/32398 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/97433268b5ebd930fa2c7b5839fa1026704737e8..2565442ac0215cbea398d7f0dc1faa49e9632a93 |
| 9743326 | https://github.com/nodejs/node/commit/97433268b5ebd930fa2c7b5839fa1026704737e8 |
| 2565442 | https://github.com/nodejs/node/commit/2565442ac0215cbea398d7f0dc1faa49e9632a93 |
|
Compare
| https://github.com/nodejs/node/compare/97433268b5ebd930fa2c7b5839fa1026704737e8..2565442ac0215cbea398d7f0dc1faa49e9632a93 |
| March 28, 2020 06:17 | https://github.com/nodejs/node/pull/32398#event-3174683576 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 28, 2020 | https://github.com/nodejs/node/pull/32398#issuecomment-605402921 |
| fa3fd78...2565442 | https://github.com/nodejs/node/compare/fa3fd78c8855379f4d785a5a40176e7cf604f857...2565442ac0215cbea398d7f0dc1faa49e9632a93 |
| Please reload this page | https://github.com/nodejs/node/pull/32398 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| 2565442 | https://github.com/nodejs/node/commit/2565442ac0215cbea398d7f0dc1faa49e9632a93 |
| Mar 28, 2020 | https://github.com/nodejs/node/pull/32398#event-3174683854 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| March 28, 2020 06:18 | https://github.com/nodejs/node/pull/32398#event-3174683904 |
| addaleax | https://github.com/addaleax |
|
Mar 30, 2020
| https://github.com/nodejs/node/pull/32398#ref-commit-11d7cf1 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: replace Map with Array in test-cluster-net-listen-ipv6only-false | https://github.com/nodejs/node/commit/11d7cf155a816e8c29c1ee9be72d7413dbe890a1 |
| 11d7cf1 | https://github.com/nodejs/node/commit/11d7cf155a816e8c29c1ee9be72d7413dbe890a1 |
| #32398 | https://github.com/nodejs/node/pull/32398 |
| addaleax | https://github.com/addaleax |
|
Mar 30, 2020
| https://github.com/nodejs/node/pull/32398#ref-commit-b1e6f29 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: use Promise.all() in test-cluster-net-listen-ipv6only-false | https://github.com/nodejs/node/commit/b1e6f297cf27ea1188ffc10624cd96b851c0ab40 |
| b1e6f29 | https://github.com/nodejs/node/commit/b1e6f297cf27ea1188ffc10624cd96b851c0ab40 |
| #32398 | https://github.com/nodejs/node/pull/32398 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Apr 13, 2020
| https://github.com/nodejs/node/pull/32398#ref-pullrequest-598870123 |
|
v13.13.0 release proposal
#32813
| https://github.com/nodejs/node/pull/32813 |
| targos | https://github.com/targos |
|
Apr 22, 2020
| https://github.com/nodejs/node/pull/32398#ref-commit-60db56d |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: replace Map with Array in test-cluster-net-listen-ipv6only-false | https://github.com/nodejs/node/commit/60db56ddba3a9c16c72470a94b59365dceb4ab03 |
| 60db56d | https://github.com/nodejs/node/commit/60db56ddba3a9c16c72470a94b59365dceb4ab03 |
| #32398 | https://github.com/nodejs/node/pull/32398 |
| targos | https://github.com/targos |
|
Apr 22, 2020
| https://github.com/nodejs/node/pull/32398#ref-commit-5cae1b7 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: use Promise.all() in test-cluster-net-listen-ipv6only-false | https://github.com/nodejs/node/commit/5cae1b7a537ae7765b4297b2f57579519ee86891 |
| 5cae1b7 | https://github.com/nodejs/node/commit/5cae1b7a537ae7765b4297b2f57579519ee86891 |
| #32398 | https://github.com/nodejs/node/pull/32398 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Apr 22, 2020
| https://github.com/nodejs/node/pull/32398#ref-pullrequest-604998404 |
|
v12.16.3 release proposal
#33009
| https://github.com/nodejs/node/pull/33009 |
|
test-net-listen-ipv6only is flaky due to IPv4 port collision
#64172
| https://github.com/nodejs/node/issues/64172 |
|
test: deflake test-net-listen-ipv6only
#64173
| https://github.com/nodejs/node/pull/64173 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32398 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/32398/files/97433268b5ebd930fa2c7b5839fa1026704737e8 |
| Please reload this page | https://github.com/nodejs/node/pull/32398 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/32398 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |