| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0631b097-11c9-eb96-f81b-b44de338da7f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DB24:3B8B53:A0282D:EAF0C1:6A4E1BF7 |
| html-safe-nonce | 3ebf5ad67bd8b91a06288545d28d4881240c72f2883887559cf51ccb10aed9ab |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjI0OjNCOEI1MzpBMDI4MkQ6RUFGMEMxOjZBNEUxQkY3IiwidmlzaXRvcl9pZCI6IjM4MjA1MTU1ODM1ODI5MzYwNTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 02da06217f9ea90fa08b8dfc1c42ec0d113fbefc638d0033efde7b841e98f359 |
| hovercard-subject-tag | pull_request:390109409 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32334/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/230bbe4104a73685645c950f0cba569d95094086be0f4a3aa43236f64270388c/nodejs/node/pull/32334 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/230bbe4104a73685645c950f0cba569d95094086be0f4a3aa43236f64270388c/nodejs/node/pull/32334 |
| og:image:alt | "Allowed to fail" tests are easy to miss. With the failure on Travis,
new contributors can learn our commit guidelines. Collaborators are
still allowed (per our current policy) to land PR... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mmarchini |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5fe497b4815fcce3df76c0e246faa739a82c3124 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/32334#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32334 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32334 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/32334 |
| Reload | https://github.com/nodejs/node/pull/32334 |
| Reload | https://github.com/nodejs/node/pull/32334 |
| Please reload this page | https://github.com/nodejs/node/pull/32334 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/32334 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
964
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| mmarchini | https://github.com/mmarchini |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mmarchini:travis-check-commit-message | https://github.com/mmarchini/node/tree/travis-check-commit-message |
| Conversation | https://github.com/nodejs/node/pull/32334 |
| Commits1 (1) | https://github.com/nodejs/node/pull/32334/commits |
| Checks | https://github.com/nodejs/node/pull/32334/checks |
| Files changed | https://github.com/nodejs/node/pull/32334/files |
| build: fail Travis if commit message check fails | https://github.com/nodejs/node/pull/32334#top |
| mmarchini | https://github.com/mmarchini |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mmarchini:travis-check-commit-message | https://github.com/mmarchini/node/tree/travis-check-commit-message |
|
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Mar 17, 2020 | https://github.com/nodejs/node/pull/32334#issue-583336261 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/32334 |
|
| https://github.com/mmarchini |
| build: fail Travis if commit message check fails | https://github.com/nodejs/node/pull/32334/commits/c44dda988acccfd0450e13b94b9af836700aa65a |
| c44dda9 | https://github.com/nodejs/node/pull/32334/commits/c44dda988acccfd0450e13b94b9af836700aa65a |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Mar 17, 2020 | https://github.com/nodejs/node/pull/32334#event-3139281040 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Mar 18, 2020
| https://github.com/nodejs/node/pull/32334#pullrequestreview-376495782 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/32334/files/c44dda988acccfd0450e13b94b9af836700aa65a |
| https://github.com/richardlau |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32334 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Mar 18, 2020 | https://github.com/nodejs/node/pull/32334#issuecomment-600385801 |
| nodejs/build#2201 | https://github.com/nodejs/build/issues/2201 |
| #31116 | https://github.com/nodejs/node/pull/31116 |
| #32336 | https://github.com/nodejs/node/pull/32336 |
| Please reload this page | https://github.com/nodejs/node/pull/32334 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Mar 18, 2020 | https://github.com/nodejs/node/pull/32334#issuecomment-600385968 |
| Please reload this page | https://github.com/nodejs/node/pull/32334 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Mar 18, 2020 | https://github.com/nodejs/node/pull/32334#issuecomment-600712283 |
| @mmarchini | https://github.com/mmarchini |
| Please reload this page | https://github.com/nodejs/node/pull/32334 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Mar 18, 2020 | https://github.com/nodejs/node/pull/32334#issuecomment-600736191 |
| Please reload this page | https://github.com/nodejs/node/pull/32334 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Mar 18, 2020 | https://github.com/nodejs/node/pull/32334#issuecomment-600757435 |
| https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/32334 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Mar 18, 2020 | https://github.com/nodejs/node/pull/32334#issuecomment-600771515 |
| pull-requests.md#step-5-rebase | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#step-5-rebase |
| Please reload this page | https://github.com/nodejs/node/pull/32334 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Mar 18, 2020 | https://github.com/nodejs/node/pull/32334#issuecomment-600779469 |
| Please reload this page | https://github.com/nodejs/node/pull/32334 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Mar 18, 2020 | https://github.com/nodejs/node/pull/32334#issuecomment-600782337 |
| https://github.com/nodejs/github-bot/blob/master/lib/node-labels.js | https://github.com/nodejs/github-bot/blob/master/lib/node-labels.js |
| Please reload this page | https://github.com/nodejs/node/pull/32334 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Mar 22, 2020 | https://github.com/nodejs/node/pull/32334#issuecomment-602144149 |
| #32417 | https://github.com/nodejs/node/pull/32417 |
| Please reload this page | https://github.com/nodejs/node/pull/32334 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Mar 22, 2020 | https://github.com/nodejs/node/pull/32334#event-3152330901 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32334 |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/32334/files/c44dda988acccfd0450e13b94b9af836700aa65a |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Please reload this page | https://github.com/nodejs/node/pull/32334 |
|
| https://github.com/mmarchini |
|
| https://github.com/richardlau |
|
| https://github.com/targos |
|
| https://github.com/sam-github |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |