René's URL Explorer Experiment


Title: src: clean up stream_base.h and stream-base-inl.h by jasnell · Pull Request #32307 · nodejs/node · GitHub

Open Graph Title: src: clean up stream_base.h and stream-base-inl.h by jasnell · Pull Request #32307 · nodejs/node

X Title: src: clean up stream_base.h and stream-base-inl.h by jasnell · Pull Request #32307 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: stream_base.h and stream_base-inl.h have always been a bit of a mess with regards to inlines, v8:: scopes, and more. This is the first step at a cleanup. Checklist make -j4 test (UNIX), or vcbuil...

X Description: stream_base.h and stream_base-inl.h have always been a bit of a mess with regards to inlines, v8:: scopes, and more. This is the first step at a cleanup. Checklist make -j4 test (UNIX), or vcbuil...

Opengraph URL: https://github.com/nodejs/node/pull/32307

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f476ca74-3b2d-6cc8-724f-dad252a300c1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB664:3B3F35:32C2C3:425A1A:6AED1E1C
html-safe-nonce846467a124c7f6434bfa581f12bc8270aa0547469742dbaf8c946ea38973b3b3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjY0OjNCM0YzNTozMkMyQzM6NDI1QTFBOjZBRUQxRTFDIiwidmlzaXRvcl9pZCI6IjI1OTg0MTk5NjcwNzczMjYzNjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd1ca304cd02f52cc040a218776625f74ca7545172d246ccbd30dcd47c884065d
hovercard-subject-tagpull_request:389498308
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32307/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/da598702657a25a027c0fda4f46c225d7744b7909254aa575edc8b5b426025d1/nodejs/node/pull/32307
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/da598702657a25a027c0fda4f46c225d7744b7909254aa575edc8b5b426025d1/nodejs/node/pull/32307
og:image:altstream_base.h and stream_base-inl.h have always been a bit of a mess with regards to inlines, v8:: scopes, and more. This is the first step at a cleanup. Checklist make -j4 test (UNIX), or vcbuil...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/32307#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32307
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32307
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/32307
Reloadhttps://github.com/nodejs/node/pull/32307
Reloadhttps://github.com/nodejs/node/pull/32307
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:cleanup-streambasehttps://github.com/jasnell/node/tree/cleanup-streambase
Conversationhttps://github.com/nodejs/node/pull/32307
Commits1 (1)https://github.com/nodejs/node/pull/32307/commits
Checkshttps://github.com/nodejs/node/pull/32307/checks
Files changedhttps://github.com/nodejs/node/pull/32307/files
src: clean up stream_base.h and stream-base-inl.hhttps://github.com/nodejs/node/pull/32307#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:cleanup-streambasehttps://github.com/jasnell/node/tree/cleanup-streambase
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 16, 2020https://github.com/nodejs/node/pull/32307#issue-582602998
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/32307
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Mar 16, 2020https://github.com/nodejs/node/pull/32307#event-3134987691
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/0f6ef691cdb22d00f39280330a5c0659b5fa0e52..ac42fe616c1126f58253cdf6a74501f2902bbd10
0f6ef69https://github.com/nodejs/node/commit/0f6ef691cdb22d00f39280330a5c0659b5fa0e52
ac42fe6https://github.com/nodejs/node/commit/ac42fe616c1126f58253cdf6a74501f2902bbd10
Compare https://github.com/nodejs/node/compare/0f6ef691cdb22d00f39280330a5c0659b5fa0e52..ac42fe616c1126f58253cdf6a74501f2902bbd10
March 16, 2020 21:15https://github.com/nodejs/node/pull/32307#event-3134989592
https://github.com/jasnell
jasnellhttps://github.com/jasnell
addaleaxhttps://github.com/addaleax
tniessenhttps://github.com/tniessen
March 16, 2020 21:15https://github.com/nodejs/node/pull/32307#event-3134989944
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 16, 2020https://github.com/nodejs/node/pull/32307#issuecomment-599762401
https://ci.nodejs.org/job/node-test-pull-request/29875/https://ci.nodejs.org/job/node-test-pull-request/29875/
Please reload this pagehttps://github.com/nodejs/node/pull/32307
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 16, 2020 https://github.com/nodejs/node/pull/32307#pullrequestreview-375592123
View reviewed changes https://github.com/nodejs/node/pull/32307/files
https://github.com/jasnell
src: clean up stream_base.h and stream-base-inl.hhttps://github.com/nodejs/node/pull/32307/commits/098cbcf769f4020940fa4b606f43b7573087043e
098cbcfhttps://github.com/nodejs/node/pull/32307/commits/098cbcf769f4020940fa4b606f43b7573087043e
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/ff51b5566d293c75abb6d4ef7f99e2fb05bd859b..098cbcf769f4020940fa4b606f43b7573087043e
ff51b55https://github.com/nodejs/node/commit/ff51b5566d293c75abb6d4ef7f99e2fb05bd859b
098cbcfhttps://github.com/nodejs/node/commit/098cbcf769f4020940fa4b606f43b7573087043e
Compare https://github.com/nodejs/node/compare/ff51b5566d293c75abb6d4ef7f99e2fb05bd859b..098cbcf769f4020940fa4b606f43b7573087043e
March 16, 2020 21:39https://github.com/nodejs/node/pull/32307#event-3135053363
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 16, 2020https://github.com/nodejs/node/pull/32307#issuecomment-599782564
https://ci.nodejs.org/job/node-test-pull-request/29876/https://ci.nodejs.org/job/node-test-pull-request/29876/
Please reload this pagehttps://github.com/nodejs/node/pull/32307
https://github.com/jasnell
jasnellhttps://github.com/jasnell
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 17, 2020https://github.com/nodejs/node/pull/32307#event-3139045704
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 19, 2020https://github.com/nodejs/node/pull/32307#issuecomment-601141433
Please reload this pagehttps://github.com/nodejs/node/pull/32307
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Mar 19, 2020 https://github.com/nodejs/node/pull/32307#pullrequestreview-377664242
View reviewed changes https://github.com/nodejs/node/pull/32307/files/098cbcf769f4020940fa4b606f43b7573087043e
src/stream_wrap.cchttps://github.com/nodejs/node/pull/32307/files/098cbcf769f4020940fa4b606f43b7573087043e#diff-b1af53e84de922979cfdda57cca9fe06a3741f616981733417d3fc62e249e83f
gengjiawenhttps://github.com/gengjiawen
Mar 19, 2020https://github.com/nodejs/node/pull/32307#discussion_r394983053
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32307
jasnellhttps://github.com/jasnell
Mar 19, 2020https://github.com/nodejs/node/pull/32307#discussion_r394984973
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32307
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Mar 19, 2020 https://github.com/nodejs/node/pull/32307#pullrequestreview-377664683
View reviewed changes https://github.com/nodejs/node/pull/32307/files/098cbcf769f4020940fa4b606f43b7573087043e
gengjiawenhttps://github.com/gengjiawen
https://github.com/nodejs/node/pull/32307#pullrequestreview-377664683
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32307
jasnellhttps://github.com/jasnell
Mar 19, 2020 https://github.com/nodejs/node/pull/32307#ref-commit-ffdf1de
https://github.com/jasnell
src: clean up stream_base.h and stream-base-inl.hhttps://github.com/nodejs/node/commit/ffdf1dec85a61a4a913f83c3970298aac7e05f93
ffdf1dehttps://github.com/nodejs/node/commit/ffdf1dec85a61a4a913f83c3970298aac7e05f93
#32307https://github.com/nodejs/node/pull/32307
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 19, 2020https://github.com/nodejs/node/pull/32307#issuecomment-601151666
ffdf1dehttps://github.com/nodejs/node/commit/ffdf1dec85a61a4a913f83c3970298aac7e05f93
Please reload this pagehttps://github.com/nodejs/node/pull/32307
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 19, 2020https://github.com/nodejs/node/pull/32307#event-3145336675
MylesBorinshttps://github.com/MylesBorins
Mar 19, 2020 https://github.com/nodejs/node/pull/32307#ref-commit-39dae8e
https://github.com/jasnell
https://github.com/MylesBorins
src: clean up stream_base.h and stream-base-inl.hhttps://github.com/nodejs/node/commit/39dae8e54f6bde2cea735d6b40c6371e13757324
39dae8ehttps://github.com/nodejs/node/commit/39dae8e54f6bde2cea735d6b40c6371e13757324
#32307https://github.com/nodejs/node/pull/32307
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 19, 2020 https://github.com/nodejs/node/pull/32307#ref-pullrequest-584728971
v13.12.0 proposal #32376 https://github.com/nodejs/node/pull/32376
MylesBorinshttps://github.com/MylesBorins
Mar 24, 2020 https://github.com/nodejs/node/pull/32307#ref-commit-1c4a112
https://github.com/jasnell
https://github.com/MylesBorins
src: clean up stream_base.h and stream-base-inl.hhttps://github.com/nodejs/node/commit/1c4a112fccb7feb12473ee9f8680eaf143c97e82
1c4a112https://github.com/nodejs/node/commit/1c4a112fccb7feb12473ee9f8680eaf143c97e82
#32307https://github.com/nodejs/node/pull/32307
https://github.com/targos
targoshttps://github.com/targos
backport-blocked-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v12.x
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
backport-blocked-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v12.x
Apr 22, 2020https://github.com/nodejs/node/pull/32307#event-3261331232
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 7, 2020 https://github.com/nodejs/node/pull/32307#ref-pullrequest-607817142
src: use BaseObjectPtr in StreamReq::Dispose #33102 https://github.com/nodejs/node/pull/33102
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jun 8, 2020 https://github.com/nodejs/node/pull/32307#ref-pullrequest-608802418
src: retrieve binding data from the context #33139 https://github.com/nodejs/node/pull/33139
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
dont-land-on-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v12.x
backport-requested-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v12.x
Sep 23, 2020https://github.com/nodejs/node/pull/32307#event-3799620282
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32307
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/32307/files/ac42fe616c1126f58253cdf6a74501f2902bbd10
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/32307/files/098cbcf769f4020940fa4b606f43b7573087043e
https://github.com/tniessen
tniessen https://github.com/tniessen
Please reload this pagehttps://github.com/nodejs/node/pull/32307
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/32307
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/gengjiawen
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.