René's URL Explorer Experiment


Title: [v12.x] backport BaseObjectPtr, SetImmediate(), Worker+report by addaleax · Pull Request #32301 · nodejs/node · GitHub

Open Graph Title: [v12.x] backport BaseObjectPtr, SetImmediate(), Worker+report by addaleax · Pull Request #32301 · nodejs/node

X Title: [v12.x] backport BaseObjectPtr, SetImmediate(), Worker+report by addaleax · Pull Request #32301 · nodejs/node

Description: Fun group backport of the following PRs because they all depend on each other: src: delete BaseObjectWeakPtr data when pointee is gone #32393 worker: move JoinThread() back into exit callback #314...

Open Graph Description: Fun group backport of the following PRs because they all depend on each other: src: delete BaseObjectWeakPtr data when pointee is gone #32393 worker: move JoinThread() back into exit callback #314...

X Description: Fun group backport of the following PRs because they all depend on each other: src: delete BaseObjectWeakPtr data when pointee is gone #32393 worker: move JoinThread() back into exit callback #314...

Opengraph URL: https://github.com/nodejs/node/pull/32301

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b2ef177b-0809-54ce-e51e-9de6ee34fbc8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC9E2:28AA86:32CF7B:41D4E3:696B3CFA
html-safe-noncee5c4fe322fca547d6cb74b30d220915080674bfe7a2896f2dd8f064b82653f8b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUUyOjI4QUE4NjozMkNGN0I6NDFENEUzOjY5NkIzQ0ZBIiwidmlzaXRvcl9pZCI6IjY3NzY5MTY3MjIxNzExOTg3MTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4c204491070694bb28ab70350030ddaacd3a5357d52fa110dec0f5025f831c09
hovercard-subject-tagpull_request:389227169
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32301/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6074b2040c85bad33cdf15fdb3ddec876b366b00d252dd99a1abbab4d3a1bb36/nodejs/node/pull/32301
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6074b2040c85bad33cdf15fdb3ddec876b366b00d252dd99a1abbab4d3a1bb36/nodejs/node/pull/32301
og:image:altFun group backport of the following PRs because they all depend on each other: src: delete BaseObjectWeakPtr data when pointee is gone #32393 worker: move JoinThread() back into exit callback #314...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/32301#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32301
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32301
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/32301
Reloadhttps://github.com/nodejs/node/pull/32301
Reloadhttps://github.com/nodejs/node/pull/32301
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/32301
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/32301
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/32301#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:v12.x-staginghttps://github.com/nodejs/node/tree/v12.x-staging
addaleax:backport-report-worker-v12.xhttps://github.com/addaleax/node/tree/backport-report-worker-v12.x
[v12.x] backport BaseObjectPtr, SetImmediate(), Worker+report https://github.com/nodejs/node/pull/32301#top
addaleaxhttps://github.com/addaleax
nodejs:v12.x-staginghttps://github.com/nodejs/node/tree/v12.x-staging
addaleax:backport-report-worker-v12.xhttps://github.com/addaleax/node/tree/backport-report-worker-v12.x
Conversation 13 https://github.com/nodejs/node/pull/32301
Commits 20 https://github.com/nodejs/node/pull/32301/commits
Checks 0 https://github.com/nodejs/node/pull/32301/checks
Files changed https://github.com/nodejs/node/pull/32301/files
Please reload this pagehttps://github.com/nodejs/node/pull/32301
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 16, 2020https://github.com/nodejs/node/pull/32301#issue-582285288
Please reload this pagehttps://github.com/nodejs/node/pull/32301
src: delete BaseObjectWeakPtr data when pointee is gone #32393https://github.com/nodejs/node/pull/32393
worker: move JoinThread() back into exit callback #31468https://github.com/nodejs/node/pull/31468
src,http2: simplify native immediate queue running and harden http2 test #31502https://github.com/nodejs/node/pull/31502
report: add support for Workers #31386https://github.com/nodejs/node/pull/31386
src: run native immediates during Environment cleanup #30666https://github.com/nodejs/node/pull/30666
src: introduce custom smart pointers for BaseObjects #30374https://github.com/nodejs/node/pull/30374
Please reload this pagehttps://github.com/nodejs/node/pull/32301
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av12.x
Mar 16, 2020https://github.com/nodejs/node/pull/32301#event-3133126088
https://github.com/codebytere
codebyterehttps://github.com/codebytere
force-pushedhttps://github.com/nodejs/node/compare/2047ccabac092404d8e74ffc947c7b0c52228c37..0606e1d2f14214ae5d383a212af14ad9d45add1a
2047ccahttps://github.com/nodejs/node/commit/2047ccabac092404d8e74ffc947c7b0c52228c37
0606e1dhttps://github.com/nodejs/node/commit/0606e1d2f14214ae5d383a212af14ad9d45add1a
Compare https://github.com/nodejs/node/compare/2047ccabac092404d8e74ffc947c7b0c52228c37..0606e1d2f14214ae5d383a212af14ad9d45add1a
March 17, 2020 02:49https://github.com/nodejs/node/pull/32301#event-3135619385
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 17, 2020https://github.com/nodejs/node/pull/32301#issuecomment-599956388
@codebyterehttps://github.com/codebytere
Please reload this pagehttps://github.com/nodejs/node/pull/32301
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/633a4121ba069ea400be5fa383cdf1498cf4a26f..30bb555c92460a7784681721d16823648d1854ef
633a412https://github.com/nodejs/node/commit/633a4121ba069ea400be5fa383cdf1498cf4a26f
30bb555https://github.com/nodejs/node/commit/30bb555c92460a7784681721d16823648d1854ef
Compare https://github.com/nodejs/node/compare/633a4121ba069ea400be5fa383cdf1498cf4a26f..30bb555c92460a7784681721d16823648d1854ef
March 17, 2020 09:02https://github.com/nodejs/node/pull/32301#event-3136414331
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 17, 2020https://github.com/nodejs/node/pull/32301#issuecomment-599956681
https://ci.nodejs.org/job/node-test-pull-request/29881/https://ci.nodejs.org/job/node-test-pull-request/29881/
Please reload this pagehttps://github.com/nodejs/node/pull/32301
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 20, 2020https://github.com/nodejs/node/pull/32301#issuecomment-601695719
https://ci.nodejs.org/job/node-test-pull-request/29948/https://ci.nodejs.org/job/node-test-pull-request/29948/
Please reload this pagehttps://github.com/nodejs/node/pull/32301
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 20, 2020https://github.com/nodejs/node/pull/32301#issuecomment-601864337
#32393https://github.com/nodejs/node/pull/32393
Please reload this pagehttps://github.com/nodejs/node/pull/32301
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Mar 20, 2020https://github.com/nodejs/node/pull/32301#event-3150566300
https://github.com/codebytere
codebyterehttps://github.com/codebytere
force-pushedhttps://github.com/nodejs/node/compare/a01fb4ac619df82f9d90fc0ec29f7cf89170f6a3..e5dc2fbd2085154b3de01641618a5c76a73fefd8
a01fb4ahttps://github.com/nodejs/node/commit/a01fb4ac619df82f9d90fc0ec29f7cf89170f6a3
e5dc2fbhttps://github.com/nodejs/node/commit/e5dc2fbd2085154b3de01641618a5c76a73fefd8
Compare https://github.com/nodejs/node/compare/a01fb4ac619df82f9d90fc0ec29f7cf89170f6a3..e5dc2fbd2085154b3de01641618a5c76a73fefd8
March 23, 2020 16:01https://github.com/nodejs/node/pull/32301#event-3155907762
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/3207231de7b254ccfdcb817af4d597fe945b5553..fb981110a1f6e7af1c1c2e84b5fe09c286d1b7a9
3207231https://github.com/nodejs/node/commit/3207231de7b254ccfdcb817af4d597fe945b5553
fb98111https://github.com/nodejs/node/commit/fb981110a1f6e7af1c1c2e84b5fe09c286d1b7a9
Compare https://github.com/nodejs/node/compare/3207231de7b254ccfdcb817af4d597fe945b5553..fb981110a1f6e7af1c1c2e84b5fe09c286d1b7a9
March 23, 2020 19:24https://github.com/nodejs/node/pull/32301#event-3156756739
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Mar 23, 2020https://github.com/nodejs/node/pull/32301#event-3156756841
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 23, 2020https://github.com/nodejs/node/pull/32301#issuecomment-602807624
https://ci.nodejs.org/job/node-test-pull-request/29996/https://ci.nodejs.org/job/node-test-pull-request/29996/
Please reload this pagehttps://github.com/nodejs/node/pull/32301
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 27, 2020https://github.com/nodejs/node/pull/32301#issuecomment-605051771
https://ci.nodejs.org/job/node-test-pull-request/30126/https://ci.nodejs.org/job/node-test-pull-request/30126/
Please reload this pagehttps://github.com/nodejs/node/pull/32301
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 28, 2020https://github.com/nodejs/node/pull/32301#issuecomment-605448105
https://ci.nodejs.org/job/node-test-pull-request/30152/https://ci.nodejs.org/job/node-test-pull-request/30152/
Please reload this pagehttps://github.com/nodejs/node/pull/32301
https://github.com/codebytere
codebyterehttps://github.com/codebytere
force-pushedhttps://github.com/nodejs/node/compare/63a03d27690f1ddd793c968bcf7fac6394158768..d57719098cf61a3237db020305d44bdaa5a53d56
63a03d2https://github.com/nodejs/node/commit/63a03d27690f1ddd793c968bcf7fac6394158768
d577190https://github.com/nodejs/node/commit/d57719098cf61a3237db020305d44bdaa5a53d56
Compare https://github.com/nodejs/node/compare/63a03d27690f1ddd793c968bcf7fac6394158768..d57719098cf61a3237db020305d44bdaa5a53d56
March 31, 2020 23:57https://github.com/nodejs/node/pull/32301#event-3185614379
addaleaxhttps://github.com/addaleax
April 1, 2020 02:33https://github.com/nodejs/node/pull/32301#commits-pushed-afa5499
https://github.com/addaleax
https://github.com/MylesBorins
src: introduce custom smart pointers for BaseObjectshttps://github.com/nodejs/node/pull/32301/commits/afa5499cd6af286179792821bab9ff841ecf2bb5
afa5499https://github.com/nodejs/node/pull/32301/commits/afa5499cd6af286179792821bab9ff841ecf2bb5
nodejs/quic#141https://github.com/nodejs/quic/pull/141
nodejs/quic#149https://github.com/nodejs/quic/pull/149
nodejs#30374https://github.com/nodejs/node/pull/30374
nodejs/quic#165https://github.com/nodejs/quic/pull/165
https://github.com/addaleax
https://github.com/MylesBorins
http2: use custom BaseObject smart pointershttps://github.com/nodejs/node/pull/32301/commits/e1b12679a115fd7bbdd46b028e3b5f17601cc9df
e1b1267https://github.com/nodejs/node/pull/32301/commits/e1b12679a115fd7bbdd46b028e3b5f17601cc9df
nodejs/quic#141https://github.com/nodejs/quic/pull/141
nodejs#30374https://github.com/nodejs/node/pull/30374
nodejs/quic#149https://github.com/nodejs/quic/pull/149
nodejs/quic#165https://github.com/nodejs/quic/pull/165
https://github.com/addaleax
https://github.com/MylesBorins
src: use BaseObjectPtr for keeping channel alive in dns bindingshttps://github.com/nodejs/node/pull/32301/commits/95bf45107832b9d447d8cbff92c71d3e79ddc3f9
95bf451https://github.com/nodejs/node/pull/32301/commits/95bf45107832b9d447d8cbff92c71d3e79ddc3f9
nodejs#30374https://github.com/nodejs/node/pull/30374
nodejs/quic#141https://github.com/nodejs/quic/pull/141
nodejs/quic#149https://github.com/nodejs/quic/pull/149
nodejs/quic#141https://github.com/nodejs/quic/pull/141
nodejs/quic#165https://github.com/nodejs/quic/pull/165
https://github.com/addaleax
https://github.com/MylesBorins
src: remove keep alive option from SetImmediate()https://github.com/nodejs/node/pull/32301/commits/cb196ce7e0dc0ec69fcc330f0b40d737fb66a763
cb196cehttps://github.com/nodejs/node/pull/32301/commits/cb196ce7e0dc0ec69fcc330f0b40d737fb66a763
nodejs#30374https://github.com/nodejs/node/pull/30374
nodejs/quic#141https://github.com/nodejs/quic/pull/141
nodejs/quic#149https://github.com/nodejs/quic/pull/149
nodejs/quic#141https://github.com/nodejs/quic/pull/141
nodejs/quic#165https://github.com/nodejs/quic/pull/165
https://github.com/addaleax
https://github.com/MylesBorins
src: remove HandleWrap instances from list once closedhttps://github.com/nodejs/node/pull/32301/commits/92cb961f80ba8140ed6c033cb0ba87707001f878
92cb961https://github.com/nodejs/node/pull/32301/commits/92cb961f80ba8140ed6c033cb0ba87707001f878
nodejs/quic#165https://github.com/nodejs/quic/pull/165
nodejs#30374https://github.com/nodejs/node/pull/30374
nodejs/quic#141https://github.com/nodejs/quic/pull/141
nodejs/quic#149https://github.com/nodejs/quic/pull/149
nodejs/quic#141https://github.com/nodejs/quic/pull/141
https://github.com/addaleax
https://github.com/MylesBorins
src: keep object alive in stream_pipe codehttps://github.com/nodejs/node/pull/32301/commits/b18531dc98da3f9d4ee7fc200142765f224b94f7
b18531dhttps://github.com/nodejs/node/pull/32301/commits/b18531dc98da3f9d4ee7fc200142765f224b94f7
a489583https://github.com/addaleax/node/commit/a489583eda4d7cebc06516834b31dc2a4cedb1b6
nodejs#30374https://github.com/nodejs/node/pull/30374
nodejs#30666https://github.com/nodejs/node/pull/30666
nodejs#30643https://github.com/nodejs/node/issues/30643
https://github.com/addaleax
https://github.com/MylesBorins
src: add more can_call_into_js() guardshttps://github.com/nodejs/node/pull/32301/commits/ece9faf23900d56fb2e1e9487cc51db17ffc288d
ece9fafhttps://github.com/nodejs/node/pull/32301/commits/ece9faf23900d56fb2e1e9487cc51db17ffc288d
nodejs#30666https://github.com/nodejs/node/pull/30666
nodejs#30643https://github.com/nodejs/node/issues/30643
nodejs#30374https://github.com/nodejs/node/pull/30374
https://github.com/addaleax
https://github.com/MylesBorins
src: no SetImmediate from destructor in stream_pipe codehttps://github.com/nodejs/node/pull/32301/commits/c3fff2511588e01da38dd84be4312f8a2c1f4616
c3fff25https://github.com/nodejs/node/pull/32301/commits/c3fff2511588e01da38dd84be4312f8a2c1f4616
nodejs#30666https://github.com/nodejs/node/pull/30666
nodejs#30643https://github.com/nodejs/node/issues/30643
nodejs#30374https://github.com/nodejs/node/pull/30374
https://github.com/addaleax
https://github.com/MylesBorins
src: run native immediates during Environment cleanuphttps://github.com/nodejs/node/pull/32301/commits/24700356d1d7ecae41d03fd8c6c28c9d522a3c93
2470035https://github.com/nodejs/node/pull/32301/commits/24700356d1d7ecae41d03fd8c6c28c9d522a3c93
nodejs#30643https://github.com/nodejs/node/issues/30643
nodejs#30666https://github.com/nodejs/node/pull/30666
nodejs#30374https://github.com/nodejs/node/pull/30374
https://github.com/addaleax
https://github.com/MylesBorins
src: better encapsulate native immediate listhttps://github.com/nodejs/node/pull/32301/commits/973f8ef12ea2a7355611ffdaab6d117c23c8ee07
973f8efhttps://github.com/nodejs/node/pull/32301/commits/973f8ef12ea2a7355611ffdaab6d117c23c8ee07
nodejs#31386https://github.com/nodejs/node/pull/31386
openjs-foundation/summit#240https://github.com/openjs-foundation/summit/pull/240
https://github.com/addaleax
https://github.com/MylesBorins
src: exclude C++ SetImmediate() from counthttps://github.com/nodejs/node/pull/32301/commits/5e1bcaee6f5a2fd75c7ac4380fe29d00d02b208a
5e1bcaehttps://github.com/nodejs/node/pull/32301/commits/5e1bcaee6f5a2fd75c7ac4380fe29d00d02b208a
nodejs#31386https://github.com/nodejs/node/pull/31386
openjs-foundation/summit#240https://github.com/openjs-foundation/summit/pull/240
addaleaxhttps://github.com/addaleax
April 1, 2020 02:33https://github.com/nodejs/node/pull/32301#commits-pushed-4d3275b
https://github.com/addaleax
https://github.com/MylesBorins
src: harden running native SetImmediate()s slightlyhttps://github.com/nodejs/node/pull/32301/commits/4d3275bf863589eeb50406aebeb864b44354ad4a
4d3275bhttps://github.com/nodejs/node/pull/32301/commits/4d3275bf863589eeb50406aebeb864b44354ad4a
nodejs#31468https://github.com/nodejs/node/pull/31468
nodejs#31386https://github.com/nodejs/node/pull/31386
https://github.com/addaleax
https://github.com/MylesBorins
src: delete BaseObjectWeakPtr data when pointee is gonehttps://github.com/nodejs/node/pull/32301/commits/d85cb07e3336bd92f631bf41376808c22535413f
d85cb07https://github.com/nodejs/node/pull/32301/commits/d85cb07e3336bd92f631bf41376808c22535413f
nodejs#30374 (comment)https://github.com/nodejs/node/pull/30374#issuecomment-601848973
nodejs#32393https://github.com/nodejs/node/pull/32393
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/fb981110a1f6e7af1c1c2e84b5fe09c286d1b7a9..d85cb07e3336bd92f631bf41376808c22535413f
fb98111https://github.com/nodejs/node/commit/fb981110a1f6e7af1c1c2e84b5fe09c286d1b7a9
d85cb07https://github.com/nodejs/node/commit/d85cb07e3336bd92f631bf41376808c22535413f
Compare https://github.com/nodejs/node/compare/fb981110a1f6e7af1c1c2e84b5fe09c286d1b7a9..d85cb07e3336bd92f631bf41376808c22535413f
April 1, 2020 06:33https://github.com/nodejs/node/pull/32301#event-3186405473
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020https://github.com/nodejs/node/pull/32301#issuecomment-607062911
Please reload this pagehttps://github.com/nodejs/node/pull/32301
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 1, 2020https://github.com/nodejs/node/pull/32301#issuecomment-607063000
https://ci.nodejs.org/job/node-test-pull-request/30319/https://ci.nodejs.org/job/node-test-pull-request/30319/
Please reload this pagehttps://github.com/nodejs/node/pull/32301
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 1, 2020https://github.com/nodejs/node/pull/32301#issuecomment-607229160
https://ci.nodejs.org/job/node-test-pull-request/30324/https://ci.nodejs.org/job/node-test-pull-request/30324/
Please reload this pagehttps://github.com/nodejs/node/pull/32301
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 1, 2020https://github.com/nodejs/node/pull/32301#issuecomment-607364919
https://ci.nodejs.org/job/node-test-pull-request/30330/https://ci.nodejs.org/job/node-test-pull-request/30330/
Please reload this pagehttps://github.com/nodejs/node/pull/32301
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 1, 2020https://github.com/nodejs/node/pull/32301#issuecomment-607474041
https://ci.nodejs.org/job/node-test-pull-request/30337/https://ci.nodejs.org/job/node-test-pull-request/30337/
Please reload this pagehttps://github.com/nodejs/node/pull/32301
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-c60780f
https://github.com/addaleax
https://github.com/MylesBorins
src: introduce custom smart pointers for BaseObjectshttps://github.com/nodejs/node/commit/c60780ff525959c1b9f0c247fb29a8a724447b4c
c60780fhttps://github.com/nodejs/node/commit/c60780ff525959c1b9f0c247fb29a8a724447b4c
nodejs/quic#141https://github.com/nodejs/quic/pull/141
nodejs/quic#149https://github.com/nodejs/quic/pull/149
#32301https://github.com/nodejs/node/pull/32301
#30374https://github.com/nodejs/node/pull/30374
nodejs/quic#165https://github.com/nodejs/quic/pull/165
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-4745ac4
https://github.com/addaleax
https://github.com/MylesBorins
http2: use custom BaseObject smart pointershttps://github.com/nodejs/node/commit/4745ac4fd721713fc2a9e2123450bde75bf3d084
4745ac4https://github.com/nodejs/node/commit/4745ac4fd721713fc2a9e2123450bde75bf3d084
nodejs/quic#141https://github.com/nodejs/quic/pull/141
#32301https://github.com/nodejs/node/pull/32301
#30374https://github.com/nodejs/node/pull/30374
nodejs/quic#149https://github.com/nodejs/quic/pull/149
nodejs/quic#165https://github.com/nodejs/quic/pull/165
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-6db84d3
https://github.com/addaleax
https://github.com/MylesBorins
src: use BaseObjectPtr for keeping channel alive in dns bindingshttps://github.com/nodejs/node/commit/6db84d3e501b3fe60717941ff9350d83e556e5af
6db84d3https://github.com/nodejs/node/commit/6db84d3e501b3fe60717941ff9350d83e556e5af
#32301https://github.com/nodejs/node/pull/32301
#30374https://github.com/nodejs/node/pull/30374
nodejs/quic#141https://github.com/nodejs/quic/pull/141
nodejs/quic#149https://github.com/nodejs/quic/pull/149
nodejs/quic#141https://github.com/nodejs/quic/pull/141
nodejs/quic#165https://github.com/nodejs/quic/pull/165
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-e17d314
https://github.com/addaleax
https://github.com/MylesBorins
src: remove keep alive option from SetImmediate()https://github.com/nodejs/node/commit/e17d314a21c3635b6bf62e124b82780ef31dbd6d
e17d314https://github.com/nodejs/node/commit/e17d314a21c3635b6bf62e124b82780ef31dbd6d
#32301https://github.com/nodejs/node/pull/32301
#30374https://github.com/nodejs/node/pull/30374
nodejs/quic#141https://github.com/nodejs/quic/pull/141
nodejs/quic#149https://github.com/nodejs/quic/pull/149
nodejs/quic#141https://github.com/nodejs/quic/pull/141
nodejs/quic#165https://github.com/nodejs/quic/pull/165
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-5f95e69
https://github.com/addaleax
https://github.com/MylesBorins
src: remove HandleWrap instances from list once closedhttps://github.com/nodejs/node/commit/5f95e69f4db40a82d09e6a2f63c45ee08e744faa
5f95e69https://github.com/nodejs/node/commit/5f95e69f4db40a82d09e6a2f63c45ee08e744faa
nodejs/quic#165https://github.com/nodejs/quic/pull/165
#32301https://github.com/nodejs/node/pull/32301
#30374https://github.com/nodejs/node/pull/30374
nodejs/quic#141https://github.com/nodejs/quic/pull/141
nodejs/quic#149https://github.com/nodejs/quic/pull/149
nodejs/quic#141https://github.com/nodejs/quic/pull/141
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-7647bfe
https://github.com/addaleax
https://github.com/MylesBorins
src: keep object alive in stream_pipe codehttps://github.com/nodejs/node/commit/7647bfe3fc358edf61e1fa15f30d06f9ee5e70a2
7647bfehttps://github.com/nodejs/node/commit/7647bfe3fc358edf61e1fa15f30d06f9ee5e70a2
a489583https://github.com/nodejs/node/commit/a489583eda4d7cebc06516834b31dc2a4cedb1b6
#30374https://github.com/nodejs/node/pull/30374
#32301https://github.com/nodejs/node/pull/32301
#30666https://github.com/nodejs/node/pull/30666
#30643https://github.com/nodejs/node/issues/30643
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-51230f7
https://github.com/addaleax
https://github.com/MylesBorins
src: add more can_call_into_js() guardshttps://github.com/nodejs/node/commit/51230f71ffa4d75ef17f28a30fcc5e2558adf41e
51230f7https://github.com/nodejs/node/commit/51230f71ffa4d75ef17f28a30fcc5e2558adf41e
#32301https://github.com/nodejs/node/pull/32301
#30666https://github.com/nodejs/node/pull/30666
#30643https://github.com/nodejs/node/issues/30643
#30374https://github.com/nodejs/node/pull/30374
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-5b65348
https://github.com/addaleax
https://github.com/MylesBorins
src: no SetImmediate from destructor in stream_pipe codehttps://github.com/nodejs/node/commit/5b65348fedfda8ff7a64df3dd8b91e4ea1ceeb27
5b65348https://github.com/nodejs/node/commit/5b65348fedfda8ff7a64df3dd8b91e4ea1ceeb27
#32301https://github.com/nodejs/node/pull/32301
#30666https://github.com/nodejs/node/pull/30666
#30643https://github.com/nodejs/node/issues/30643
#30374https://github.com/nodejs/node/pull/30374
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-2625244
https://github.com/addaleax
https://github.com/MylesBorins
src: run native immediates during Environment cleanuphttps://github.com/nodejs/node/commit/2625244111f3546774f9b843889f3499b7309442
2625244https://github.com/nodejs/node/commit/2625244111f3546774f9b843889f3499b7309442
#30643https://github.com/nodejs/node/issues/30643
#32301https://github.com/nodejs/node/pull/32301
#30666https://github.com/nodejs/node/pull/30666
#30374https://github.com/nodejs/node/pull/30374
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-5df9698
https://github.com/addaleax
https://github.com/MylesBorins
src: better encapsulate native immediate listhttps://github.com/nodejs/node/commit/5df969826df0f2bc9d977ccee8db5ecc84155f63
5df9698https://github.com/nodejs/node/commit/5df969826df0f2bc9d977ccee8db5ecc84155f63
#32301https://github.com/nodejs/node/pull/32301
#31386https://github.com/nodejs/node/pull/31386
openjs-foundation/summit#240https://github.com/openjs-foundation/summit/pull/240
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-aafb224
https://github.com/addaleax
https://github.com/MylesBorins
src: exclude C++ SetImmediate() from counthttps://github.com/nodejs/node/commit/aafb224147555c59d5abd277cc45f76668ac7046
aafb224https://github.com/nodejs/node/commit/aafb224147555c59d5abd277cc45f76668ac7046
#32301https://github.com/nodejs/node/pull/32301
#31386https://github.com/nodejs/node/pull/31386
openjs-foundation/summit#240https://github.com/openjs-foundation/summit/pull/240
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-748a530
https://github.com/addaleax
https://github.com/MylesBorins
src: add a threadsafe variant of SetImmediate()https://github.com/nodejs/node/commit/748a530046a4e8293f887e2892539a3b61f991a0
748a530https://github.com/nodejs/node/commit/748a530046a4e8293f887e2892539a3b61f991a0
#32301https://github.com/nodejs/node/pull/32301
#31386https://github.com/nodejs/node/pull/31386
openjs-foundation/summit#240https://github.com/openjs-foundation/summit/pull/240
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-7c2c068
https://github.com/addaleax
https://github.com/MylesBorins
src: remove AsyncRequesthttps://github.com/nodejs/node/commit/7c2c068aeba719e01707c37343281d22b0eb5353
7c2c068https://github.com/nodejs/node/commit/7c2c068aeba719e01707c37343281d22b0eb5353
#32301https://github.com/nodejs/node/pull/32301
#31386https://github.com/nodejs/node/pull/31386
openjs-foundation/summit#240https://github.com/openjs-foundation/summit/pull/240
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-22bf867
https://github.com/addaleax
https://github.com/MylesBorins
src: add interrupts to Environments/Workershttps://github.com/nodejs/node/commit/22bf8671490d7d7b839274895c8bec94dbc6799e
22bf867https://github.com/nodejs/node/commit/22bf8671490d7d7b839274895c8bec94dbc6799e
#32301https://github.com/nodejs/node/pull/32301
#31386https://github.com/nodejs/node/pull/31386
openjs-foundation/summit#240https://github.com/openjs-foundation/summit/pull/240
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-c2176e1
https://github.com/addaleax
https://github.com/MylesBorins
src: move MemoryInfo() for worker code to .cc fileshttps://github.com/nodejs/node/commit/c2176e15ea0897fe01ed7ce277e7feff8837d15b
c2176e1https://github.com/nodejs/node/commit/c2176e15ea0897fe01ed7ce277e7feff8837d15b
#32301https://github.com/nodejs/node/pull/32301
#31386https://github.com/nodejs/node/pull/31386
openjs-foundation/summit#240https://github.com/openjs-foundation/summit/pull/240
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-87cfbb2
https://github.com/addaleax
https://github.com/MylesBorins
report: add support for Workershttps://github.com/nodejs/node/commit/87cfbb2da1e588fba9ad3333b65ac0b1127efc5b
87cfbb2https://github.com/nodejs/node/commit/87cfbb2da1e588fba9ad3333b65ac0b1127efc5b
openjs-foundation/summit#240https://github.com/openjs-foundation/summit/pull/240
#32301https://github.com/nodejs/node/pull/32301
#31386https://github.com/nodejs/node/pull/31386
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-cb16aab
https://github.com/addaleax
https://github.com/MylesBorins
src: simplify native immediate queue runninghttps://github.com/nodejs/node/commit/cb16aabd15d0b56af4d266034a0b23c02559099f
cb16aabhttps://github.com/nodejs/node/commit/cb16aabd15d0b56af4d266034a0b23c02559099f
#32301https://github.com/nodejs/node/pull/32301
#31502https://github.com/nodejs/node/pull/31502
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-c5de212
https://github.com/addaleax
https://github.com/MylesBorins
worker: move JoinThread() back into exit callbackhttps://github.com/nodejs/node/commit/c5de212039bd6dc40acf3a9aff5c58d5295c4bd1
c5de212https://github.com/nodejs/node/commit/c5de212039bd6dc40acf3a9aff5c58d5295c4bd1
de2c68chttps://github.com/nodejs/node/commit/de2c68c7dd17a217a818ea881e433034006fdb4b
#31386https://github.com/nodejs/node/pull/31386
#32301https://github.com/nodejs/node/pull/32301
#31468https://github.com/nodejs/node/pull/31468
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-56a4509
https://github.com/addaleax
https://github.com/MylesBorins
src: harden running native SetImmediate()s slightlyhttps://github.com/nodejs/node/commit/56a45095b71f4ebcf5405f83ab5af665452289db
56a4509https://github.com/nodejs/node/commit/56a45095b71f4ebcf5405f83ab5af665452289db
#32301https://github.com/nodejs/node/pull/32301
#31468https://github.com/nodejs/node/pull/31468
#31386https://github.com/nodejs/node/pull/31386
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020 https://github.com/nodejs/node/pull/32301#ref-commit-fbd5be6
https://github.com/addaleax
https://github.com/MylesBorins
src: delete BaseObjectWeakPtr data when pointee is gonehttps://github.com/nodejs/node/commit/fbd5be673417680284a1e863ecfa54f8d52344c4
fbd5be6https://github.com/nodejs/node/commit/fbd5be673417680284a1e863ecfa54f8d52344c4
#30374 (comment)https://github.com/nodejs/node/pull/30374#issuecomment-601848973
#32301https://github.com/nodejs/node/pull/32301
#32393https://github.com/nodejs/node/pull/32393
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020https://github.com/nodejs/node/pull/32301#issuecomment-607502829
d568efc...fbd5be6https://github.com/nodejs/node/compare/d568efcd224fcc24b78581dcd587c834f24689d6...fbd5be673417680284a1e863ecfa54f8d52344c4
Please reload this pagehttps://github.com/nodejs/node/pull/32301
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 1, 2020https://github.com/nodejs/node/pull/32301#event-3189772457
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32301
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/32301
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.