René's URL Explorer Experiment


Title: report: handle on-fatalerror better by HarshithaKP · Pull Request #32207 · nodejs/node · GitHub

Open Graph Title: report: handle on-fatalerror better by HarshithaKP · Pull Request #32207 · nodejs/node

X Title: report: handle on-fatalerror better by HarshithaKP · Pull Request #32207 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: --report-on-fatalerror was not honored properly, as there was no way to check the value which was stored in the Environment pointer which can be inaccessible under certain fatal error situations. M...

X Description: --report-on-fatalerror was not honored properly, as there was no way to check the value which was stored in the Environment pointer which can be inaccessible under certain fatal error situations. M...

Mail addresses
schittora@paypal.com

Opengraph URL: https://github.com/nodejs/node/pull/32207

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:94d8dc31-ead2-6fb0-16fb-b37b69fc9939
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC1A:E2378:1CB3EA4:2761654:6A4EB79C
html-safe-nonce892f40ce41d3cb6f6de8d0fc21a5d1abb6b6f1deccaa9668552a1f7782a7960a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzFBOkUyMzc4OjFDQjNFQTQ6Mjc2MTY1NDo2QTRFQjc5QyIsInZpc2l0b3JfaWQiOiI2OTc1ODAyMTI3Nzg5NTA0NDEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd441500fcf9850fe1577106913244d4b90232ab2f90a81679be7ed868f74e3ce
hovercard-subject-tagpull_request:386829078
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32207/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/87889f79a95a04c379216d0f892ebbe3d865e31ac55949bb47f956d133730aee/nodejs/node/pull/32207
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/87889f79a95a04c379216d0f892ebbe3d865e31ac55949bb47f956d133730aee/nodejs/node/pull/32207
og:image:alt--report-on-fatalerror was not honored properly, as there was no way to check the value which was stored in the Environment pointer which can be inaccessible under certain fatal error situations. M...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameHarshithaKP
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/32207#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32207
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32207
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/32207
Reloadhttps://github.com/nodejs/node/pull/32207
Reloadhttps://github.com/nodejs/node/pull/32207
Please reload this pagehttps://github.com/nodejs/node/pull/32207
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/32207
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
HarshithaKPhttps://github.com/HarshithaKP
nodejs:masterhttps://github.com/nodejs/node/tree/master
HarshithaKP:diagnostic_report_fatal_errorhttps://github.com/HarshithaKP/node/tree/diagnostic_report_fatal_error
Conversationhttps://github.com/nodejs/node/pull/32207
Commits4 (4)https://github.com/nodejs/node/pull/32207/commits
Checkshttps://github.com/nodejs/node/pull/32207/checks
Files changedhttps://github.com/nodejs/node/pull/32207/files
report: handle on-fatalerror betterhttps://github.com/nodejs/node/pull/32207#top
HarshithaKPhttps://github.com/HarshithaKP
nodejs:masterhttps://github.com/nodejs/node/tree/master
HarshithaKP:diagnostic_report_fatal_errorhttps://github.com/HarshithaKP/node/tree/diagnostic_report_fatal_error
https://github.com/HarshithaKP
HarshithaKPhttps://github.com/HarshithaKP
Mar 11, 2020https://github.com/nodejs/node/pull/32207#issue-579434768
#31576https://github.com/nodejs/node/issues/31576
#29881https://github.com/nodejs/node/pull/29881
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/32207
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Mar 11, 2020https://github.com/nodejs/node/pull/32207#event-3119851247
https://github.com/HarshithaKP
HarshithaKPhttps://github.com/HarshithaKP
Mar 11, 2020https://github.com/nodejs/node/pull/32207#event-3119869325
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 11, 2020 https://github.com/nodejs/node/pull/32207#pullrequestreview-372995970
View reviewed changes https://github.com/nodejs/node/pull/32207/files
src/node_report_module.cchttps://github.com/nodejs/node/pull/32207/files#diff-41855b5f20bbd1dfcb5c3de86a87d6fdd12589ab0727c3fe0dcef5daf7fb5435
Please reload this pagehttps://github.com/nodejs/node/pull/32207
https://github.com/HarshithaKP
HarshithaKPhttps://github.com/HarshithaKP
force-pushedhttps://github.com/nodejs/node/compare/ae976b0a5705c96f85374a3cf9dcd14af002d809..a0df7305d1a12c5a1e1b4ded3324d930d47d9851
ae976b0https://github.com/nodejs/node/commit/ae976b0a5705c96f85374a3cf9dcd14af002d809
a0df730https://github.com/nodejs/node/commit/a0df7305d1a12c5a1e1b4ded3324d930d47d9851
Compare https://github.com/nodejs/node/compare/ae976b0a5705c96f85374a3cf9dcd14af002d809..a0df7305d1a12c5a1e1b4ded3324d930d47d9851
March 12, 2020 08:39https://github.com/nodejs/node/pull/32207#event-3121872324
https://github.com/HarshithaKP
HarshithaKPhttps://github.com/HarshithaKP
Mar 12, 2020 https://github.com/nodejs/node/pull/32207#pullrequestreview-373363478
View reviewed changes https://github.com/nodejs/node/pull/32207/files
src/node_options.cchttps://github.com/nodejs/node/pull/32207/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8
HarshithaKPhttps://github.com/HarshithaKP
Mar 12, 2020https://github.com/nodejs/node/pull/32207#discussion_r391470231
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#29881https://github.com/nodejs/node/pull/29881
#29881 (comment)https://github.com/nodejs/node/pull/29881#issuecomment-581345483
Please reload this pagehttps://github.com/nodejs/node/pull/32207
https://github.com/HarshithaKP
HarshithaKPhttps://github.com/HarshithaKP
Mar 12, 2020https://github.com/nodejs/node/pull/32207#event-3121883269
https://github.com/HarshithaKP
HarshithaKPhttps://github.com/HarshithaKP
Mar 12, 2020 https://github.com/nodejs/node/pull/32207#ref-issue-413860712
Discussion: Criteria for upgrading diagnostic reporting from experimental to stable #26293 https://github.com/nodejs/node/issues/26293
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Mar 13, 2020 https://github.com/nodejs/node/pull/32207#ref-pullrequest-580365424
report: move diagnostic reports to stable #32242 https://github.com/nodejs/node/pull/32242
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Mar 13, 2020 https://github.com/nodejs/node/pull/32207#pullrequestreview-374068881
View reviewed changes https://github.com/nodejs/node/pull/32207/files
src/node_options.cchttps://github.com/nodejs/node/pull/32207/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8
Please reload this pagehttps://github.com/nodejs/node/pull/32207
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Mar 13, 2020https://github.com/nodejs/node/pull/32207#issuecomment-598568497
#32242https://github.com/nodejs/node/pull/32242
Please reload this pagehttps://github.com/nodejs/node/pull/32207
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 15, 2020https://github.com/nodejs/node/pull/32207#issuecomment-599159112
https://ci.nodejs.org/job/node-test-pull-request/29841/https://ci.nodejs.org/job/node-test-pull-request/29841/
Please reload this pagehttps://github.com/nodejs/node/pull/32207
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
addaleaxhttps://github.com/addaleax
cjihrighttps://github.com/cjihrig
March 15, 2020 05:35https://github.com/nodejs/node/pull/32207#event-3130148788
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 15, 2020 https://github.com/nodejs/node/pull/32207#pullrequestreview-374803447
View reviewed changes https://github.com/nodejs/node/pull/32207/files
src/node_options.cchttps://github.com/nodejs/node/pull/32207/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8
cjihrighttps://github.com/cjihrig
Mar 15, 2020https://github.com/nodejs/node/pull/32207#discussion_r392678437
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#32242https://github.com/nodejs/node/pull/32242
Please reload this pagehttps://github.com/nodejs/node/pull/32207
HarshithaKPhttps://github.com/HarshithaKP
Mar 16, 2020https://github.com/nodejs/node/pull/32207#discussion_r392804560
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/32207
src/node_options.cchttps://github.com/nodejs/node/pull/32207/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8
cjihrighttps://github.com/cjihrig
Mar 15, 2020https://github.com/nodejs/node/pull/32207#discussion_r392678539
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#32242https://github.com/nodejs/node/pull/32242
Please reload this pagehttps://github.com/nodejs/node/pull/32207
HarshithaKPhttps://github.com/HarshithaKP
Mar 16, 2020https://github.com/nodejs/node/pull/32207#discussion_r392804744
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32207
test/report/test-report-fatal-error.jshttps://github.com/nodejs/node/pull/32207/files#diff-6f9064ce8b6d80a190a87aef9b8b9590f0573ab92058befc904e67d61b32f86d
cjihrighttps://github.com/cjihrig
Mar 15, 2020https://github.com/nodejs/node/pull/32207#discussion_r392678666
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#32242https://github.com/nodejs/node/pull/32242
Please reload this pagehttps://github.com/nodejs/node/pull/32207
HarshithaKPhttps://github.com/HarshithaKP
Mar 16, 2020https://github.com/nodejs/node/pull/32207#discussion_r392804939
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32207
test/report/test-report-fatal-error.jshttps://github.com/nodejs/node/pull/32207/files#diff-6f9064ce8b6d80a190a87aef9b8b9590f0573ab92058befc904e67d61b32f86d
cjihrighttps://github.com/cjihrig
Mar 15, 2020https://github.com/nodejs/node/pull/32207#discussion_r392678908
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32207
HarshithaKPhttps://github.com/HarshithaKP
Mar 16, 2020https://github.com/nodejs/node/pull/32207#discussion_r392812704
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32207
https://github.com/HarshithaKP
HarshithaKPhttps://github.com/HarshithaKP
force-pushedhttps://github.com/nodejs/node/compare/cc0c963a3daf157c052213d2f7fd442a98196e13..8d7144969d69efe30a6706cc1cf9eb15b7358c25
cc0c963https://github.com/nodejs/node/commit/cc0c963a3daf157c052213d2f7fd442a98196e13
8d71449https://github.com/nodejs/node/commit/8d7144969d69efe30a6706cc1cf9eb15b7358c25
Compare https://github.com/nodejs/node/compare/cc0c963a3daf157c052213d2f7fd442a98196e13..8d7144969d69efe30a6706cc1cf9eb15b7358c25
March 16, 2020 06:28https://github.com/nodejs/node/pull/32207#event-3131740678
https://github.com/HarshithaKP
HarshithaKPhttps://github.com/HarshithaKP
Mar 16, 2020https://github.com/nodejs/node/pull/32207#issuecomment-599368692
Please reload this pagehttps://github.com/nodejs/node/pull/32207
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 16, 2020https://github.com/nodejs/node/pull/32207#issuecomment-599523636
Please reload this pagehttps://github.com/nodejs/node/pull/32207
https://github.com/HarshithaKP
HarshithaKPhttps://github.com/HarshithaKP
Mar 16, 2020https://github.com/nodejs/node/pull/32207#issuecomment-599533646
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/32207
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Mar 16, 2020 https://github.com/nodejs/node/pull/32207#pullrequestreview-375209610
View reviewed changes https://github.com/nodejs/node/pull/32207/files
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Mar 16, 2020 https://github.com/nodejs/node/pull/32207#pullrequestreview-375511103
View reviewed changes https://github.com/nodejs/node/pull/32207/files
sam-githubhttps://github.com/sam-github
https://github.com/nodejs/node/pull/32207#pullrequestreview-375511103
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32207
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 16, 2020https://github.com/nodejs/node/pull/32207#issuecomment-599717443
https://ci.nodejs.org/job/node-test-pull-request/29873/https://ci.nodejs.org/job/node-test-pull-request/29873/
Please reload this pagehttps://github.com/nodejs/node/pull/32207
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Mar 23, 2020https://github.com/nodejs/node/pull/32207#issuecomment-602844484
Please reload this pagehttps://github.com/nodejs/node/pull/32207
@HarshithaKPhttps://github.com/HarshithaKP
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requestshttps://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests
Please reload this pagehttps://github.com/nodejs/node/pull/32207
HarshithaKPhttps://github.com/HarshithaKP
March 24, 2020 02:39https://github.com/nodejs/node/pull/32207#commits-pushed-175c2e7
https://github.com/HarshithaKP
report: handle on-fatalerror betterhttps://github.com/nodejs/node/pull/32207/commits/175c2e7a3f40c0e97edd46f9322878aaaa43710d
175c2e7https://github.com/nodejs/node/pull/32207/commits/175c2e7a3f40c0e97edd46f9322878aaaa43710d
nodejs#31576https://github.com/nodejs/node/issues/31576
nodejs#29881https://github.com/nodejs/node/pull/29881
https://github.com/HarshithaKP
fixup: address review commenthttps://github.com/nodejs/node/pull/32207/commits/7915e7eb4665df8965d4bbb3e0766b1abb8639af
7915e7ehttps://github.com/nodejs/node/pull/32207/commits/7915e7eb4665df8965d4bbb3e0766b1abb8639af
https://github.com/HarshithaKP
fixup: fix linter errorhttps://github.com/nodejs/node/pull/32207/commits/3bf8c608974205ade1a89b03ac5a770ccc8868e3
3bf8c60https://github.com/nodejs/node/pull/32207/commits/3bf8c608974205ade1a89b03ac5a770ccc8868e3
https://github.com/HarshithaKP
fixup: fix linter errorhttps://github.com/nodejs/node/pull/32207/commits/7dbc5dea7cfd8a87f3019b94002923c4d78495ee
7dbc5dehttps://github.com/nodejs/node/pull/32207/commits/7dbc5dea7cfd8a87f3019b94002923c4d78495ee
https://github.com/HarshithaKP
HarshithaKPhttps://github.com/HarshithaKP
force-pushedhttps://github.com/nodejs/node/compare/5e9fdd9dc3b6744f54b89cccc139e7e3d0bf4ad9..7dbc5dea7cfd8a87f3019b94002923c4d78495ee
5e9fdd9https://github.com/nodejs/node/commit/5e9fdd9dc3b6744f54b89cccc139e7e3d0bf4ad9
7dbc5dehttps://github.com/nodejs/node/commit/7dbc5dea7cfd8a87f3019b94002923c4d78495ee
Compare https://github.com/nodejs/node/compare/5e9fdd9dc3b6744f54b89cccc139e7e3d0bf4ad9..7dbc5dea7cfd8a87f3019b94002923c4d78495ee
March 24, 2020 06:45https://github.com/nodejs/node/pull/32207#event-3158287711
https://github.com/HarshithaKP
HarshithaKPhttps://github.com/HarshithaKP
Mar 24, 2020https://github.com/nodejs/node/pull/32207#issuecomment-603058361
@sam-githubhttps://github.com/sam-github
Please reload this pagehttps://github.com/nodejs/node/pull/32207
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Mar 26, 2020 https://github.com/nodejs/node/pull/32207#ref-pullrequest-588134569
src: handle report options on fatalerror #32497 https://github.com/nodejs/node/pull/32497
addaleaxhttps://github.com/addaleax
Mar 28, 2020 https://github.com/nodejs/node/pull/32207#ref-commit-9336772
https://github.com/addaleax
report: add missing locks for report_on_fatalerror accessorshttps://github.com/addaleax/node/commit/9336772e34e16765017b94713766a67d81effbf3
9336772https://github.com/addaleax/node/commit/9336772e34e16765017b94713766a67d81effbf3
2fa74e3https://github.com/addaleax/node/commit/2fa74e3e38bb028339e48763138456b3ed10ed97
nodejs#32207https://github.com/nodejs/node/pull/32207
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 28, 2020 https://github.com/nodejs/node/pull/32207#ref-pullrequest-589580517
report: add missing locks for report_on_fatalerror accessors #32535 https://github.com/nodejs/node/pull/32535
sam-githubhttps://github.com/sam-github
Mar 30, 2020 https://github.com/nodejs/node/pull/32207#ref-commit-921d4e0
https://github.com/sam-github
src: handle report options on fatalerrorhttps://github.com/sam-github/node/commit/921d4e027395af5d7fbc557375e8f843bd6efd70
921d4e0https://github.com/sam-github/node/commit/921d4e027395af5d7fbc557375e8f843bd6efd70
nodejs#32207https://github.com/nodejs/node/pull/32207
sam-githubhttps://github.com/sam-github
Mar 31, 2020 https://github.com/nodejs/node/pull/32207#ref-commit-867ff41
https://github.com/sam-github
src: handle report options on fatalerrorhttps://github.com/nodejs/node/commit/867ff41d87e292997ff2ceb8d77e715145aed7b7
867ff41https://github.com/nodejs/node/commit/867ff41d87e292997ff2ceb8d77e715145aed7b7
#32207https://github.com/nodejs/node/pull/32207
#32497https://github.com/nodejs/node/pull/32497
MylesBorinshttps://github.com/MylesBorins
Mar 31, 2020 https://github.com/nodejs/node/pull/32207#ref-commit-04237ec
https://github.com/sam-github
https://github.com/MylesBorins
src: handle report options on fatalerrorhttps://github.com/nodejs/node/commit/04237eca5543251cfe7254f0412d45cdcb49b6a5
04237echttps://github.com/nodejs/node/commit/04237eca5543251cfe7254f0412d45cdcb49b6a5
#32207https://github.com/nodejs/node/pull/32207
#32497https://github.com/nodejs/node/pull/32497
addaleaxhttps://github.com/addaleax
Apr 2, 2020 https://github.com/nodejs/node/pull/32207#ref-commit-e06512b
https://github.com/addaleax
report: add missing locks for report_on_fatalerror accessorshttps://github.com/nodejs/node/commit/e06512b9b75552f73371512ded879e472c0ec57e
e06512bhttps://github.com/nodejs/node/commit/e06512b9b75552f73371512ded879e472c0ec57e
2fa74e3https://github.com/nodejs/node/commit/2fa74e3e38bb028339e48763138456b3ed10ed97
#32207https://github.com/nodejs/node/pull/32207
#32535https://github.com/nodejs/node/pull/32535
BethGriggshttps://github.com/BethGriggs
Apr 7, 2020 https://github.com/nodejs/node/pull/32207#ref-commit-6e30f54
https://github.com/addaleax
https://github.com/BethGriggs
report: add missing locks for report_on_fatalerror accessorshttps://github.com/nodejs/node/commit/6e30f54c7177afc7d2ddf1fd2777eae9e3fc1112
6e30f54https://github.com/nodejs/node/commit/6e30f54c7177afc7d2ddf1fd2777eae9e3fc1112
2fa74e3https://github.com/nodejs/node/commit/2fa74e3e38bb028339e48763138456b3ed10ed97
#32207https://github.com/nodejs/node/pull/32207
#32535https://github.com/nodejs/node/pull/32535
targoshttps://github.com/targos
Apr 12, 2020 https://github.com/nodejs/node/pull/32207#ref-commit-c095520
https://github.com/addaleax
https://github.com/targos
report: add missing locks for report_on_fatalerror accessorshttps://github.com/nodejs/node/commit/c09552063bd5cc0c9b837dc6613bcd48c79c794e
c095520https://github.com/nodejs/node/commit/c09552063bd5cc0c9b837dc6613bcd48c79c794e
2fa74e3https://github.com/nodejs/node/commit/2fa74e3e38bb028339e48763138456b3ed10ed97
#32207https://github.com/nodejs/node/pull/32207
#32535https://github.com/nodejs/node/pull/32535
https://github.com/targos
targoshttps://github.com/targos
backport-blocked-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v12.x
backport-blocked-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v12.x
Apr 22, 2020https://github.com/nodejs/node/pull/32207#event-3261390208
targoshttps://github.com/targos
Apr 25, 2020 https://github.com/nodejs/node/pull/32207#ref-commit-c35f3ea
https://github.com/HarshithaKP
https://github.com/targos
report: handle on-fatalerror betterhttps://github.com/targos/node/commit/c35f3ea8b2c5bae41da9fc4e25c5e11691fcd0f2
c35f3eahttps://github.com/targos/node/commit/c35f3ea8b2c5bae41da9fc4e25c5e11691fcd0f2
nodejs#32207https://github.com/nodejs/node/pull/32207
nodejs#31576https://github.com/nodejs/node/issues/31576
nodejs#29881https://github.com/nodejs/node/pull/29881
targoshttps://github.com/targos
Apr 25, 2020 https://github.com/nodejs/node/pull/32207#ref-commit-c6da2f4
https://github.com/sam-github
https://github.com/targos
src: handle report options on fatalerrorhttps://github.com/targos/node/commit/c6da2f4abab9dc03d68987aec327a71c6851fc48
c6da2f4https://github.com/targos/node/commit/c6da2f4abab9dc03d68987aec327a71c6851fc48
nodejs#32207https://github.com/nodejs/node/pull/32207
nodejs#32497https://github.com/nodejs/node/pull/32497
targoshttps://github.com/targos
Apr 25, 2020 https://github.com/nodejs/node/pull/32207#ref-commit-b02f4b7
https://github.com/addaleax
https://github.com/targos
report: add missing locks for report_on_fatalerror accessorshttps://github.com/targos/node/commit/b02f4b72367ef14079c7b9d8f7a35e936a231465
b02f4b7https://github.com/targos/node/commit/b02f4b72367ef14079c7b9d8f7a35e936a231465
2fa74e3https://github.com/targos/node/commit/2fa74e3e38bb028339e48763138456b3ed10ed97
nodejs#32207https://github.com/nodejs/node/pull/32207
nodejs#32535https://github.com/nodejs/node/pull/32535
targoshttps://github.com/targos
Apr 28, 2020 https://github.com/nodejs/node/pull/32207#ref-commit-c126d28
https://github.com/HarshithaKP
https://github.com/targos
report: handle on-fatalerror betterhttps://github.com/nodejs/node/commit/c126d28c2ecfcc3c00e4bf2a65f85195e1782de9
c126d28https://github.com/nodejs/node/commit/c126d28c2ecfcc3c00e4bf2a65f85195e1782de9
#32207https://github.com/nodejs/node/pull/32207
#31576https://github.com/nodejs/node/issues/31576
#29881https://github.com/nodejs/node/pull/29881
targoshttps://github.com/targos
Apr 28, 2020 https://github.com/nodejs/node/pull/32207#ref-commit-8e3dd47
https://github.com/sam-github
https://github.com/targos
src: handle report options on fatalerrorhttps://github.com/nodejs/node/commit/8e3dd47db7c6e7f0ec75f6fa4d2031db714a52fb
8e3dd47https://github.com/nodejs/node/commit/8e3dd47db7c6e7f0ec75f6fa4d2031db714a52fb
#32207https://github.com/nodejs/node/pull/32207
#32497https://github.com/nodejs/node/pull/32497
targoshttps://github.com/targos
Apr 28, 2020 https://github.com/nodejs/node/pull/32207#ref-commit-4b96fc5
https://github.com/addaleax
https://github.com/targos
report: add missing locks for report_on_fatalerror accessorshttps://github.com/nodejs/node/commit/4b96fc522c1fdc2a8f0e61bdf16de1f430ad02d0
4b96fc5https://github.com/nodejs/node/commit/4b96fc522c1fdc2a8f0e61bdf16de1f430ad02d0
2fa74e3https://github.com/nodejs/node/commit/2fa74e3e38bb028339e48763138456b3ed10ed97
#32207https://github.com/nodejs/node/pull/32207
#32535https://github.com/nodejs/node/pull/32535
https://github.com/targos
targoshttps://github.com/targos
May 2, 2020 https://github.com/nodejs/node/pull/32207#ref-pullrequest-610737650
v12.17.0 release proposal #33197 https://github.com/nodejs/node/pull/33197
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Oct 15, 2020 https://github.com/nodejs/node/pull/32207#ref-pullrequest-722083923
doc: upgrade stability status of report API #35654 https://github.com/nodejs/node/pull/35654
gireeshpunathilhttps://github.com/gireeshpunathil
Oct 19, 2020 https://github.com/nodejs/node/pull/32207#ref-commit-7798e59
https://github.com/gireeshpunathil
doc: upgrade stability status of report APIhttps://github.com/gireeshpunathil/node/commit/7798e59e988a66e731cc233f4a2fbee01269736d
7798e59https://github.com/gireeshpunathil/node/commit/7798e59e988a66e731cc233f4a2fbee01269736d
nodejs#32207https://github.com/nodejs/node/pull/32207
nodejs#35654https://github.com/nodejs/node/pull/35654
BethGriggshttps://github.com/BethGriggs
Dec 8, 2020 https://github.com/nodejs/node/pull/32207#ref-commit-45156e1
https://github.com/gireeshpunathil
https://github.com/BethGriggs
doc: upgrade stability status of report APIhttps://github.com/nodejs/node/commit/45156e187ca967710e3d4d3a160c4aa94c18464d
45156e1https://github.com/nodejs/node/commit/45156e187ca967710e3d4d3a160c4aa94c18464d
#32207https://github.com/nodejs/node/pull/32207
#35654https://github.com/nodejs/node/pull/35654
targoshttps://github.com/targos
Mar 3, 2021 https://github.com/nodejs/node/pull/32207#ref-commit-b297c11
https://github.com/gireeshpunathil
https://github.com/targos
doc: upgrade stability status of report APIhttps://github.com/nodejs/node/commit/b297c1175314a78b789fd4024aa2c1a9e625524f
b297c11https://github.com/nodejs/node/commit/b297c1175314a78b789fd4024aa2c1a9e625524f
#32207https://github.com/nodejs/node/pull/32207
#35654https://github.com/nodejs/node/pull/35654
MylesBorinshttps://github.com/MylesBorins
Apr 6, 2021 https://github.com/nodejs/node/pull/32207#ref-commit-4a768bc
https://github.com/gireeshpunathil
https://github.com/MylesBorins
doc: upgrade stability status of report APIhttps://github.com/nodejs/node/commit/4a768bc13bc2f6b58ec9d03f8e4115e2e65b4ab8
4a768bchttps://github.com/nodejs/node/commit/4a768bc13bc2f6b58ec9d03f8e4115e2e65b4ab8
#32207https://github.com/nodejs/node/pull/32207
#35654https://github.com/nodejs/node/pull/35654
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32207
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/32207/files/8a749a4d67a5cae3d11bc587010a41e889bd8c7d
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/32207/files/5e9fdd9dc3b6744f54b89cccc139e7e3d0bf4ad9
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/32207/files/7dbc5dea7cfd8a87f3019b94002923c4d78495ee
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Diagnostic report on fatal error does not respect settings https://github.com/nodejs/node/issues/31576
Please reload this pagehttps://github.com/nodejs/node/pull/32207
https://github.com/HarshithaKP
https://github.com/gireeshpunathil
https://github.com/nodejs-github-bot
https://github.com/cjihrig
https://github.com/sam-github
https://github.com/addaleax
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.