René's URL Explorer Experiment


Title: async_wrap: correctly pass parent to init callback by trevnorris · Pull Request #3216 · nodejs/node · GitHub

Open Graph Title: async_wrap: correctly pass parent to init callback by trevnorris · Pull Request #3216 · nodejs/node

X Title: async_wrap: correctly pass parent to init callback by trevnorris · Pull Request #3216 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Previous logic didn't allow parent to propagate to the init callback properly. The fix now allows the init callback to be called and passed the parent if: async wrap callbacks are enabled and ...

X Description: Previous logic didn't allow parent to propagate to the init callback properly. The fix now allows the init callback to be called and passed the parent if: async wrap callbacks are enabled ...

Opengraph URL: https://github.com/nodejs/node/pull/3216

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:167eca71-20fa-f4c3-afe9-1c390ac7523c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id93D0:136033:130F92:19095F:6A4D83EC
html-safe-nonced3ded7becdf3d8f49465e6ba6214de63ae56ec9aec59c738b846a7b9a8eb04ed
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0QwOjEzNjAzMzoxMzBGOTI6MTkwOTVGOjZBNEQ4M0VDIiwidmlzaXRvcl9pZCI6IjMyOTY2ODU2MTcwOTQwMTA2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf5bb5bffc01533f27100e665ed5ce059bfb6fcb268051aaa4606c8bb2a84c408
hovercard-subject-tagpull_request:46928760
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/3216/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/668024837466b046c8b8f547da16bf35c7b1ed8089ef34bc008eea17d1b657a8/nodejs/node/pull/3216
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/668024837466b046c8b8f547da16bf35c7b1ed8089ef34bc008eea17d1b657a8/nodejs/node/pull/3216
og:image:altPrevious logic didn't allow parent to propagate to the init callback properly. The fix now allows the init callback to be called and passed the parent if: async wrap callbacks are enabled and ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrevnorris
hostnamegithub.com
expected-hostnamegithub.com
Nonec6bf61c909482ec3072ef5d7a5a28f2a9d214788c9a44793eca1960048cb05ae
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6702a58b419a792226bd21ef0fb1bcb318bbcaa3
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/3216#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3216
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3216
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/3216
Reloadhttps://github.com/nodejs/node/pull/3216
Reloadhttps://github.com/nodejs/node/pull/3216
Please reload this pagehttps://github.com/nodejs/node/pull/3216
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/3216
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
trevnorrishttps://github.com/trevnorris
nodejs:masterhttps://github.com/nodejs/node/tree/master
trevnorris:propagate-parenthttps://github.com/trevnorris/node/tree/propagate-parent
Conversationhttps://github.com/nodejs/node/pull/3216
Commits1 (1)https://github.com/nodejs/node/pull/3216/commits
Checkshttps://github.com/nodejs/node/pull/3216/checks
Files changedhttps://github.com/nodejs/node/pull/3216/files
async_wrap: correctly pass parent to init callbackhttps://github.com/nodejs/node/pull/3216#top
trevnorrishttps://github.com/trevnorris
nodejs:masterhttps://github.com/nodejs/node/tree/master
trevnorris:propagate-parenthttps://github.com/trevnorris/node/tree/propagate-parent
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 6, 2015https://github.com/nodejs/node/pull/3216#issue-110052566
@bnoordhuishttps://github.com/bnoordhuis
https://ci.nodejs.org/job/node-test-pull-request/428/https://ci.nodejs.org/job/node-test-pull-request/428/
Please reload this pagehttps://github.com/nodejs/node/pull/3216
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Oct 6, 2015https://github.com/nodejs/node/pull/3216#event-428194547
thefourtheyehttps://github.com/thefourtheye
Oct 6, 2015 https://github.com/nodejs/node/pull/3216#discussion-diff-41295366
View reviewed changes https://github.com/nodejs/node/pull/3216/files#diff-bca4f40098eba1366f89d45f647b98c2dff95590c86c443ceb70cdaf29e28690
test/parallel/test-async-wrap-propagate-parent.jshttps://github.com/nodejs/node/pull/3216/files#diff-bca4f40098eba1366f89d45f647b98c2dff95590c86c443ceb70cdaf29e28690
thefourtheyehttps://github.com/thefourtheye
Oct 6, 2015https://github.com/nodejs/node/pull/3216#discussion_r41295366
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3216
trevnorrishttps://github.com/trevnorris
Oct 6, 2015https://github.com/nodejs/node/pull/3216#discussion_r41298976
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3216
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 6, 2015 https://github.com/nodejs/node/pull/3216#ref-pullrequest-109894436
docs: add up to date documentation for AsyncWrap nodejs/diagnostics#27 https://github.com/nodejs/diagnostics/pull/27
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
force-pushedhttps://github.com/nodejs/node/compare/ca27d2ab39bf52045340e7c986d6d78b173b4acc..a4672354ef8af4c7c48aed7a3235379d31cbe5ff
ca27d2ahttps://github.com/nodejs/node/commit/ca27d2ab39bf52045340e7c986d6d78b173b4acc
a467235https://github.com/nodejs/node/commit/a4672354ef8af4c7c48aed7a3235379d31cbe5ff
Compare https://github.com/nodejs/node/compare/ca27d2ab39bf52045340e7c986d6d78b173b4acc..a4672354ef8af4c7c48aed7a3235379d31cbe5ff
October 6, 2015 18:22https://github.com/nodejs/node/pull/3216#event-428290793
rvagghttps://github.com/rvagg
Oct 7, 2015 https://github.com/nodejs/node/pull/3216#discussion-diff-41343606
View reviewed changes https://github.com/nodejs/node/pull/3216/files#diff-d8b7d6bdd23982bd8c12159afe2d7523b36d19a383d51970b4f3f99efe394778
test/parallel/test-async-wrap-disabled-propagate-parent.jshttps://github.com/nodejs/node/pull/3216/files#diff-d8b7d6bdd23982bd8c12159afe2d7523b36d19a383d51970b4f3f99efe394778
rvagghttps://github.com/rvagg
Oct 7, 2015https://github.com/nodejs/node/pull/3216#discussion_r41343606
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3216
trevnorrishttps://github.com/trevnorris
Oct 7, 2015https://github.com/nodejs/node/pull/3216#discussion_r41423365
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3216
https://github.com/rvagg
rvagghttps://github.com/rvagg
Oct 7, 2015https://github.com/nodejs/node/pull/3216#issuecomment-146053237
@thlorenzhttps://github.com/thlorenz
Please reload this pagehttps://github.com/nodejs/node/pull/3216
https://github.com/trevnorris
async_wrap: correctly pass parent to init callbackhttps://github.com/nodejs/node/pull/3216/commits/71568ea03749b8cdec6d4d1924b7d7fb37d80154
71568eahttps://github.com/nodejs/node/pull/3216/commits/71568ea03749b8cdec6d4d1924b7d7fb37d80154
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
force-pushedhttps://github.com/nodejs/node/compare/a4672354ef8af4c7c48aed7a3235379d31cbe5ff..71568ea03749b8cdec6d4d1924b7d7fb37d80154
a467235https://github.com/nodejs/node/commit/a4672354ef8af4c7c48aed7a3235379d31cbe5ff
71568eahttps://github.com/nodejs/node/commit/71568ea03749b8cdec6d4d1924b7d7fb37d80154
Compare https://github.com/nodejs/node/compare/a4672354ef8af4c7c48aed7a3235379d31cbe5ff..71568ea03749b8cdec6d4d1924b7d7fb37d80154
October 7, 2015 17:58https://github.com/nodejs/node/pull/3216#event-429431007
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 7, 2015https://github.com/nodejs/node/pull/3216#issuecomment-146278627
https://ci.nodejs.org/job/node-test-pull-request/443/https://ci.nodejs.org/job/node-test-pull-request/443/
Please reload this pagehttps://github.com/nodejs/node/pull/3216
AsyncWrap: HTTP has no handle context #3241 https://github.com/nodejs/node/issues/3241
AsyncWrap: TCPWrap created before MakeCallback #2986 https://github.com/nodejs/node/issues/2986
[async_hooks] tracking issue nodejs/diagnostics#29 https://github.com/nodejs/diagnostics/issues/29
trevnorrishttps://github.com/trevnorris
Oct 7, 2015 https://github.com/nodejs/node/pull/3216#ref-commit-aeee956
https://github.com/trevnorris
async_wrap: correctly pass parent to init callbackhttps://github.com/nodejs/node/commit/aeee956ac73de7af914b747926168714fe4d1c4c
aeee956https://github.com/nodejs/node/commit/aeee956ac73de7af914b747926168714fe4d1c4c
#2986https://github.com/nodejs/node/issues/2986
#3216https://github.com/nodejs/node/pull/3216
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 7, 2015https://github.com/nodejs/node/pull/3216#issuecomment-146304499
aeee956https://github.com/nodejs/node/commit/aeee956ac73de7af914b747926168714fe4d1c4c
Please reload this pagehttps://github.com/nodejs/node/pull/3216
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 7, 2015https://github.com/nodejs/node/pull/3216#event-429530330
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
October 7, 2015 20:15https://github.com/nodejs/node/pull/3216#event-429570781
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
Oct 7, 2015https://github.com/nodejs/node/pull/3216#event-429636345
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 8, 2015 https://github.com/nodejs/node/pull/3216#ref-issue-110350972
Preparing v4.x for LTS #3252 https://github.com/nodejs/node/issues/3252
trevnorrishttps://github.com/trevnorris
Oct 8, 2015 https://github.com/nodejs/node/pull/3216#ref-commit-3eaa593
https://github.com/trevnorris
https://github.com/jasnell
async_wrap: correctly pass parent to init callbackhttps://github.com/nodejs/node/commit/3eaa593a320d62a18324f9e9ac36b1fd56042d0d
3eaa593https://github.com/nodejs/node/commit/3eaa593a320d62a18324f9e9ac36b1fd56042d0d
#2986https://github.com/nodejs/node/issues/2986
#3216https://github.com/nodejs/node/pull/3216
https://github.com/jasnell
jasnellhttps://github.com/jasnell
lts-landed-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-landed-on-v4.x
Oct 8, 2015https://github.com/nodejs/node/pull/3216#event-429877674
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 8, 2015 https://github.com/nodejs/node/pull/3216#ref-pullrequest-110375513
Release proposal: v4.2.0 'Argon' (LTS) #3258 https://github.com/nodejs/node/pull/3258
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
Nov 17, 2015https://github.com/nodejs/node/pull/3216#event-466126929
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2015https://github.com/nodejs/node/pull/3216#issuecomment-157219244
3eaa593https://github.com/nodejs/node/commit/3eaa593a320d62a18324f9e9ac36b1fd56042d0d
Please reload this pagehttps://github.com/nodejs/node/pull/3216
https://github.com/apps/snyk-io
snyk-iohttps://github.com/apps/snyk-io
Oct 23, 2024 https://github.com/nodejs/node/pull/3216#ref-pullrequest-2609829401
[Snyk] Security upgrade semantic-release from 20.1.3 to 23.0.4 Graybar-codespace/node#125 https://github.com/Graybar-codespace/node/pull/125
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3216
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/3216
https://github.com/trevnorris
https://github.com/rvagg
https://github.com/MylesBorins
https://github.com/thefourtheye
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.