René's URL Explorer Experiment


Title: http: detach socket from IncomingMessage on keep-alive by ronag · Pull Request #32153 · nodejs/node · GitHub

Open Graph Title: http: detach socket from IncomingMessage on keep-alive by ronag · Pull Request #32153 · nodejs/node

X Title: http: detach socket from IncomingMessage on keep-alive by ronag · Pull Request #32153 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: If the socket is not detached then a future call to res.destroy (through e.g. pipeline) would unecessarily kill the socket while its in the agent free list. Checklist make -j4 test (UNIX), or v...

X Description: If the socket is not detached then a future call to res.destroy (through e.g. pipeline) would unecessarily kill the socket while its in the agent free list. Checklist make -j4 test (UNIX), or v...

Opengraph URL: https://github.com/nodejs/node/pull/32153

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b20e58ef-26c6-1961-0eb5-fb22e2d77085
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF3A:1C7D35:F9C883:14CC523:6AED4D28
html-safe-noncee83d11b69054674377e3e072fe3d450d2a931d3cc07727be9b165452169ea02e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjNBOjFDN0QzNTpGOUM4ODM6MTRDQzUyMzo2QUVENEQyOCIsInZpc2l0b3JfaWQiOiI1NTM3Mzg2NjgyMzc0NzY5OTYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4170c008c6bc153d0e9f9cff88f6006135bbd5c142075da425a5d6766cef6a32
hovercard-subject-tagpull_request:385323197
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32153/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e7d48197595602e7bb4753724cccae01a1ed5004f69882ede2dba445edcf2d8d/nodejs/node/pull/32153
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e7d48197595602e7bb4753724cccae01a1ed5004f69882ede2dba445edcf2d8d/nodejs/node/pull/32153
og:image:altIf the socket is not detached then a future call to res.destroy (through e.g. pipeline) would unecessarily kill the socket while its in the agent free list. Checklist make -j4 test (UNIX), or v...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/32153#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32153
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32153
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/32153
Reloadhttps://github.com/nodejs/node/pull/32153
Reloadhttps://github.com/nodejs/node/pull/32153
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-client-res-destroyhttps://github.com/nxtedition/node/tree/http-client-res-destroy
Conversationhttps://github.com/nodejs/node/pull/32153
Commits1 (1)https://github.com/nodejs/node/pull/32153/commits
Checkshttps://github.com/nodejs/node/pull/32153/checks
Files changedhttps://github.com/nodejs/node/pull/32153/files
http: detach socket from IncomingMessage on keep-alivehttps://github.com/nodejs/node/pull/32153#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-client-res-destroyhttps://github.com/nxtedition/node/tree/http-client-res-destroy
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 8, 2020https://github.com/nodejs/node/pull/32153#issue-577578549
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/32153
https://github.com/ronag
ronaghttps://github.com/ronag
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Mar 8, 2020https://github.com/nodejs/node/pull/32153#event-3108767575
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 8, 2020https://github.com/nodejs/node/pull/32153#issuecomment-596261300
@szmarczakhttps://github.com/szmarczak
Please reload this pagehttps://github.com/nodejs/node/pull/32153
https://github.com/ronag
ronaghttps://github.com/ronag
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Mar 8, 2020https://github.com/nodejs/node/pull/32153#event-3108767918
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 8, 2020https://github.com/nodejs/node/pull/32153#issuecomment-596261404
Please reload this pagehttps://github.com/nodejs/node/pull/32153
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 8, 2020 https://github.com/nodejs/node/pull/32153#ref-pullrequest-577487728
http: align OutgoingMessage and ClientRequest destroy #32148 https://github.com/nodejs/node/pull/32148
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/7304bc7706e9aaa844d7829dd47b2e6c0b754a9c..4ed671f10dc7ef6e76396b945df90a095cea056b
7304bc7https://github.com/nodejs/node/commit/7304bc7706e9aaa844d7829dd47b2e6c0b754a9c
4ed671fhttps://github.com/nodejs/node/commit/4ed671f10dc7ef6e76396b945df90a095cea056b
Compare https://github.com/nodejs/node/compare/7304bc7706e9aaa844d7829dd47b2e6c0b754a9c..4ed671f10dc7ef6e76396b945df90a095cea056b
March 8, 2020 22:43https://github.com/nodejs/node/pull/32153#event-3108770213
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Mar 8, 2020 https://github.com/nodejs/node/pull/32153#pullrequestreview-370864004
View reviewed changes https://github.com/nodejs/node/pull/32153/files
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Mar 8, 2020https://github.com/nodejs/node/pull/32153#issuecomment-596261823
Please reload this pagehttps://github.com/nodejs/node/pull/32153
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Mar 8, 2020 https://github.com/nodejs/node/pull/32153#ref-issue-575985748
Broken with Node.js ≥ 13.10.0 sindresorhus/got#1107 https://github.com/sindresorhus/got/issues/1107
https://github.com/ronag
http: detach socket from IncomingMessage on keep-alivehttps://github.com/nodejs/node/pull/32153/commits/30601b57fd0984c85ba0971b7ed80a2074d13901
30601b5https://github.com/nodejs/node/pull/32153/commits/30601b57fd0984c85ba0971b7ed80a2074d13901
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 8, 2020https://github.com/nodejs/node/pull/32153#event-3108773532
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/4ed671f10dc7ef6e76396b945df90a095cea056b..30601b57fd0984c85ba0971b7ed80a2074d13901
4ed671fhttps://github.com/nodejs/node/commit/4ed671f10dc7ef6e76396b945df90a095cea056b
30601b5https://github.com/nodejs/node/commit/30601b57fd0984c85ba0971b7ed80a2074d13901
Compare https://github.com/nodejs/node/compare/4ed671f10dc7ef6e76396b945df90a095cea056b..30601b57fd0984c85ba0971b7ed80a2074d13901
March 8, 2020 22:48https://github.com/nodejs/node/pull/32153#event-3108773533
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 9, 2020 https://github.com/nodejs/node/pull/32153#pullrequestreview-371040970
View reviewed changes https://github.com/nodejs/node/pull/32153/files/30601b57fd0984c85ba0971b7ed80a2074d13901
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 9, 2020https://github.com/nodejs/node/pull/32153#issuecomment-596438726
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2296/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2296/
Please reload this pagehttps://github.com/nodejs/node/pull/32153
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 9, 2020https://github.com/nodejs/node/pull/32153#issuecomment-596441768
https://ci.nodejs.org/job/node-test-pull-request/29640/https://ci.nodejs.org/job/node-test-pull-request/29640/
Please reload this pagehttps://github.com/nodejs/node/pull/32153
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 9, 2020 https://github.com/nodejs/node/pull/32153#pullrequestreview-371367469
View reviewed changes https://github.com/nodejs/node/pull/32153/files/30601b57fd0984c85ba0971b7ed80a2074d13901
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 9, 2020https://github.com/nodejs/node/pull/32153#event-3112551819
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 10, 2020https://github.com/nodejs/node/pull/32153#issuecomment-597208134
Please reload this pagehttps://github.com/nodejs/node/pull/32153
ronaghttps://github.com/ronag
Mar 10, 2020 https://github.com/nodejs/node/pull/32153#ref-commit-c1b2f6a
https://github.com/ronag
http: detach socket from IncomingMessage on keep-alivehttps://github.com/nodejs/node/commit/c1b2f6afbe03841a6f0ca5fa363ceb5bcdcfe638
c1b2f6ahttps://github.com/nodejs/node/commit/c1b2f6afbe03841a6f0ca5fa363ceb5bcdcfe638
#32153https://github.com/nodejs/node/pull/32153
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 10, 2020https://github.com/nodejs/node/pull/32153#issuecomment-597356842
c1b2f6ahttps://github.com/nodejs/node/commit/c1b2f6afbe03841a6f0ca5fa363ceb5bcdcfe638
Please reload this pagehttps://github.com/nodejs/node/pull/32153
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 10, 2020https://github.com/nodejs/node/pull/32153#event-3116721671
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Mar 11, 2020https://github.com/nodejs/node/pull/32153#issuecomment-597586408
Please reload this pagehttps://github.com/nodejs/node/pull/32153
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 11, 2020https://github.com/nodejs/node/pull/32153#issuecomment-597587381
@szmarczakhttps://github.com/szmarczak
Please reload this pagehttps://github.com/nodejs/node/pull/32153
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Mar 11, 2020 https://github.com/nodejs/node/pull/32153#ref-issue-578853759
Regression: socket hang up when uploading and streaming with pipeline #32184 https://github.com/nodejs/node/issues/32184
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Mar 17, 2020 https://github.com/nodejs/node/pull/32153#ref-pullrequest-578760228
2020-04-21, Version 14.0.0 (Current) #32181 https://github.com/nodejs/node/pull/32181
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Apr 28, 2020 https://github.com/nodejs/node/pull/32153#ref-issue-599746927
request.abort() still destroys the socket on a successful request #32851 https://github.com/nodejs/node/issues/32851
hyj1991https://github.com/hyj1991
May 14, 2020 https://github.com/nodejs/node/pull/32153#ref-commit-85ae99b
https://github.com/hyj1991
fix: res.socket is null in node-v14.xhttps://github.com/hyj1991/urllib/commit/85ae99bfb9bb59e15e86dbcd704b3476ea2cd387
85ae99bhttps://github.com/hyj1991/urllib/commit/85ae99bfb9bb59e15e86dbcd704b3476ea2cd387
nodejs/node#32153https://github.com/nodejs/node/pull/32153
https://github.com/hyj1991
hyj1991https://github.com/hyj1991
May 14, 2020 https://github.com/nodejs/node/pull/32153#ref-pullrequest-617947166
fix: res.socket is null in node-v14.x node-modules/urllib#339 https://github.com/node-modules/urllib/pull/339
hyj1991https://github.com/hyj1991
May 14, 2020 https://github.com/nodejs/node/pull/32153#ref-commit-9552eee
https://github.com/hyj1991
fix: res.socket is null in node-v14.xhttps://github.com/hyj1991/urllib/commit/9552eeeedbceabae5282aadaf0fd38de31eb18df
9552eeehttps://github.com/hyj1991/urllib/commit/9552eeeedbceabae5282aadaf0fd38de31eb18df
nodejs/node#32153https://github.com/nodejs/node/pull/32153
fengmk2https://github.com/fengmk2
May 15, 2020 https://github.com/nodejs/node/pull/32153#ref-commit-175ad2b
https://github.com/hyj1991
fix: res.socket is null in node-v14.x (https://github.com/node-modules/urllib/commit/175ad2b3e17196626c701ef72396dd6932d14c7a
#339https://github.com/node-modules/urllib/pull/339
)https://github.com/node-modules/urllib/commit/175ad2b3e17196626c701ef72396dd6932d14c7a
175ad2bhttps://github.com/node-modules/urllib/commit/175ad2b3e17196626c701ef72396dd6932d14c7a
nodejs/node#32153https://github.com/nodejs/node/pull/32153
https://github.com/Jimbly
Jimblyhttps://github.com/Jimbly
Jan 1, 2021 https://github.com/nodejs/node/pull/32153#pullrequestreview-560603020
View reviewed changes https://github.com/nodejs/node/pull/32153/files/30601b57fd0984c85ba0971b7ed80a2074d13901
test/parallel/test-http-agent-destroyed-socket.jshttps://github.com/nodejs/node/pull/32153/files/30601b57fd0984c85ba0971b7ed80a2074d13901#diff-74b6ea6e79dd73647ea3c568196ad7d1edbe6a8aed1ca6d28e6d306f9b0aa4ab
Jimblyhttps://github.com/Jimbly
Jan 1, 2021https://github.com/nodejs/node/pull/32153#discussion_r550802193
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
http-parser-jshttps://github.com/creationix/http-parser-js/blob/master/tests/parallel/test-http-agent-destroyed-socket.js
Please reload this pagehttps://github.com/nodejs/node/pull/32153
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Jul 2, 2026 https://github.com/nodejs/node/pull/32153#ref-pullrequest-4793382638
feat: maxRequestBodySize server option h3js/srvx#216 https://github.com/h3js/srvx/pull/216
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Jul 14, 2026 https://github.com/nodejs/node/pull/32153#ref-pullrequest-4886383490
feat(workspaces): move file storage and extraction to R2 ThinkEx-OSS/thinkex#643 https://github.com/ThinkEx-OSS/thinkex/pull/643
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Jul 26, 2026 https://github.com/nodejs/node/pull/32153#ref-pullrequest-4981073804
feat(stackstack): add the Safe Exposure Challenge susumutomita/TenkaCloudChallenge#306 https://github.com/susumutomita/TenkaCloudChallenge/pull/306
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32153
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/32153/files/30601b57fd0984c85ba0971b7ed80a2074d13901
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/32153/files/30601b57fd0984c85ba0971b7ed80a2074d13901
https://github.com/Jimbly
Jimbly https://github.com/Jimbly
https://github.com/nodejs/node/pull/32153/files/30601b57fd0984c85ba0971b7ed80a2074d13901
https://github.com/szmarczak
szmarczak https://github.com/szmarczak
https://github.com/nodejs/node/pull/32153/files/4ed671f10dc7ef6e76396b945df90a095cea056b
Please reload this pagehttps://github.com/nodejs/node/pull/32153
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/32153
https://github.com/ronag
https://github.com/szmarczak
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/Jimbly
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.