René's URL Explorer Experiment


Title: http: align OutgoingMessage and ClientRequest destroy by ronag · Pull Request #32148 · nodejs/node · GitHub

Open Graph Title: http: align OutgoingMessage and ClientRequest destroy by ronag · Pull Request #32148 · nodejs/node

X Title: http: align OutgoingMessage and ClientRequest destroy by ronag · Pull Request #32148 · nodejs/node

Description: Added .destroyed property to OutgoingMessage and ClientRequest to align with streams. Fixed ClientRequest.destroy to dump res and re-use socket in agent pool aligning it with abort. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Open Graph Description: Added .destroyed property to OutgoingMessage and ClientRequest to align with streams. Fixed ClientRequest.destroy to dump res and re-use socket in agent pool aligning it with abort. Checklist m...

X Description: Added .destroyed property to OutgoingMessage and ClientRequest to align with streams. Fixed ClientRequest.destroy to dump res and re-use socket in agent pool aligning it with abort. Checklist m...

Opengraph URL: https://github.com/nodejs/node/pull/32148

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files/:range(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:005edd30-95b8-6eef-8640-1a10c91d9a3f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAAF8:3B2C08:628853:845B9C:6AEDBF85
html-safe-nonce0cec5b9b3fc6b922015e1b8acb772bfb56582f998e726989a0ca2e75628ed7e6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUY4OjNCMkMwODo2Mjg4NTM6ODQ1QjlDOjZBRURCRjg1IiwidmlzaXRvcl9pZCI6IjI1MjkxNzc3MzY5ODY4Njk2MzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0cbe0339a0f889a1ba9c11c3dd1832dfdeea0c7b36ddd26ac34eeadead565326
hovercard-subject-tagpull_request:385257214
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486
twitter:imagehttps://avatars.githubusercontent.com/u/3065230?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3065230?s=400&v=4
og:image:altAdded .destroyed property to OutgoingMessage and ClientRequest to align with streams. Fixed ClientRequest.destroy to dump res and re-use socket in agent pool aligning it with abort. Checklist m...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None1eb5f7cedbc707472687eab1a30e6c4619c00791815622ceaba9694eb161930f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef31f9c89203c022acdb651c34ae048cf41764208
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32148%2Ffiles%2F88ce62458ad86f55dcc276940c5632151b60f486
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32148%2Ffiles%2F88ce62458ad86f55dcc276940c5632151b60f486
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486
Reloadhttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486
Reloadhttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests664 (664)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-client-destroy4https://github.com/nxtedition/node/tree/http-client-destroy4
Conversation 66 https://github.com/nodejs/node/pull/32148
Commits 9 https://github.com/nodejs/node/pull/32148/commits
Checks 0 https://github.com/nodejs/node/pull/32148/checks
Files changed https://github.com/nodejs/node/pull/32148/files
Please reload this pagehttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486
http: align OutgoingMessage and ClientRequest destroy https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#top
Show all changes 9 commits https://github.com/nodejs/node/pull/32148/files
1b275e0 http: align OutgoingMessage and ClientRequest destroy ronag Mar 8, 2020 https://github.com/nodejs/node/pull/32148/commits/1b275e09b59d3b95fcab74d1461f955900bba3b8
54de489 fixup: use destroy when available ronag Mar 8, 2020 https://github.com/nodejs/node/pull/32148/commits/54de4897871d24001e01aaa79758327b1e7e8f76
88ce624 fixup: reduce changes ronag Mar 8, 2020 https://github.com/nodejs/node/pull/32148/commits/88ce62458ad86f55dcc276940c5632151b60f486
2746f70 fixup ronag Mar 8, 2020 https://github.com/nodejs/node/pull/32148/commits/2746f705dfe17003a18aa6b18dc764a7c392145e
0998e9b fixup: make more similar to original ronag Mar 8, 2020 https://github.com/nodejs/node/pull/32148/commits/0998e9b150d335667978c55f29242373ff93e88a
0245e4e fixup: refactor for TODO ronag Mar 8, 2020 https://github.com/nodejs/node/pull/32148/commits/0245e4e142bde5fbb596b05cae19a51a75fdc1a3
6f11b24 fixup: reuse if not headersSent ronag Mar 8, 2020 https://github.com/nodejs/node/pull/32148/commits/6f11b2431985f0de6555f731d746cbc3adc5608d
2750006 Revert "fixup: reuse if not headersSent" ronag Mar 8, 2020 https://github.com/nodejs/node/pull/32148/commits/2750006c0eff27e9164b450c2efdaa4a41f4ec47
f24b4a7 fixup: test ronag Mar 8, 2020 https://github.com/nodejs/node/pull/32148/commits/f24b4a7199e74802402f0799e62d990052d41182
Clear filters https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486
Please reload this pagehttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486
Please reload this pagehttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486
_http_client.js https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
_http_outgoing.js https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-48d21edbddb6e855d1ee5716c49bcdc0d913c11ee8a24a98ea7dbc60cd253556
destroy.js https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-f9aa56489c061a70f83b602c8a32200b4f092a23b6eb8769f978ac1adb322a46
test-http-client-abort-destroy.js https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-5131b1dcb747ec6d13f58709404382737749e97bff51443a03a8741ff9521a46
test-http-client-abort-keep-alive-queued-tcp-socket.js https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-722aa187b6d0e3d992f68ec8ea21a47520bd1fc2897e1dbd7d35f4f4be933470
test-http-client-close-event.js https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-ceec51beac25060bb9e58acede396864bfd70e277a755c95679d99f46bbeeeef
test-http-outgoing-proto.js https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-34dad4dcb768e9254dd0db1b029b0010c03af8b3eb439c7c76843e09677dc228
lib/_http_client.jshttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
View file https://github.com/nxtedition/node/blob/88ce62458ad86f55dcc276940c5632151b60f486/lib/_http_client.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/32148/files/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
Please reload this pagehttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486
Please reload this pagehttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486
ronaghttps://github.com/ronag
Mar 8, 2020https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#r389361225
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
lib/_http_outgoing.jshttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-48d21edbddb6e855d1ee5716c49bcdc0d913c11ee8a24a98ea7dbc60cd253556
View file https://github.com/nxtedition/node/blob/88ce62458ad86f55dcc276940c5632151b60f486/lib/_http_outgoing.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/32148/files/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-48d21edbddb6e855d1ee5716c49bcdc0d913c11ee8a24a98ea7dbc60cd253556
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-48d21edbddb6e855d1ee5716c49bcdc0d913c11ee8a24a98ea7dbc60cd253556
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-48d21edbddb6e855d1ee5716c49bcdc0d913c11ee8a24a98ea7dbc60cd253556
Please reload this pagehttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-48d21edbddb6e855d1ee5716c49bcdc0d913c11ee8a24a98ea7dbc60cd253556
lib/internal/streams/destroy.jshttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-f9aa56489c061a70f83b602c8a32200b4f092a23b6eb8769f978ac1adb322a46
View file https://github.com/nxtedition/node/blob/88ce62458ad86f55dcc276940c5632151b60f486/lib/internal/streams/destroy.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/32148/files/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-f9aa56489c061a70f83b602c8a32200b4f092a23b6eb8769f978ac1adb322a46
Please reload this pagehttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-f9aa56489c061a70f83b602c8a32200b4f092a23b6eb8769f978ac1adb322a46
test/parallel/test-http-client-abort-destroy.jshttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-5131b1dcb747ec6d13f58709404382737749e97bff51443a03a8741ff9521a46
View file https://github.com/nxtedition/node/blob/88ce62458ad86f55dcc276940c5632151b60f486/test/parallel/test-http-client-abort-destroy.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/32148/files/{{ revealButtonHref }}
test/parallel/test-http-client-abort-keep-alive-queued-tcp-socket.jshttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-722aa187b6d0e3d992f68ec8ea21a47520bd1fc2897e1dbd7d35f4f4be933470
View file https://github.com/nxtedition/node/blob/88ce62458ad86f55dcc276940c5632151b60f486/test/parallel/test-http-client-abort-keep-alive-queued-tcp-socket.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/32148/files/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-722aa187b6d0e3d992f68ec8ea21a47520bd1fc2897e1dbd7d35f4f4be933470
test/parallel/test-http-client-close-event.jshttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-ceec51beac25060bb9e58acede396864bfd70e277a755c95679d99f46bbeeeef
View file https://github.com/nxtedition/node/blob/88ce62458ad86f55dcc276940c5632151b60f486/test/parallel/test-http-client-close-event.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/32148/files/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-ceec51beac25060bb9e58acede396864bfd70e277a755c95679d99f46bbeeeef
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-ceec51beac25060bb9e58acede396864bfd70e277a755c95679d99f46bbeeeef
test/parallel/test-http-outgoing-proto.jshttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-34dad4dcb768e9254dd0db1b029b0010c03af8b3eb439c7c76843e09677dc228
View file https://github.com/nxtedition/node/blob/88ce62458ad86f55dcc276940c5632151b60f486/test/parallel/test-http-outgoing-proto.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/32148/files/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-34dad4dcb768e9254dd0db1b029b0010c03af8b3eb439c7c76843e09677dc228
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.