René's URL Explorer Experiment


Title: http: align OutgoingMessage and ClientRequest destroy by ronag · Pull Request #32148 · nodejs/node · GitHub

Open Graph Title: http: align OutgoingMessage and ClientRequest destroy by ronag · Pull Request #32148 · nodejs/node

X Title: http: align OutgoingMessage and ClientRequest destroy by ronag · Pull Request #32148 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Added .destroyed property to OutgoingMessage and ClientRequest to align with streams. Fixed ClientRequest.destroy to dump res and re-use socket in agent pool aligning it with abort. Checklist m...

X Description: Added .destroyed property to OutgoingMessage and ClientRequest to align with streams. Fixed ClientRequest.destroy to dump res and re-use socket in agent pool aligning it with abort. Checklist m...

Opengraph URL: https://github.com/nodejs/node/pull/32148

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:778d655a-4ed6-ac80-87c9-5e87162f9be0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA492:A2B38:EC4105:133A1B9:6AED5612
html-safe-nonced0e605c252727d4529168265ffa9a5c45d3b6b28072c0f7899969191ca653120
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDkyOkEyQjM4OkVDNDEwNToxMzNBMUI5OjZBRUQ1NjEyIiwidmlzaXRvcl9pZCI6IjczNTU2MDE5NDU0MzY3MDYzMjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8cc81bfdb7c502c918e8c77d88c4b91c3a966fc1b7d5f61ad60e3a33fe32e0d5
hovercard-subject-tagpull_request:385257214
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32148/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d5b02b4d1a934e138b5cc1ff9f363cd7aaf84e505ee8818c056103c4d7cb9f5a/nodejs/node/pull/32148
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d5b02b4d1a934e138b5cc1ff9f363cd7aaf84e505ee8818c056103c4d7cb9f5a/nodejs/node/pull/32148
og:image:altAdded .destroyed property to OutgoingMessage and ClientRequest to align with streams. Fixed ClientRequest.destroy to dump res and re-use socket in agent pool aligning it with abort. Checklist m...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/32148#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32148
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32148
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/32148
Reloadhttps://github.com/nodejs/node/pull/32148
Reloadhttps://github.com/nodejs/node/pull/32148
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-client-destroy4https://github.com/nxtedition/node/tree/http-client-destroy4
Conversationhttps://github.com/nodejs/node/pull/32148
Commits9 (9)https://github.com/nodejs/node/pull/32148/commits
Checkshttps://github.com/nodejs/node/pull/32148/checks
Files changedhttps://github.com/nodejs/node/pull/32148/files
http: align OutgoingMessage and ClientRequest destroyhttps://github.com/nodejs/node/pull/32148#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-client-destroy4https://github.com/nxtedition/node/tree/http-client-destroy4
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 8, 2020https://github.com/nodejs/node/pull/32148#issue-577487728
Please reload this pagehttps://github.com/nodejs/node/pull/32148
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/ronag
http: align OutgoingMessage and ClientRequest destroyhttps://github.com/nodejs/node/pull/32148/commits/1b275e09b59d3b95fcab74d1461f955900bba3b8
1b275e0https://github.com/nodejs/node/pull/32148/commits/1b275e09b59d3b95fcab74d1461f955900bba3b8
https://github.com/ronag
ronaghttps://github.com/ronag
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Mar 8, 2020https://github.com/nodejs/node/pull/32148#event-3108361274
https://github.com/ronag
ronaghttps://github.com/ronag
jasnellhttps://github.com/jasnell
mcollinahttps://github.com/mcollina
March 8, 2020 11:42https://github.com/nodejs/node/pull/32148#event-3108361277
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 8, 2020 https://github.com/nodejs/node/pull/32148#pullrequestreview-370823651
View reviewed changes https://github.com/nodejs/node/pull/32148/files/1b275e09b59d3b95fcab74d1461f955900bba3b8
lib/_http_client.jshttps://github.com/nodejs/node/pull/32148/files/1b275e09b59d3b95fcab74d1461f955900bba3b8#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
ronaghttps://github.com/ronag
Mar 8, 2020https://github.com/nodejs/node/pull/32148#discussion_r389361225
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 8, 2020https://github.com/nodejs/node/pull/32148#issuecomment-596196400
https://ci.nodejs.org/job/node-test-pull-request/29630/https://ci.nodejs.org/job/node-test-pull-request/29630/
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/ronag
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32148
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 8, 2020https://github.com/nodejs/node/pull/32148#issuecomment-596197221
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/b79509621814350c0e831e255f0fd09c94babcde..36a003ada055d2bba9381ca30f891c831a165a38
b795096https://github.com/nodejs/node/commit/b79509621814350c0e831e255f0fd09c94babcde
36a003ahttps://github.com/nodejs/node/commit/36a003ada055d2bba9381ca30f891c831a165a38
Compare https://github.com/nodejs/node/compare/b79509621814350c0e831e255f0fd09c94babcde..36a003ada055d2bba9381ca30f891c831a165a38
March 8, 2020 12:08https://github.com/nodejs/node/pull/32148#event-3108375138
https://github.com/ronag
fixup: use destroy when availablehttps://github.com/nodejs/node/pull/32148/commits/54de4897871d24001e01aaa79758327b1e7e8f76
54de489https://github.com/nodejs/node/pull/32148/commits/54de4897871d24001e01aaa79758327b1e7e8f76
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/36a003ada055d2bba9381ca30f891c831a165a38..54de4897871d24001e01aaa79758327b1e7e8f76
36a003ahttps://github.com/nodejs/node/commit/36a003ada055d2bba9381ca30f891c831a165a38
54de489https://github.com/nodejs/node/commit/54de4897871d24001e01aaa79758327b1e7e8f76
Compare https://github.com/nodejs/node/compare/36a003ada055d2bba9381ca30f891c831a165a38..54de4897871d24001e01aaa79758327b1e7e8f76
March 8, 2020 12:08https://github.com/nodejs/node/pull/32148#event-3108375510
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Mar 8, 2020https://github.com/nodejs/node/pull/32148#issuecomment-596206191
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 8, 2020 https://github.com/nodejs/node/pull/32148#pullrequestreview-370825448
View reviewed changes https://github.com/nodejs/node/pull/32148/files
lib/internal/streams/destroy.jshttps://github.com/nodejs/node/pull/32148/files#diff-f9aa56489c061a70f83b602c8a32200b4f092a23b6eb8769f978ac1adb322a46
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 8, 2020 https://github.com/nodejs/node/pull/32148#pullrequestreview-370832030
View reviewed changes https://github.com/nodejs/node/pull/32148/files/54de4897871d24001e01aaa79758327b1e7e8f76
lib/_http_client.jshttps://github.com/nodejs/node/pull/32148/files/54de4897871d24001e01aaa79758327b1e7e8f76#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 8, 2020https://github.com/nodejs/node/pull/32148#issuecomment-596208829
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/ronag
fixup: reduce changeshttps://github.com/nodejs/node/pull/32148/commits/88ce62458ad86f55dcc276940c5632151b60f486
88ce624https://github.com/nodejs/node/pull/32148/commits/88ce62458ad86f55dcc276940c5632151b60f486
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/dae0286ea14e72da2d49f5ce8f4c730fa6fc6b92..88ce62458ad86f55dcc276940c5632151b60f486
dae0286https://github.com/nodejs/node/commit/dae0286ea14e72da2d49f5ce8f4c730fa6fc6b92
88ce624https://github.com/nodejs/node/commit/88ce62458ad86f55dcc276940c5632151b60f486
Compare https://github.com/nodejs/node/compare/dae0286ea14e72da2d49f5ce8f4c730fa6fc6b92..88ce62458ad86f55dcc276940c5632151b60f486
March 8, 2020 14:01https://github.com/nodejs/node/pull/32148#event-3108439969
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 8, 2020https://github.com/nodejs/node/pull/32148#issuecomment-596208952
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/ronag
fixuphttps://github.com/nodejs/node/pull/32148/commits/2746f705dfe17003a18aa6b18dc764a7c392145e
2746f70https://github.com/nodejs/node/pull/32148/commits/2746f705dfe17003a18aa6b18dc764a7c392145e
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/844adca9b84f364bbfdea545c916b5d3b13cda2a..97bfd14c71e6f2baf2d946eb61e47b5f8ca9bacc
844adcahttps://github.com/nodejs/node/commit/844adca9b84f364bbfdea545c916b5d3b13cda2a
97bfd14https://github.com/nodejs/node/commit/97bfd14c71e6f2baf2d946eb61e47b5f8ca9bacc
Compare https://github.com/nodejs/node/compare/844adca9b84f364bbfdea545c916b5d3b13cda2a..97bfd14c71e6f2baf2d946eb61e47b5f8ca9bacc
March 8, 2020 14:21https://github.com/nodejs/node/pull/32148#event-3108452546
https://github.com/ronag
fixup: make more similar to originalhttps://github.com/nodejs/node/pull/32148/commits/0998e9b150d335667978c55f29242373ff93e88a
0998e9bhttps://github.com/nodejs/node/pull/32148/commits/0998e9b150d335667978c55f29242373ff93e88a
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/97bfd14c71e6f2baf2d946eb61e47b5f8ca9bacc..0998e9b150d335667978c55f29242373ff93e88a
97bfd14https://github.com/nodejs/node/commit/97bfd14c71e6f2baf2d946eb61e47b5f8ca9bacc
0998e9bhttps://github.com/nodejs/node/commit/0998e9b150d335667978c55f29242373ff93e88a
Compare https://github.com/nodejs/node/compare/97bfd14c71e6f2baf2d946eb61e47b5f8ca9bacc..0998e9b150d335667978c55f29242373ff93e88a
March 8, 2020 14:21https://github.com/nodejs/node/pull/32148#event-3108452902
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Mar 8, 2020 https://github.com/nodejs/node/pull/32148#pullrequestreview-370833187
View reviewed changes https://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486
lib/_http_outgoing.jshttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-48d21edbddb6e855d1ee5716c49bcdc0d913c11ee8a24a98ea7dbc60cd253556
Please reload this pagehttps://github.com/nodejs/node/pull/32148
lib/_http_client.jshttps://github.com/nodejs/node/pull/32148/files/88ce62458ad86f55dcc276940c5632151b60f486#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
Please reload this pagehttps://github.com/nodejs/node/pull/32148
lib/_http_client.jshttps://github.com/nodejs/node/pull/32148/files/0998e9b150d335667978c55f29242373ff93e88a#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/ronag
fixup: refactor for TODOhttps://github.com/nodejs/node/pull/32148/commits/0245e4e142bde5fbb596b05cae19a51a75fdc1a3
0245e4ehttps://github.com/nodejs/node/pull/32148/commits/0245e4e142bde5fbb596b05cae19a51a75fdc1a3
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/92207e2317af38b7f307aa20268883f7fa30b200..0245e4e142bde5fbb596b05cae19a51a75fdc1a3
92207e2https://github.com/nodejs/node/commit/92207e2317af38b7f307aa20268883f7fa30b200
0245e4ehttps://github.com/nodejs/node/commit/0245e4e142bde5fbb596b05cae19a51a75fdc1a3
Compare https://github.com/nodejs/node/compare/92207e2317af38b7f307aa20268883f7fa30b200..0245e4e142bde5fbb596b05cae19a51a75fdc1a3
March 8, 2020 15:56https://github.com/nodejs/node/pull/32148#event-3108513813
https://github.com/ronag
fixup: reuse if not headersSenthttps://github.com/nodejs/node/pull/32148/commits/6f11b2431985f0de6555f731d746cbc3adc5608d
6f11b24https://github.com/nodejs/node/pull/32148/commits/6f11b2431985f0de6555f731d746cbc3adc5608d
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/a5199da77cfc52c6aad88a955ff8b92b786390de..6f11b2431985f0de6555f731d746cbc3adc5608d
a5199dahttps://github.com/nodejs/node/commit/a5199da77cfc52c6aad88a955ff8b92b786390de
6f11b24https://github.com/nodejs/node/commit/6f11b2431985f0de6555f731d746cbc3adc5608d
Compare https://github.com/nodejs/node/compare/a5199da77cfc52c6aad88a955ff8b92b786390de..6f11b2431985f0de6555f731d746cbc3adc5608d
March 8, 2020 16:59https://github.com/nodejs/node/pull/32148#event-3108554176
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 8, 2020 https://github.com/nodejs/node/pull/32148#pullrequestreview-370844597
View reviewed changes https://github.com/nodejs/node/pull/32148/files/6f11b2431985f0de6555f731d746cbc3adc5608d
lib/_http_client.jshttps://github.com/nodejs/node/pull/32148/files/6f11b2431985f0de6555f731d746cbc3adc5608d#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32148
ronaghttps://github.com/ronag
March 8, 2020 19:00https://github.com/nodejs/node/pull/32148#commits-pushed-2750006
https://github.com/ronag
Revert "fixup: reuse if not headersSent"https://github.com/nodejs/node/pull/32148/commits/2750006c0eff27e9164b450c2efdaa4a41f4ec47
2750006https://github.com/nodejs/node/pull/32148/commits/2750006c0eff27e9164b450c2efdaa4a41f4ec47
6f11b24https://github.com/nxtedition/node/commit/6f11b2431985f0de6555f731d746cbc3adc5608d
https://github.com/ronag
fixup: testhttps://github.com/nodejs/node/pull/32148/commits/f24b4a7199e74802402f0799e62d990052d41182
f24b4a7https://github.com/nodejs/node/pull/32148/commits/f24b4a7199e74802402f0799e62d990052d41182
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 8, 2020https://github.com/nodejs/node/pull/32148#issuecomment-596258942
https://ci.nodejs.org/job/node-test-pull-request/29635/https://ci.nodejs.org/job/node-test-pull-request/29635/
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Mar 8, 2020 https://github.com/nodejs/node/pull/32148#pullrequestreview-370862876
View reviewed changes https://github.com/nodejs/node/pull/32148/files/f24b4a7199e74802402f0799e62d990052d41182
szmarczakhttps://github.com/szmarczak
https://github.com/nodejs/node/pull/32148#pullrequestreview-370862876
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Mar 8, 2020https://github.com/nodejs/node/pull/32148#issuecomment-596261165
Please reload this pagehttps://github.com/nodejs/node/pull/32148
node/lib/_http_incoming.jshttps://github.com/nodejs/node/blob/7bb4f95c1cdf860082a27e2592488c2ba6734c20/lib/_http_incoming.js#L118-L124
7bb4f95https://github.com/nodejs/node/commit/7bb4f95c1cdf860082a27e2592488c2ba6734c20
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 8, 2020https://github.com/nodejs/node/pull/32148#issuecomment-596261474
@szmarczakhttps://github.com/szmarczak
#32153https://github.com/nodejs/node/pull/32153
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/codecov-io
codecov-iohttps://github.com/codecov-io
Mar 9, 2020https://github.com/nodejs/node/pull/32148#issuecomment-596312323
Codecovhttps://codecov.io/gh/nodejs/node/pull/32148?src=pr&el=h1
Click here to learn what that meanshttps://docs.codecov.io/docs/error-reference#section-missing-base-commit
https://codecov.io/gh/nodejs/node/pull/32148?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/nodejs/node/pull/32148?src=pr&el=tree
lib/wasi.jshttps://codecov.io/gh/nodejs/node/pull/32148/diff?src=pr&el=tree#diff-bGliL3dhc2kuanM=
Continue to review full report at Codecovhttps://codecov.io/gh/nodejs/node/pull/32148?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/nodejs/node/pull/32148?src=pr&el=footer
4d93e10...f24b4a7https://codecov.io/gh/nodejs/node/pull/32148?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 9, 2020 https://github.com/nodejs/node/pull/32148#pullrequestreview-371127477
View reviewed changes https://github.com/nodejs/node/pull/32148/files/f24b4a7199e74802402f0799e62d990052d41182
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 9, 2020https://github.com/nodejs/node/pull/32148#issuecomment-596505493
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2298/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2298/
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Mar 10, 2020 https://github.com/nodejs/node/pull/32148#ref-issue-575985748
Broken with Node.js ≥ 13.10.0 sindresorhus/got#1107 https://github.com/sindresorhus/got/issues/1107
https://github.com/ronag
ronaghttps://github.com/ronag
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 10, 2020https://github.com/nodejs/node/pull/32148#event-3113658069
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 10, 2020https://github.com/nodejs/node/pull/32148#issuecomment-596959605
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 10, 2020https://github.com/nodejs/node/pull/32148#issuecomment-597047887
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 10, 2020 https://github.com/nodejs/node/pull/32148#pullrequestreview-372128902
View reviewed changes https://github.com/nodejs/node/pull/32148/files/f24b4a7199e74802402f0799e62d990052d41182
lib/internal/streams/destroy.jshttps://github.com/nodejs/node/pull/32148/files/f24b4a7199e74802402f0799e62d990052d41182#diff-f9aa56489c061a70f83b602c8a32200b4f092a23b6eb8769f978ac1adb322a46
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 10, 2020 https://github.com/nodejs/node/pull/32148#pullrequestreview-372154510
View reviewed changes https://github.com/nodejs/node/pull/32148/files/f24b4a7199e74802402f0799e62d990052d41182
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/32148#pullrequestreview-372154510
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/32148
ronaghttps://github.com/ronag
Mar 10, 2020 https://github.com/nodejs/node/pull/32148#ref-commit-173d044
https://github.com/ronag
http: align OutgoingMessage and ClientRequest destroyhttps://github.com/nodejs/node/commit/173d044d0976e30bc2ab0a40807ec617b0b8a55a
173d044https://github.com/nodejs/node/commit/173d044d0976e30bc2ab0a40807ec617b0b8a55a
#32148https://github.com/nodejs/node/pull/32148
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 10, 2020https://github.com/nodejs/node/pull/32148#issuecomment-597207175
173d044https://github.com/nodejs/node/commit/173d044d0976e30bc2ab0a40807ec617b0b8a55a
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 10, 2020https://github.com/nodejs/node/pull/32148#event-3115678076
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Mar 10, 2020https://github.com/nodejs/node/pull/32148#issuecomment-597270963
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 10, 2020https://github.com/nodejs/node/pull/32148#issuecomment-597271626
@szmarczakhttps://github.com/szmarczak
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Mar 17, 2020 https://github.com/nodejs/node/pull/32148#ref-pullrequest-578760228
2020-04-21, Version 14.0.0 (Current) #32181 https://github.com/nodejs/node/pull/32181
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 16, 2020 https://github.com/nodejs/node/pull/32148#ref-pullrequest-598770492
http: doc deprecate abort and improve docs #32807 https://github.com/nodejs/node/pull/32807
https://github.com/mastermatt
mastermatthttps://github.com/mastermatt
May 8, 2020 https://github.com/nodejs/node/pull/32148#ref-pullrequest-613713872
fix(ClientRequest): Use native abort and destroy nock/nock#2000 https://github.com/nock/nock/pull/2000
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32148
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/32148/files/f24b4a7199e74802402f0799e62d990052d41182
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/32148/files/f24b4a7199e74802402f0799e62d990052d41182
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/szmarczak
szmarczak https://github.com/szmarczak
https://github.com/nodejs/node/pull/32148/files/f24b4a7199e74802402f0799e62d990052d41182
Please reload this pagehttps://github.com/nodejs/node/pull/32148
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/32148
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/szmarczak
https://github.com/codecov-io
https://github.com/mcollina
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.