René's URL Explorer Experiment


Title: stream: make stream.destroy with callback API public by ronag · Pull Request #32021 · nodejs/node · GitHub

Open Graph Title: stream: make stream.destroy with callback API public by ronag · Pull Request #32021 · nodejs/node

X Title: stream: make stream.destroy with callback API public by ronag · Pull Request #32021 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This makes the stream.destroy(err, callback) API public. Additionally it makes some changes: The callback is always (see TODO) invoked with the same behavior as eos The callback is no longer immed...

X Description: This makes the stream.destroy(err, callback) API public. Additionally it makes some changes: The callback is always (see TODO) invoked with the same behavior as eos The callback is no longer immed...

Opengraph URL: https://github.com/nodejs/node/pull/32021

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:917a24bf-4360-e90f-ad39-7ae9a1767998
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA7E:2463B8:EC2ABD:1342B7C:6AED56A2
html-safe-nonce495f0d2f42421c1b57139ba6e89fc762686dcea008d7db93c62c23182ff2891e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTdFOjI0NjNCODpFQzJBQkQ6MTM0MkI3Qzo2QUVENTZBMiIsInZpc2l0b3JfaWQiOiIxNTMyOTY1MDAzMzAyMDk4NTk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac99c27617c7be6ba5995929761d0201ea55748c92c136f988070ffba80ce7e7ac
hovercard-subject-tagpull_request:381824002
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/32021/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1fa553948d0e13a9e2fa5a2d206fa3f91280ef2cd6899c8fa993dac17a605474/nodejs/node/pull/32021
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1fa553948d0e13a9e2fa5a2d206fa3f91280ef2cd6899c8fa993dac17a605474/nodejs/node/pull/32021
og:image:altThis makes the stream.destroy(err, callback) API public. Additionally it makes some changes: The callback is always (see TODO) invoked with the same behavior as eos The callback is no longer immed...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/32021#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32021
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32021
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/32021
Reloadhttps://github.com/nodejs/node/pull/32021
Reloadhttps://github.com/nodejs/node/pull/32021
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-cb-destroyhttps://github.com/nxtedition/node/tree/stream-cb-destroy
Conversationhttps://github.com/nodejs/node/pull/32021
Commits7 (7)https://github.com/nodejs/node/pull/32021/commits
Checkshttps://github.com/nodejs/node/pull/32021/checks
Files changedhttps://github.com/nodejs/node/pull/32021/files
stream: make stream.destroy with callback API publichttps://github.com/nodejs/node/pull/32021#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-cb-destroyhttps://github.com/nxtedition/node/tree/stream-cb-destroy
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 29, 2020https://github.com/nodejs/node/pull/32021#issue-573259495
Please reload this pagehttps://github.com/nodejs/node/pull/32021
#31509https://github.com/nodejs/node/pull/31509
https://github.com/nodejs/node/blob/master/lib/internal/fs/streams.js#L275https://github.com/nodejs/node/blob/master/lib/internal/fs/streams.js#L275
https://github.com/nodejs/node/blob/master/lib/internal/stream_base_commons.js#L154https://github.com/nodejs/node/blob/master/lib/internal/stream_base_commons.js#L154
https://github.com/nodejs/node/blob/master/lib/internal/stream_base_commons.js#L93https://github.com/nodejs/node/blob/master/lib/internal/stream_base_commons.js#L93
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/32021
https://github.com/ronag
ronaghttps://github.com/ronag
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Feb 29, 2020https://github.com/nodejs/node/pull/32021#event-3084582636
https://github.com/ronag
ronaghttps://github.com/ronag
lpincahttps://github.com/lpinca
mcollinahttps://github.com/mcollina
February 29, 2020 09:15https://github.com/nodejs/node/pull/32021#event-3084582640
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/fa2d4b6f7331825a9c9bb91e395609a5c4e23780..740e44170eab9fb2f7a9eff257a030d71f9cc9ba
fa2d4b6https://github.com/nodejs/node/commit/fa2d4b6f7331825a9c9bb91e395609a5c4e23780
740e441https://github.com/nodejs/node/commit/740e44170eab9fb2f7a9eff257a030d71f9cc9ba
Compare https://github.com/nodejs/node/compare/fa2d4b6f7331825a9c9bb91e395609a5c4e23780..740e44170eab9fb2f7a9eff257a030d71f9cc9ba
February 29, 2020 09:21https://github.com/nodejs/node/pull/32021#event-3084586020
https://github.com/ronag
ronaghttps://github.com/ronag
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Feb 29, 2020https://github.com/nodejs/node/pull/32021#event-3084586367
https://github.com/ronag
stream: make stream.destroy with callback API publichttps://github.com/nodejs/node/pull/32021/commits/4d51ce200dc852149646705790e61d9d9e177711
4d51ce2https://github.com/nodejs/node/pull/32021/commits/4d51ce200dc852149646705790e61d9d9e177711
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/740e44170eab9fb2f7a9eff257a030d71f9cc9ba..4d51ce200dc852149646705790e61d9d9e177711
740e441https://github.com/nodejs/node/commit/740e44170eab9fb2f7a9eff257a030d71f9cc9ba
4d51ce2https://github.com/nodejs/node/commit/4d51ce200dc852149646705790e61d9d9e177711
Compare https://github.com/nodejs/node/compare/740e44170eab9fb2f7a9eff257a030d71f9cc9ba..4d51ce200dc852149646705790e61d9d9e177711
February 29, 2020 09:26https://github.com/nodejs/node/pull/32021#event-3084588808
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32021
ronaghttps://github.com/ronag
February 29, 2020 10:42https://github.com/nodejs/node/pull/32021#commits-pushed-54f62fc
https://github.com/ronag
fixup: docshttps://github.com/nodejs/node/pull/32021/commits/54f62fcff0d3b7c65beb560f68aaaf62f5142a7c
54f62fchttps://github.com/nodejs/node/pull/32021/commits/54f62fcff0d3b7c65beb560f68aaaf62f5142a7c
https://github.com/ronag
fixup: docshttps://github.com/nodejs/node/pull/32021/commits/c0203240817edf2a201b3aaf1c88ae87901b3805
c020324https://github.com/nodejs/node/pull/32021/commits/c0203240817edf2a201b3aaf1c88ae87901b3805
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 29, 2020https://github.com/nodejs/node/pull/32021#issuecomment-592927768
Please reload this pagehttps://github.com/nodejs/node/pull/32021
https://github.com/ronag
fixup: tls test + writable write complete errhttps://github.com/nodejs/node/pull/32021/commits/80cf7f68d517a4bd4d54ba6a27c376a37892acd6
80cf7f6https://github.com/nodejs/node/pull/32021/commits/80cf7f68d517a4bd4d54ba6a27c376a37892acd6
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 29, 2020 https://github.com/nodejs/node/pull/32021#pullrequestreview-366789816
View reviewed changes https://github.com/nodejs/node/pull/32021/files/80cf7f68d517a4bd4d54ba6a27c376a37892acd6
lib/_stream_writable.jshttps://github.com/nodejs/node/pull/32021/files/80cf7f68d517a4bd4d54ba6a27c376a37892acd6#diff-a7fdfe149712099064db4e7b80a1b39e28515b4efb3fab2f4b9499ce3b7c51c3
Please reload this pagehttps://github.com/nodejs/node/pull/32021
https://github.com/ronag
fixup: testhttps://github.com/nodejs/node/pull/32021/commits/43472c4b04a8950780c3683cf6c04333fa4df976
43472c4https://github.com/nodejs/node/pull/32021/commits/43472c4b04a8950780c3683cf6c04333fa4df976
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/00cd9b399719c2a86a16ff15a0d2e625e6d44c31..43472c4b04a8950780c3683cf6c04333fa4df976
00cd9b3https://github.com/nodejs/node/commit/00cd9b399719c2a86a16ff15a0d2e625e6d44c31
43472c4https://github.com/nodejs/node/commit/43472c4b04a8950780c3683cf6c04333fa4df976
Compare https://github.com/nodejs/node/compare/00cd9b399719c2a86a16ff15a0d2e625e6d44c31..43472c4b04a8950780c3683cf6c04333fa4df976
February 29, 2020 10:22https://github.com/nodejs/node/pull/32021#event-3084622105
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 29, 2020 https://github.com/nodejs/node/pull/32021#pullrequestreview-366790462
View reviewed changes https://github.com/nodejs/node/pull/32021/files/43472c4b04a8950780c3683cf6c04333fa4df976
test/parallel/test-tls-writewrap-leak.jshttps://github.com/nodejs/node/pull/32021/files/43472c4b04a8950780c3683cf6c04333fa4df976#diff-b7698cef62236b126425545953483a2ef802de030854f627bffdc02672d97c01
Please reload this pagehttps://github.com/nodejs/node/pull/32021
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/cf8de82b1a9d24605291e133ed712cbb89fbb444..c21a15c5081145b0a45d62c6339ed46e9d76155c
cf8de82https://github.com/nodejs/node/commit/cf8de82b1a9d24605291e133ed712cbb89fbb444
c21a15chttps://github.com/nodejs/node/commit/c21a15c5081145b0a45d62c6339ed46e9d76155c
Compare https://github.com/nodejs/node/compare/cf8de82b1a9d24605291e133ed712cbb89fbb444..c21a15c5081145b0a45d62c6339ed46e9d76155c
February 29, 2020 10:35https://github.com/nodejs/node/pull/32021#event-3084628779
https://github.com/ronag
fixup: reduce changeshttps://github.com/nodejs/node/pull/32021/commits/b40a103eab79f98a240ff615dc3066cae9fbe849
b40a103https://github.com/nodejs/node/pull/32021/commits/b40a103eab79f98a240ff615dc3066cae9fbe849
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/8a13506bad9110fa2b15f819d84547ca893c68a1..97d1fd40169cbf1da9a5f80f670bae3ef57b765f
8a13506https://github.com/nodejs/node/commit/8a13506bad9110fa2b15f819d84547ca893c68a1
97d1fd4https://github.com/nodejs/node/commit/97d1fd40169cbf1da9a5f80f670bae3ef57b765f
Compare https://github.com/nodejs/node/compare/8a13506bad9110fa2b15f819d84547ca893c68a1..97d1fd40169cbf1da9a5f80f670bae3ef57b765f
February 29, 2020 10:57https://github.com/nodejs/node/pull/32021#event-3084642227
https://github.com/ronag
fixup: always register eoshttps://github.com/nodejs/node/pull/32021/commits/81de706be6d4a9c0aa1d8804668e4107417b0aee
81de706https://github.com/nodejs/node/pull/32021/commits/81de706be6d4a9c0aa1d8804668e4107417b0aee
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/97d1fd40169cbf1da9a5f80f670bae3ef57b765f..81de706be6d4a9c0aa1d8804668e4107417b0aee
97d1fd4https://github.com/nodejs/node/commit/97d1fd40169cbf1da9a5f80f670bae3ef57b765f
81de706https://github.com/nodejs/node/commit/81de706be6d4a9c0aa1d8804668e4107417b0aee
Compare https://github.com/nodejs/node/compare/97d1fd40169cbf1da9a5f80f670bae3ef57b765f..81de706be6d4a9c0aa1d8804668e4107417b0aee
February 29, 2020 10:58https://github.com/nodejs/node/pull/32021#event-3084642919
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 1, 2020https://github.com/nodejs/node/pull/32021#issuecomment-593082733
#29179https://github.com/nodejs/node/pull/29179
Please reload this pagehttps://github.com/nodejs/node/pull/32021
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 1, 2020https://github.com/nodejs/node/pull/32021#event-3085463086
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F32021
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/lpinca
lpinca https://github.com/lpinca
Please reload this pagehttps://github.com/nodejs/node/pull/32021
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/32021
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.