René's URL Explorer Experiment


Title: src: move InternalCallbackScope to StartExecution by codebytere · Pull Request #31944 · nodejs/node · GitHub

Open Graph Title: src: move InternalCallbackScope to StartExecution by codebytere · Pull Request #31944 · nodejs/node

X Title: src: move InternalCallbackScope to StartExecution by codebytere · Pull Request #31944 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Refs #30467. As Electron embeds Node.js, when running in ELECTRON_RUN_AS_NODE we need to mimic NodeMainInstance::Run() as much as possible. However, the externally-facing CallbackScope does not a...

X Description: Refs #30467. As Electron embeds Node.js, when running in ELECTRON_RUN_AS_NODE we need to mimic NodeMainInstance::Run() as much as possible. However, the externally-facing CallbackScope does not a...

Opengraph URL: https://github.com/nodejs/node/pull/31944

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:13375a0b-863b-8de0-5682-2af858a1600d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDBE6:3BD8F2:14BFFAF:1C284F2:6A4F020E
html-safe-nonce65f21ebd3a1704f1a3beee009e64415077f1ef20d807041a15a8967a8e36bfad
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkU2OjNCRDhGMjoxNEJGRkFGOjFDMjg0RjI6NkE0RjAyMEUiLCJ2aXNpdG9yX2lkIjoiMzE5OTQ1NDI0NTkwNTQzMzEwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac52d40a3d1bd8737aefd77f272b7a5adbc42cd137c4138f0718e33706a52d7ecb
hovercard-subject-tagpull_request:379342337
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31944/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e0a47d66db9a912dc10c1fdee0e624143d4658c14d16f2079814a401adc62055/nodejs/node/pull/31944
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e0a47d66db9a912dc10c1fdee0e624143d4658c14d16f2079814a401adc62055/nodejs/node/pull/31944
og:image:altRefs #30467. As Electron embeds Node.js, when running in ELECTRON_RUN_AS_NODE we need to mimic NodeMainInstance::Run() as much as possible. However, the externally-facing CallbackScope does not a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecodebytere
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31944#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31944
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31944
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31944
Reloadhttps://github.com/nodejs/node/pull/31944
Reloadhttps://github.com/nodejs/node/pull/31944
Please reload this pagehttps://github.com/nodejs/node/pull/31944
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/31944
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
codebyterehttps://github.com/codebytere
nodejs:masterhttps://github.com/nodejs/node/tree/master
codebytere:move-cb-scopehttps://github.com/codebytere/node/tree/move-cb-scope
Conversationhttps://github.com/nodejs/node/pull/31944
Commits1 (1)https://github.com/nodejs/node/pull/31944/commits
Checkshttps://github.com/nodejs/node/pull/31944/checks
Files changedhttps://github.com/nodejs/node/pull/31944/files
src: move InternalCallbackScope to StartExecutionhttps://github.com/nodejs/node/pull/31944#top
codebyterehttps://github.com/codebytere
nodejs:masterhttps://github.com/nodejs/node/tree/master
codebytere:move-cb-scopehttps://github.com/codebytere/node/tree/move-cb-scope
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Feb 25, 2020https://github.com/nodejs/node/pull/31944#issue-570282953
Please reload this pagehttps://github.com/nodejs/node/pull/31944
#30467https://github.com/nodejs/node/pull/30467
@addaleaxhttps://github.com/addaleax
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/31944
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Feb 25, 2020https://github.com/nodejs/node/pull/31944#event-3067810211
https://github.com/codebytere
codebyterehttps://github.com/codebytere
addaleaxhttps://github.com/addaleax
February 25, 2020 03:17https://github.com/nodejs/node/pull/31944#event-3067810734
https://github.com/codebytere
codebyterehttps://github.com/codebytere
force-pushedhttps://github.com/nodejs/node/compare/f53a34e1bee18659d3f238aa5e95ef4f9f0789dc..fc81fd8597a5cd3b9c05f14f45e8d466ac6b94c3
f53a34ehttps://github.com/nodejs/node/commit/f53a34e1bee18659d3f238aa5e95ef4f9f0789dc
fc81fd8https://github.com/nodejs/node/commit/fc81fd8597a5cd3b9c05f14f45e8d466ac6b94c3
Compare https://github.com/nodejs/node/compare/f53a34e1bee18659d3f238aa5e95ef4f9f0789dc..fc81fd8597a5cd3b9c05f14f45e8d466ac6b94c3
February 25, 2020 03:54https://github.com/nodejs/node/pull/31944#event-3067870960
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 25, 2020 https://github.com/nodejs/node/pull/31944#pullrequestreview-363864813
View reviewed changes https://github.com/nodejs/node/pull/31944/files
https://github.com/Qard
Qardhttps://github.com/Qard
Feb 25, 2020 https://github.com/nodejs/node/pull/31944#pullrequestreview-363897592
View reviewed changes https://github.com/nodejs/node/pull/31944/files
src/node.cchttps://github.com/nodejs/node/pull/31944/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
Please reload this pagehttps://github.com/nodejs/node/pull/31944
https://github.com/codebytere
src: move InternalCallbackScope to StartExecutionhttps://github.com/nodejs/node/pull/31944/commits/0f14c550731d1f418764d33ee46712d97ffae469
0f14c55https://github.com/nodejs/node/pull/31944/commits/0f14c550731d1f418764d33ee46712d97ffae469
https://github.com/codebytere
codebyterehttps://github.com/codebytere
force-pushedhttps://github.com/nodejs/node/compare/fc81fd8597a5cd3b9c05f14f45e8d466ac6b94c3..0f14c550731d1f418764d33ee46712d97ffae469
fc81fd8https://github.com/nodejs/node/commit/fc81fd8597a5cd3b9c05f14f45e8d466ac6b94c3
0f14c55https://github.com/nodejs/node/commit/0f14c550731d1f418764d33ee46712d97ffae469
Compare https://github.com/nodejs/node/compare/fc81fd8597a5cd3b9c05f14f45e8d466ac6b94c3..0f14c550731d1f418764d33ee46712d97ffae469
February 25, 2020 16:08https://github.com/nodejs/node/pull/31944#event-3070095073
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Qardhttps://github.com/Qard
February 25, 2020 16:08https://github.com/nodejs/node/pull/31944#event-3070095111
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Qardhttps://github.com/Qard
stale reviewhttps://github.com/nodejs/node/pull/31944#pullrequestreview-363897592
February 26, 2020 03:27https://github.com/nodejs/node/pull/31944#event-3071994647
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 26, 2020https://github.com/nodejs/node/pull/31944#issuecomment-591220121
https://ci.nodejs.org/job/node-test-pull-request/29362/https://ci.nodejs.org/job/node-test-pull-request/29362/
Please reload this pagehttps://github.com/nodejs/node/pull/31944
https://github.com/Qard
Qardhttps://github.com/Qard
Feb 26, 2020 https://github.com/nodejs/node/pull/31944#pullrequestreview-364692967
View reviewed changes https://github.com/nodejs/node/pull/31944/files/0f14c550731d1f418764d33ee46712d97ffae469
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Feb 26, 2020 https://github.com/nodejs/node/pull/31944#pullrequestreview-364976271
View reviewed changes https://github.com/nodejs/node/pull/31944/files/0f14c550731d1f418764d33ee46712d97ffae469
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 27, 2020https://github.com/nodejs/node/pull/31944#issuecomment-591784313
https://ci.nodejs.org/job/node-test-pull-request/29404/https://ci.nodejs.org/job/node-test-pull-request/29404/
Please reload this pagehttps://github.com/nodejs/node/pull/31944
codebyterehttps://github.com/codebytere
Feb 27, 2020 https://github.com/nodejs/node/pull/31944#ref-commit-18ddb1d
https://github.com/codebytere
src: move InternalCallbackScope to StartExecutionhttps://github.com/nodejs/node/commit/18ddb1da38ad6eb78c357f182b5379a8ab3332ce
18ddb1dhttps://github.com/nodejs/node/commit/18ddb1da38ad6eb78c357f182b5379a8ab3332ce
#31944https://github.com/nodejs/node/pull/31944
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Feb 27, 2020https://github.com/nodejs/node/pull/31944#issuecomment-592038329
18ddb1dhttps://github.com/nodejs/node/commit/18ddb1da38ad6eb78c357f182b5379a8ab3332ce
Please reload this pagehttps://github.com/nodejs/node/pull/31944
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Feb 27, 2020https://github.com/nodejs/node/pull/31944#event-3078410433
https://github.com/codebytere
codebyterehttps://github.com/codebytere
February 27, 2020 16:05https://github.com/nodejs/node/pull/31944#event-3078410746
codebyterehttps://github.com/codebytere
Feb 27, 2020 https://github.com/nodejs/node/pull/31944#ref-commit-3497370
https://github.com/codebytere
src: move InternalCallbackScope to StartExecutionhttps://github.com/nodejs/node/commit/3497370d66117f9f734c3307867ff21b7e5956de
3497370https://github.com/nodejs/node/commit/3497370d66117f9f734c3307867ff21b7e5956de
#31944https://github.com/nodejs/node/pull/31944
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Feb 29, 2020 https://github.com/nodejs/node/pull/31944#ref-pullrequest-573431833
v13.10.0 proposal #32027 https://github.com/nodejs/node/pull/32027
https://github.com/targos
targoshttps://github.com/targos
backported-to-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v12.x
Mar 7, 2020https://github.com/nodejs/node/pull/31944#event-3107567758
https://github.com/puzpuzpuz
puzpuzpuzhttps://github.com/puzpuzpuz
Mar 7, 2020 https://github.com/nodejs/node/pull/31944#ref-pullrequest-577117410
[v12.x backport] async_hooks: add executionAsyncResource #32131 https://github.com/nodejs/node/pull/32131
puzpuzpuzhttps://github.com/puzpuzpuz
Apr 14, 2020 https://github.com/nodejs/node/pull/31944#ref-commit-0e12a43
https://github.com/codebytere
https://github.com/puzpuzpuz
src: move InternalCallbackScope to StartExecutionhttps://github.com/puzpuzpuz/node/commit/0e12a430938e9e86a90ae9cde60959d3b8fba08e
0e12a43https://github.com/puzpuzpuz/node/commit/0e12a430938e9e86a90ae9cde60959d3b8fba08e
nodejs#31944https://github.com/nodejs/node/pull/31944
puzpuzpuzhttps://github.com/puzpuzpuz
Apr 14, 2020 https://github.com/nodejs/node/pull/31944#ref-commit-adc1afb
https://github.com/codebytere
https://github.com/puzpuzpuz
src: move InternalCallbackScope to StartExecutionhttps://github.com/puzpuzpuz/node/commit/adc1afbcc491f190c6899186fa5d1350334c1a6a
adc1afbhttps://github.com/puzpuzpuz/node/commit/adc1afbcc491f190c6899186fa5d1350334c1a6a
nodejs#31944https://github.com/nodejs/node/pull/31944
targoshttps://github.com/targos
Apr 25, 2020 https://github.com/nodejs/node/pull/31944#ref-commit-c0e1e6e
https://github.com/codebytere
https://github.com/targos
src: move InternalCallbackScope to StartExecutionhttps://github.com/targos/node/commit/c0e1e6e01835bd6d26f9ab7a1d4382f22940b718
c0e1e6ehttps://github.com/targos/node/commit/c0e1e6e01835bd6d26f9ab7a1d4382f22940b718
nodejs#31944https://github.com/nodejs/node/pull/31944
targoshttps://github.com/targos
Apr 28, 2020 https://github.com/nodejs/node/pull/31944#ref-commit-ffefb05
https://github.com/codebytere
https://github.com/targos
src: move InternalCallbackScope to StartExecutionhttps://github.com/nodejs/node/commit/ffefb059e23743b1eb00ce2c616a3d3ae5820543
ffefb05https://github.com/nodejs/node/commit/ffefb059e23743b1eb00ce2c616a3d3ae5820543
#31944https://github.com/nodejs/node/pull/31944
https://github.com/targos
targoshttps://github.com/targos
May 2, 2020 https://github.com/nodejs/node/pull/31944#ref-pullrequest-610737650
v12.17.0 release proposal #33197 https://github.com/nodejs/node/pull/33197
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Dec 15, 2020 https://github.com/nodejs/node/pull/31944#ref-pullrequest-768117349
refactor: remove last use of InternalCallbackScope electron/electron#27029 https://github.com/electron/electron/pull/27029
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31944
https://github.com/Qard
Qard https://github.com/Qard
https://github.com/nodejs/node/pull/31944/files/0f14c550731d1f418764d33ee46712d97ffae469
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/31944/files/fc81fd8597a5cd3b9c05f14f45e8d466ac6b94c3
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/31944/files/0f14c550731d1f418764d33ee46712d97ffae469
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/31944
https://github.com/codebytere
https://github.com/nodejs-github-bot
https://github.com/Qard
https://github.com/addaleax
https://github.com/joyeecheung
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.