| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:777c19d1-9e83-9cc8-6d0f-6e643eef0cba |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B8C6:232221:B43524:B828A3:6A4DB711 |
| html-safe-nonce | 6c722222cce00fd30d257c3025bc4ba8ce999e1c600ef4de8168c7ff1a12ef8b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEM2OjIzMjIyMTpCNDM1MjQ6QjgyOEEzOjZBNERCNzExIiwidmlzaXRvcl9pZCI6IjEzNDczODUxNjU4NTMwNzkzMTMiLCJyZWdpb25fZWRnZSI6InNlYSIsInJlZ2lvbl9yZW5kZXIiOiJzZWEifQ== |
| visitor-hmac | 0e2633204d34206a958307a1b2136b83c8a2dc1bb854b92bd4412ed62a38e89e |
| hovercard-subject-tag | pull_request:379338572 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31943/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6ced0b9da140ec98194212514dd895e8f73adba6d91d63c08e5afe9b2ffad58d/nodejs/node/pull/31943 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6ced0b9da140ec98194212514dd895e8f73adba6d91d63c08e5afe9b2ffad58d/nodejs/node/pull/31943 |
| og:image:alt | Refs #31820.
This PR updates repl evaluation to eagerly wrap all input in parentheses and adds a regression test using the example given in the above issue. I plan to open a follow-up PR to allow t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | codebytere |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 32f7b614aca06e6bbd89842b1370df1328264f68 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/31943#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31943 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31943 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/31943 |
| Reload | https://github.com/nodejs/node/pull/31943 |
| Reload | https://github.com/nodejs/node/pull/31943 |
| Please reload this page | https://github.com/nodejs/node/pull/31943 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/31943 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
962
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| codebytere | https://github.com/codebytere |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| codebytere:fix-repl-eval-issue | https://github.com/codebytere/node/tree/fix-repl-eval-issue |
| Conversation | https://github.com/nodejs/node/pull/31943 |
| Commits1 (1) | https://github.com/nodejs/node/pull/31943/commits |
| Checks | https://github.com/nodejs/node/pull/31943/checks |
| Files changed | https://github.com/nodejs/node/pull/31943/files |
| repl: eager-evaluate input in parens | https://github.com/nodejs/node/pull/31943#top |
| codebytere | https://github.com/codebytere |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| codebytere:fix-repl-eval-issue | https://github.com/codebytere/node/tree/fix-repl-eval-issue |
|
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| Feb 25, 2020 | https://github.com/nodejs/node/pull/31943#issue-570278141 |
| #31820 | https://github.com/nodejs/node/issues/31820 |
| @BridgeAR | https://github.com/BridgeAR |
| @devsnek | https://github.com/devsnek |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/31943 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
repl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl |
| Feb 25, 2020 | https://github.com/nodejs/node/pull/31943#event-3067784653 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| BridgeAR | https://github.com/BridgeAR |
| devsnek | https://github.com/devsnek |
| February 25, 2020 03:34 | https://github.com/nodejs/node/pull/31943#event-3067839363 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
|
Feb 25, 2020
| https://github.com/nodejs/node/pull/31943#pullrequestreview-363866459 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31943/files |
| devsnek | https://github.com/devsnek |
| https://github.com/nodejs/node/pull/31943#pullrequestreview-363866459 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/31943 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 25, 2020
| https://github.com/nodejs/node/pull/31943#pullrequestreview-364349525 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31943/files |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Feb 25, 2020
| https://github.com/nodejs/node/pull/31943#pullrequestreview-364406640 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31943/files |
| BridgeAR | https://github.com/BridgeAR |
| https://github.com/nodejs/node/pull/31943#pullrequestreview-364406640 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/31943 |
| lib/repl.js | https://github.com/nodejs/node/pull/31943/files#diff-392b628f0a5eb047b1117351e6eedcefb8ec70a48933479e0e9bdc711a04f047 |
| Please reload this page | https://github.com/nodejs/node/pull/31943 |
| test/parallel/test-repl-preview.js | https://github.com/nodejs/node/pull/31943/files#diff-4b0398958c1cbfc4690145d2d5a4dc1819bb76b89ed855f8b412b4ed6463f577 |
| Please reload this page | https://github.com/nodejs/node/pull/31943 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| force-pushed | https://github.com/nodejs/node/compare/2bba06cdbc3f4478b8c99df96b8b10f9e4751d27..8098e49773c2efe40b57bdb0bbcdb8a4dbe0c8d5 |
| 2bba06c | https://github.com/nodejs/node/commit/2bba06cdbc3f4478b8c99df96b8b10f9e4751d27 |
| 8098e49 | https://github.com/nodejs/node/commit/8098e49773c2efe40b57bdb0bbcdb8a4dbe0c8d5 |
|
Compare
| https://github.com/nodejs/node/compare/2bba06cdbc3f4478b8c99df96b8b10f9e4751d27..8098e49773c2efe40b57bdb0bbcdb8a4dbe0c8d5 |
| February 26, 2020 02:15 | https://github.com/nodejs/node/pull/31943#event-3071865445 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| BridgeAR | https://github.com/BridgeAR |
| February 26, 2020 02:15 | https://github.com/nodejs/node/pull/31943#event-3071865834 |
|
| https://github.com/codebytere |
| repl: eager-evaluate input in parens | https://github.com/nodejs/node/pull/31943/commits/e39244e78007a7560a3c681d5dbbecc90a3e4934 |
| e39244e | https://github.com/nodejs/node/pull/31943/commits/e39244e78007a7560a3c681d5dbbecc90a3e4934 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| force-pushed | https://github.com/nodejs/node/compare/8098e49773c2efe40b57bdb0bbcdb8a4dbe0c8d5..e39244e78007a7560a3c681d5dbbecc90a3e4934 |
| 8098e49 | https://github.com/nodejs/node/commit/8098e49773c2efe40b57bdb0bbcdb8a4dbe0c8d5 |
| e39244e | https://github.com/nodejs/node/commit/e39244e78007a7560a3c681d5dbbecc90a3e4934 |
|
Compare
| https://github.com/nodejs/node/compare/8098e49773c2efe40b57bdb0bbcdb8a4dbe0c8d5..e39244e78007a7560a3c681d5dbbecc90a3e4934 |
| February 26, 2020 02:46 | https://github.com/nodejs/node/pull/31943#event-3071925659 |
| https://github.com/nodejs |
| nodejs | https://github.com/nodejs |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 26, 2020 | https://github.com/nodejs/node/pull/31943#event-3071925719 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 26, 2020 | https://github.com/nodejs/node/pull/31943#issuecomment-591210038 |
| https://ci.nodejs.org/job/node-test-pull-request/29361/ | https://ci.nodejs.org/job/node-test-pull-request/29361/ |
| Please reload this page | https://github.com/nodejs/node/pull/31943 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Feb 26, 2020
| https://github.com/nodejs/node/pull/31943#pullrequestreview-365116464 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31943/files/e39244e78007a7560a3c681d5dbbecc90a3e4934 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| Feb 27, 2020 | https://github.com/nodejs/node/pull/31943#issuecomment-591784807 |
| 20a51b9 | https://github.com/nodejs/node/commit/20a51b9dff69c3cc9c38e1e57c389db16ea02807 |
| Please reload this page | https://github.com/nodejs/node/pull/31943 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| Feb 27, 2020 | https://github.com/nodejs/node/pull/31943#event-3076415537 |
| codebytere | https://github.com/codebytere |
|
Feb 27, 2020
| https://github.com/nodejs/node/pull/31943#ref-commit-20a51b9 |
|
| https://github.com/codebytere |
| repl: eager-evaluate input in parens | https://github.com/nodejs/node/commit/20a51b9dff69c3cc9c38e1e57c389db16ea02807 |
| 20a51b9 | https://github.com/nodejs/node/commit/20a51b9dff69c3cc9c38e1e57c389db16ea02807 |
| #31943 | https://github.com/nodejs/node/pull/31943 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| February 27, 2020 05:11 | https://github.com/nodejs/node/pull/31943#event-3076415654 |
| codebytere | https://github.com/codebytere |
|
Feb 27, 2020
| https://github.com/nodejs/node/pull/31943#ref-commit-6adbfac |
|
| https://github.com/codebytere |
| repl: eager-evaluate input in parens | https://github.com/nodejs/node/commit/6adbfac9b06d44366b3cfb32d6fa2f549336b593 |
| 6adbfac | https://github.com/nodejs/node/commit/6adbfac9b06d44366b3cfb32d6fa2f549336b593 |
| #31943 | https://github.com/nodejs/node/pull/31943 |
|
Wrong hint message when parsing expression such as {a:1}['a'] === 1 in node
#31820
| https://github.com/nodejs/node/issues/31820 |
|
repl: allow recovery for wrapped eval
#31990
| https://github.com/nodejs/node/pull/31990 |
|
v13.10.0 proposal
#32027
| https://github.com/nodejs/node/pull/32027 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backport-blocked-v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v12.x |
| Apr 18, 2020 | https://github.com/nodejs/node/pull/31943#event-3246741561 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Apr 18, 2020 | https://github.com/nodejs/node/pull/31943#issuecomment-615831568 |
| Please reload this page | https://github.com/nodejs/node/pull/31943 |
| targos | https://github.com/targos |
|
Apr 25, 2020
| https://github.com/nodejs/node/pull/31943#ref-commit-5f0cdb6 |
|
| https://github.com/codebytere |
|
| https://github.com/targos |
| repl: eager-evaluate input in parens | https://github.com/targos/node/commit/5f0cdb651e41ad11de79630e6c7fdf1a426f10df |
| 5f0cdb6 | https://github.com/targos/node/commit/5f0cdb651e41ad11de79630e6c7fdf1a426f10df |
| nodejs#31943 | https://github.com/nodejs/node/pull/31943 |
| targos | https://github.com/targos |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/31943#ref-commit-709d3e5 |
|
| https://github.com/codebytere |
|
| https://github.com/targos |
| repl: eager-evaluate input in parens | https://github.com/nodejs/node/commit/709d3e5eb318c9763290a9b9ad69960a5d18e543 |
| 709d3e5 | https://github.com/nodejs/node/commit/709d3e5eb318c9763290a9b9ad69960a5d18e543 |
| #31943 | https://github.com/nodejs/node/pull/31943 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 2, 2020
| https://github.com/nodejs/node/pull/31943#ref-pullrequest-610737650 |
|
v12.17.0 release proposal
#33197
| https://github.com/nodejs/node/pull/33197 |
| https://github.com/cola119 |
| cola119 | https://github.com/cola119 |
|
Dec 24, 2022
| https://github.com/nodejs/node/pull/31943#ref-issue-1510124395 |
|
Wrong interpretation of { a: 1 }['a'] in the REPL (BlockStatement v.s. ExpressionStatement)
#45964
| https://github.com/nodejs/node/issues/45964 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31943 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/31943/files/2bba06cdbc3f4478b8c99df96b8b10f9e4751d27 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/31943/files/e39244e78007a7560a3c681d5dbbecc90a3e4934 |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/nodejs/node/pull/31943/files/2bba06cdbc3f4478b8c99df96b8b10f9e4751d27 |
|
repl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl |
| Please reload this page | https://github.com/nodejs/node/pull/31943 |
|
| https://github.com/codebytere |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/targos |
|
| https://github.com/jasnell |
|
| https://github.com/devsnek |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |