René's URL Explorer Experiment


Title: crypto: simplify exportKeyingMaterial by tniessen · Pull Request #31922 · nodejs/node · GitHub

Open Graph Title: crypto: simplify exportKeyingMaterial by tniessen · Pull Request #31922 · nodejs/node

X Title: crypto: simplify exportKeyingMaterial by tniessen · Pull Request #31922 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Use bool instead of int. Don't call Buffer::HasInstance. We shouldn't silently ignore non-buffers, and ByteSource::FromBuffer will CHECK that the input is a Buffer anyway. Rename key to con...

X Description: Use bool instead of int. Don't call Buffer::HasInstance. We shouldn't silently ignore non-buffers, and ByteSource::FromBuffer will CHECK that the input is a Buffer anyway. Rename ke...

Opengraph URL: https://github.com/nodejs/node/pull/31922

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d4f09a6e-76b7-95a1-6d23-34d04a2d0176
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCAC4:15393D:19D9D03:249F468:6A50CC48
html-safe-nonce12a604dba253adc0b277e756954d65ebed8c07f983fec894f842610a6248fd44
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUM0OjE1MzkzRDoxOUQ5RDAzOjI0OUY0Njg6NkE1MENDNDgiLCJ2aXNpdG9yX2lkIjoiNDU3NjYzMjEzNzgxODYyMzA0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfec0ce9e3f08f13444965374ad91e5c7c334498b36120138e35f9f33815673cd
hovercard-subject-tagpull_request:378724699
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31922/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7a1b1f23721ac8ca9a995c5ec196235f88feb4b45e9f40a11becba1687412479/nodejs/node/pull/31922
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7a1b1f23721ac8ca9a995c5ec196235f88feb4b45e9f40a11becba1687412479/nodejs/node/pull/31922
og:image:altUse bool instead of int. Don't call Buffer::HasInstance. We shouldn't silently ignore non-buffers, and ByteSource::FromBuffer will CHECK that the input is a Buffer anyway. Rename key to con...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release08e79d53fc070870d5b168356afebb1e286a2ffe
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31922#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31922
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31922
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31922
Reloadhttps://github.com/nodejs/node/pull/31922
Reloadhttps://github.com/nodejs/node/pull/31922
Please reload this pagehttps://github.com/nodejs/node/pull/31922
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/31922
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 979 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-simplify-exportkeyingmaterialhttps://github.com/tniessen/node/tree/crypto-simplify-exportkeyingmaterial
Conversationhttps://github.com/nodejs/node/pull/31922
Commits2 (2)https://github.com/nodejs/node/pull/31922/commits
Checkshttps://github.com/nodejs/node/pull/31922/checks
Files changedhttps://github.com/nodejs/node/pull/31922/files
crypto: simplify exportKeyingMaterialhttps://github.com/nodejs/node/pull/31922#top
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-simplify-exportkeyingmaterialhttps://github.com/tniessen/node/tree/crypto-simplify-exportkeyingmaterial
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Feb 23, 2020https://github.com/nodejs/node/pull/31922#issue-569521347
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/31922
https://github.com/tniessen
crypto: simplify exportKeyingMaterialhttps://github.com/nodejs/node/pull/31922/commits/7d46e3efc05bec08cb5f729b873bbac7a109a3b6
7d46e3ehttps://github.com/nodejs/node/pull/31922/commits/7d46e3efc05bec08cb5f729b873bbac7a109a3b6
https://github.com/tniessen
tniessenhttps://github.com/tniessen
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Feb 23, 2020https://github.com/nodejs/node/pull/31922#event-3063537009
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 24, 2020 https://github.com/nodejs/node/pull/31922#pullrequestreview-363170787
View reviewed changes https://github.com/nodejs/node/pull/31922/files/7d46e3efc05bec08cb5f729b873bbac7a109a3b6
src/node_crypto.cchttps://github.com/nodejs/node/pull/31922/files/7d46e3efc05bec08cb5f729b873bbac7a109a3b6#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
Please reload this pagehttps://github.com/nodejs/node/pull/31922
https://github.com/tniessen
https://github.com/addaleax
Update src/node_crypto.cchttps://github.com/nodejs/node/pull/31922/commits/8a7076881a5a02bb292813d402fcf3ef9418f57d
8a70768https://github.com/nodejs/node/pull/31922/commits/8a7076881a5a02bb292813d402fcf3ef9418f57d
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31922
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 24, 2020 https://github.com/nodejs/node/pull/31922#pullrequestreview-363421744
View reviewed changes https://github.com/nodejs/node/pull/31922/files/8a7076881a5a02bb292813d402fcf3ef9418f57d
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 24, 2020 https://github.com/nodejs/node/pull/31922#pullrequestreview-363459457
View reviewed changes https://github.com/nodejs/node/pull/31922/files/8a7076881a5a02bb292813d402fcf3ef9418f57d
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31922
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31922
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Feb 24, 2020 https://github.com/nodejs/node/pull/31922#pullrequestreview-363643317
View reviewed changes https://github.com/nodejs/node/pull/31922/files/8a7076881a5a02bb292813d402fcf3ef9418f57d
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31922
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31922
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31922
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31922
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31922
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 29, 2020https://github.com/nodejs/node/pull/31922#issuecomment-592982711
https://ci.nodejs.org/job/node-test-pull-request/29461/https://ci.nodejs.org/job/node-test-pull-request/29461/
Please reload this pagehttps://github.com/nodejs/node/pull/31922
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 1, 2020https://github.com/nodejs/node/pull/31922#issuecomment-593023005
51cae73https://github.com/nodejs/node/commit/51cae73a8cc0c581b0365dbffce06db229f9bac1
Please reload this pagehttps://github.com/nodejs/node/pull/31922
Trotthttps://github.com/Trott
Mar 1, 2020 https://github.com/nodejs/node/pull/31922#ref-commit-51cae73
https://github.com/tniessen
https://github.com/Trott
crypto: simplify exportKeyingMaterialhttps://github.com/nodejs/node/commit/51cae73a8cc0c581b0365dbffce06db229f9bac1
51cae73https://github.com/nodejs/node/commit/51cae73a8cc0c581b0365dbffce06db229f9bac1
#31922https://github.com/nodejs/node/pull/31922
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 1, 2020https://github.com/nodejs/node/pull/31922#event-3085157329
MylesBorinshttps://github.com/MylesBorins
Mar 4, 2020 https://github.com/nodejs/node/pull/31922#ref-commit-0fc45f8
https://github.com/tniessen
https://github.com/MylesBorins
crypto: simplify exportKeyingMaterialhttps://github.com/nodejs/node/commit/0fc45f80b59db586c46d8b0fca265446a46ed121
0fc45f8https://github.com/nodejs/node/commit/0fc45f80b59db586c46d8b0fca265446a46ed121
#31922https://github.com/nodejs/node/pull/31922
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 4, 2020 https://github.com/nodejs/node/pull/31922#ref-pullrequest-575822587
v13.10.1 proposal #32099 https://github.com/nodejs/node/pull/32099
https://github.com/targos
targoshttps://github.com/targos
backport-blocked-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v12.x
Apr 20, 2020https://github.com/nodejs/node/pull/31922#event-3253298158
https://github.com/targos
targoshttps://github.com/targos
Apr 20, 2020https://github.com/nodejs/node/pull/31922#issuecomment-616768806
#31814https://github.com/nodejs/node/pull/31814
Please reload this pagehttps://github.com/nodejs/node/pull/31922
https://github.com/targos
targoshttps://github.com/targos
backport-blocked-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v12.x
Apr 25, 2020https://github.com/nodejs/node/pull/31922#event-3272280968
targoshttps://github.com/targos
Apr 25, 2020 https://github.com/nodejs/node/pull/31922#ref-commit-cfaa156
https://github.com/tniessen
https://github.com/targos
crypto: simplify exportKeyingMaterialhttps://github.com/targos/node/commit/cfaa1566de08d444ee0e0460b59636e23d599de5
cfaa156https://github.com/targos/node/commit/cfaa1566de08d444ee0e0460b59636e23d599de5
nodejs#31922https://github.com/nodejs/node/pull/31922
targoshttps://github.com/targos
Apr 28, 2020 https://github.com/nodejs/node/pull/31922#ref-commit-0847bc3
https://github.com/tniessen
https://github.com/targos
crypto: simplify exportKeyingMaterialhttps://github.com/nodejs/node/commit/0847bc37882c6aef1dc29c30ae051edc9bb09698
0847bc3https://github.com/nodejs/node/commit/0847bc37882c6aef1dc29c30ae051edc9bb09698
#31922https://github.com/nodejs/node/pull/31922
https://github.com/targos
targoshttps://github.com/targos
May 2, 2020 https://github.com/nodejs/node/pull/31922#ref-pullrequest-610737650
v12.17.0 release proposal #33197 https://github.com/nodejs/node/pull/33197
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31922
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/31922/files/8a7076881a5a02bb292813d402fcf3ef9418f57d
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/31922/files/8a7076881a5a02bb292813d402fcf3ef9418f57d
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/31922/files/7d46e3efc05bec08cb5f729b873bbac7a109a3b6
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/31922/files/8a7076881a5a02bb292813d402fcf3ef9418f57d
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/31922/files/8a7076881a5a02bb292813d402fcf3ef9418f57d
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Please reload this pagehttps://github.com/nodejs/node/pull/31922
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/targos
https://github.com/jasnell
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/devnexen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.