René's URL Explorer Experiment


Title: stream: fix finished typo by ronag · Pull Request #31881 · nodejs/node · GitHub

Open Graph Title: stream: fix finished typo by ronag · Pull Request #31881 · nodejs/node

X Title: stream: fix finished typo by ronag · Pull Request #31881 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: #31509 introduced a slight typo. Fortunately this typo does not have big impact due to isWritableFinished(). Fixes: #31509 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) pas...

X Description: #31509 introduced a slight typo. Fortunately this typo does not have big impact due to isWritableFinished(). Fixes: #31509 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) pas...

Opengraph URL: https://github.com/nodejs/node/pull/31881

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b2962c5c-a2da-788b-e3f0-e51b801a87bd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE22A:2C47BC:DC57A9:121AF84:6AED56AA
html-safe-noncef8bc05134155dc8d99c16ef839f981ce71323f1fb40ac4d5787aa8a5c6a8098a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjJBOjJDNDdCQzpEQzU3QTk6MTIxQUY4NDo2QUVENTZBQSIsInZpc2l0b3JfaWQiOiI4Njk1MTYyODQ3MzI0MTAwMjY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9f650aa627059598ab3eca005579b558fac4ef93830f230712cdf0de22abecc3
hovercard-subject-tagpull_request:377599328
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31881/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/da11096df8b8ad3a8d7c54bd0eadd2fc9db84a7d1f39d584bb2c8b8793a4e7bb/nodejs/node/pull/31881
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/da11096df8b8ad3a8d7c54bd0eadd2fc9db84a7d1f39d584bb2c8b8793a4e7bb/nodejs/node/pull/31881
og:image:alt#31509 introduced a slight typo. Fortunately this typo does not have big impact due to isWritableFinished(). Fixes: #31509 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) pas...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31881#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31881
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31881
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31881
Reloadhttps://github.com/nodejs/node/pull/31881
Reloadhttps://github.com/nodejs/node/pull/31881
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-finished-typohttps://github.com/nxtedition/node/tree/stream-finished-typo
Conversationhttps://github.com/nodejs/node/pull/31881
Commits1 (1)https://github.com/nodejs/node/pull/31881/commits
Checkshttps://github.com/nodejs/node/pull/31881/checks
Files changedhttps://github.com/nodejs/node/pull/31881/files
stream: fix finished typohttps://github.com/nodejs/node/pull/31881#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-finished-typohttps://github.com/nxtedition/node/tree/stream-finished-typo
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 20, 2020https://github.com/nodejs/node/pull/31881#issue-568109853
Please reload this pagehttps://github.com/nodejs/node/pull/31881
#31509https://github.com/nodejs/node/pull/31509
#31509 (comment)https://github.com/nodejs/node/pull/31509#discussion_r381809355
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/31881
https://github.com/ronag
ronaghttps://github.com/ronag
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Feb 20, 2020https://github.com/nodejs/node/pull/31881#event-3054690403
https://github.com/ronag
ronaghttps://github.com/ronag
lpincahttps://github.com/lpinca
mcollinahttps://github.com/mcollina
February 20, 2020 07:41https://github.com/nodejs/node/pull/31881#event-3054690405
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/81741056f1f3f51343a1e733f7e9b119df1c941f..5c00c96071dae0ea5d058b282f6a3a9933a486c1
8174105https://github.com/nodejs/node/commit/81741056f1f3f51343a1e733f7e9b119df1c941f
5c00c96https://github.com/nodejs/node/commit/5c00c96071dae0ea5d058b282f6a3a9933a486c1
Compare https://github.com/nodejs/node/compare/81741056f1f3f51343a1e733f7e9b119df1c941f..5c00c96071dae0ea5d058b282f6a3a9933a486c1
February 20, 2020 07:41https://github.com/nodejs/node/pull/31881#event-3054690426
https://github.com/ronag
stream: fix finished typohttps://github.com/nodejs/node/pull/31881/commits/242ccc2e52bd6d4871972554d07b8a1820f97dc4
242ccc2https://github.com/nodejs/node/pull/31881/commits/242ccc2e52bd6d4871972554d07b8a1820f97dc4
nodejs#31509https://github.com/nodejs/node/pull/31509
nodejs#31509 (comment)https://github.com/nodejs/node/pull/31509#discussion_r381809355
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/5c00c96071dae0ea5d058b282f6a3a9933a486c1..242ccc2e52bd6d4871972554d07b8a1820f97dc4
5c00c96https://github.com/nodejs/node/commit/5c00c96071dae0ea5d058b282f6a3a9933a486c1
242ccc2https://github.com/nodejs/node/commit/242ccc2e52bd6d4871972554d07b8a1820f97dc4
Compare https://github.com/nodejs/node/compare/5c00c96071dae0ea5d058b282f6a3a9933a486c1..242ccc2e52bd6d4871972554d07b8a1820f97dc4
February 20, 2020 07:41https://github.com/nodejs/node/pull/31881#event-3054691178
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 20, 2020https://github.com/nodejs/node/pull/31881#issuecomment-588694190
https://ci.nodejs.org/job/node-test-pull-request/29249/https://ci.nodejs.org/job/node-test-pull-request/29249/
Please reload this pagehttps://github.com/nodejs/node/pull/31881
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Feb 20, 2020 https://github.com/nodejs/node/pull/31881#pullrequestreview-361894421
View reviewed changes https://github.com/nodejs/node/pull/31881/files/242ccc2e52bd6d4871972554d07b8a1820f97dc4
test/parallel/test-stream-finished.jshttps://github.com/nodejs/node/pull/31881/files/242ccc2e52bd6d4871972554d07b8a1820f97dc4#diff-8d1e590f7f886b8a511a291673bc2a48fa5a189b39317e5854196947c39548b1
tniessenhttps://github.com/tniessen
Feb 20, 2020https://github.com/nodejs/node/pull/31881#discussion_r381993791
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31881
ronaghttps://github.com/ronag
Feb 20, 2020https://github.com/nodejs/node/pull/31881#discussion_r382004656
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31881
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Feb 20, 2020 https://github.com/nodejs/node/pull/31881#pullrequestreview-361995962
View reviewed changes https://github.com/nodejs/node/pull/31881/files/242ccc2e52bd6d4871972554d07b8a1820f97dc4
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/31881#pullrequestreview-361995962
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31881
https://github.com/lpinca
lpincahttps://github.com/lpinca
Feb 20, 2020 https://github.com/nodejs/node/pull/31881#pullrequestreview-362087020
View reviewed changes https://github.com/nodejs/node/pull/31881/files/242ccc2e52bd6d4871972554d07b8a1820f97dc4
https://github.com/ronag
ronaghttps://github.com/ronag
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Feb 20, 2020https://github.com/nodejs/node/pull/31881#event-3057932339
ronaghttps://github.com/ronag
Feb 22, 2020 https://github.com/nodejs/node/pull/31881#ref-commit-21bd667
https://github.com/ronag
stream: fix finished typohttps://github.com/nodejs/node/commit/21bd6679ce150e193cacd4b1b6585928224f255a
21bd667https://github.com/nodejs/node/commit/21bd6679ce150e193cacd4b1b6585928224f255a
#31509https://github.com/nodejs/node/pull/31509
#31509 (comment)https://github.com/nodejs/node/pull/31509#discussion_r381809355
#31881https://github.com/nodejs/node/pull/31881
#31509https://github.com/nodejs/node/pull/31509
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 22, 2020https://github.com/nodejs/node/pull/31881#issuecomment-589937746
21bd667https://github.com/nodejs/node/commit/21bd6679ce150e193cacd4b1b6585928224f255a
Please reload this pagehttps://github.com/nodejs/node/pull/31881
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 22, 2020https://github.com/nodejs/node/pull/31881#event-3062618008
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
Mar 4, 2020https://github.com/nodejs/node/pull/31881#event-3098620628
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 4, 2020https://github.com/nodejs/node/pull/31881#issuecomment-594857340
Please reload this pagehttps://github.com/nodejs/node/pull/31881
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Apr 14, 2020 https://github.com/nodejs/node/pull/31881#ref-pullrequest-578760228
2020-04-21, Version 14.0.0 (Current) #32181 https://github.com/nodejs/node/pull/32181
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31881
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/31881/files/242ccc2e52bd6d4871972554d07b8a1820f97dc4
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/31881/files/242ccc2e52bd6d4871972554d07b8a1820f97dc4
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/31881/files/242ccc2e52bd6d4871972554d07b8a1820f97dc4
Please reload this pagehttps://github.com/nodejs/node/pull/31881
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/31881
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/MylesBorins
https://github.com/mcollina
https://github.com/lpinca
https://github.com/tniessen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.