| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b51a2ee9-c7f1-9afa-0f71-732040142d13 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8926:15A51:1645AB3:1F9D4AB:6A50BC1D |
| html-safe-nonce | 84f55b0b9ea6b5539a778a3744c3779611c298a5e4f1afbb4f5c65376942e1ce |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTI2OjE1QTUxOjE2NDVBQjM6MUY5RDRBQjo2QTUwQkMxRCIsInZpc2l0b3JfaWQiOiIyMzU1MjA4NDM3Mzg0NjU3OTQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2a6799fb652ed94b0967f0f5e2f76685bef2fc73ce0d09ab35c5fb8af3226a6d |
| hovercard-subject-tag | pull_request:375743203 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31814/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2fb994d7ee5cc0277735a1ddf37d1ca9391c7c2be2302554975e6a4318055660/nodejs/node/pull/31814 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2fb994d7ee5cc0277735a1ddf37d1ca9391c7c2be2302554975e6a4318055660/nodejs/node/pull/31814 |
| og:image:alt | closes #31802
I added one test, that just checks if the function is available and returns the requested amount of data.
Please double check if I have done the memory allocation right.
Checklist
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | simllll |
| hostname | github.com |
| expected-hostname | github.com |
| None | 72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 08e79d53fc070870d5b168356afebb1e286a2ffe |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/31814#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31814 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31814 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/31814 |
| Reload | https://github.com/nodejs/node/pull/31814 |
| Reload | https://github.com/nodejs/node/pull/31814 |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
979
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| simllll | https://github.com/simllll |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| simllll:feat/expose-SSL_export_keying_material | https://github.com/simllll/node/tree/feat/expose-SSL_export_keying_material |
| Conversation | https://github.com/nodejs/node/pull/31814 |
| Commits1 (1) | https://github.com/nodejs/node/pull/31814/commits |
| Checks | https://github.com/nodejs/node/pull/31814/checks |
| Files changed | https://github.com/nodejs/node/pull/31814/files |
| tls: expose SSL_export_keying_material | https://github.com/nodejs/node/pull/31814#top |
| simllll | https://github.com/simllll |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| simllll:feat/expose-SSL_export_keying_material | https://github.com/simllll/node/tree/feat/expose-SSL_export_keying_material |
|
| https://github.com/simllll |
| simllll | https://github.com/simllll |
| Feb 15, 2020 | https://github.com/nodejs/node/pull/31814#issue-565788619 |
| #31802 | https://github.com/nodejs/node/issues/31802 |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Feb 15, 2020 | https://github.com/nodejs/node/pull/31814#event-3041055531 |
| https://github.com/simllll |
| simllll | https://github.com/simllll |
|
Feb 15, 2020
| https://github.com/nodejs/node/pull/31814#ref-issue-565571642 |
|
expose SSL_export_keying_material via Node API (e.g. like SSL_get_shared_sigalgs)
#31802
| https://github.com/nodejs/node/issues/31802 |
| https://github.com/simllll |
| simllll | https://github.com/simllll |
| force-pushed | https://github.com/nodejs/node/compare/886fb4569db203cb22f2b2956015d08ec4ef7bce..e46860bbe294b7365f6f257534b563728c7809a5 |
| 886fb45 | https://github.com/nodejs/node/commit/886fb4569db203cb22f2b2956015d08ec4ef7bce |
| e46860b | https://github.com/nodejs/node/commit/e46860bbe294b7365f6f257534b563728c7809a5 |
|
Compare
| https://github.com/nodejs/node/compare/886fb4569db203cb22f2b2956015d08ec4ef7bce..e46860bbe294b7365f6f257534b563728c7809a5 |
| February 15, 2020 18:37 | https://github.com/nodejs/node/pull/31814#event-3041069165 |
| https://github.com/simllll |
| simllll | https://github.com/simllll |
| Feb 15, 2020 | https://github.com/nodejs/node/pull/31814#event-3041069452 |
| https://github.com/simllll |
| simllll | https://github.com/simllll |
| sam-github | https://github.com/sam-github |
| February 15, 2020 18:38 | https://github.com/nodejs/node/pull/31814#event-3041069719 |
| https://github.com/simllll |
| simllll | https://github.com/simllll |
| force-pushed | https://github.com/nodejs/node/compare/e46860bbe294b7365f6f257534b563728c7809a5..e44ec54a27693fce17e0cd71db44e74db37fae88 |
| e46860b | https://github.com/nodejs/node/commit/e46860bbe294b7365f6f257534b563728c7809a5 |
| e44ec54 | https://github.com/nodejs/node/commit/e44ec54a27693fce17e0cd71db44e74db37fae88 |
|
Compare
| https://github.com/nodejs/node/compare/e46860bbe294b7365f6f257534b563728c7809a5..e44ec54a27693fce17e0cd71db44e74db37fae88 |
| February 15, 2020 18:40 | https://github.com/nodejs/node/pull/31814#event-3041070540 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Feb 15, 2020
| https://github.com/nodejs/node/pull/31814#pullrequestreview-359360767 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31814/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/31814/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| doc/api/tls.md | https://github.com/nodejs/node/pull/31814/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/31814/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/31814/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Feb 15, 2020 | https://github.com/nodejs/node/pull/31814#event-3041085617 |
| https://github.com/simllll |
| simllll | https://github.com/simllll |
| force-pushed | https://github.com/nodejs/node/compare/e44ec54a27693fce17e0cd71db44e74db37fae88..367dcc08a0aede20c6f28e9d67eb2903b9d6bae7 |
| e44ec54 | https://github.com/nodejs/node/commit/e44ec54a27693fce17e0cd71db44e74db37fae88 |
| 367dcc0 | https://github.com/nodejs/node/commit/367dcc08a0aede20c6f28e9d67eb2903b9d6bae7 |
|
Compare
| https://github.com/nodejs/node/compare/e44ec54a27693fce17e0cd71db44e74db37fae88..367dcc08a0aede20c6f28e9d67eb2903b9d6bae7 |
| February 15, 2020 19:42 | https://github.com/nodejs/node/pull/31814#event-3041102834 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Feb 15, 2020
| https://github.com/nodejs/node/pull/31814#pullrequestreview-359363063 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31814/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Feb 15, 2020 | https://github.com/nodejs/node/pull/31814#issuecomment-586635132 |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 15, 2020 | https://github.com/nodejs/node/pull/31814#issuecomment-586635201 |
| https://ci.nodejs.org/job/node-test-pull-request/29160/ | https://ci.nodejs.org/job/node-test-pull-request/29160/ |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Feb 15, 2020
| https://github.com/nodejs/node/pull/31814#pullrequestreview-359371433 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31814/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/31814/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/31814/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/31814/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/31814/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/31814/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/simllll |
| simllll | https://github.com/simllll |
| force-pushed | https://github.com/nodejs/node/compare/0a9170ab9a13b2544624f76e2624cd19674d51b7..94f7fce1e2f56701882eb3bc0b095d807dda2e75 |
| 0a9170a | https://github.com/nodejs/node/commit/0a9170ab9a13b2544624f76e2624cd19674d51b7 |
| 94f7fce | https://github.com/nodejs/node/commit/94f7fce1e2f56701882eb3bc0b095d807dda2e75 |
|
Compare
| https://github.com/nodejs/node/compare/0a9170ab9a13b2544624f76e2624cd19674d51b7..94f7fce1e2f56701882eb3bc0b095d807dda2e75 |
| February 17, 2020 08:14 | https://github.com/nodejs/node/pull/31814#event-3042685649 |
| https://github.com/simllll |
| simllll | https://github.com/simllll |
| Feb 17, 2020 | https://github.com/nodejs/node/pull/31814#issuecomment-586868230 |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Feb 17, 2020
| https://github.com/nodejs/node/pull/31814#pullrequestreview-359596790 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31814/files |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/31814#pullrequestreview-359596790 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| lib/_tls_wrap.js | https://github.com/nodejs/node/pull/31814/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8 |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| lib/_tls_wrap.js | https://github.com/nodejs/node/pull/31814/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8 |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/31814/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/simllll |
| simllll | https://github.com/simllll |
| force-pushed | https://github.com/nodejs/node/compare/94f7fce1e2f56701882eb3bc0b095d807dda2e75..337becfaea474fa0068207adf2666d412f454b6b |
| 94f7fce | https://github.com/nodejs/node/commit/94f7fce1e2f56701882eb3bc0b095d807dda2e75 |
| 337becf | https://github.com/nodejs/node/commit/337becfaea474fa0068207adf2666d412f454b6b |
|
Compare
| https://github.com/nodejs/node/compare/94f7fce1e2f56701882eb3bc0b095d807dda2e75..337becfaea474fa0068207adf2666d412f454b6b |
| February 17, 2020 11:25 | https://github.com/nodejs/node/pull/31814#event-3043345014 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 17, 2020
| https://github.com/nodejs/node/pull/31814#pullrequestreview-359754164 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31814/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/31814/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 17, 2020
| https://github.com/nodejs/node/pull/31814#pullrequestreview-359754437 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31814/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/31814/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 17, 2020
| https://github.com/nodejs/node/pull/31814#pullrequestreview-359756034 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31814/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/31814/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 17, 2020
| https://github.com/nodejs/node/pull/31814#pullrequestreview-359757079 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31814/files |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/31814/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 17, 2020
| https://github.com/nodejs/node/pull/31814#pullrequestreview-359758531 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31814/files |
| test/parallel/test-tls-exportkeyingmaterial.js | https://github.com/nodejs/node/pull/31814/files#diff-b76b6be9a6116c63ca78aa1ffc41593ef84e56f3afcb1dc06fab6fca6d47912b |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 17, 2020
| https://github.com/nodejs/node/pull/31814#pullrequestreview-359758642 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31814/files |
| test/parallel/test-tls-exportkeyingmaterial.js | https://github.com/nodejs/node/pull/31814/files#diff-b76b6be9a6116c63ca78aa1ffc41593ef84e56f3afcb1dc06fab6fca6d47912b |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 17, 2020
| https://github.com/nodejs/node/pull/31814#pullrequestreview-359758899 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31814/files |
| test/parallel/test-tls-exportkeyingmaterial.js | https://github.com/nodejs/node/pull/31814/files#diff-b76b6be9a6116c63ca78aa1ffc41593ef84e56f3afcb1dc06fab6fca6d47912b |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 17, 2020
| https://github.com/nodejs/node/pull/31814#pullrequestreview-359759032 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31814/files |
| test/parallel/test-tls-exportkeyingmaterial.js | https://github.com/nodejs/node/pull/31814/files#diff-b76b6be9a6116c63ca78aa1ffc41593ef84e56f3afcb1dc06fab6fca6d47912b |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/simllll |
| simllll | https://github.com/simllll |
| force-pushed | https://github.com/nodejs/node/compare/337becfaea474fa0068207adf2666d412f454b6b..c98c1b563d0fddcc89b690fbaf388dc42d9267c6 |
| 337becf | https://github.com/nodejs/node/commit/337becfaea474fa0068207adf2666d412f454b6b |
| c98c1b5 | https://github.com/nodejs/node/commit/c98c1b563d0fddcc89b690fbaf388dc42d9267c6 |
|
Compare
| https://github.com/nodejs/node/compare/337becfaea474fa0068207adf2666d412f454b6b..c98c1b563d0fddcc89b690fbaf388dc42d9267c6 |
| February 17, 2020 15:03 | https://github.com/nodejs/node/pull/31814#event-3044065906 |
| https://github.com/simllll |
| simllll | https://github.com/simllll |
|
Feb 20, 2020
| https://github.com/nodejs/node/pull/31814#ref-issue-568555091 |
|
SSL Wrong version number
simllll/node-radius-server#2
| https://github.com/simllll/node-radius-server/issues/2 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Feb 22, 2020
| https://github.com/nodejs/node/pull/31814#pullrequestreview-363045779 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31814/files |
| tniessen | https://github.com/tniessen |
| https://github.com/nodejs/node/pull/31814#pullrequestreview-363045779 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/simllll |
| simllll | https://github.com/simllll |
| force-pushed | https://github.com/nodejs/node/compare/a37a1440f8e5cde872ef996f2ec414b512b58fbd..119ae43c38e4e23baa5029cc662114b374d58d2b |
| a37a144 | https://github.com/nodejs/node/commit/a37a1440f8e5cde872ef996f2ec414b512b58fbd |
| 119ae43 | https://github.com/nodejs/node/commit/119ae43c38e4e23baa5029cc662114b374d58d2b |
|
Compare
| https://github.com/nodejs/node/compare/a37a1440f8e5cde872ef996f2ec414b512b58fbd..119ae43c38e4e23baa5029cc662114b374d58d2b |
| February 22, 2020 19:31 | https://github.com/nodejs/node/pull/31814#event-3062932290 |
| https://github.com/simllll |
| simllll | https://github.com/simllll |
| tniessen | https://github.com/tniessen |
| February 22, 2020 22:23 | https://github.com/nodejs/node/pull/31814#event-3063016481 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Feb 23, 2020
| https://github.com/nodejs/node/pull/31814#pullrequestreview-363058139 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31814/files |
| tniessen | https://github.com/tniessen |
| https://github.com/nodejs/node/pull/31814#pullrequestreview-363058139 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| doc/api/tls.md | https://github.com/nodejs/node/pull/31814/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| doc/api/tls.md | https://github.com/nodejs/node/pull/31814/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31814 |
| https://github.com/simllll |
| simllll | https://github.com/simllll |
| force-pushed | https://github.com/nodejs/node/compare/119ae43c38e4e23baa5029cc662114b374d58d2b..176f4e6d90d0e4a72bb2f3d3a049dd92a29f231d |
| 119ae43 | https://github.com/nodejs/node/commit/119ae43c38e4e23baa5029cc662114b374d58d2b |
| 176f4e6 | https://github.com/nodejs/node/commit/176f4e6d90d0e4a72bb2f3d3a049dd92a29f231d |
|
Compare
| https://github.com/nodejs/node/compare/119ae43c38e4e23baa5029cc662114b374d58d2b..176f4e6d90d0e4a72bb2f3d3a049dd92a29f231d |
| February 23, 2020 00:45 | https://github.com/nodejs/node/pull/31814#event-3063075728 |
|
| https://github.com/simllll |
| tls: expose SSL_export_keying_material via tlsSocket.exportKeyingMate… | https://github.com/nodejs/node/pull/31814/commits/c2b23f9148c10401897a0e6ed460823490f322ff |
| c2b23f9 | https://github.com/nodejs/node/pull/31814/commits/c2b23f9148c10401897a0e6ed460823490f322ff |
| https://github.com/simllll |
| simllll | https://github.com/simllll |
| force-pushed | https://github.com/nodejs/node/compare/176f4e6d90d0e4a72bb2f3d3a049dd92a29f231d..c2b23f9148c10401897a0e6ed460823490f322ff |
| 176f4e6 | https://github.com/nodejs/node/commit/176f4e6d90d0e4a72bb2f3d3a049dd92a29f231d |
| c2b23f9 | https://github.com/nodejs/node/commit/c2b23f9148c10401897a0e6ed460823490f322ff |
|
Compare
| https://github.com/nodejs/node/compare/176f4e6d90d0e4a72bb2f3d3a049dd92a29f231d..c2b23f9148c10401897a0e6ed460823490f322ff |
| February 23, 2020 00:51 | https://github.com/nodejs/node/pull/31814#event-3063077722 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 23, 2020 | https://github.com/nodejs/node/pull/31814#issuecomment-590018977 |
| https://ci.nodejs.org/job/node-test-pull-request/29289/ | https://ci.nodejs.org/job/node-test-pull-request/29289/ |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| tniessen | https://github.com/tniessen |
|
Feb 23, 2020
| https://github.com/nodejs/node/pull/31814#ref-commit-341c06f |
|
| https://github.com/simllll |
|
| https://github.com/tniessen |
| tls: expose SSL_export_keying_material | https://github.com/nodejs/node/commit/341c06f0889e5295d7a7a34c3e38296bd2c4ac18 |
| 341c06f | https://github.com/nodejs/node/commit/341c06f0889e5295d7a7a34c3e38296bd2c4ac18 |
| #31802 | https://github.com/nodejs/node/issues/31802 |
| #31814 | https://github.com/nodejs/node/pull/31814 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Feb 23, 2020 | https://github.com/nodejs/node/pull/31814#issuecomment-590028784 |
| 341c06f | https://github.com/nodejs/node/commit/341c06f0889e5295d7a7a34c3e38296bd2c4ac18 |
| @simllll | https://github.com/simllll |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Feb 23, 2020 | https://github.com/nodejs/node/pull/31814#event-3063171875 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Feb 23, 2020 | https://github.com/nodejs/node/pull/31814#event-3063171926 |
| https://github.com/simllll |
| simllll | https://github.com/simllll |
| Feb 23, 2020 | https://github.com/nodejs/node/pull/31814#issuecomment-590062898 |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
| https://github.com/simllll |
| simllll | https://github.com/simllll |
| February 23, 2020 12:21 | https://github.com/nodejs/node/pull/31814#event-3063382116 |
| codebytere | https://github.com/codebytere |
|
Feb 27, 2020
| https://github.com/nodejs/node/pull/31814#ref-commit-acb3aff |
|
| https://github.com/simllll |
|
| https://github.com/codebytere |
| tls: expose SSL_export_keying_material | https://github.com/nodejs/node/commit/acb3aff6748e82212b6e35276a1d753595799fe4 |
| acb3aff | https://github.com/nodejs/node/commit/acb3aff6748e82212b6e35276a1d753595799fe4 |
| #31802 | https://github.com/nodejs/node/issues/31802 |
| #31814 | https://github.com/nodejs/node/pull/31814 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Feb 29, 2020
| https://github.com/nodejs/node/pull/31814#ref-pullrequest-573431833 |
|
v13.10.0 proposal
#32027
| https://github.com/nodejs/node/pull/32027 |
| codebytere | https://github.com/codebytere |
|
Mar 1, 2020
| https://github.com/nodejs/node/pull/31814#ref-commit-165ecaa |
|
| https://github.com/codebytere |
| 2020-03-03 Version 13.10.0 (Current) | https://github.com/nodejs/node/commit/165ecaaca5c1e7f98ff797734afd09c214f356fa |
| 165ecaa | https://github.com/nodejs/node/commit/165ecaaca5c1e7f98ff797734afd09c214f356fa |
| #26540 | https://github.com/nodejs/node/pull/26540 |
| #31223 | https://github.com/nodejs/node/pull/31223 |
| #31814 | https://github.com/nodejs/node/pull/31814 |
| #31824 | https://github.com/nodejs/node/pull/31824 |
| #32027 | https://github.com/nodejs/node/pull/32027 |
| codebytere | https://github.com/codebytere |
|
Mar 3, 2020
| https://github.com/nodejs/node/pull/31814#ref-commit-e39b006 |
|
| https://github.com/codebytere |
| 2020-03-03 Version 13.10.0 (Current) | https://github.com/nodejs/node/commit/e39b0067b0fcdcb4d80af92e59616ac8f24e987b |
| e39b006 | https://github.com/nodejs/node/commit/e39b0067b0fcdcb4d80af92e59616ac8f24e987b |
| #26540 | https://github.com/nodejs/node/pull/26540 |
| #31223 | https://github.com/nodejs/node/pull/31223 |
| #31814 | https://github.com/nodejs/node/pull/31814 |
| #31824 | https://github.com/nodejs/node/pull/31824 |
| #32027 | https://github.com/nodejs/node/pull/32027 |
| codebytere | https://github.com/codebytere |
|
Mar 3, 2020
| https://github.com/nodejs/node/pull/31814#ref-commit-471590e |
|
| https://github.com/codebytere |
| 2020-03-03 Version 13.10.0 (Current) | https://github.com/nodejs/node/commit/471590e18f77a89845b2cd6e370aed4010077455 |
| 471590e | https://github.com/nodejs/node/commit/471590e18f77a89845b2cd6e370aed4010077455 |
| #26540 | https://github.com/nodejs/node/pull/26540 |
| #31223 | https://github.com/nodejs/node/pull/31223 |
| #31814 | https://github.com/nodejs/node/pull/31814 |
| #31824 | https://github.com/nodejs/node/pull/31824 |
| #32027 | https://github.com/nodejs/node/pull/32027 |
| codebytere | https://github.com/codebytere |
|
Mar 3, 2020
| https://github.com/nodejs/node/pull/31814#ref-commit-f6ffdc2 |
|
| https://github.com/codebytere |
| 2020-03-04 Version 13.10.0 (Current) | https://github.com/nodejs/node/commit/f6ffdc2fa3ddebba5f9ba755fdf550946eb2f218 |
| f6ffdc2 | https://github.com/nodejs/node/commit/f6ffdc2fa3ddebba5f9ba755fdf550946eb2f218 |
| #26540 | https://github.com/nodejs/node/pull/26540 |
| #31223 | https://github.com/nodejs/node/pull/31223 |
| #31814 | https://github.com/nodejs/node/pull/31814 |
| #31824 | https://github.com/nodejs/node/pull/31824 |
| #32027 | https://github.com/nodejs/node/pull/32027 |
| codebytere | https://github.com/codebytere |
|
Mar 4, 2020
| https://github.com/nodejs/node/pull/31814#ref-commit-7546686 |
|
| https://github.com/codebytere |
| 2020-03-04 Version 13.10.0 (Current) | https://github.com/nodejs/node/commit/75466869fb6e1dd09b36dc2b44ef8748ecc6e7de |
| 7546686 | https://github.com/nodejs/node/commit/75466869fb6e1dd09b36dc2b44ef8748ecc6e7de |
| #26540 | https://github.com/nodejs/node/pull/26540 |
| #31223 | https://github.com/nodejs/node/pull/31223 |
| #31814 | https://github.com/nodejs/node/pull/31814 |
| #31824 | https://github.com/nodejs/node/pull/31824 |
| #32027 | https://github.com/nodejs/node/pull/32027 |
| https://github.com/developher-net |
| developher-net | https://github.com/developher-net |
|
Mar 11, 2020
| https://github.com/nodejs/node/pull/31814#ref-issue-577950383 |
|
Verification stopped with node v13
semantic-release/gitlab#139
| https://github.com/semantic-release/gitlab/issues/139 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Apr 20, 2020
| https://github.com/nodejs/node/pull/31814#ref-pullrequest-569521347 |
|
crypto: simplify exportKeyingMaterial
#31922
| https://github.com/nodejs/node/pull/31922 |
| targos | https://github.com/targos |
|
Apr 25, 2020
| https://github.com/nodejs/node/pull/31814#ref-commit-b4c431e |
|
| https://github.com/simllll |
|
| https://github.com/targos |
| tls: expose SSL_export_keying_material | https://github.com/targos/node/commit/b4c431eaf61f6bd660bd9a4807ac7592b6eead3a |
| b4c431e | https://github.com/targos/node/commit/b4c431eaf61f6bd660bd9a4807ac7592b6eead3a |
| nodejs#31802 | https://github.com/nodejs/node/issues/31802 |
| nodejs#31814 | https://github.com/nodejs/node/pull/31814 |
| targos | https://github.com/targos |
|
Apr 28, 2020
| https://github.com/nodejs/node/pull/31814#ref-commit-6348fae |
|
| https://github.com/simllll |
|
| https://github.com/targos |
| tls: expose SSL_export_keying_material | https://github.com/nodejs/node/commit/6348fae6903bf76d6ccdfe90a298b0e25f9a2066 |
| 6348fae | https://github.com/nodejs/node/commit/6348fae6903bf76d6ccdfe90a298b0e25f9a2066 |
| #31802 | https://github.com/nodejs/node/issues/31802 |
| #31814 | https://github.com/nodejs/node/pull/31814 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 2, 2020
| https://github.com/nodejs/node/pull/31814#ref-pullrequest-610737650 |
|
v12.17.0 release proposal
#33197
| https://github.com/nodejs/node/pull/33197 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31814 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/31814/files/054de1423db5a86f0c5f25cde3858d723addf083 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/31814/files/a37a1440f8e5cde872ef996f2ec414b512b58fbd |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/31814/files/ee21a35986a3cde48a33712d82c1f3f9ef121d72 |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/31814/files/119ae43c38e4e23baa5029cc662114b374d58d2b |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
|
expose SSL_export_keying_material via Node API (e.g. like SSL_get_shared_sigalgs)
| https://github.com/nodejs/node/issues/31802 |
| Please reload this page | https://github.com/nodejs/node/pull/31814 |
|
| https://github.com/simllll |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/tniessen |
|
| https://github.com/bnoordhuis |
|
| https://github.com/jasnell |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |