René's URL Explorer Experiment


Title: stream: fix sync callback leak by ronag · Pull Request #31765 · nodejs/node · GitHub

Open Graph Title: stream: fix sync callback leak by ronag · Pull Request #31765 · nodejs/node

X Title: stream: fix sync callback leak by ronag · Pull Request #31765 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This PR currently is mostly a suggestion to discuss related to #31756. It's not properly cleaned up and is mostly to illustrate the problem and possible solution. Today when working with callba...

X Description: This PR currently is mostly a suggestion to discuss related to #31756. It's not properly cleaned up and is mostly to illustrate the problem and possible solution. Today when working with ca...

Opengraph URL: https://github.com/nodejs/node/pull/31765

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:49fdff3a-f121-3f76-83ec-1fc59f53fca5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBF52:16C3D3:614890F:88FB9BA:6A501F27
html-safe-nonce47527be2f97a6647b1582c49185ec0984aa7e48953d7636f4bf9ddfe830543bb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjUyOjE2QzNEMzo2MTQ4OTBGOjg4RkI5QkE6NkE1MDFGMjciLCJ2aXNpdG9yX2lkIjoiNDQ3MTU5OTMyNjc3NTIyMjA1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2b9631d54a24848245a9db54d75fbe61b99fa0ca716fa363ee76427885badf1f
hovercard-subject-tagpull_request:374785422
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31765/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/88e0d9c2d39870220bac936533b59d6f3cce9788301c955f2885629be82abc78/nodejs/node/pull/31765
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/88e0d9c2d39870220bac936533b59d6f3cce9788301c955f2885629be82abc78/nodejs/node/pull/31765
og:image:altThis PR currently is mostly a suggestion to discuss related to #31756. It's not properly cleaned up and is mostly to illustrate the problem and possible solution. Today when working with callba...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None14f013003d3992e8746116a6f2f55cd2fdaccd329ee0423392831ae051ecb535
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26ee7c1a62943cf19a6fcc1d1ac93ac83465c885
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31765#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31765
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31765
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31765
Reloadhttps://github.com/nodejs/node/pull/31765
Reloadhttps://github.com/nodejs/node/pull/31765
Please reload this pagehttps://github.com/nodejs/node/pull/31765
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/31765
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 977 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-sync-leakhttps://github.com/nxtedition/node/tree/stream-sync-leak
Conversationhttps://github.com/nodejs/node/pull/31765
Commits1 (1)https://github.com/nodejs/node/pull/31765/commits
Checkshttps://github.com/nodejs/node/pull/31765/checks
Files changedhttps://github.com/nodejs/node/pull/31765/files
stream: fix sync callback leakhttps://github.com/nodejs/node/pull/31765#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-sync-leakhttps://github.com/nxtedition/node/tree/stream-sync-leak
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 13, 2020https://github.com/nodejs/node/pull/31765#issue-564582419
Please reload this pagehttps://github.com/nodejs/node/pull/31765
#31756https://github.com/nodejs/node/pull/31756
#31756https://github.com/nodejs/node/pull/31756
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/31765
https://github.com/ronag
ronaghttps://github.com/ronag
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
Feb 13, 2020https://github.com/nodejs/node/pull/31765#event-3034260720
https://github.com/ronag
ronaghttps://github.com/ronag
jasnellhttps://github.com/jasnell
mcollinahttps://github.com/mcollina
February 13, 2020 10:25https://github.com/nodejs/node/pull/31765#event-3034261030
https://github.com/ronag
stream: fix sync callback leakhttps://github.com/nodejs/node/pull/31765/commits/25dedbab6380f77262ee6fd871a9b3036c076bd7
25dedbahttps://github.com/nodejs/node/pull/31765/commits/25dedbab6380f77262ee6fd871a9b3036c076bd7
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/618a737698e45077083367dff305796621a60e97..25dedbab6380f77262ee6fd871a9b3036c076bd7
618a737https://github.com/nodejs/node/commit/618a737698e45077083367dff305796621a60e97
25dedbahttps://github.com/nodejs/node/commit/25dedbab6380f77262ee6fd871a9b3036c076bd7
Compare https://github.com/nodejs/node/compare/618a737698e45077083367dff305796621a60e97..25dedbab6380f77262ee6fd871a9b3036c076bd7
February 13, 2020 10:26https://github.com/nodejs/node/pull/31765#event-3034265858
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Feb 13, 2020 https://github.com/nodejs/node/pull/31765#pullrequestreview-358113826
View reviewed changes https://github.com/nodejs/node/pull/31765/files/25dedbab6380f77262ee6fd871a9b3036c076bd7
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/31765#pullrequestreview-358113826
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31765
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 13, 2020https://github.com/nodejs/node/pull/31765#issuecomment-585665827
Please reload this pagehttps://github.com/nodejs/node/pull/31765
Please reload this pagehttps://github.com/nodejs/node/pull/31765
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 13, 2020https://github.com/nodejs/node/pull/31765#issuecomment-585774629
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/31765
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Feb 13, 2020https://github.com/nodejs/node/pull/31765#issuecomment-585779246
4d7eddchttps://github.com/nodejs/node/commit/4d7eddc5dd5ca1379b6df705eeb962574f07fde8
Please reload this pagehttps://github.com/nodejs/node/pull/31765
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 13, 2020 https://github.com/nodejs/node/pull/31765#pullrequestreview-358262619
View reviewed changes https://github.com/nodejs/node/pull/31765/files/25dedbab6380f77262ee6fd871a9b3036c076bd7
mscdexhttps://github.com/mscdex
https://github.com/nodejs/node/pull/31765#pullrequestreview-358262619
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
performance regressionshttps://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/529/console
Please reload this pagehttps://github.com/nodejs/node/pull/31765
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 13, 2020https://github.com/nodejs/node/pull/31765#issuecomment-585810190
Please reload this pagehttps://github.com/nodejs/node/pull/31765
Please reload this pagehttps://github.com/nodejs/node/pull/31765
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 13, 2020https://github.com/nodejs/node/pull/31765#issuecomment-585810823
Please reload this pagehttps://github.com/nodejs/node/pull/31765
4d7eddchttps://github.com/nodejs/node/commit/4d7eddc5dd5ca1379b6df705eeb962574f07fde8
Please reload this pagehttps://github.com/nodejs/node/pull/31765
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 13, 2020 https://github.com/nodejs/node/pull/31765#ref-pullrequest-564249042
stream: add known_issue test for sync callback with error #31756 https://github.com/nodejs/node/pull/31756
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 13, 2020 https://github.com/nodejs/node/pull/31765#pullrequestreview-358306999
View reviewed changes https://github.com/nodejs/node/pull/31765/files/25dedbab6380f77262ee6fd871a9b3036c076bd7
lib/internal/process/task_queues.jshttps://github.com/nodejs/node/pull/31765/files/25dedbab6380f77262ee6fd871a9b3036c076bd7#diff-99bad7c13fcb19d95a5047ca8d7f7e519c19932899f2346085390b1b2e1f33c1
ronaghttps://github.com/ronag
Feb 13, 2020https://github.com/nodejs/node/pull/31765#discussion_r378930508
Please reload this pagehttps://github.com/nodejs/node/pull/31765
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/31765
addaleaxhttps://github.com/addaleax
Feb 13, 2020https://github.com/nodejs/node/pull/31765#discussion_r378941497
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31765
jasnellhttps://github.com/jasnell
Feb 13, 2020https://github.com/nodejs/node/pull/31765#discussion_r378950248
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31765
addaleaxhttps://github.com/addaleax
Feb 13, 2020https://github.com/nodejs/node/pull/31765#discussion_r378952126
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31765
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 15, 2020 https://github.com/nodejs/node/pull/31765#ref-pullrequest-565746762
doc: fix Writable.write callback description #31812 https://github.com/nodejs/node/pull/31812
ronaghttps://github.com/ronag
Feb 15, 2020 https://github.com/nodejs/node/pull/31765#ref-commit-8c19c23
https://github.com/ronag
doc: fix Writable.write callback descriptionhttps://github.com/nxtedition/node/commit/8c19c23e0ff00b5681fd9da6973dc146e0e826d6
8c19c23https://github.com/nxtedition/node/commit/8c19c23e0ff00b5681fd9da6973dc146e0e826d6
nodejs#31756https://github.com/nodejs/node/pull/31756
nodejs#31765https://github.com/nodejs/node/pull/31765
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 15, 2020https://github.com/nodejs/node/pull/31765#issuecomment-586589585
@lpincahttps://github.com/lpinca
Please reload this pagehttps://github.com/nodejs/node/pull/31765
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 15, 2020 https://github.com/nodejs/node/pull/31765#pullrequestreview-359349588
View reviewed changes https://github.com/nodejs/node/pull/31765/files/25dedbab6380f77262ee6fd871a9b3036c076bd7
lib/_stream_writable.jshttps://github.com/nodejs/node/pull/31765/files/25dedbab6380f77262ee6fd871a9b3036c076bd7#diff-a7fdfe149712099064db4e7b80a1b39e28515b4efb3fab2f4b9499ce3b7c51c3
ronaghttps://github.com/ronag
Feb 15, 2020https://github.com/nodejs/node/pull/31765#discussion_r379836426
Please reload this pagehttps://github.com/nodejs/node/pull/31765
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/31765
mcollinahttps://github.com/mcollina
Feb 15, 2020https://github.com/nodejs/node/pull/31765#discussion_r379861866
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31765
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 18, 2020 https://github.com/nodejs/node/pull/31765#ref-pullrequest-476202890
process: add .stillSynchronous #28941 https://github.com/nodejs/node/pull/28941
ronaghttps://github.com/ronag
Feb 18, 2020 https://github.com/nodejs/node/pull/31765#ref-commit-7c524fb
https://github.com/ronag
doc: fix Writable.write callback descriptionhttps://github.com/nodejs/node/commit/7c524fb092b143470795c8ca869de4654c728fe1
7c524fbhttps://github.com/nodejs/node/commit/7c524fb092b143470795c8ca869de4654c728fe1
#31756https://github.com/nodejs/node/pull/31756
#31765https://github.com/nodejs/node/pull/31765
#31812https://github.com/nodejs/node/pull/31812
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 25, 2020https://github.com/nodejs/node/pull/31765#issuecomment-591000291
Please reload this pagehttps://github.com/nodejs/node/pull/31765
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 25, 2020https://github.com/nodejs/node/pull/31765#event-3070504282
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31765
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/31765/files/25dedbab6380f77262ee6fd871a9b3036c076bd7
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/31765/files/25dedbab6380f77262ee6fd871a9b3036c076bd7
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/31765/files/25dedbab6380f77262ee6fd871a9b3036c076bd7
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Please reload this pagehttps://github.com/nodejs/node/pull/31765
https://github.com/ronag
https://github.com/addaleax
https://github.com/mcollina
https://github.com/mscdex
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.