| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2b29e3e1-3f84-8665-bd95-f7f740ebb1bf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BD58:13C54:14EB765:1C8F65F:6A4F02A0 |
| html-safe-nonce | 37b7dd9166a19d4fc895bf567364c05a608f45cd09ec6497a930eb937eb17b2c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDU4OjEzQzU0OjE0RUI3NjU6MUM4RjY1Rjo2QTRGMDJBMCIsInZpc2l0b3JfaWQiOiIxOTc5NTE5OTY4NjAxODk5NjgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a2a2630b50e7095e9ecb3817f4b1010f0eb054a9795384184c27ec6cc4aea3f5 |
| hovercard-subject-tag | pull_request:374556785 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31757/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/eddc312468bd1250c6001336e174063e7532eac3cc5c958b690ae5d8de78ab54/nodejs/node/pull/31757 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/eddc312468bd1250c6001336e174063e7532eac3cc5c958b690ae5d8de78ab54/nodejs/node/pull/31757 |
| og:image:alt | Resolves #31754.
Ensure package self resolution remains behind --experimental-modules.
//cc @nodejs/modules-active-members @MylesBorins
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | guybedford |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/31757#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31757 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31757 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/31757 |
| Reload | https://github.com/nodejs/node/pull/31757 |
| Reload | https://github.com/nodejs/node/pull/31757 |
| Please reload this page | https://github.com/nodejs/node/pull/31757 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/31757 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
965
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| guybedford | https://github.com/guybedford |
| nodejs:v12.x-staging | https://github.com/nodejs/node/tree/v12.x-staging |
| guybedford:flag-self-resolve | https://github.com/guybedford/node/tree/flag-self-resolve |
| Conversation | https://github.com/nodejs/node/pull/31757 |
| Commits1 (1) | https://github.com/nodejs/node/pull/31757/commits |
| Checks | https://github.com/nodejs/node/pull/31757/checks |
| Files changed | https://github.com/nodejs/node/pull/31757/files |
| [12.x] module: self resolve flag as experimental modules | https://github.com/nodejs/node/pull/31757#top |
| guybedford | https://github.com/guybedford |
| nodejs:v12.x-staging | https://github.com/nodejs/node/tree/v12.x-staging |
| guybedford:flag-self-resolve | https://github.com/guybedford/node/tree/flag-self-resolve |
|
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| Feb 12, 2020 | https://github.com/nodejs/node/pull/31757#issue-564299553 |
| Please reload this page | https://github.com/nodejs/node/pull/31757 |
| #31754 | https://github.com/nodejs/node/issues/31754 |
| @MylesBorins | https://github.com/MylesBorins |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/31757 |
|
| https://github.com/guybedford |
| module: 12.x self resolve flag as experimental modules | https://github.com/nodejs/node/pull/31757/commits/052e1a9e644cea95546f57ff4a39beec5775c141 |
| 052e1a9 | https://github.com/nodejs/node/pull/31757/commits/052e1a9e644cea95546f57ff4a39beec5775c141 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av12.x |
| Feb 12, 2020 | https://github.com/nodejs/node/pull/31757#event-3032608945 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| force-pushed | https://github.com/nodejs/node/compare/1c3899749638814ba69f5769df3150b995096c70..052e1a9e644cea95546f57ff4a39beec5775c141 |
| 1c38997 | https://github.com/nodejs/node/commit/1c3899749638814ba69f5769df3150b995096c70 |
| 052e1a9 | https://github.com/nodejs/node/commit/052e1a9e644cea95546f57ff4a39beec5775c141 |
|
Compare
| https://github.com/nodejs/node/compare/1c3899749638814ba69f5769df3150b995096c70..052e1a9e644cea95546f57ff4a39beec5775c141 |
| February 12, 2020 21:56 | https://github.com/nodejs/node/pull/31757#event-3032610343 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| Feb 12, 2020 | https://github.com/nodejs/node/pull/31757#event-3032610886 |
| https://github.com/ljharb |
| ljharb | https://github.com/ljharb |
|
Feb 12, 2020
| https://github.com/nodejs/node/pull/31757#pullrequestreview-357824951 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31757/files/052e1a9e644cea95546f57ff4a39beec5775c141 |
| ljharb | https://github.com/ljharb |
| Please reload this page | https://github.com/nodejs/node/pull/31757 |
| https://github.com/nodejs/node/pull/31757#pullrequestreview-357824951 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/31757 |
| https://github.com/ljharb |
| ljharb | https://github.com/ljharb |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
module
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule |
| Feb 12, 2020 | https://github.com/nodejs/node/pull/31757#event-3032700163 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
Feb 12, 2020
| https://github.com/nodejs/node/pull/31757#pullrequestreview-357837135 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31757/files/052e1a9e644cea95546f57ff4a39beec5775c141 |
| https://github.com/hybrist |
| hybrist | https://github.com/hybrist |
| Feb 12, 2020 | https://github.com/nodejs/node/pull/31757#issuecomment-585454678 |
| https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#how-are-lts-branches-managed | https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#how-are-lts-branches-managed |
| Please reload this page | https://github.com/nodejs/node/pull/31757 |
| https://github.com/hybrist |
| hybrist | https://github.com/hybrist |
|
Feb 12, 2020
| https://github.com/nodejs/node/pull/31757#pullrequestreview-357841836 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31757/files/052e1a9e644cea95546f57ff4a39beec5775c141 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| February 13, 2020 11:56 | https://github.com/nodejs/node/pull/31757#event-3034550908 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 13, 2020
| https://github.com/nodejs/node/pull/31757#pullrequestreview-358453169 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31757/files/052e1a9e644cea95546f57ff4a39beec5775c141 |
| MylesBorins | https://github.com/MylesBorins |
| https://github.com/nodejs/node/pull/31757#pullrequestreview-358453169 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/31757 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 13, 2020 | https://github.com/nodejs/node/pull/31757#issuecomment-585905134 |
| Please reload this page | https://github.com/nodejs/node/pull/31757 |
| https://ci.nodejs.org/job/node-test-pull-request/29104/ | https://ci.nodejs.org/job/node-test-pull-request/29104/ |
| https://ci.nodejs.org/job/node-test-commit-plinux/30916/ | https://ci.nodejs.org/job/node-test-commit-plinux/30916/ |
| https://ci.nodejs.org/job/node-test-binary-arm-12+/4342/ | https://ci.nodejs.org/job/node-test-binary-arm-12+/4342/ |
| Please reload this page | https://github.com/nodejs/node/pull/31757 |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 13, 2020
| https://github.com/nodejs/node/pull/31757#ref-commit-f0b2d87 |
|
| https://github.com/guybedford |
|
| https://github.com/MylesBorins |
| module: 12.x self resolve flag as experimental modules | https://github.com/nodejs/node/commit/f0b2d875d96d942d6d22612986dceb225317fede |
| f0b2d87 | https://github.com/nodejs/node/commit/f0b2d875d96d942d6d22612986dceb225317fede |
| #31757 | https://github.com/nodejs/node/pull/31757 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Feb 13, 2020 | https://github.com/nodejs/node/pull/31757#issuecomment-586013753 |
| f0b2d87 | https://github.com/nodejs/node/commit/f0b2d875d96d942d6d22612986dceb225317fede |
| Please reload this page | https://github.com/nodejs/node/pull/31757 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Feb 13, 2020 | https://github.com/nodejs/node/pull/31757#event-3036838806 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 13, 2020
| https://github.com/nodejs/node/pull/31757#ref-pullrequest-565004689 |
|
v12.16.1 proposal
#31781
| https://github.com/nodejs/node/pull/31781 |
| https://github.com/ljharb |
| ljharb | https://github.com/ljharb |
| Feb 13, 2020 | https://github.com/nodejs/node/pull/31757#issuecomment-586024418 |
| Please reload this page | https://github.com/nodejs/node/pull/31757 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
|
Apr 21, 2020
| https://github.com/nodejs/node/pull/31757#ref-pullrequest-566807138 |
|
module: disable conditional exports, self resolve warnings
#31845
| https://github.com/nodejs/node/pull/31845 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31757 |
|
| https://github.com/ljharb |
|
ljharb
| https://github.com/ljharb |
|
| https://github.com/nodejs/node/pull/31757/files/052e1a9e644cea95546f57ff4a39beec5775c141 |
|
| https://github.com/GeoffreyBooth |
|
GeoffreyBooth
| https://github.com/GeoffreyBooth |
|
| https://github.com/nodejs/node/pull/31757/files/052e1a9e644cea95546f57ff4a39beec5775c141 |
|
| https://github.com/hybrist |
|
hybrist
| https://github.com/hybrist |
|
| https://github.com/nodejs/node/pull/31757/files/052e1a9e644cea95546f57ff4a39beec5775c141 |
|
| https://github.com/MylesBorins |
|
MylesBorins
| https://github.com/MylesBorins |
|
| https://github.com/nodejs/node/pull/31757/files/052e1a9e644cea95546f57ff4a39beec5775c141 |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
module
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule |
| Please reload this page | https://github.com/nodejs/node/pull/31757 |
|
| https://github.com/guybedford |
|
| https://github.com/hybrist |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/MylesBorins |
|
| https://github.com/ljharb |
|
| https://github.com/GeoffreyBooth |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |