René's URL Explorer Experiment


Title: worker_threads: proper env and NODE_OPTIONS handling by lundibundi · Pull Request #31711 · nodejs/node · GitHub

Open Graph Title: worker_threads: proper env and NODE_OPTIONS handling by lundibundi · Pull Request #31711 · nodejs/node

X Title: worker_threads: proper env and NODE_OPTIONS handling by lundibundi · Pull Request #31711 · nodejs/node

Description: Draft for now, as I still want to review the documentation and take another look at the code. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Closes: #30627 /cc @nodejs/workers @addaleax

Open Graph Description: Draft for now, as I still want to review the documentation and take another look at the code. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are inclu...

X Description: Draft for now, as I still want to review the documentation and take another look at the code. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are inclu...

Opengraph URL: https://github.com/nodejs/node/pull/31711

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9be2f9cd-64b0-3e83-b2b0-df453c5da181
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8EEA:115683:4DB7FB:67B72A:6A4C32D2
html-safe-nonce620d7a7866d8ccc6b70c3ea757d10555c227e0947d38139f2e38779f1f38c96e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RUVBOjExNTY4Mzo0REI3RkI6NjdCNzJBOjZBNEMzMkQyIiwidmlzaXRvcl9pZCI6IjU3Mzg1OTc1NTUwNjAzNTU3OTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac97134c8e5f8b324e6cde7d5d02ad7dbd1d2b01da41a62fbd647979cadb80abbe
hovercard-subject-tagpull_request:372881741
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/31711/files
twitter:imagehttps://avatars.githubusercontent.com/u/9109612?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9109612?s=400&v=4
og:image:altDraft for now, as I still want to review the documentation and take another look at the code. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are inclu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None1b6b16d04026f131a36d57e3b01d0f4d26a51800edf48bf5ed0256e0ac905511
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9ee13484b32cf23e15fde191da4c9aa47d41201c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31711/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31711%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31711%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31711/files
Reloadhttps://github.com/nodejs/node/pull/31711/files
Reloadhttps://github.com/nodejs/node/pull/31711/files
Please reload this pagehttps://github.com/nodejs/node/pull/31711/files
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/31711/files
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 967 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
lundibundihttps://github.com/lundibundi
nodejs:masterhttps://github.com/nodejs/node/tree/master
lundibundi:worker-proper-argv-handlinghttps://github.com/lundibundi/node/tree/worker-proper-argv-handling
Conversation 20 https://github.com/nodejs/node/pull/31711
Commits 2 https://github.com/nodejs/node/pull/31711/commits
Checks 0 https://github.com/nodejs/node/pull/31711/checks
Files changed https://github.com/nodejs/node/pull/31711/files
Please reload this pagehttps://github.com/nodejs/node/pull/31711/files
worker_threads: proper env and NODE_OPTIONS handling https://github.com/nodejs/node/pull/31711/files#top
Show all changes 2 commits https://github.com/nodejs/node/pull/31711/files
0c87f8c src: allow to reuse env options handling lundibundi Feb 9, 2020 https://github.com/nodejs/node/pull/31711/commits/0c87f8cb1359139316b220a46f461a7923f037f8
503003e worker_threads: properly handle env and NODE_OPTIONS in workers lundibundi Feb 9, 2020 https://github.com/nodejs/node/pull/31711/commits/503003eec63bf3ee1b6f5c7bb2f3e4e8b2c07073
Clear filters https://github.com/nodejs/node/pull/31711/files
Please reload this pagehttps://github.com/nodejs/node/pull/31711/files
Please reload this pagehttps://github.com/nodejs/node/pull/31711/files
errors.js https://github.com/nodejs/node/pull/31711/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
worker.js https://github.com/nodejs/node/pull/31711/files#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564
node.cc https://github.com/nodejs/node/pull/31711/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
node_options-inl.h https://github.com/nodejs/node/pull/31711/files#diff-9839d2ff827c6533c400880889fc1772119349be904a5aedf07bf4c5118bc4db
node_options.cc https://github.com/nodejs/node/pull/31711/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8
node_options.h https://github.com/nodejs/node/pull/31711/files#diff-a6dd6c44925932d3134081da80ed07216f5f66449f540442835557616bcd14f9
node_worker.cc https://github.com/nodejs/node/pull/31711/files#diff-b06b65a7f7e33816a1986d731765d732ab23f585bece6b23c5e83ca3682dba62
node_worker.h https://github.com/nodejs/node/pull/31711/files#diff-9128e8acf93d3308d3c2410b62fe8ee82d5fce8128e12d89e67a6eecf333f1fc
test-cli-node-options.js https://github.com/nodejs/node/pull/31711/files#diff-92036e8e1bc1f6cf849fcd5498840ba1dbbc53ba4d6335b81ea4f84426d30081
test-require-symlink.js https://github.com/nodejs/node/pull/31711/files#diff-db47cf10fc70a49e25fa3374dd7095217aecf850606fea9919bc3346670e3351
lib/internal/errors.jshttps://github.com/nodejs/node/pull/31711/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
View file https://github.com/lundibundi/node/blob/503003eec63bf3ee1b6f5c7bb2f3e4e8b2c07073/lib/internal/errors.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/31711/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/31711/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
addaleaxhttps://github.com/addaleax
Feb 9, 2020https://github.com/nodejs/node/pull/31711/files#r376822156
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31711/files
lundibundihttps://github.com/lundibundi
Feb 10, 2020https://github.com/nodejs/node/pull/31711/files#r377000016
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31711/files
addaleaxhttps://github.com/addaleax
Feb 10, 2020https://github.com/nodejs/node/pull/31711/files#r377090550
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31711/files
lundibundihttps://github.com/lundibundi
Feb 10, 2020https://github.com/nodejs/node/pull/31711/files#r377164753
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#31251https://github.com/nodejs/node/pull/31251
Please reload this pagehttps://github.com/nodejs/node/pull/31711/files
https://github.com/nodejs/node/pull/31711/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
lib/internal/worker.jshttps://github.com/nodejs/node/pull/31711/files#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564
View file https://github.com/lundibundi/node/blob/503003eec63bf3ee1b6f5c7bb2f3e4e8b2c07073/lib/internal/worker.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/31711/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/31711/files#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564
https://github.com/nodejs/node/pull/31711/files#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564
src/node.cchttps://github.com/nodejs/node/pull/31711/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
View file https://github.com/lundibundi/node/blob/503003eec63bf3ee1b6f5c7bb2f3e4e8b2c07073/src/node.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/31711/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/31711/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
https://github.com/nodejs/node/pull/31711/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
src/node_options-inl.hhttps://github.com/nodejs/node/pull/31711/files#diff-9839d2ff827c6533c400880889fc1772119349be904a5aedf07bf4c5118bc4db
View file https://github.com/lundibundi/node/blob/503003eec63bf3ee1b6f5c7bb2f3e4e8b2c07073/src/node_options-inl.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/31711/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/31711/files#diff-9839d2ff827c6533c400880889fc1772119349be904a5aedf07bf4c5118bc4db
https://github.com/nodejs/node/pull/31711/files#diff-9839d2ff827c6533c400880889fc1772119349be904a5aedf07bf4c5118bc4db
src/node_options.cchttps://github.com/nodejs/node/pull/31711/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8
View file https://github.com/lundibundi/node/blob/503003eec63bf3ee1b6f5c7bb2f3e4e8b2c07073/src/node_options.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/31711/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/31711/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8
https://github.com/nodejs/node/pull/31711/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8
https://github.com/nodejs/node/pull/31711/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8
Please reload this pagehttps://github.com/nodejs/node/pull/31711/files
src/node_options.hhttps://github.com/nodejs/node/pull/31711/files#diff-a6dd6c44925932d3134081da80ed07216f5f66449f540442835557616bcd14f9
View file https://github.com/lundibundi/node/blob/503003eec63bf3ee1b6f5c7bb2f3e4e8b2c07073/src/node_options.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/31711/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/31711/files#diff-a6dd6c44925932d3134081da80ed07216f5f66449f540442835557616bcd14f9
https://github.com/nodejs/node/pull/31711/files#diff-a6dd6c44925932d3134081da80ed07216f5f66449f540442835557616bcd14f9
Please reload this pagehttps://github.com/nodejs/node/pull/31711/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.