| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:01d04fbe-630f-0b22-f747-5ac11de9395b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E17A:2DCEFE:7189:8BAD:696B2C35 |
| html-safe-nonce | 4aa196f5d7c8f6798722b5b958979e0cc563a3633001cc8b7818f7691aac4d27 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTdBOjJEQ0VGRTo3MTg5OjhCQUQ6Njk2QjJDMzUiLCJ2aXNpdG9yX2lkIjoiNzk5MDY0NDkwNDg3NTk5NDE2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6bd4fe6c939e294f4b764b63bbd4d6bf2949a8cd35efdde970c061400aa29c28 |
| hovercard-subject-tag | pull_request:369884338 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31599/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fcb85ac15058d66efbc6e02c954a863ce37c51d5298a0e1ac3632f496cf70d8d/nodejs/node/pull/31599 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fcb85ac15058d66efbc6e02c954a863ce37c51d5298a0e1ac3632f496cf70d8d/nodejs/node/pull/31599 |
| og:image:alt | This fixes a compiler warning introduced in 9225939.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | addaleax |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/31599#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31599 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31599 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/31599 |
| Reload | https://github.com/nodejs/node/pull/31599 |
| Reload | https://github.com/nodejs/node/pull/31599 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/31599 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
691
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/31599 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/31599#issue-comment-box |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:worker-no-child-port | https://github.com/addaleax/node/tree/worker-no-child-port |
|
src: remove unused Worker::child_port_ member
| https://github.com/nodejs/node/pull/31599#top |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:worker-no-child-port | https://github.com/addaleax/node/tree/worker-no-child-port |
|
Conversation
4
| https://github.com/nodejs/node/pull/31599 |
|
Commits
1
| https://github.com/nodejs/node/pull/31599/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/31599/checks |
|
Files changed
| https://github.com/nodejs/node/pull/31599/files |
| Please reload this page | https://github.com/nodejs/node/pull/31599 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Feb 1, 2020 | https://github.com/nodejs/node/pull/31599#issue-558521996 |
| 9225939 | https://github.com/nodejs/node/commit/9225939528590f652e6ee1ccf73e709b029d4ca5 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/31599 |
|
| https://github.com/addaleax |
| src: remove unused Worker::child_port_ member | https://github.com/nodejs/node/pull/31599/commits/7735b2a904255caa53a581c918df3df47e5c8e52 |
| 7735b2a | https://github.com/nodejs/node/pull/31599/commits/7735b2a904255caa53a581c918df3df47e5c8e52 |
| 9225939 | https://github.com/addaleax/node/commit/9225939528590f652e6ee1ccf73e709b029d4ca5 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
worker
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker |
| Feb 1, 2020 | https://github.com/nodejs/node/pull/31599#event-2999266618 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Feb 1, 2020
| https://github.com/nodejs/node/pull/31599#pullrequestreview-351886676 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31599/files/7735b2a904255caa53a581c918df3df47e5c8e52 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 1, 2020
| https://github.com/nodejs/node/pull/31599#pullrequestreview-351896056 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31599/files/7735b2a904255caa53a581c918df3df47e5c8e52 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Feb 1, 2020
| https://github.com/nodejs/node/pull/31599#pullrequestreview-351902237 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31599/files/7735b2a904255caa53a581c918df3df47e5c8e52 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Feb 3, 2020
| https://github.com/nodejs/node/pull/31599#pullrequestreview-352004108 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31599/files/7735b2a904255caa53a581c918df3df47e5c8e52 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Feb 3, 2020 | https://github.com/nodejs/node/pull/31599#issuecomment-581241643 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4127/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4127/ |
| Please reload this page | https://github.com/nodejs/node/pull/31599 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Feb 3, 2020
| https://github.com/nodejs/node/pull/31599#pullrequestreview-352286651 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31599/files/7735b2a904255caa53a581c918df3df47e5c8e52 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 3, 2020 | https://github.com/nodejs/node/pull/31599#issuecomment-581459357 |
| https://ci.nodejs.org/job/node-test-pull-request/28895/ | https://ci.nodejs.org/job/node-test-pull-request/28895/ |
| Please reload this page | https://github.com/nodejs/node/pull/31599 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 4, 2020 | https://github.com/nodejs/node/pull/31599#issuecomment-581746297 |
| https://ci.nodejs.org/job/node-test-pull-request/28915/ | https://ci.nodejs.org/job/node-test-pull-request/28915/ |
| Please reload this page | https://github.com/nodejs/node/pull/31599 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Feb 4, 2020 | https://github.com/nodejs/node/pull/31599#event-3004809937 |
| danbev | https://github.com/danbev |
|
Feb 4, 2020
| https://github.com/nodejs/node/pull/31599#ref-commit-60de60a |
|
| https://github.com/addaleax |
|
| https://github.com/danbev |
| src: remove unused Worker::child_port_ member | https://github.com/nodejs/node/commit/60de60a0ce21378c80353489759dc70f05156cc7 |
| 60de60a | https://github.com/nodejs/node/commit/60de60a0ce21378c80353489759dc70f05156cc7 |
| 9225939 | https://github.com/nodejs/node/commit/9225939528590f652e6ee1ccf73e709b029d4ca5 |
| #31599 | https://github.com/nodejs/node/pull/31599 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Feb 4, 2020 | https://github.com/nodejs/node/pull/31599#issuecomment-581757076 |
| 60de60a | https://github.com/nodejs/node/commit/60de60a0ce21378c80353489759dc70f05156cc7 |
| Please reload this page | https://github.com/nodejs/node/pull/31599 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Feb 4, 2020 | https://github.com/nodejs/node/pull/31599#event-3004814308 |
| codebytere | https://github.com/codebytere |
|
Feb 17, 2020
| https://github.com/nodejs/node/pull/31599#ref-commit-425662e |
|
| https://github.com/addaleax |
|
| https://github.com/codebytere |
| src: remove unused Worker::child_port_ member | https://github.com/nodejs/node/commit/425662e2d67b907edd1ddb6f69dd2c4a48d12d8b |
| 425662e | https://github.com/nodejs/node/commit/425662e2d67b907edd1ddb6f69dd2c4a48d12d8b |
| 9225939 | https://github.com/nodejs/node/commit/9225939528590f652e6ee1ccf73e709b029d4ca5 |
| #31599 | https://github.com/nodejs/node/pull/31599 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Feb 17, 2020
| https://github.com/nodejs/node/pull/31599#ref-pullrequest-566518355 |
|
v13.9.0 proposal
#31837
| https://github.com/nodejs/node/pull/31837 |
| codebytere | https://github.com/codebytere |
|
Mar 15, 2020
| https://github.com/nodejs/node/pull/31599#ref-commit-ae9ea95 |
|
| https://github.com/addaleax |
|
| https://github.com/codebytere |
| src: remove unused Worker::child_port_ member | https://github.com/nodejs/node/commit/ae9ea95d7a8265f40c4dc534f42411dce482efac |
| ae9ea95 | https://github.com/nodejs/node/commit/ae9ea95d7a8265f40c4dc534f42411dce482efac |
| 9225939 | https://github.com/nodejs/node/commit/9225939528590f652e6ee1ccf73e709b029d4ca5 |
| #31599 | https://github.com/nodejs/node/pull/31599 |
| codebytere | https://github.com/codebytere |
|
Mar 17, 2020
| https://github.com/nodejs/node/pull/31599#ref-commit-f434c8c |
|
| https://github.com/addaleax |
|
| https://github.com/codebytere |
| src: remove unused Worker::child_port_ member | https://github.com/nodejs/node/commit/f434c8c2d76b7a7164da506a8b2173bb27ceb238 |
| f434c8c | https://github.com/nodejs/node/commit/f434c8c2d76b7a7164da506a8b2173bb27ceb238 |
| 9225939 | https://github.com/nodejs/node/commit/9225939528590f652e6ee1ccf73e709b029d4ca5 |
| #31599 | https://github.com/nodejs/node/pull/31599 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Mar 17, 2020
| https://github.com/nodejs/node/pull/31599#ref-pullrequest-582721275 |
|
v12.16.2 proposal
#32313
| https://github.com/nodejs/node/pull/32313 |
| codebytere | https://github.com/codebytere |
|
Mar 30, 2020
| https://github.com/nodejs/node/pull/31599#ref-commit-753db6a |
|
| https://github.com/addaleax |
|
| https://github.com/codebytere |
| src: remove unused Worker::child_port_ member | https://github.com/nodejs/node/commit/753db6aee2f76d9e4810fa39ac86b9d425c6688c |
| 753db6a | https://github.com/nodejs/node/commit/753db6aee2f76d9e4810fa39ac86b9d425c6688c |
| 9225939 | https://github.com/nodejs/node/commit/9225939528590f652e6ee1ccf73e709b029d4ca5 |
| #31599 | https://github.com/nodejs/node/pull/31599 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31599 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/31599/files/7735b2a904255caa53a581c918df3df47e5c8e52 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/31599/files/7735b2a904255caa53a581c918df3df47e5c8e52 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/31599/files/7735b2a904255caa53a581c918df3df47e5c8e52 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/31599/files/7735b2a904255caa53a581c918df3df47e5c8e52 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/31599/files/7735b2a904255caa53a581c918df3df47e5c8e52 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
worker
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker |
| Please reload this page | https://github.com/nodejs/node/pull/31599 |
|
| https://github.com/addaleax |
|
| https://github.com/danbev |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/Trott |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/gireeshpunathil |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |