René's URL Explorer Experiment


Title: stream: fix finished writable/readable state by ronag · Pull Request #31527 · nodejs/node · GitHub

Open Graph Title: stream: fix finished writable/readable state by ronag · Pull Request #31527 · nodejs/node

X Title: stream: fix finished writable/readable state by ronag · Pull Request #31527 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: writable/readable does not indicate whether as stream is a Writable/Readable. This implements a better check for whether a object is a Writable/Readable. Checklist make -j4 test (UNIX), or vcbu...

X Description: writable/readable does not indicate whether as stream is a Writable/Readable. This implements a better check for whether a object is a Writable/Readable. Checklist make -j4 test (UNIX), or vcbu...

Opengraph URL: https://github.com/nodejs/node/pull/31527

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8076707d-a023-9dab-e562-ba0270c89104
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD03A:5E42D:300A633:4346605:6A50EA0E
html-safe-nonce5c4ed399a90259bdd7150b184a6e3f02deb540d1bc4e8c5c8dfe5983303e1d2d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDNBOjVFNDJEOjMwMEE2MzM6NDM0NjYwNTo2QTUwRUEwRSIsInZpc2l0b3JfaWQiOiI0MzUyNzg4MTIzMjA3Mzk1ODU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb5cab33232e72be169ea624475e42a3a9400487c5450d0ad486c785012b589a8
hovercard-subject-tagpull_request:367266732
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31527/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bd377ba38524b34a21414521b5c19df59f1b2fff440aef46d7104e0d6718b095/nodejs/node/pull/31527
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bd377ba38524b34a21414521b5c19df59f1b2fff440aef46d7104e0d6718b095/nodejs/node/pull/31527
og:image:altwritable/readable does not indicate whether as stream is a Writable/Readable. This implements a better check for whether a object is a Writable/Readable. Checklist make -j4 test (UNIX), or vcbu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefb19d617b534959801b4b7453938ecf1dfa22131
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31527#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31527
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31527
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31527
Reloadhttps://github.com/nodejs/node/pull/31527
Reloadhttps://github.com/nodejs/node/pull/31527
Please reload this pagehttps://github.com/nodejs/node/pull/31527
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/31527
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 978 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:eos-finished-readablehttps://github.com/nxtedition/node/tree/eos-finished-readable
Conversationhttps://github.com/nodejs/node/pull/31527
Commits2 (2)https://github.com/nodejs/node/pull/31527/commits
Checkshttps://github.com/nodejs/node/pull/31527/checks
Files changedhttps://github.com/nodejs/node/pull/31527/files
stream: fix finished writable/readable statehttps://github.com/nodejs/node/pull/31527#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:eos-finished-readablehttps://github.com/nxtedition/node/tree/eos-finished-readable
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 26, 2020https://github.com/nodejs/node/pull/31527#issue-555295351
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/31527
https://github.com/ronag
stream: fix finished writable/readable statehttps://github.com/nodejs/node/pull/31527/commits/428485925dd5c4a96a8cafe28b2b04e0e7a06846
4284859https://github.com/nodejs/node/pull/31527/commits/428485925dd5c4a96a8cafe28b2b04e0e7a06846
https://github.com/ronag
ronaghttps://github.com/ronag
lpincahttps://github.com/lpinca
mafintoshhttps://github.com/mafintosh
mcollinahttps://github.com/mcollina
January 26, 2020 22:09https://github.com/nodejs/node/pull/31527#event-2980205252
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 26, 2020https://github.com/nodejs/node/pull/31527#issuecomment-578548530
Please reload this pagehttps://github.com/nodejs/node/pull/31527
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 26, 2020https://github.com/nodejs/node/pull/31527#issuecomment-578548923
Please reload this pagehttps://github.com/nodejs/node/pull/31527
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 26, 2020https://github.com/nodejs/node/pull/31527#issuecomment-578549857
Please reload this pagehttps://github.com/nodejs/node/pull/31527
https://github.com/mcollina
mcollinahttps://github.com/mcollina
baking-for-lts https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts
Jan 26, 2020https://github.com/nodejs/node/pull/31527#event-2980220375
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 26, 2020https://github.com/nodejs/node/pull/31527#issuecomment-578550972
Please reload this pagehttps://github.com/nodejs/node/pull/31527
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 26, 2020 https://github.com/nodejs/node/pull/31527#pullrequestreview-348409256
View reviewed changes https://github.com/nodejs/node/pull/31527/files/428485925dd5c4a96a8cafe28b2b04e0e7a06846
lib/internal/streams/end-of-stream.jshttps://github.com/nodejs/node/pull/31527/files/428485925dd5c4a96a8cafe28b2b04e0e7a06846#diff-f355a772a51133f54ef288a365ec05a70b9f3f2e0a2f46f5ba2612e31a62f810
Please reload this pagehttps://github.com/nodejs/node/pull/31527
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 26, 2020https://github.com/nodejs/node/pull/31527#issuecomment-578551442
Please reload this pagehttps://github.com/nodejs/node/pull/31527
https://github.com/ronag
fixup: add Readdable testhttps://github.com/nodejs/node/pull/31527/commits/818e972f7d73620795c69f781b9eabac69805326
818e972https://github.com/nodejs/node/pull/31527/commits/818e972f7d73620795c69f781b9eabac69805326
https://github.com/ronag
ronaghttps://github.com/ronag
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jan 26, 2020https://github.com/nodejs/node/pull/31527#event-2980224193
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 26, 2020https://github.com/nodejs/node/pull/31527#issuecomment-578555695
Please reload this pagehttps://github.com/nodejs/node/pull/31527
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 27, 2020 https://github.com/nodejs/node/pull/31527#pullrequestreview-348460947
View reviewed changes https://github.com/nodejs/node/pull/31527/files/818e972f7d73620795c69f781b9eabac69805326
test/parallel/test-stream-finished.jshttps://github.com/nodejs/node/pull/31527/files/818e972f7d73620795c69f781b9eabac69805326#diff-8d1e590f7f886b8a511a291673bc2a48fa5a189b39317e5854196947c39548b1
Please reload this pagehttps://github.com/nodejs/node/pull/31527
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 27, 2020 https://github.com/nodejs/node/pull/31527#pullrequestreview-348485860
View reviewed changes https://github.com/nodejs/node/pull/31527/files/818e972f7d73620795c69f781b9eabac69805326
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 27, 2020https://github.com/nodejs/node/pull/31527#issuecomment-578650080
https://ci.nodejs.org/job/node-test-pull-request/28712/https://ci.nodejs.org/job/node-test-pull-request/28712/
Please reload this pagehttps://github.com/nodejs/node/pull/31527
https://github.com/ronag
ronaghttps://github.com/ronag
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 27, 2020https://github.com/nodejs/node/pull/31527#event-2980953794
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 27, 2020https://github.com/nodejs/node/pull/31527#issuecomment-578650448
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/31527
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 27, 2020 https://github.com/nodejs/node/pull/31527#pullrequestreview-348508975
View reviewed changes https://github.com/nodejs/node/pull/31527/files/818e972f7d73620795c69f781b9eabac69805326
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/31527#pullrequestreview-348508975
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31527
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 27, 2020https://github.com/nodejs/node/pull/31527#issuecomment-578661098
https://ci.nodejs.org/job/node-test-pull-request/28713/https://ci.nodejs.org/job/node-test-pull-request/28713/
Please reload this pagehttps://github.com/nodejs/node/pull/31527
https://github.com/JungMinu
JungMinuhttps://github.com/JungMinu
Jan 27, 2020 https://github.com/nodejs/node/pull/31527#pullrequestreview-348831215
View reviewed changes https://github.com/nodejs/node/pull/31527/files/818e972f7d73620795c69f781b9eabac69805326
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 28, 2020 https://github.com/nodejs/node/pull/31527#pullrequestreview-349426195
View reviewed changes https://github.com/nodejs/node/pull/31527/files/818e972f7d73620795c69f781b9eabac69805326
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 29, 2020https://github.com/nodejs/node/pull/31527#issuecomment-579579619
b851d7bhttps://github.com/nodejs/node/commit/b851d7b98644bc81adcd905dbebda102eeedd888
Please reload this pagehttps://github.com/nodejs/node/pull/31527
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 29, 2020https://github.com/nodejs/node/pull/31527#event-2988081354
Trotthttps://github.com/Trott
Jan 29, 2020 https://github.com/nodejs/node/pull/31527#ref-commit-b851d7b
https://github.com/ronag
https://github.com/Trott
stream: fix finished writable/readable statehttps://github.com/Trott/io.js/commit/b851d7b98644bc81adcd905dbebda102eeedd888
b851d7bhttps://github.com/Trott/io.js/commit/b851d7b98644bc81adcd905dbebda102eeedd888
nodejs#31527https://github.com/nodejs/node/pull/31527
codebyterehttps://github.com/codebytere
Feb 17, 2020 https://github.com/nodejs/node/pull/31527#ref-commit-f255053
https://github.com/ronag
https://github.com/codebytere
stream: fix finished writable/readable statehttps://github.com/nodejs/node/commit/f2550530339444794e830aa0448a9dfbd58a0987
f255053https://github.com/nodejs/node/commit/f2550530339444794e830aa0448a9dfbd58a0987
#31527https://github.com/nodejs/node/pull/31527
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Feb 17, 2020 https://github.com/nodejs/node/pull/31527#ref-pullrequest-566518355
v13.9.0 proposal #31837 https://github.com/nodejs/node/pull/31837
https://github.com/targos
targoshttps://github.com/targos
backport-blocked-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v12.x
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 25, 2020https://github.com/nodejs/node/pull/31527#event-3272218991
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 2, 2020 https://github.com/nodejs/node/pull/31527#ref-pullrequest-655960801
stream: Rename opts to options #34339 https://github.com/nodejs/node/pull/34339
https://github.com/targos
targoshttps://github.com/targos
baking-for-lts https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts
Sep 16, 2022https://github.com/nodejs/node/pull/31527#event-7401919110
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31527
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/31527/files/818e972f7d73620795c69f781b9eabac69805326
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/31527/files/818e972f7d73620795c69f781b9eabac69805326
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/31527/files/818e972f7d73620795c69f781b9eabac69805326
https://github.com/JungMinu
JungMinu https://github.com/JungMinu
https://github.com/nodejs/node/pull/31527/files/818e972f7d73620795c69f781b9eabac69805326
https://github.com/mafintosh
mafintosh https://github.com/mafintosh
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/31527
https://github.com/ronag
https://github.com/mcollina
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/lpinca
https://github.com/JungMinu
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.