René's URL Explorer Experiment


Title: stream: finished should invoke callback for closed streams by ronag · Pull Request #31509 · nodejs/node · GitHub

Open Graph Title: stream: finished should invoke callback for closed streams by ronag · Pull Request #31509 · nodejs/node

X Title: stream: finished should invoke callback for closed streams by ronag · Pull Request #31509 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Previously finished(stream, cb) would not invoke the callback for streams that have already finished, ended or errored before being passed to finished(stream, cb). Ref: #31508 Ref: #31314 (comment)...

X Description: Previously finished(stream, cb) would not invoke the callback for streams that have already finished, ended or errored before being passed to finished(stream, cb). Ref: #31508 Ref: #31314 (comment)...

Opengraph URL: https://github.com/nodejs/node/pull/31509

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:84745695-3793-28b3-f7ce-169d1137c24c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDE32:257BEE:10A8D53:1627889:6AED542F
html-safe-nonce25deb980e8b042954088ef336e2b112c0775b9cd8c30f04644750841bfeec96c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTMyOjI1N0JFRToxMEE4RDUzOjE2Mjc4ODk6NkFFRDU0MkYiLCJ2aXNpdG9yX2lkIjoiNTAyMTcwNzc5NjE0MzIzMjA0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7f0e92cc83a4040ee19071f97080f07cd0ed82b474e9df58b8a38a6d06d6f0ab
hovercard-subject-tagpull_request:367131423
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31509/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6a403c1bfd55247f4f57fa0b8b829866931e27e9c8ab398f814aa682e8fb18a8/nodejs/node/pull/31509
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6a403c1bfd55247f4f57fa0b8b829866931e27e9c8ab398f814aa682e8fb18a8/nodejs/node/pull/31509
og:image:altPreviously finished(stream, cb) would not invoke the callback for streams that have already finished, ended or errored before being passed to finished(stream, cb). Ref: #31508 Ref: #31314 (comment)...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31509#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31509
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31509
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31509
Reloadhttps://github.com/nodejs/node/pull/31509
Reloadhttps://github.com/nodejs/node/pull/31509
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:eos-closedhttps://github.com/nxtedition/node/tree/eos-closed
Conversationhttps://github.com/nodejs/node/pull/31509
Commits2 (2)https://github.com/nodejs/node/pull/31509/commits
Checkshttps://github.com/nodejs/node/pull/31509/checks
Files changedhttps://github.com/nodejs/node/pull/31509/files
stream: finished should invoke callback for closed streamshttps://github.com/nodejs/node/pull/31509#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:eos-closedhttps://github.com/nxtedition/node/tree/eos-closed
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 25, 2020https://github.com/nodejs/node/pull/31509#issue-555105431
Please reload this pagehttps://github.com/nodejs/node/pull/31509
#31508https://github.com/nodejs/node/pull/31508
#31314 (comment)https://github.com/nodejs/node/pull/31314#issuecomment-578397279
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Jan 25, 2020https://github.com/nodejs/node/pull/31509#event-2979397586
https://github.com/ronag
ronaghttps://github.com/ronag
mcollinahttps://github.com/mcollina
January 25, 2020 16:33https://github.com/nodejs/node/pull/31509#event-2979397655
https://github.com/ronag
ronaghttps://github.com/ronag
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jan 25, 2020https://github.com/nodejs/node/pull/31509#event-2979397673
https://github.com/ronag
ronaghttps://github.com/ronag
lpincahttps://github.com/lpinca
mafintoshhttps://github.com/mafintosh
January 25, 2020 16:37https://github.com/nodejs/node/pull/31509#event-2979399453
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 25, 2020 https://github.com/nodejs/node/pull/31509#pullrequestreview-348333930
View reviewed changes https://github.com/nodejs/node/pull/31509/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/31509#pullrequestreview-348333930
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 25, 2020https://github.com/nodejs/node/pull/31509#issuecomment-578422494
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
ronaghttps://github.com/ronag
mcollinahttps://github.com/mcollina
January 25, 2020 16:54https://github.com/nodejs/node/pull/31509#event-2979408278
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/1fa0d4fe84695913a64e3ceb73b6285a63fa5577..9739e883b88ef88d0d4e4556ff8cd3f239e85527
1fa0d4fhttps://github.com/nodejs/node/commit/1fa0d4fe84695913a64e3ceb73b6285a63fa5577
9739e88https://github.com/nodejs/node/commit/9739e883b88ef88d0d4e4556ff8cd3f239e85527
Compare https://github.com/nodejs/node/compare/1fa0d4fe84695913a64e3ceb73b6285a63fa5577..9739e883b88ef88d0d4e4556ff8cd3f239e85527
January 25, 2020 16:56https://github.com/nodejs/node/pull/31509#event-2979408926
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 25, 2020https://github.com/nodejs/node/pull/31509#issuecomment-578422686
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 25, 2020https://github.com/nodejs/node/pull/31509#issuecomment-578422950
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 25, 2020https://github.com/nodejs/node/pull/31509#issuecomment-578423294
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 25, 2020https://github.com/nodejs/node/pull/31509#issuecomment-578423392
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 25, 2020https://github.com/nodejs/node/pull/31509#issuecomment-578424415
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 25, 2020https://github.com/nodejs/node/pull/31509#issuecomment-578437204
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 25, 2020https://github.com/nodejs/node/pull/31509#issuecomment-578453179
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 26, 2020https://github.com/nodejs/node/pull/31509#issuecomment-578475101
@jasnellhttps://github.com/jasnell
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 26, 2020https://github.com/nodejs/node/pull/31509#issuecomment-578475440
https://ci.nodejs.org/job/node-test-pull-request/28676/https://ci.nodejs.org/job/node-test-pull-request/28676/
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/7d918c2b6efe4f11f050c6ccb1233a89fdb083fd..dc32141666e22e20210032a3e4b6ed1d33cc7b56
7d918c2https://github.com/nodejs/node/commit/7d918c2b6efe4f11f050c6ccb1233a89fdb083fd
dc32141https://github.com/nodejs/node/commit/dc32141666e22e20210032a3e4b6ed1d33cc7b56
Compare https://github.com/nodejs/node/compare/7d918c2b6efe4f11f050c6ccb1233a89fdb083fd..dc32141666e22e20210032a3e4b6ed1d33cc7b56
January 26, 2020 17:28https://github.com/nodejs/node/pull/31509#event-2980051953
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 26, 2020https://github.com/nodejs/node/pull/31509#issuecomment-578523904
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 26, 2020https://github.com/nodejs/node/pull/31509#issuecomment-578523959
https://ci.nodejs.org/job/node-test-pull-request/28691/https://ci.nodejs.org/job/node-test-pull-request/28691/
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 26, 2020https://github.com/nodejs/node/pull/31509#issuecomment-578547143
https://ci.nodejs.org/job/node-test-pull-request/28702/https://ci.nodejs.org/job/node-test-pull-request/28702/
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 26, 2020 https://github.com/nodejs/node/pull/31509#ref-pullrequest-555073122
stream: fix async iterator return when destroyed earlier #31508 https://github.com/nodejs/node/pull/31508
https://github.com/ronag
ronaghttps://github.com/ronag
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 26, 2020https://github.com/nodejs/node/pull/31509#event-2980232252
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 27, 2020https://github.com/nodejs/node/pull/31509#issuecomment-578600417
@mcollinahttps://github.com/mcollina
change requesthttps://github.com/nodejs/node/pull/31509#pullrequestreview-348333930
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 27, 2020https://github.com/nodejs/node/pull/31509#issuecomment-578600535
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 27, 2020https://github.com/nodejs/node/pull/31509#event-2980573920
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 27, 2020 https://github.com/nodejs/node/pull/31509#pullrequestreview-348467976
View reviewed changes https://github.com/nodejs/node/pull/31509/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/31509#pullrequestreview-348467976
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 27, 2020 https://github.com/nodejs/node/pull/31509#ref-pullrequest-555295351
stream: fix finished writable/readable state #31527 https://github.com/nodejs/node/pull/31527
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/c29f54802b3c9977f4e5f3b84d813b8834dc1472..066ca5211021a35afbb9b87755f3184a9a11ed47
c29f548https://github.com/nodejs/node/commit/c29f54802b3c9977f4e5f3b84d813b8834dc1472
066ca52https://github.com/nodejs/node/commit/066ca5211021a35afbb9b87755f3184a9a11ed47
Compare https://github.com/nodejs/node/compare/c29f54802b3c9977f4e5f3b84d813b8834dc1472..066ca5211021a35afbb9b87755f3184a9a11ed47
January 29, 2020 07:59https://github.com/nodejs/node/pull/31509#event-2988515417
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 29, 2020https://github.com/nodejs/node/pull/31509#issuecomment-579640643
Please reload this pagehttps://github.com/nodejs/node/pull/31509
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31509
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31509
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 31, 2020https://github.com/nodejs/node/pull/31509#issuecomment-580893413
https://ci.nodejs.org/job/node-test-pull-request/28815/https://ci.nodejs.org/job/node-test-pull-request/28815/
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 31, 2020https://github.com/nodejs/node/pull/31509#issuecomment-580905336
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 31, 2020https://github.com/nodejs/node/pull/31509#issuecomment-580914262
Please reload this pagehttps://github.com/nodejs/node/pull/31509
#31596https://github.com/nodejs/node/issues/31596
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 1, 2020https://github.com/nodejs/node/pull/31509#issuecomment-581064895
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/Trott
Trotthttps://github.com/Trott
Feb 5, 2020https://github.com/nodejs/node/pull/31509#issuecomment-582569921
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
stream: finished should invoke callback for closed streamshttps://github.com/nodejs/node/pull/31509/commits/f90f2a1d97b92fd57b700096a76d91e71a9dcec8
f90f2a1https://github.com/nodejs/node/pull/31509/commits/f90f2a1d97b92fd57b700096a76d91e71a9dcec8
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 5, 2020https://github.com/nodejs/node/pull/31509#issuecomment-582615422
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/066ca5211021a35afbb9b87755f3184a9a11ed47..f90f2a1d97b92fd57b700096a76d91e71a9dcec8
066ca52https://github.com/nodejs/node/commit/066ca5211021a35afbb9b87755f3184a9a11ed47
f90f2a1https://github.com/nodejs/node/commit/f90f2a1d97b92fd57b700096a76d91e71a9dcec8
Compare https://github.com/nodejs/node/compare/066ca5211021a35afbb9b87755f3184a9a11ed47..f90f2a1d97b92fd57b700096a76d91e71a9dcec8
February 5, 2020 21:13https://github.com/nodejs/node/pull/31509#event-3011626836
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 7, 2020https://github.com/nodejs/node/pull/31509#issuecomment-583356872
https://ci.nodejs.org/job/node-test-pull-request/28982/https://ci.nodejs.org/job/node-test-pull-request/28982/
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
fixup: bad mergehttps://github.com/nodejs/node/pull/31509/commits/2203706656a7c9a39ea12cebaab5fc41b0eb2fdd
2203706https://github.com/nodejs/node/pull/31509/commits/2203706656a7c9a39ea12cebaab5fc41b0eb2fdd
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 8, 2020https://github.com/nodejs/node/pull/31509#issuecomment-583745387
https://ci.nodejs.org/job/node-test-pull-request/29021/https://ci.nodejs.org/job/node-test-pull-request/29021/
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 8, 2020https://github.com/nodejs/node/pull/31509#issuecomment-583761329
https://ci.nodejs.org/job/node-test-pull-request/29027/https://ci.nodejs.org/job/node-test-pull-request/29027/
Please reload this pagehttps://github.com/nodejs/node/pull/31509
ronaghttps://github.com/ronag
Feb 8, 2020 https://github.com/nodejs/node/pull/31509#ref-commit-d016b9d
https://github.com/ronag
stream: finished callback for closed streamshttps://github.com/nodejs/node/commit/d016b9d70897b7702e7862252d768ecdde89bc48
https://github.com/nodejs/node/commit/d016b9d70897b7702e7862252d768ecdde89bc48#comments
d016b9dhttps://github.com/nodejs/node/commit/d016b9d70897b7702e7862252d768ecdde89bc48
#31509https://github.com/nodejs/node/pull/31509
#31508https://github.com/nodejs/node/pull/31508
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 8, 2020https://github.com/nodejs/node/pull/31509#issuecomment-583783614
d016b9dhttps://github.com/nodejs/node/commit/d016b9d70897b7702e7862252d768ecdde89bc48
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 8, 2020https://github.com/nodejs/node/pull/31509#event-3020203846
https://github.com/lpinca
lpincahttps://github.com/lpinca
Feb 16, 2020 https://github.com/nodejs/node/pull/31509#ref-pullrequest-565884810
http: align with stream.Writable #31818 https://github.com/nodejs/node/pull/31818
https://github.com/swarthy
swarthyhttps://github.com/swarthy
Feb 20, 2020 https://github.com/nodejs/node/pull/31509#pullrequestreview-361664656
View reviewed changes https://github.com/nodejs/node/pull/31509/files/2203706656a7c9a39ea12cebaab5fc41b0eb2fdd
lib/internal/streams/end-of-stream.jshttps://github.com/nodejs/node/pull/31509/files/2203706656a7c9a39ea12cebaab5fc41b0eb2fdd#diff-f355a772a51133f54ef288a365ec05a70b9f3f2e0a2f46f5ba2612e31a62f810
swarthyhttps://github.com/swarthy
Feb 20, 2020https://github.com/nodejs/node/pull/31509#discussion_r381809355
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 20, 2020 https://github.com/nodejs/node/pull/31509#ref-pullrequest-568109853
stream: fix finished typo #31881 https://github.com/nodejs/node/pull/31881
ronaghttps://github.com/ronag
Feb 20, 2020 https://github.com/nodejs/node/pull/31509#ref-commit-242ccc2
https://github.com/ronag
stream: fix finished typohttps://github.com/nxtedition/node/commit/242ccc2e52bd6d4871972554d07b8a1820f97dc4
242ccc2https://github.com/nxtedition/node/commit/242ccc2e52bd6d4871972554d07b8a1820f97dc4
nodejs#31509https://github.com/nodejs/node/pull/31509
nodejs#31509 (comment)https://github.com/nodejs/node/pull/31509#discussion_r381809355
ronaghttps://github.com/ronag
Feb 22, 2020 https://github.com/nodejs/node/pull/31509#ref-commit-21bd667
https://github.com/ronag
stream: fix finished typohttps://github.com/nodejs/node/commit/21bd6679ce150e193cacd4b1b6585928224f255a
21bd667https://github.com/nodejs/node/commit/21bd6679ce150e193cacd4b1b6585928224f255a
#31509https://github.com/nodejs/node/pull/31509
#31509 (comment)https://github.com/nodejs/node/pull/31509#discussion_r381809355
#31881https://github.com/nodejs/node/pull/31881
#31509https://github.com/nodejs/node/pull/31509
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 29, 2020 https://github.com/nodejs/node/pull/31509#ref-pullrequest-573259495
stream: make stream.destroy with callback API public #32021 https://github.com/nodejs/node/pull/32021
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Mar 10, 2020 https://github.com/nodejs/node/pull/31509#ref-pullrequest-578760228
2020-04-21, Version 14.0.0 (Current) #32181 https://github.com/nodejs/node/pull/32181
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 14, 2020 https://github.com/nodejs/node/pull/31509#ref-issue-467339704
eos and pipeline will deadlock if streams are not in assumed state #28650 https://github.com/nodejs/node/issues/28650
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 25, 2020 https://github.com/nodejs/node/pull/31509#ref-pullrequest-606837246
doc: document major finished changes in v14 #33065 https://github.com/nodejs/node/pull/33065
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31509
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/31509/files/dc32141666e22e20210032a3e4b6ed1d33cc7b56
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/31509/files/c29f54802b3c9977f4e5f3b84d813b8834dc1472
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/31509/files/c29f54802b3c9977f4e5f3b84d813b8834dc1472
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/mafintosh
mafintosh https://github.com/mafintosh
https://github.com/swarthy
swarthy https://github.com/swarthy
https://github.com/nodejs/node/pull/31509/files/2203706656a7c9a39ea12cebaab5fc41b0eb2fdd
Please reload this pagehttps://github.com/nodejs/node/pull/31509
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/31509
https://github.com/ronag
https://github.com/lpinca
https://github.com/mcollina
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jasnell
https://github.com/swarthy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.