René's URL Explorer Experiment

Title: stream: fix async iterator return when destroyed earlier by mcollina · Pull Request #31508 · nodejs/node · GitHub

Open Graph Title: stream: fix async iterator return when destroyed earlier by mcollina · Pull Request #31508 · nodejs/node

X Title: stream: fix async iterator return when destroyed earlier by mcollina · Pull Request #31508 · nodejs/node

Description: Unfortunately, #31314 introduced a regression that made the loop not terminate: 'use strict' const { Readable } = require('stream') const r = new Readable({ read () {} }) r.destroy() async function run () { for await (let chunk of r) { } } r.on('close', () => { console.log('close emitted') run().then(() => console.log('finished')) }) I see that as more critical as an error not being forwarded. See #31314 (comment) for more details. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

Open Graph Description: Unfortunately, #31314 introduced a regression that made the loop not terminate: 'use strict' const { Readable } = require('stream') const r = new Readable({ read () {} }) r.des...

X Description: Unfortunately, #31314 introduced a regression that made the loop not terminate: 'use strict' const { Readable } = require('stream') const r = new Readable({ read...

Opengraph URL: https://github.com/nodejs/node/pull/31508

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width