| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a9f193e4-44d7-d7a9-a2c0-2d4886fb482d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AE90:1672C1:13F348B:1A0AD89:696B1ACC |
| html-safe-nonce | 42e5c81d85259eea22f5c1ce135297cc125295856fb7b0cd4d1a3db9fc078b91 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTkwOjE2NzJDMToxM0YzNDhCOjFBMEFEODk6Njk2QjFBQ0MiLCJ2aXNpdG9yX2lkIjoiODIwNzk1OTY3MTU0OTEzOTY2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 41ca9b0e0811337c6a56d09415de6fab95a25014b1e332d444c4da61c121ce1c |
| hovercard-subject-tag | pull_request:366388626 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31475/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9992eebf314885ad45195b91fb84d43b1fd5abe179f1c8e93a8d2801775e1d1d/nodejs/node/pull/31475 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9992eebf314885ad45195b91fb84d43b1fd5abe179f1c8e93a8d2801775e1d1d/nodejs/node/pull/31475 |
| og:image:alt | This commit suggests that cast-function-type warnings be ignored
from v8.h. Currently, GCC reports a number of warnings like this:
In file included from ../src/util.h:27,
from ../s... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | danbev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/31475#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31475 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31475 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/31475 |
| Reload | https://github.com/nodejs/node/pull/31475 |
| Reload | https://github.com/nodejs/node/pull/31475 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/31475 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
691
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/31475 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/31475#issue-comment-box |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:gcc-v8-cast-function-type | https://github.com/danbev/node/tree/gcc-v8-cast-function-type |
|
src: ignore GCC -Wcast-function-type for v8.h
| https://github.com/nodejs/node/pull/31475#top |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:gcc-v8-cast-function-type | https://github.com/danbev/node/tree/gcc-v8-cast-function-type |
|
Conversation
9
| https://github.com/nodejs/node/pull/31475 |
|
Commits
1
| https://github.com/nodejs/node/pull/31475/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/31475/checks |
|
Files changed
| https://github.com/nodejs/node/pull/31475/files |
| Please reload this page | https://github.com/nodejs/node/pull/31475 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Jan 23, 2020 | https://github.com/nodejs/node/pull/31475#issue-554189598 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/31475 |
|
| https://github.com/danbev |
| src: ignore GCC -Wcast-function-type for v8.h | https://github.com/nodejs/node/pull/31475/commits/3e2f5d615d3b89a2660fc108b83a266dd2eea820 |
| 3e2f5d6 | https://github.com/nodejs/node/pull/31475/commits/3e2f5d615d3b89a2660fc108b83a266dd2eea820 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Jan 23, 2020 | https://github.com/nodejs/node/pull/31475#event-2973914318 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jan 23, 2020
| https://github.com/nodejs/node/pull/31475#pullrequestreview-347337324 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31475/files/3e2f5d615d3b89a2660fc108b83a266dd2eea820 |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/31475#pullrequestreview-347337324 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/31475 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Jan 23, 2020 | https://github.com/nodejs/node/pull/31475#issuecomment-577707094 |
| Please reload this page | https://github.com/nodejs/node/pull/31475 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 23, 2020
| https://github.com/nodejs/node/pull/31475#pullrequestreview-347346225 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31475/files/3e2f5d615d3b89a2660fc108b83a266dd2eea820 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
|
Jan 23, 2020
| https://github.com/nodejs/node/pull/31475#pullrequestreview-347366725 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31475/files/3e2f5d615d3b89a2660fc108b83a266dd2eea820 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Jan 23, 2020
| https://github.com/nodejs/node/pull/31475#pullrequestreview-347376331 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31475/files/3e2f5d615d3b89a2660fc108b83a266dd2eea820 |
| sam-github | https://github.com/sam-github |
| https://github.com/nodejs/node/pull/31475#pullrequestreview-347376331 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/31475 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 24, 2020 | https://github.com/nodejs/node/pull/31475#issuecomment-577989971 |
| https://ci.nodejs.org/job/node-test-pull-request/28602/ | https://ci.nodejs.org/job/node-test-pull-request/28602/ |
| Please reload this page | https://github.com/nodejs/node/pull/31475 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jan 25, 2020
| https://github.com/nodejs/node/pull/31475#pullrequestreview-348310509 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31475/files/3e2f5d615d3b89a2660fc108b83a266dd2eea820 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 25, 2020 | https://github.com/nodejs/node/pull/31475#issuecomment-578451633 |
| https://ci.nodejs.org/job/node-test-pull-request/28669/ | https://ci.nodejs.org/job/node-test-pull-request/28669/ |
| Please reload this page | https://github.com/nodejs/node/pull/31475 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 25, 2020 | https://github.com/nodejs/node/pull/31475#issuecomment-578453574 |
| https://ci.nodejs.org/job/node-test-pull-request/28670/ | https://ci.nodejs.org/job/node-test-pull-request/28670/ |
| Please reload this page | https://github.com/nodejs/node/pull/31475 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 25, 2020 | https://github.com/nodejs/node/pull/31475#issuecomment-578453678 |
| https://ci.nodejs.org/job/node-test-pull-request/28671/ | https://ci.nodejs.org/job/node-test-pull-request/28671/ |
| Please reload this page | https://github.com/nodejs/node/pull/31475 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 25, 2020 | https://github.com/nodejs/node/pull/31475#issuecomment-578454801 |
| 3ff2aec | https://github.com/nodejs/node/commit/3ff2aeceba88928f1aa33fe3ff1cc9bf84da739b |
| Please reload this page | https://github.com/nodejs/node/pull/31475 |
| Trott | https://github.com/Trott |
|
Jan 25, 2020
| https://github.com/nodejs/node/pull/31475#ref-commit-3ff2aec |
|
| https://github.com/danbev |
|
| https://github.com/Trott |
| src: ignore GCC -Wcast-function-type for v8.h | https://github.com/nodejs/node/commit/3ff2aeceba88928f1aa33fe3ff1cc9bf84da739b |
| 3ff2aec | https://github.com/nodejs/node/commit/3ff2aeceba88928f1aa33fe3ff1cc9bf84da739b |
| #31475 | https://github.com/nodejs/node/pull/31475 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 25, 2020 | https://github.com/nodejs/node/pull/31475#event-2979610935 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Jan 26, 2020
| https://github.com/nodejs/node/pull/31475#ref-issue-555218955 |
|
Compiler warnings with recent commit
#31517
| https://github.com/nodejs/node/issues/31517 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jan 26, 2020
| https://github.com/nodejs/node/pull/31475#ref-pullrequest-555249710 |
|
src: fix ignore GCC -Wcast-function-type for older compilers
#31524
| https://github.com/nodejs/node/pull/31524 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| January 27, 2020 05:30 | https://github.com/nodejs/node/pull/31475#event-2980552486 |
|
[v12.x backport] src: ignore GCC -Wcast-function-type for v8.h 31475 31524
#31646
| https://github.com/nodejs/node/pull/31646 |
|
[v13.x backport] src: ignore GCC -Wcast-function-type for v8.h
#31649
| https://github.com/nodejs/node/pull/31649 |
| addaleax | https://github.com/addaleax |
|
Feb 5, 2020
| https://github.com/nodejs/node/pull/31475#ref-commit-3ba8cca |
|
| https://github.com/danbev |
|
| https://github.com/addaleax |
| src: ignore GCC -Wcast-function-type for v8.h | https://github.com/nodejs/node/commit/3ba8cca2ff8008d8fa635e4e7d3cd3250c79300a |
| 3ba8cca | https://github.com/nodejs/node/commit/3ba8cca2ff8008d8fa635e4e7d3cd3250c79300a |
| #31475 | https://github.com/nodejs/node/pull/31475 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 6, 2020
| https://github.com/nodejs/node/pull/31475#ref-commit-e7b7a38 |
|
| https://github.com/danbev |
|
| https://github.com/BethGriggs |
| src: ignore GCC -Wcast-function-type for v8.h | https://github.com/nodejs/node/commit/e7b7a3824d3b11715297b4e6afa4d370d05ee150 |
| e7b7a38 | https://github.com/nodejs/node/commit/e7b7a3824d3b11715297b4e6afa4d370d05ee150 |
| #31475 | https://github.com/nodejs/node/pull/31475 |
| codebytere | https://github.com/codebytere |
|
Feb 17, 2020
| https://github.com/nodejs/node/pull/31475#ref-commit-13c6965 |
|
| https://github.com/danbev |
|
| https://github.com/codebytere |
| src: ignore GCC -Wcast-function-type for v8.h | https://github.com/nodejs/node/commit/13c69657037591427f217808780f95db17f0fe50 |
| 13c6965 | https://github.com/nodejs/node/commit/13c69657037591427f217808780f95db17f0fe50 |
| #31475 | https://github.com/nodejs/node/pull/31475 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Feb 17, 2020
| https://github.com/nodejs/node/pull/31475#ref-pullrequest-566518355 |
|
v13.9.0 proposal
#31837
| https://github.com/nodejs/node/pull/31837 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Mar 3, 2020 | https://github.com/nodejs/node/pull/31475#issuecomment-593974589 |
| @addaleax | https://github.com/addaleax |
| https://chromium-review.googlesource.com/c/v8/v8/+/2080361 | https://chromium-review.googlesource.com/c/v8/v8/+/2080361 |
| Please reload this page | https://github.com/nodejs/node/pull/31475 |
| codebytere | https://github.com/codebytere |
|
Mar 14, 2020
| https://github.com/nodejs/node/pull/31475#ref-commit-1107309 |
|
| https://github.com/danbev |
|
| https://github.com/codebytere |
| src: ignore GCC -Wcast-function-type for v8.h | https://github.com/nodejs/node/commit/1107309e694f41b44970e9cfdb3acd07e9b1ec68 |
| 1107309 | https://github.com/nodejs/node/commit/1107309e694f41b44970e9cfdb3acd07e9b1ec68 |
| #31475 | https://github.com/nodejs/node/pull/31475 |
| codebytere | https://github.com/codebytere |
|
Mar 17, 2020
| https://github.com/nodejs/node/pull/31475#ref-commit-a8d9c0f |
|
| https://github.com/danbev |
|
| https://github.com/codebytere |
| src: ignore GCC -Wcast-function-type for v8.h | https://github.com/nodejs/node/commit/a8d9c0f8b6ef774a0a20ebe871d9eca35e204a95 |
| a8d9c0f | https://github.com/nodejs/node/commit/a8d9c0f8b6ef774a0a20ebe871d9eca35e204a95 |
| #31475 | https://github.com/nodejs/node/pull/31475 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Mar 17, 2020
| https://github.com/nodejs/node/pull/31475#ref-pullrequest-582721275 |
|
v12.16.2 proposal
#32313
| https://github.com/nodejs/node/pull/32313 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31475 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/31475/files/3e2f5d615d3b89a2660fc108b83a266dd2eea820 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/31475/files/3e2f5d615d3b89a2660fc108b83a266dd2eea820 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/31475/files/3e2f5d615d3b89a2660fc108b83a266dd2eea820 |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/31475/files/3e2f5d615d3b89a2660fc108b83a266dd2eea820 |
|
| https://github.com/devnexen |
|
devnexen
| https://github.com/devnexen |
|
| https://github.com/nodejs/node/pull/31475/files/3e2f5d615d3b89a2660fc108b83a266dd2eea820 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Please reload this page | https://github.com/nodejs/node/pull/31475 |
|
| https://github.com/danbev |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/sam-github |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/devnexen |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |