René's URL Explorer Experiment


Title: src: define noreturn attribute for windows by lxbndr · Pull Request #31467 · nodejs/node · GitHub

Open Graph Title: src: define noreturn attribute for windows by lxbndr · Pull Request #31467 · nodejs/node

X Title: src: define noreturn attribute for windows by lxbndr · Pull Request #31467 · nodejs/node

Description: As MSVC has it's own noreturn attribute, wouldn't it be useful to utilize it in NAPI_NO_RETURN macro? I believe it will have almost zero impact for majority of addons, but code analysis tools would...

Open Graph Description: As MSVC has it's own noreturn attribute, wouldn't it be useful to utilize it in NAPI_NO_RETURN macro? I believe it will have almost zero impact for majority of addons, but code analysis too...

X Description: As MSVC has it's own noreturn attribute, wouldn't it be useful to utilize it in NAPI_NO_RETURN macro? I believe it will have almost zero impact for majority of addons, but code anal...

Opengraph URL: https://github.com/nodejs/node/pull/31467

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7880de50-bf73-2325-c59e-47713952827b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAFC8:2B1AB1:1358AE6:19566C1:696B1A6E
html-safe-noncec65f621aeab1eff2178c7d9615f3fbb55c6a7616b2b02e76713ca497c7eb797b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkM4OjJCMUFCMToxMzU4QUU2OjE5NTY2QzE6Njk2QjFBNkUiLCJ2aXNpdG9yX2lkIjoiODk5NjU4MTEyMjM5NjMzMDYwNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6852abbbd38204dc53f806d648bfad55af186b0519027a261154dae4733cba12
hovercard-subject-tagpull_request:366086425
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31467/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/17d358650f85a515e35fe1652cccb0aa35c039c8c50b5fea22952c69d1c6af53/nodejs/node/pull/31467
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/17d358650f85a515e35fe1652cccb0aa35c039c8c50b5fea22952c69d1c6af53/nodejs/node/pull/31467
og:image:altAs MSVC has it's own noreturn attribute, wouldn't it be useful to utilize it in NAPI_NO_RETURN macro? I believe it will have almost zero impact for majority of addons, but code analysis too...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelxbndr
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31467#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31467
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31467
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31467
Reloadhttps://github.com/nodejs/node/pull/31467
Reloadhttps://github.com/nodejs/node/pull/31467
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/31467
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/31467
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/31467#issue-comment-box
lxbndrhttps://github.com/lxbndr
nodejs:masterhttps://github.com/nodejs/node/tree/master
src: define noreturn attribute for windows https://github.com/nodejs/node/pull/31467#top
lxbndrhttps://github.com/lxbndr
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversation 10 https://github.com/nodejs/node/pull/31467
Commits 1 https://github.com/nodejs/node/pull/31467/commits
Checks 0 https://github.com/nodejs/node/pull/31467/checks
Files changed https://github.com/nodejs/node/pull/31467/files
Please reload this pagehttps://github.com/nodejs/node/pull/31467
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/lxbndr
lxbndrhttps://github.com/lxbndr
Jan 22, 2020https://github.com/nodejs/node/pull/31467#issue-553821618
Please reload this pagehttps://github.com/nodejs/node/pull/31467
https://github.com/lxbndr
src: define noreturn attribute for windowshttps://github.com/nodejs/node/pull/31467/commits/f58495d1374b95ae41cc2034d9820bcb3117fee5
f58495dhttps://github.com/nodejs/node/pull/31467/commits/f58495d1374b95ae41cc2034d9820bcb3117fee5
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Jan 22, 2020https://github.com/nodejs/node/pull/31467#event-2971779674
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 22, 2020 https://github.com/nodejs/node/pull/31467#pullrequestreview-346937348
View reviewed changes https://github.com/nodejs/node/pull/31467/files/f58495d1374b95ae41cc2034d9820bcb3117fee5
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 22, 2020https://github.com/nodejs/node/pull/31467#issuecomment-577408848
https://ci.nodejs.org/job/node-test-pull-request/28574/https://ci.nodejs.org/job/node-test-pull-request/28574/
Please reload this pagehttps://github.com/nodejs/node/pull/31467
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 22, 2020 https://github.com/nodejs/node/pull/31467#pullrequestreview-346966284
View reviewed changes https://github.com/nodejs/node/pull/31467/files/f58495d1374b95ae41cc2034d9820bcb3117fee5
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 23, 2020 https://github.com/nodejs/node/pull/31467#pullrequestreview-347011964
View reviewed changes https://github.com/nodejs/node/pull/31467/files/f58495d1374b95ae41cc2034d9820bcb3117fee5
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jan 23, 2020 https://github.com/nodejs/node/pull/31467#pullrequestreview-347040386
View reviewed changes https://github.com/nodejs/node/pull/31467/files/f58495d1374b95ae41cc2034d9820bcb3117fee5
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Jan 23, 2020 https://github.com/nodejs/node/pull/31467#pullrequestreview-347057318
View reviewed changes https://github.com/nodejs/node/pull/31467/files/f58495d1374b95ae41cc2034d9820bcb3117fee5
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 25, 2020 https://github.com/nodejs/node/pull/31467#pullrequestreview-348310623
View reviewed changes https://github.com/nodejs/node/pull/31467/files/f58495d1374b95ae41cc2034d9820bcb3117fee5
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 25, 2020https://github.com/nodejs/node/pull/31467#event-2979124899
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 25, 2020https://github.com/nodejs/node/pull/31467#issuecomment-578377716
https://ci.nodejs.org/job/node-test-pull-request/28629/https://ci.nodejs.org/job/node-test-pull-request/28629/
Please reload this pagehttps://github.com/nodejs/node/pull/31467
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 25, 2020https://github.com/nodejs/node/pull/31467#issuecomment-578417725
https://ci.nodejs.org/job/node-test-pull-request/28646/https://ci.nodejs.org/job/node-test-pull-request/28646/
Please reload this pagehttps://github.com/nodejs/node/pull/31467
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 25, 2020https://github.com/nodejs/node/pull/31467#issuecomment-578418234
https://ci.nodejs.org/job/node-test-pull-request/28649/https://ci.nodejs.org/job/node-test-pull-request/28649/
Please reload this pagehttps://github.com/nodejs/node/pull/31467
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 25, 2020https://github.com/nodejs/node/pull/31467#issuecomment-578419288
https://ci.nodejs.org/job/node-test-pull-request/28650/https://ci.nodejs.org/job/node-test-pull-request/28650/
Please reload this pagehttps://github.com/nodejs/node/pull/31467
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 25, 2020https://github.com/nodejs/node/pull/31467#issuecomment-578420196
https://ci.nodejs.org/job/node-test-pull-request/28654/https://ci.nodejs.org/job/node-test-pull-request/28654/
Please reload this pagehttps://github.com/nodejs/node/pull/31467
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 25, 2020https://github.com/nodejs/node/pull/31467#issuecomment-578420703
https://ci.nodejs.org/job/node-test-pull-request/28657/https://ci.nodejs.org/job/node-test-pull-request/28657/
Please reload this pagehttps://github.com/nodejs/node/pull/31467
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 25, 2020https://github.com/nodejs/node/pull/31467#issuecomment-578425041
https://ci.nodejs.org/job/node-test-pull-request/28661/https://ci.nodejs.org/job/node-test-pull-request/28661/
Please reload this pagehttps://github.com/nodejs/node/pull/31467
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 25, 2020https://github.com/nodejs/node/pull/31467#issuecomment-578425356
https://ci.nodejs.org/job/node-test-pull-request/28662/https://ci.nodejs.org/job/node-test-pull-request/28662/
Please reload this pagehttps://github.com/nodejs/node/pull/31467
Trotthttps://github.com/Trott
Jan 25, 2020 https://github.com/nodejs/node/pull/31467#ref-commit-3188afe
https://github.com/lxbndr
https://github.com/Trott
src: define noreturn attribute for windowshttps://github.com/nodejs/node/commit/3188afebf472976460f54559e205b6e18af0343f
3188afehttps://github.com/nodejs/node/commit/3188afebf472976460f54559e205b6e18af0343f
#31467https://github.com/nodejs/node/pull/31467
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 25, 2020https://github.com/nodejs/node/pull/31467#issuecomment-578428783
3188afehttps://github.com/nodejs/node/commit/3188afebf472976460f54559e205b6e18af0343f
Please reload this pagehttps://github.com/nodejs/node/pull/31467
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 25, 2020https://github.com/nodejs/node/pull/31467#event-2979447825
https://github.com/lxbndr
lxbndrhttps://github.com/lxbndr
January 25, 2020 20:18https://github.com/nodejs/node/pull/31467#event-2979514870
codebyterehttps://github.com/codebytere
Feb 17, 2020 https://github.com/nodejs/node/pull/31467#ref-commit-bc0c142
https://github.com/lxbndr
https://github.com/codebytere
src: define noreturn attribute for windowshttps://github.com/nodejs/node/commit/bc0c1420f06e057c0f4c8763b0b327898f855159
bc0c142https://github.com/nodejs/node/commit/bc0c1420f06e057c0f4c8763b0b327898f855159
#31467https://github.com/nodejs/node/pull/31467
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Feb 17, 2020 https://github.com/nodejs/node/pull/31467#ref-pullrequest-566518355
v13.9.0 proposal #31837 https://github.com/nodejs/node/pull/31837
codebyterehttps://github.com/codebytere
Mar 15, 2020 https://github.com/nodejs/node/pull/31467#ref-commit-8c25c56
https://github.com/lxbndr
https://github.com/codebytere
src: define noreturn attribute for windowshttps://github.com/nodejs/node/commit/8c25c567c6f752fc25b81dc48c3f512db4e42081
8c25c56https://github.com/nodejs/node/commit/8c25c567c6f752fc25b81dc48c3f512db4e42081
#31467https://github.com/nodejs/node/pull/31467
codebyterehttps://github.com/codebytere
Mar 17, 2020 https://github.com/nodejs/node/pull/31467#ref-commit-fb32043
https://github.com/lxbndr
https://github.com/codebytere
src: define noreturn attribute for windowshttps://github.com/nodejs/node/commit/fb32043e6ad026b6ee6c691e28c6f43a46b9908e
fb32043https://github.com/nodejs/node/commit/fb32043e6ad026b6ee6c691e28c6f43a46b9908e
#31467https://github.com/nodejs/node/pull/31467
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Mar 17, 2020 https://github.com/nodejs/node/pull/31467#ref-pullrequest-582721275
v12.16.2 proposal #32313 https://github.com/nodejs/node/pull/32313
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31467
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/31467/files/f58495d1374b95ae41cc2034d9820bcb3117fee5
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/31467/files/f58495d1374b95ae41cc2034d9820bcb3117fee5
https://github.com/gabrielschulhof
gabrielschulhof https://github.com/gabrielschulhof
https://github.com/nodejs/node/pull/31467/files/f58495d1374b95ae41cc2034d9820bcb3117fee5
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/31467/files/f58495d1374b95ae41cc2034d9820bcb3117fee5
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/31467/files/f58495d1374b95ae41cc2034d9820bcb3117fee5
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/31467/files/f58495d1374b95ae41cc2034d9820bcb3117fee5
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Please reload this pagehttps://github.com/nodejs/node/pull/31467
https://github.com/lxbndr
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/addaleax
https://github.com/gabrielschulhof
https://github.com/cjihrig
https://github.com/devnexen
https://github.com/richardlau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.