| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c449f810-b49a-93bf-236f-e8fd6ccf9b15 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EAF2:356387:89B159:B1DA7A:696B1A1C |
| html-safe-nonce | 61d8d8cde413c2954cd3e9a9cb335f6effda90d14b0d01722b04baaaab4c8b28 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUYyOjM1NjM4Nzo4OUIxNTk6QjFEQTdBOjY5NkIxQTFDIiwidmlzaXRvcl9pZCI6IjcxMzQ2OTc4ODMxNTg5MTE1MTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 555896b9a61b4b54ee0036e567d104278290263073ae1603e12e04540cb924f0 |
| hovercard-subject-tag | pull_request:366050079 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31465/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1a2ff77560c1225ccfb09ae3f5652062254c224ec1f2973aedc8bb5ee59c33c5/nodejs/node/pull/31465 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1a2ff77560c1225ccfb09ae3f5652062254c224ec1f2973aedc8bb5ee59c33c5/nodejs/node/pull/31465 |
| og:image:alt | Just a small simplification noticed while reading the code.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lundibundi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/31465#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31465 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31465 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/31465 |
| Reload | https://github.com/nodejs/node/pull/31465 |
| Reload | https://github.com/nodejs/node/pull/31465 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/31465 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
691
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/31465 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/31465#issue-comment-box |
| lundibundi | https://github.com/lundibundi |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lundibundi:small-bootstrap-refactor | https://github.com/lundibundi/node/tree/small-bootstrap-refactor |
|
src: reduce code duplication in BootstrapNode
| https://github.com/nodejs/node/pull/31465#top |
| lundibundi | https://github.com/lundibundi |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lundibundi:small-bootstrap-refactor | https://github.com/lundibundi/node/tree/small-bootstrap-refactor |
|
Conversation
8
| https://github.com/nodejs/node/pull/31465 |
|
Commits
1
| https://github.com/nodejs/node/pull/31465/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/31465/checks |
|
Files changed
| https://github.com/nodejs/node/pull/31465/files |
| Please reload this page | https://github.com/nodejs/node/pull/31465 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
| Jan 22, 2020 | https://github.com/nodejs/node/pull/31465#issue-553777622 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/31465 |
|
| https://github.com/lundibundi |
| src: reduce code duplication in BootstrapNode | https://github.com/nodejs/node/pull/31465/commits/e92e318d8ea3c16b16212523206fdc9ebf28374b |
| e92e318 | https://github.com/nodejs/node/pull/31465/commits/e92e318d8ea3c16b16212523206fdc9ebf28374b |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Jan 22, 2020 | https://github.com/nodejs/node/pull/31465#event-2971509878 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 22, 2020 | https://github.com/nodejs/node/pull/31465#issuecomment-577373481 |
| https://ci.nodejs.org/job/node-test-pull-request/28568/ | https://ci.nodejs.org/job/node-test-pull-request/28568/ |
| Please reload this page | https://github.com/nodejs/node/pull/31465 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jan 22, 2020
| https://github.com/nodejs/node/pull/31465#pullrequestreview-346887503 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31465/files/e92e318d8ea3c16b16212523206fdc9ebf28374b |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 22, 2020
| https://github.com/nodejs/node/pull/31465#pullrequestreview-346966649 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31465/files/e92e318d8ea3c16b16212523206fdc9ebf28374b |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
|
Jan 23, 2020
| https://github.com/nodejs/node/pull/31465#pullrequestreview-347057154 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31465/files/e92e318d8ea3c16b16212523206fdc9ebf28374b |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
|
Jan 23, 2020
| https://github.com/nodejs/node/pull/31465#pullrequestreview-347064918 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31465/files/e92e318d8ea3c16b16212523206fdc9ebf28374b |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 23, 2020 | https://github.com/nodejs/node/pull/31465#issuecomment-577510142 |
| https://ci.nodejs.org/job/node-test-pull-request/28583/ | https://ci.nodejs.org/job/node-test-pull-request/28583/ |
| Please reload this page | https://github.com/nodejs/node/pull/31465 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 23, 2020
| https://github.com/nodejs/node/pull/31465#pullrequestreview-347440087 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31465/files/e92e318d8ea3c16b16212523206fdc9ebf28374b |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jan 23, 2020
| https://github.com/nodejs/node/pull/31465#pullrequestreview-347577639 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31465/files/e92e318d8ea3c16b16212523206fdc9ebf28374b |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 25, 2020 | https://github.com/nodejs/node/pull/31465#issuecomment-578377742 |
| https://ci.nodejs.org/job/node-test-pull-request/28630/ | https://ci.nodejs.org/job/node-test-pull-request/28630/ |
| Please reload this page | https://github.com/nodejs/node/pull/31465 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jan 25, 2020
| https://github.com/nodejs/node/pull/31465#pullrequestreview-348310688 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31465/files/e92e318d8ea3c16b16212523206fdc9ebf28374b |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 25, 2020 | https://github.com/nodejs/node/pull/31465#issuecomment-578417852 |
| https://ci.nodejs.org/job/node-test-pull-request/28647/ | https://ci.nodejs.org/job/node-test-pull-request/28647/ |
| Please reload this page | https://github.com/nodejs/node/pull/31465 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 25, 2020 | https://github.com/nodejs/node/pull/31465#issuecomment-578419513 |
| https://ci.nodejs.org/job/node-test-pull-request/28651/ | https://ci.nodejs.org/job/node-test-pull-request/28651/ |
| Please reload this page | https://github.com/nodejs/node/pull/31465 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 25, 2020 | https://github.com/nodejs/node/pull/31465#issuecomment-578420253 |
| https://ci.nodejs.org/job/node-test-pull-request/28655/ | https://ci.nodejs.org/job/node-test-pull-request/28655/ |
| Please reload this page | https://github.com/nodejs/node/pull/31465 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 25, 2020 | https://github.com/nodejs/node/pull/31465#issuecomment-578420664 |
| https://ci.nodejs.org/job/node-test-pull-request/28656/ | https://ci.nodejs.org/job/node-test-pull-request/28656/ |
| Please reload this page | https://github.com/nodejs/node/pull/31465 |
| Trott | https://github.com/Trott |
|
Jan 25, 2020
| https://github.com/nodejs/node/pull/31465#ref-commit-08f5726 |
|
| https://github.com/lundibundi |
|
| https://github.com/Trott |
| src: reduce code duplication in BootstrapNode | https://github.com/nodejs/node/commit/08f57265b5c58c16af9e93510cda39462ecf2713 |
| 08f5726 | https://github.com/nodejs/node/commit/08f57265b5c58c16af9e93510cda39462ecf2713 |
| #31465 | https://github.com/nodejs/node/pull/31465 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 25, 2020 | https://github.com/nodejs/node/pull/31465#issuecomment-578425164 |
| 08f5726 | https://github.com/nodejs/node/commit/08f57265b5c58c16af9e93510cda39462ecf2713 |
| Please reload this page | https://github.com/nodejs/node/pull/31465 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 25, 2020 | https://github.com/nodejs/node/pull/31465#event-2979425220 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
| January 26, 2020 09:40 | https://github.com/nodejs/node/pull/31465#event-2979804108 |
| codebytere | https://github.com/codebytere |
|
Feb 17, 2020
| https://github.com/nodejs/node/pull/31465#ref-commit-9e9dbd4 |
|
| https://github.com/lundibundi |
|
| https://github.com/codebytere |
| src: reduce code duplication in BootstrapNode | https://github.com/nodejs/node/commit/9e9dbd44feb57720f43fdb809f0cda8573187860 |
| 9e9dbd4 | https://github.com/nodejs/node/commit/9e9dbd44feb57720f43fdb809f0cda8573187860 |
| #31465 | https://github.com/nodejs/node/pull/31465 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Feb 17, 2020
| https://github.com/nodejs/node/pull/31465#ref-pullrequest-566518355 |
|
v13.9.0 proposal
#31837
| https://github.com/nodejs/node/pull/31837 |
| codebytere | https://github.com/codebytere |
|
Mar 15, 2020
| https://github.com/nodejs/node/pull/31465#ref-commit-7274416 |
|
| https://github.com/lundibundi |
|
| https://github.com/codebytere |
| src: reduce code duplication in BootstrapNode | https://github.com/nodejs/node/commit/7274416de38add4e50e59088615e3e13835c0101 |
| 7274416 | https://github.com/nodejs/node/commit/7274416de38add4e50e59088615e3e13835c0101 |
| #31465 | https://github.com/nodejs/node/pull/31465 |
| codebytere | https://github.com/codebytere |
|
Mar 17, 2020
| https://github.com/nodejs/node/pull/31465#ref-commit-ce6b9d1 |
|
| https://github.com/lundibundi |
|
| https://github.com/codebytere |
| src: reduce code duplication in BootstrapNode | https://github.com/nodejs/node/commit/ce6b9d15d2e123e256d5c459d4a322c1c2bfa7f8 |
| ce6b9d1 | https://github.com/nodejs/node/commit/ce6b9d15d2e123e256d5c459d4a322c1c2bfa7f8 |
| #31465 | https://github.com/nodejs/node/pull/31465 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Mar 17, 2020
| https://github.com/nodejs/node/pull/31465#ref-pullrequest-582721275 |
|
v12.16.2 proposal
#32313
| https://github.com/nodejs/node/pull/32313 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31465 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/31465/files/e92e318d8ea3c16b16212523206fdc9ebf28374b |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/31465/files/e92e318d8ea3c16b16212523206fdc9ebf28374b |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/31465/files/e92e318d8ea3c16b16212523206fdc9ebf28374b |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/31465/files/e92e318d8ea3c16b16212523206fdc9ebf28374b |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/31465/files/e92e318d8ea3c16b16212523206fdc9ebf28374b |
|
| https://github.com/ZYSzys |
|
ZYSzys
| https://github.com/ZYSzys |
|
| https://github.com/nodejs/node/pull/31465/files/e92e318d8ea3c16b16212523206fdc9ebf28374b |
|
| https://github.com/devnexen |
|
devnexen
| https://github.com/devnexen |
|
| https://github.com/nodejs/node/pull/31465/files/e92e318d8ea3c16b16212523206fdc9ebf28374b |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Please reload this page | https://github.com/nodejs/node/pull/31465 |
|
| https://github.com/lundibundi |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/devnexen |
|
| https://github.com/ZYSzys |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |