René's URL Explorer Experiment


Title: http: decode username and password before encoding by addaleax · Pull Request #31450 · nodejs/node · GitHub

Open Graph Title: http: decode username and password before encoding by addaleax · Pull Request #31450 · nodejs/node

X Title: http: decode username and password before encoding by addaleax · Pull Request #31450 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: @nodejs/url @nodejs/security I’m marking this as blocked, because I’d like somebody to take a look at this who is somewhat familiar with the security implications of this – there are no obvious dow...

X Description: @nodejs/url @nodejs/security I’m marking this as blocked, because I’d like somebody to take a look at this who is somewhat familiar with the security implications of this – there are no obvious dow...

Opengraph URL: https://github.com/nodejs/node/pull/31450

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:aeaa44b0-9f89-a6db-b5cb-f01fc312c29c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB688:1F16:2A0D37:3C26DF:6A4F4BAA
html-safe-nonced0ad036f6599c35ab5ea528ef413cb1fc10af3329d0d8a7227ec790bbe6fa066
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjg4OjFGMTY6MkEwRDM3OjNDMjZERjo2QTRGNEJBQSIsInZpc2l0b3JfaWQiOiI4NjM0MDUzNjEwMjQ0NjIzMjc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2095cf898f38fb096308d2f4e0b0ea5e847b7f3e62d78238559582ddce7921d3
hovercard-subject-tagpull_request:365560020
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31450/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ed134f6b9aa9357b0cf8d1dc9efd91a93e72260153f80487dcdede4c4b2cf715/nodejs/node/pull/31450
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ed134f6b9aa9357b0cf8d1dc9efd91a93e72260153f80487dcdede4c4b2cf715/nodejs/node/pull/31450
og:image:alt@nodejs/url @nodejs/security I’m marking this as blocked, because I’d like somebody to take a look at this who is somewhat familiar with the security implications of this – there are no obvious dow...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31450#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31450
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31450
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31450
Reloadhttps://github.com/nodejs/node/pull/31450
Reloadhttps://github.com/nodejs/node/pull/31450
Please reload this pagehttps://github.com/nodejs/node/pull/31450
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/31450
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 969 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:mainhttps://github.com/nodejs/node/tree/main
addaleax:decode-uri-requesthttps://github.com/addaleax/node/tree/decode-uri-request
Conversationhttps://github.com/nodejs/node/pull/31450
Commits4 (4)https://github.com/nodejs/node/pull/31450/commits
Checkshttps://github.com/nodejs/node/pull/31450/checks
Files changedhttps://github.com/nodejs/node/pull/31450/files
http: decode username and password before encodinghttps://github.com/nodejs/node/pull/31450#top
addaleaxhttps://github.com/addaleax
nodejs:mainhttps://github.com/nodejs/node/tree/main
addaleax:decode-uri-requesthttps://github.com/addaleax/node/tree/decode-uri-request
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 21, 2020https://github.com/nodejs/node/pull/31450#issue-553185012
#31439https://github.com/nodejs/node/issues/31439
@izonderhttps://github.com/izonder
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/addaleax
http: decode username and password before encodinghttps://github.com/nodejs/node/pull/31450/commits/17ef5bf57b0c8eeea1d002b51cc6f961a51ccbbf
17ef5bfhttps://github.com/nodejs/node/pull/31450/commits/17ef5bf57b0c8eeea1d002b51cc6f961a51ccbbf
nodejs#31439https://github.com/nodejs/node/issues/31439
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
whatwg-url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
Jan 21, 2020https://github.com/nodejs/node/pull/31450#event-2968048026
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 21, 2020https://github.com/nodejs/node/pull/31450#issuecomment-576921613
https://nodejs.org/api/url.html#url_url_usernamehttps://nodejs.org/api/url.html#url_url_username
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/addaleax
fixup! http: decode username and password before encodinghttps://github.com/nodejs/node/pull/31450/commits/76ca7362bc7866c49c7a97010e141b4dac2f1f68
76ca736https://github.com/nodejs/node/pull/31450/commits/76ca7362bc7866c49c7a97010e141b4dac2f1f68
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 21, 2020https://github.com/nodejs/node/pull/31450#issuecomment-576924884
https://nodejs.org/api/url.html#url_url_usernamehttps://nodejs.org/api/url.html#url_url_username
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 22, 2020 https://github.com/nodejs/node/pull/31450#pullrequestreview-346373710
View reviewed changes https://github.com/nodejs/node/pull/31450/files/76ca7362bc7866c49c7a97010e141b4dac2f1f68
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 22, 2020https://github.com/nodejs/node/pull/31450#issuecomment-577034819
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 22, 2020 https://github.com/nodejs/node/pull/31450#pullrequestreview-346394656
View reviewed changes https://github.com/nodejs/node/pull/31450/files/76ca7362bc7866c49c7a97010e141b4dac2f1f68
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/31450#pullrequestreview-346394656
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jan 22, 2020 https://github.com/nodejs/node/pull/31450#pullrequestreview-346397316
View reviewed changes https://github.com/nodejs/node/pull/31450/files/76ca7362bc7866c49c7a97010e141b4dac2f1f68
doc/api/url.mdhttps://github.com/nodejs/node/pull/31450/files/76ca7362bc7866c49c7a97010e141b4dac2f1f68#diff-737c677bb1f49f0cb9b632fd91231a1ccfb80764439aaf4768bbd9f8d365689a
richardlauhttps://github.com/richardlau
Jan 22, 2020https://github.com/nodejs/node/pull/31450#discussion_r369412034
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31450
bnoordhuishttps://github.com/bnoordhuis
Jan 22, 2020https://github.com/nodejs/node/pull/31450#discussion_r369476766
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31450
addaleaxhttps://github.com/addaleax
Jan 23, 2020https://github.com/nodejs/node/pull/31450#discussion_r370366593
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://user-images.githubusercontent.com/899444/73025759-745fa900-3e30-11ea-84e2-dad35b2f2808.jpg
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 22, 2020 https://github.com/nodejs/node/pull/31450#pullrequestreview-346479846
View reviewed changes https://github.com/nodejs/node/pull/31450/files/76ca7362bc7866c49c7a97010e141b4dac2f1f68
doc/api/url.mdhttps://github.com/nodejs/node/pull/31450/files/76ca7362bc7866c49c7a97010e141b4dac2f1f68#diff-737c677bb1f49f0cb9b632fd91231a1ccfb80764439aaf4768bbd9f8d365689a
bnoordhuishttps://github.com/bnoordhuis
Jan 22, 2020https://github.com/nodejs/node/pull/31450#discussion_r369476766
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31450
lib/internal/url.jshttps://github.com/nodejs/node/pull/31450/files/76ca7362bc7866c49c7a97010e141b4dac2f1f68#diff-26e6b1e2a90040b1ce20e7f305b2ff3140b483f863ee2573b4c6af9b696ad31e
bnoordhuishttps://github.com/bnoordhuis
Jan 22, 2020https://github.com/nodejs/node/pull/31450#discussion_r369484701
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
RFC 7617, section 2https://tools.ietf.org/html/rfc7617#section-2
Please reload this pagehttps://github.com/nodejs/node/pull/31450
izonderhttps://github.com/izonder
Jan 22, 2020https://github.com/nodejs/node/pull/31450#discussion_r369490243
Please reload this pagehttps://github.com/nodejs/node/pull/31450
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31450
addaleaxhttps://github.com/addaleax
Jan 22, 2020https://github.com/nodejs/node/pull/31450#discussion_r369685938
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31450
bnoordhuishttps://github.com/bnoordhuis
Jan 23, 2020https://github.com/nodejs/node/pull/31450#discussion_r369996772
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31450
addaleaxhttps://github.com/addaleax
Jan 23, 2020https://github.com/nodejs/node/pull/31450#discussion_r370365653
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 23, 2020https://github.com/nodejs/node/pull/31450#issuecomment-577768472
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/addaleax
fixup! http: decode username and password before encodinghttps://github.com/nodejs/node/pull/31450/commits/8ccf69f306d532d81ce800b37f06fe362d7db1e0
8ccf69fhttps://github.com/nodejs/node/pull/31450/commits/8ccf69f306d532d81ce800b37f06fe362d7db1e0
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 23, 2020https://github.com/nodejs/node/pull/31450#issuecomment-577886333
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/addaleax
fixup! http: decode username and password before encodinghttps://github.com/nodejs/node/pull/31450/commits/5ebbb79a3bd56b99821081c23e1f5db9c879fce8
5ebbb79https://github.com/nodejs/node/pull/31450/commits/5ebbb79a3bd56b99821081c23e1f5db9c879fce8
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 25, 2020https://github.com/nodejs/node/pull/31450#issuecomment-578416758
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 27, 2020https://github.com/nodejs/node/pull/31450#issuecomment-578869683
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/izonder
izonderhttps://github.com/izonder
Feb 20, 2020https://github.com/nodejs/node/pull/31450#issuecomment-588874378
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/bruno-xo7
bruno-xo7https://github.com/bruno-xo7
Apr 22, 2020 https://github.com/nodejs/node/pull/31450#ref-issue-603852488
The authorization header is improperly encoded sindresorhus/got#1169 https://github.com/sindresorhus/got/issues/1169
https://github.com/markablov
markablovhttps://github.com/markablov
Apr 29, 2020 https://github.com/nodejs/node/pull/31450#pullrequestreview-402369078
View reviewed changes https://github.com/nodejs/node/pull/31450/files/5ebbb79a3bd56b99821081c23e1f5db9c879fce8
lib/internal/url.jshttps://github.com/nodejs/node/pull/31450/files/5ebbb79a3bd56b99821081c23e1f5db9c879fce8#diff-26e6b1e2a90040b1ce20e7f305b2ff3140b483f863ee2573b4c6af9b696ad31e
markablovhttps://github.com/markablov
Apr 29, 2020https://github.com/nodejs/node/pull/31450#discussion_r417071453
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31450
bnoordhuishttps://github.com/bnoordhuis
May 30, 2020https://github.com/nodejs/node/pull/31450#discussion_r432831546
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/markablov
markablovhttps://github.com/markablov
Apr 29, 2020 https://github.com/nodejs/node/pull/31450#pullrequestreview-402369568
View reviewed changes https://github.com/nodejs/node/pull/31450/files/5ebbb79a3bd56b99821081c23e1f5db9c879fce8
lib/internal/url.jshttps://github.com/nodejs/node/pull/31450/files/5ebbb79a3bd56b99821081c23e1f5db9c879fce8#diff-26e6b1e2a90040b1ce20e7f305b2ff3140b483f863ee2573b4c6af9b696ad31e
markablovhttps://github.com/markablov
Apr 29, 2020https://github.com/nodejs/node/pull/31450#discussion_r417071895
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31450
szmarczakhttps://github.com/szmarczak
Jul 16, 2020https://github.com/nodejs/node/pull/31450#discussion_r455750887
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 29, 2020https://github.com/nodejs/node/pull/31450#issuecomment-636167711
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 29, 2020 https://github.com/nodejs/node/pull/31450#pullrequestreview-421253470
View reviewed changes https://github.com/nodejs/node/pull/31450/files/5ebbb79a3bd56b99821081c23e1f5db9c879fce8
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5
8ae28ffhttps://github.com/nodejs/node/commit/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda
2935f72https://github.com/nodejs/node/commit/2935f72ae1b991c64118031dec12e7d7db7714a5
Compare https://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5
May 31, 2020 12:19https://github.com/nodejs/node/pull/31450#event-3390559084
https://github.com/ronag
ronaghttps://github.com/ronag
Jun 21, 2020https://github.com/nodejs/node/pull/31450#issuecomment-647143858
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 22, 2020https://github.com/nodejs/node/pull/31450#issuecomment-647719491
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/sindresorhus
sindresorhushttps://github.com/sindresorhus
Jul 4, 2020 https://github.com/nodejs/node/pull/31450#ref-issue-638836093
Password with special characters throws a URI malformed exception sindresorhus/got#1317 https://github.com/sindresorhus/got/issues/1317
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Jul 16, 2020 https://github.com/nodejs/node/pull/31450#pullrequestreview-449809253
View reviewed changes https://github.com/nodejs/node/pull/31450/files/5ebbb79a3bd56b99821081c23e1f5db9c879fce8
lib/internal/url.jshttps://github.com/nodejs/node/pull/31450/files/5ebbb79a3bd56b99821081c23e1f5db9c879fce8#diff-26e6b1e2a90040b1ce20e7f305b2ff3140b483f863ee2573b4c6af9b696ad31e
szmarczakhttps://github.com/szmarczak
Jul 16, 2020https://github.com/nodejs/node/pull/31450#discussion_r455756800
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/addaleax/node/blob/5ebbb79a3bd56b99821081c23e1f5db9c879fce8/lib/internal/url.js#L1296https://github.com/addaleax/node/blob/5ebbb79a3bd56b99821081c23e1f5db9c879fce8/lib/internal/url.js#L1296
Please reload this pagehttps://github.com/nodejs/node/pull/31450
szmarczakhttps://github.com/szmarczak
Jul 28, 2020https://github.com/nodejs/node/pull/31450#discussion_r461507362
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Jul 28, 2020https://github.com/nodejs/node/pull/31450#issuecomment-664983832
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
code ownerhttps://github.com/nodejs/node/blob/64acae2e0681ba02f99c0f2d3ee9c2058c0f7e46/.github/CODEOWNERS#L43
August 10, 2020 16:07https://github.com/nodejs/node/pull/31450#event-3639468368
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 15, 2020 https://github.com/nodejs/node/pull/31450#ref-issue-679537652
http: decode username and password before encoding stevenvachon/url-to-options#2 https://github.com/stevenvachon/url-to-options/issues/2
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 15, 2020https://github.com/nodejs/node/pull/31450#issuecomment-674376992
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 15, 2020https://github.com/nodejs/node/pull/31450#issuecomment-674377073
Please reload this pagehttps://github.com/nodejs/node/pull/31450
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/ronag
ronaghttps://github.com/ronag
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Aug 15, 2020https://github.com/nodejs/node/pull/31450#event-3658386759
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 15, 2020 https://github.com/nodejs/node/pull/31450#pullrequestreview-467961881
View reviewed changes https://github.com/nodejs/node/pull/31450/files/5ebbb79a3bd56b99821081c23e1f5db9c879fce8
ronaghttps://github.com/ronag
https://github.com/nodejs/node/pull/31450#pullrequestreview-467961881
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/sindresorhus
sindresorhushttps://github.com/sindresorhus
Sep 16, 2020https://github.com/nodejs/node/pull/31450#issuecomment-693717243
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 27, 2020https://github.com/nodejs/node/pull/31450#issuecomment-751521967
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 6, 2021 https://github.com/nodejs/node/pull/31450#ref-issue-780585503
Special Characters in WS Authorization websockets/ws#1831 https://github.com/websockets/ws/issues/1831
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Mar 20, 2021https://github.com/nodejs/node/pull/31450#issuecomment-803246833
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04..8e46568b1e12fe00581b1292bd6c2b01373f17bd
dc5a5dahttps://github.com/nodejs/node/commit/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04
8e46568https://github.com/nodejs/node/commit/8e46568b1e12fe00581b1292bd6c2b01373f17bd
Compare https://github.com/nodejs/node/compare/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04..8e46568b1e12fe00581b1292bd6c2b01373f17bd
March 29, 2021 21:33https://github.com/nodejs/node/pull/31450#event-4523995948
https://github.com/lewgordon
lewgordonhttps://github.com/lewgordon
Jul 8, 2021 https://github.com/nodejs/node/pull/31450#ref-pullrequest-940008118
http: decodes url.username and url.password for authorization header #39310 https://github.com/nodejs/node/pull/39310
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Jul 29, 2022 https://github.com/nodejs/node/pull/31450#ref-issue-1321170486
Library erroneously URI-encodes usersname and password sindresorhus/got#2093 https://github.com/sindresorhus/got/issues/2093
https://github.com/ferronrsmith
ferronrsmithhttps://github.com/ferronrsmith
Sep 18, 2023 https://github.com/nodejs/node/pull/31450#ref-issue-1900307471
Password contains @，Iunable to connect[BUG] elasticsearch-dump/elasticsearch-dump#991 https://github.com/elasticsearch-dump/elasticsearch-dump/issues/991
https://github.com/Uzlopak
Uzlopakhttps://github.com/Uzlopak
Jan 6, 2024https://github.com/nodejs/node/pull/31450#issuecomment-1879443427
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31450
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/31450/files/5ebbb79a3bd56b99821081c23e1f5db9c879fce8
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/31450/files/76ca7362bc7866c49c7a97010e141b4dac2f1f68
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/31450/files/5ebbb79a3bd56b99821081c23e1f5db9c879fce8
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/31450/files/76ca7362bc7866c49c7a97010e141b4dac2f1f68
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/31450/files/5ebbb79a3bd56b99821081c23e1f5db9c879fce8
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/31450/files/76ca7362bc7866c49c7a97010e141b4dac2f1f68
https://github.com/markablov
markablov https://github.com/markablov
https://github.com/nodejs/node/pull/31450/files/5ebbb79a3bd56b99821081c23e1f5db9c879fce8
https://github.com/izonder
izonder https://github.com/izonder
https://github.com/nodejs/node/pull/31450/files/76ca7362bc7866c49c7a97010e141b4dac2f1f68
https://github.com/szmarczak
szmarczak https://github.com/szmarczak
https://github.com/nodejs/node/pull/31450/files/5ebbb79a3bd56b99821081c23e1f5db9c879fce8
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
whatwg-url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
Passing username from URL object to http.clientRequest without decoding https://github.com/nodejs/node/issues/31439
Please reload this pagehttps://github.com/nodejs/node/pull/31450
https://github.com/addaleax
https://github.com/mcollina
https://github.com/lpinca
https://github.com/jasnell
https://github.com/Trott
https://github.com/izonder
https://github.com/ronag
https://github.com/szmarczak
https://github.com/sindresorhus
https://github.com/Uzlopak
https://github.com/bnoordhuis
https://github.com/markablov
https://github.com/richardlau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.