René's URL Explorer Experiment


Title: fs: change streams to always emit close by default by ronag · Pull Request #31408 · nodejs/node · GitHub

Open Graph Title: fs: change streams to always emit close by default by ronag · Pull Request #31408 · nodejs/node

X Title: fs: change streams to always emit close by default by ronag · Pull Request #31408 · nodejs/node

Description: Previously due to compat reasons 'close' was only emitted if no 'error'. This removes the compat behavior in order to properly follow expected streams behavior. Not sure why this compat behavior has remained for so long but I believe it should be possible to make fs stream consistent with normal streams in a semver-major. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Open Graph Description: Previously due to compat reasons 'close' was only emitted if no 'error'. This removes the compat behavior in order to properly follow expected streams behavior. Not sure why this co...

X Description: Previously due to compat reasons 'close' was only emitted if no 'error'. This removes the compat behavior in order to properly follow expected streams behavior. Not ...

Opengraph URL: https://github.com/nodejs/node/pull/31408

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files/:range(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a391e9d9-913e-c392-db36-c2c85e098b6d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD5F2:2678AD:2ABCB4:3B5CD2:6AEDB223
html-safe-nonceeef2583669fb08d44d326fbbe4dfbda7a7fcef7cde5f10cf43566e76c127d18d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUYyOjI2NzhBRDoyQUJDQjQ6M0I1Q0QyOjZBRURCMjIzIiwidmlzaXRvcl9pZCI6IjgyODE3NjkzNTg4NjYxMDA3NzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac81296bf326798a115571d7faa0b62c8360c99064576a84bf76c1219dc1e057b7
hovercard-subject-tagpull_request:364429250
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d
twitter:imagehttps://avatars.githubusercontent.com/u/3065230?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3065230?s=400&v=4
og:image:altPreviously due to compat reasons 'close' was only emitted if no 'error'. This removes the compat behavior in order to properly follow expected streams behavior. Not sure why this co...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee40242599af5e7da0f281843dec7492c322688d4a48caeea85f9fb8e41c8ea53
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release89cbf2bb52a24fc179bf5925abba0ba574b262ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31408%2Ffiles%2Fc3a49d7045dcbce5216a68fe61ff4cfc533ff91d
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31408%2Ffiles%2Fc3a49d7045dcbce5216a68fe61ff4cfc533ff91d
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d
Reloadhttps://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d
Reloadhttps://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests663 (663)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:fs-stream-emit-closehttps://github.com/nxtedition/node/tree/fs-stream-emit-close
Conversation 10 https://github.com/nodejs/node/pull/31408
Commits 1 https://github.com/nodejs/node/pull/31408/commits
Checks 0 https://github.com/nodejs/node/pull/31408/checks
Files changed https://github.com/nodejs/node/pull/31408/files
Please reload this pagehttps://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d
fs: change streams to always emit close by default https://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d#top
Show all changes 1 commit https://github.com/nodejs/node/pull/31408/files
c3a49d7 fs: change streams to always emit close by default ronag Jan 18, 2020 https://github.com/nodejs/node/pull/31408/commits/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d
Clear filters https://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d
Please reload this pagehttps://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d
Please reload this pagehttps://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d
streams.js https://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
test-fs-stream-destroy-emit-error.js https://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d#diff-c6f292de439f17404addece94b8e003c4d696dddb7b7df9c1b4e0ceb8275ba49
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
View file https://github.com/nxtedition/node/blob/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d/lib/internal/fs/streams.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/31408/files/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
https://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
https://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
https://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
https://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
test/parallel/test-fs-stream-destroy-emit-error.jshttps://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d#diff-c6f292de439f17404addece94b8e003c4d696dddb7b7df9c1b4e0ceb8275ba49
View file https://github.com/nxtedition/node/blob/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d/test/parallel/test-fs-stream-destroy-emit-error.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/31408/files/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d#diff-c6f292de439f17404addece94b8e003c4d696dddb7b7df9c1b4e0ceb8275ba49
https://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d#diff-c6f292de439f17404addece94b8e003c4d696dddb7b7df9c1b4e0ceb8275ba49
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.