René's URL Explorer Experiment


Title: fs: change streams to always emit close by default by ronag · Pull Request #31408 · nodejs/node · GitHub

Open Graph Title: fs: change streams to always emit close by default by ronag · Pull Request #31408 · nodejs/node

X Title: fs: change streams to always emit close by default by ronag · Pull Request #31408 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Previously due to compat reasons 'close' was only emitted if no 'error'. This removes the compat behavior in order to properly follow expected streams behavior. Not sure why this co...

X Description: Previously due to compat reasons 'close' was only emitted if no 'error'. This removes the compat behavior in order to properly follow expected streams behavior. Not ...

Opengraph URL: https://github.com/nodejs/node/pull/31408

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9d48eec7-9e4e-306d-116c-dca69d121842
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id922E:3BA6B9:100F2A6:15681C8:6AED51A4
html-safe-nonce7483a01d5a65aa45bff8d2cf1c8058c39b5909e2e2523f4c215a3edfbf043d2e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjJFOjNCQTZCOToxMDBGMkE2OjE1NjgxQzg6NkFFRDUxQTQiLCJ2aXNpdG9yX2lkIjoiNjQ0MzAyNjk5OTY5MjU3OTIzNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5ac3127fdf16253afc601caf6a8858f0223fe5d1745efed43b7a31dbdea7902e
hovercard-subject-tagpull_request:364429250
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31408/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ee92048f77c3e3314ed3de6884118ebf0ecdda90edad4be85e17032014d22cce/nodejs/node/pull/31408
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ee92048f77c3e3314ed3de6884118ebf0ecdda90edad4be85e17032014d22cce/nodejs/node/pull/31408
og:image:altPreviously due to compat reasons 'close' was only emitted if no 'error'. This removes the compat behavior in order to properly follow expected streams behavior. Not sure why this co...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31408#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31408
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31408
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31408
Reloadhttps://github.com/nodejs/node/pull/31408
Reloadhttps://github.com/nodejs/node/pull/31408
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:fs-stream-emit-closehttps://github.com/nxtedition/node/tree/fs-stream-emit-close
Conversationhttps://github.com/nodejs/node/pull/31408
Commits1 (1)https://github.com/nodejs/node/pull/31408/commits
Checkshttps://github.com/nodejs/node/pull/31408/checks
Files changedhttps://github.com/nodejs/node/pull/31408/files
fs: change streams to always emit close by defaulthttps://github.com/nodejs/node/pull/31408#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:fs-stream-emit-closehttps://github.com/nxtedition/node/tree/fs-stream-emit-close
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 18, 2020https://github.com/nodejs/node/pull/31408#issue-551772974
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/31408
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Jan 18, 2020https://github.com/nodejs/node/pull/31408#event-2960236988
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/8d236d7c03fe85f6750e71cdbd7d777f234139f4..009687aefaea574aa5a841a52e31fda91646fe5e
8d236d7https://github.com/nodejs/node/commit/8d236d7c03fe85f6750e71cdbd7d777f234139f4
009687ahttps://github.com/nodejs/node/commit/009687aefaea574aa5a841a52e31fda91646fe5e
Compare https://github.com/nodejs/node/compare/8d236d7c03fe85f6750e71cdbd7d777f234139f4..009687aefaea574aa5a841a52e31fda91646fe5e
January 18, 2020 13:59https://github.com/nodejs/node/pull/31408#event-2960237117
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 18, 2020https://github.com/nodejs/node/pull/31408#issuecomment-575900784
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/31408
https://github.com/ronag
ronaghttps://github.com/ronag
addaleaxhttps://github.com/addaleax
January 18, 2020 14:00https://github.com/nodejs/node/pull/31408#event-2960237979
https://github.com/mscdex
mscdexhttps://github.com/mscdex
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Jan 18, 2020https://github.com/nodejs/node/pull/31408#event-2960327199
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 18, 2020 https://github.com/nodejs/node/pull/31408#pullrequestreview-344963287
View reviewed changes https://github.com/nodejs/node/pull/31408/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 18, 2020https://github.com/nodejs/node/pull/31408#issuecomment-575939682
Please reload this pagehttps://github.com/nodejs/node/pull/31408
https://ci.nodejs.org/job/node-test-pull-request/28475/https://ci.nodejs.org/job/node-test-pull-request/28475/
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2226/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2226/
Please reload this pagehttps://github.com/nodejs/node/pull/31408
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 19, 2020 https://github.com/nodejs/node/pull/31408#pullrequestreview-345022397
View reviewed changes https://github.com/nodejs/node/pull/31408/files
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 20, 2020 https://github.com/nodejs/node/pull/31408#pullrequestreview-345272659
View reviewed changes https://github.com/nodejs/node/pull/31408/files
https://github.com/ronag
fs: change streams to always emit close by defaulthttps://github.com/nodejs/node/pull/31408/commits/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d
c3a49d7https://github.com/nodejs/node/pull/31408/commits/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 20, 2020https://github.com/nodejs/node/pull/31408#issuecomment-576263173
Please reload this pagehttps://github.com/nodejs/node/pull/31408
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/009687aefaea574aa5a841a52e31fda91646fe5e..c3a49d7045dcbce5216a68fe61ff4cfc533ff91d
009687ahttps://github.com/nodejs/node/commit/009687aefaea574aa5a841a52e31fda91646fe5e
c3a49d7https://github.com/nodejs/node/commit/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d
Compare https://github.com/nodejs/node/compare/009687aefaea574aa5a841a52e31fda91646fe5e..c3a49d7045dcbce5216a68fe61ff4cfc533ff91d
January 20, 2020 12:58https://github.com/nodejs/node/pull/31408#event-2962855679
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 20, 2020https://github.com/nodejs/node/pull/31408#issuecomment-576308355
https://ci.nodejs.org/job/node-test-pull-request/28498/https://ci.nodejs.org/job/node-test-pull-request/28498/
Please reload this pagehttps://github.com/nodejs/node/pull/31408
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 20, 2020 https://github.com/nodejs/node/pull/31408#pullrequestreview-345361373
View reviewed changes https://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 20, 2020https://github.com/nodejs/node/pull/31408#issuecomment-576309426
Please reload this pagehttps://github.com/nodejs/node/pull/31408
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 20, 2020https://github.com/nodejs/node/pull/31408#issuecomment-576319467
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/31408
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 20, 2020https://github.com/nodejs/node/pull/31408#event-2963900291
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 20, 2020https://github.com/nodejs/node/pull/31408#issuecomment-576392634
https://ci.nodejs.org/job/node-test-pull-request/28512/https://ci.nodejs.org/job/node-test-pull-request/28512/
Please reload this pagehttps://github.com/nodejs/node/pull/31408
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 21, 2020https://github.com/nodejs/node/pull/31408#issuecomment-576521642
https://ci.nodejs.org/job/node-test-pull-request/28527/https://ci.nodejs.org/job/node-test-pull-request/28527/
Please reload this pagehttps://github.com/nodejs/node/pull/31408
Trotthttps://github.com/Trott
Jan 21, 2020 https://github.com/nodejs/node/pull/31408#ref-commit-f0d2df4
https://github.com/ronag
https://github.com/Trott
fs: change streams to always emit close by defaulthttps://github.com/nodejs/node/commit/f0d2df41f8716670435b284e987b2fcc23221947
f0d2df4https://github.com/nodejs/node/commit/f0d2df41f8716670435b284e987b2fcc23221947
#31408https://github.com/nodejs/node/pull/31408
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 21, 2020https://github.com/nodejs/node/pull/31408#issuecomment-576528161
f0d2df4https://github.com/nodejs/node/commit/f0d2df41f8716670435b284e987b2fcc23221947
Please reload this pagehttps://github.com/nodejs/node/pull/31408
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 21, 2020https://github.com/nodejs/node/pull/31408#event-2964919289
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Mar 10, 2020 https://github.com/nodejs/node/pull/31408#ref-pullrequest-578760228
2020-04-21, Version 14.0.0 (Current) #32181 https://github.com/nodejs/node/pull/32181
https://github.com/AbdelrahmanHafez
AbdelrahmanHafezhttps://github.com/AbdelrahmanHafez
Apr 22, 2020 https://github.com/nodejs/node/pull/31408#ref-issue-604655712
[Bug] closing a cursor on Node 14 calls on('close', callback); twice Automattic/mongoose#8835 https://github.com/Automattic/mongoose/issues/8835
https://github.com/kevinoid
kevinoidhttps://github.com/kevinoid
Dec 28, 2020 https://github.com/nodejs/node/pull/31408#ref-pullrequest-775135411
doc: Update emitClose default for fs streams #36653 https://github.com/nodejs/node/pull/36653
Trotthttps://github.com/Trott
Jan 2, 2021 https://github.com/nodejs/node/pull/31408#ref-commit-d548f4d
https://github.com/kevinoid
https://github.com/Trott
doc: update emitClose default for fs streamshttps://github.com/kevinoid/node/commit/d548f4d1164a5dc9e1390fcaaafbbf2feddaf28e
d548f4dhttps://github.com/kevinoid/node/commit/d548f4d1164a5dc9e1390fcaaafbbf2feddaf28e
nodejs#31408https://github.com/nodejs/node/pull/31408
f0d2df4https://github.com/kevinoid/node/commit/f0d2df41f8716670435b284e987b2fcc23221947
nodejs#36653https://github.com/nodejs/node/pull/36653
danielleadamshttps://github.com/danielleadams
Jan 12, 2021 https://github.com/nodejs/node/pull/31408#ref-commit-d3dc124
https://github.com/kevinoid
https://github.com/danielleadams
doc: update emitClose default for fs streamshttps://github.com/nodejs/node/commit/d3dc1245750a7fc6d987e6a16b2aebd06b9a9e68
d3dc124https://github.com/nodejs/node/commit/d3dc1245750a7fc6d987e6a16b2aebd06b9a9e68
#31408https://github.com/nodejs/node/pull/31408
f0d2df4https://github.com/nodejs/node/commit/f0d2df41f8716670435b284e987b2fcc23221947
#36653https://github.com/nodejs/node/pull/36653
targoshttps://github.com/targos
Aug 8, 2021 https://github.com/nodejs/node/pull/31408#ref-commit-78bb65e
https://github.com/kevinoid
https://github.com/targos
doc: update emitClose default for fs streamshttps://github.com/nodejs/node/commit/78bb65e38108678c25fd0f8411dddb80a3c46602
78bb65ehttps://github.com/nodejs/node/commit/78bb65e38108678c25fd0f8411dddb80a3c46602
#31408https://github.com/nodejs/node/pull/31408
f0d2df4https://github.com/nodejs/node/commit/f0d2df41f8716670435b284e987b2fcc23221947
#36653https://github.com/nodejs/node/pull/36653
BethGriggshttps://github.com/BethGriggs
Aug 12, 2021 https://github.com/nodejs/node/pull/31408#ref-commit-73e6781
https://github.com/kevinoid
https://github.com/BethGriggs
doc: update emitClose default for fs streamshttps://github.com/nodejs/node/commit/73e6781ad371b3193382969bd2723fce487957eb
73e6781https://github.com/nodejs/node/commit/73e6781ad371b3193382969bd2723fce487957eb
#31408https://github.com/nodejs/node/pull/31408
f0d2df4https://github.com/nodejs/node/commit/f0d2df41f8716670435b284e987b2fcc23221947
#36653https://github.com/nodejs/node/pull/36653
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 19, 2023 https://github.com/nodejs/node/pull/31408#ref-issue-1857683834
writableStream.destroy() closes the underlying file even when stream is created with {autoClose: false, emitClose: false} #49241 https://github.com/nodejs/node/issues/49241
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Jul 31, 2026 https://github.com/nodejs/node/pull/31408#ref-pullrequest-5022499308
fix(file-write): clean up temp archive when zip patching fails before the atomic replace bookorbit/bookorbit#836 https://github.com/bookorbit/bookorbit/pull/836
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31408
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/31408/files/c3a49d7045dcbce5216a68fe61ff4cfc533ff91d
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/31408/files/009687aefaea574aa5a841a52e31fda91646fe5e
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/31408/files/009687aefaea574aa5a841a52e31fda91646fe5e
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/31408/files/009687aefaea574aa5a841a52e31fda91646fe5e
Please reload this pagehttps://github.com/nodejs/node/pull/31408
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/31408
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/addaleax
https://github.com/lpinca
https://github.com/BridgeAR
https://github.com/mscdex
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.