René's URL Explorer Experiment


Title: feat: make fs.read params optional by lholmquist · Pull Request #31402 · nodejs/node · GitHub

Open Graph Title: feat: make fs.read params optional by lholmquist · Pull Request #31402 · nodejs/node

X Title: feat: make fs.read params optional by lholmquist · Pull Request #31402 · nodejs/node

Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes [] tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines This makes...

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes [] tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines This makes...

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes [] tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines This makes...

Opengraph URL: https://github.com/nodejs/node/pull/31402

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1cd437dc-6c6d-9931-484a-7263359d5c5e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD3E:2FE310:1EFC4:27543:696B5701
html-safe-noncea2ceb3d295e70e50c3dff989dcf4c35f7c92d6f997829580d16235a2364a0db1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDNFOjJGRTMxMDoxRUZDNDoyNzU0Mzo2OTZCNTcwMSIsInZpc2l0b3JfaWQiOiIxNzg4NzI1NDE4MDgwODE4OTQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacca16b4c3543a0ef7c23b17fcc4d3da16e90065c99b285972f80c2e0417424de1
hovercard-subject-tagpull_request:364296650
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31402/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bd2290fa9c86ee8fc5bf52c64ec73f8301dc77c2c32eb67d41e20eeefabe4feb/nodejs/node/pull/31402
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bd2290fa9c86ee8fc5bf52c64ec73f8301dc77c2c32eb67d41e20eeefabe4feb/nodejs/node/pull/31402
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes [] tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines This makes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelholmquist
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31402#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31402
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31402
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31402
Reloadhttps://github.com/nodejs/node/pull/31402
Reloadhttps://github.com/nodejs/node/pull/31402
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/31402
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 690 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/31402
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/31402#issue-comment-box
lholmquisthttps://github.com/lholmquist
nodejs:masterhttps://github.com/nodejs/node/tree/master
lholmquist:31237-fs-read-params-optionalhttps://github.com/lholmquist/node/tree/31237-fs-read-params-optional
feat: make fs.read params optional https://github.com/nodejs/node/pull/31402#top
lholmquisthttps://github.com/lholmquist
nodejs:masterhttps://github.com/nodejs/node/tree/master
lholmquist:31237-fs-read-params-optionalhttps://github.com/lholmquist/node/tree/31237-fs-read-params-optional
Conversation 52 https://github.com/nodejs/node/pull/31402
Commits 17 https://github.com/nodejs/node/pull/31402/commits
Checks 0 https://github.com/nodejs/node/pull/31402/checks
Files changed https://github.com/nodejs/node/pull/31402/files
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/lholmquist
lholmquisthttps://github.com/lholmquist
Jan 17, 2020https://github.com/nodejs/node/pull/31402#issue-551604614
Please reload this pagehttps://github.com/nodejs/node/pull/31402
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
#31237https://github.com/nodejs/node/issues/31237
which i've commented in the codehttps://github.com/nodejs/node/pull/31402/files#diff-9a205ef7ee967ee32efee02e58b3482dR461
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/lholmquist
feat: make fs.read params optionalhttps://github.com/nodejs/node/pull/31402/commits/95f03ef4201a3c3d7558703a488c108e965d0784
95f03efhttps://github.com/nodejs/node/pull/31402/commits/95f03ef4201a3c3d7558703a488c108e965d0784
nodejs#31237https://github.com/nodejs/node/issues/31237
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Jan 17, 2020https://github.com/nodejs/node/pull/31402#event-2959328190
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jan 17, 2020https://github.com/nodejs/node/pull/31402#issuecomment-575797665
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/lholmquist
lholmquisthttps://github.com/lholmquist
Jan 18, 2020https://github.com/nodejs/node/pull/31402#issuecomment-575857692
https://github.com/nodejs/node/pull/31402/files#diff-9a205ef7ee967ee32efee02e58b3482dR547https://github.com/nodejs/node/pull/31402/files#diff-9a205ef7ee967ee32efee02e58b3482dR547
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jan 18, 2020https://github.com/nodejs/node/pull/31402#issuecomment-575867961
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 18, 2020https://github.com/nodejs/node/pull/31402#issuecomment-575891309
Please reload this pagehttps://github.com/nodejs/node/pull/31402
#30109https://github.com/nodejs/node/pull/30109
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Jan 20, 2020https://github.com/nodejs/node/pull/31402#event-2963904507
https://github.com/lholmquist
squash: doc updateshttps://github.com/nodejs/node/pull/31402/commits/478d2f020ade9525279d08ea4e10427ccc6a709d
478d2f0https://github.com/nodejs/node/pull/31402/commits/478d2f020ade9525279d08ea4e10427ccc6a709d
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 22, 2020 https://github.com/nodejs/node/pull/31402#pullrequestreview-346830500
View reviewed changes https://github.com/nodejs/node/pull/31402/files/478d2f020ade9525279d08ea4e10427ccc6a709d
lib/fs.jshttps://github.com/nodejs/node/pull/31402/files/478d2f020ade9525279d08ea4e10427ccc6a709d#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 22, 2020 https://github.com/nodejs/node/pull/31402#pullrequestreview-346831130
View reviewed changes https://github.com/nodejs/node/pull/31402/files/478d2f020ade9525279d08ea4e10427ccc6a709d
lib/fs.jshttps://github.com/nodejs/node/pull/31402/files/478d2f020ade9525279d08ea4e10427ccc6a709d#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/lholmquist
squash: adding in testhttps://github.com/nodejs/node/pull/31402/commits/10d3902db2ef8d089e25576bc794abaa8ee767a1
10d3902https://github.com/nodejs/node/pull/31402/commits/10d3902db2ef8d089e25576bc794abaa8ee767a1
https://github.com/lholmquist
lholmquisthttps://github.com/lholmquist
Jan 22, 2020https://github.com/nodejs/node/pull/31402#issuecomment-577353851
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/lholmquist
squash: better use of destructoringhttps://github.com/nodejs/node/pull/31402/commits/dfdd3b42693579b4b27c48eaf598b320735ec332
dfdd3b4https://github.com/nodejs/node/pull/31402/commits/dfdd3b42693579b4b27c48eaf598b320735ec332
https://github.com/ronag
ronaghttps://github.com/ronag
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Jan 27, 2020https://github.com/nodejs/node/pull/31402#event-2982438713
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 27, 2020https://github.com/nodejs/node/pull/31402#issuecomment-578946059
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/513/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/513/
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 27, 2020 https://github.com/nodejs/node/pull/31402#pullrequestreview-348996530
View reviewed changes https://github.com/nodejs/node/pull/31402/files/dfdd3b42693579b4b27c48eaf598b320735ec332
doc/api/fs.mdhttps://github.com/nodejs/node/pull/31402/files/dfdd3b42693579b4b27c48eaf598b320735ec332#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
jasnellhttps://github.com/jasnell
Jan 27, 2020https://github.com/nodejs/node/pull/31402#discussion_r371499325
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31402
lholmquisthttps://github.com/lholmquist
Jan 28, 2020https://github.com/nodejs/node/pull/31402#discussion_r371809733
Please reload this pagehttps://github.com/nodejs/node/pull/31402
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/31402
lholmquisthttps://github.com/lholmquist
Jan 28, 2020https://github.com/nodejs/node/pull/31402#discussion_r372012908
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/31402
jasnellhttps://github.com/jasnell
Jan 28, 2020https://github.com/nodejs/node/pull/31402#discussion_r372035502
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31402
lholmquisthttps://github.com/lholmquist
Jan 28, 2020https://github.com/nodejs/node/pull/31402#discussion_r372042130
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@jasnellhttps://github.com/jasnell
@ronaghttps://github.com/ronag
#31402 (comment)https://github.com/nodejs/node/pull/31402#discussion_r371809733
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 27, 2020https://github.com/nodejs/node/pull/31402#issuecomment-578969017
https://nodejs.org/dist/latest-v13.x/docs/api/fs.html#fs_filehandle_read_buffer_offset_length_positionhttps://nodejs.org/dist/latest-v13.x/docs/api/fs.html#fs_filehandle_read_buffer_offset_length_position
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/lholmquist
lholmquisthttps://github.com/lholmquist
Jan 28, 2020https://github.com/nodejs/node/pull/31402#issuecomment-579253651
Please reload this pagehttps://github.com/nodejs/node/pull/31402
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/lholmquist
lholmquisthttps://github.com/lholmquist
Jan 28, 2020https://github.com/nodejs/node/pull/31402#issuecomment-579415222
Please reload this pagehttps://github.com/nodejs/node/pull/31402
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 28, 2020https://github.com/nodejs/node/pull/31402#issuecomment-579438120
Please reload this pagehttps://github.com/nodejs/node/pull/31402
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/lholmquist
lholmquisthttps://github.com/lholmquist
Feb 4, 2020https://github.com/nodejs/node/pull/31402#issuecomment-582052860
Please reload this pagehttps://github.com/nodejs/node/pull/31402
@jasnellhttps://github.com/jasnell
@ronaghttps://github.com/ronag
#31402 (comment)https://github.com/nodejs/node/pull/31402#discussion_r371809733
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 4, 2020https://github.com/nodejs/node/pull/31402#issuecomment-582054774
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/lholmquist
lholmquisthttps://github.com/lholmquist
Feb 4, 2020https://github.com/nodejs/node/pull/31402#issuecomment-582057609
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 4, 2020https://github.com/nodejs/node/pull/31402#issuecomment-582058412
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/lholmquist
squash: refactor.https://github.com/nodejs/node/pull/31402/commits/cf320a00a57339e40d6fa4e9fa81298c2e3c7d18
cf320a0https://github.com/nodejs/node/pull/31402/commits/cf320a00a57339e40d6fa4e9fa81298c2e3c7d18
https://github.com/lholmquist
lholmquisthttps://github.com/lholmquist
Feb 11, 2020https://github.com/nodejs/node/pull/31402#issuecomment-584830798
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Feb 12, 2020 https://github.com/nodejs/node/pull/31402#pullrequestreview-357147930
View reviewed changes https://github.com/nodejs/node/pull/31402/files/cf320a00a57339e40d6fa4e9fa81298c2e3c7d18
doc/api/fs.mdhttps://github.com/nodejs/node/pull/31402/files/cf320a00a57339e40d6fa4e9fa81298c2e3c7d18#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
Please reload this pagehttps://github.com/nodejs/node/pull/31402
doc/api/fs.mdhttps://github.com/nodejs/node/pull/31402/files/cf320a00a57339e40d6fa4e9fa81298c2e3c7d18#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
Please reload this pagehttps://github.com/nodejs/node/pull/31402
lholmquisthttps://github.com/lholmquist
February 12, 2020 08:04https://github.com/nodejs/node/pull/31402#commits-pushed-418b6fd
https://github.com/lholmquist
https://github.com/richardlau
squash: Update doc/api/fs.mdhttps://github.com/nodejs/node/pull/31402/commits/418b6fdab68efedd991cd18cfd191dd202610586
418b6fdhttps://github.com/nodejs/node/pull/31402/commits/418b6fdab68efedd991cd18cfd191dd202610586
https://github.com/lholmquist
https://github.com/richardlau
squash: Update doc/api/fs.mdhttps://github.com/nodejs/node/pull/31402/commits/e3835c28752bc6f6a848afdb79f64a78fcd48611
e3835c2https://github.com/nodejs/node/pull/31402/commits/e3835c28752bc6f6a848afdb79f64a78fcd48611
https://github.com/lholmquist
squash: reverting some doc updateshttps://github.com/nodejs/node/pull/31402/commits/128aeaba03fa3611466e2446d62e2da05c72f7a3
128aeabhttps://github.com/nodejs/node/pull/31402/commits/128aeaba03fa3611466e2446d62e2da05c72f7a3
lholmquisthttps://github.com/lholmquist
February 26, 2020 12:26https://github.com/nodejs/node/pull/31402#commits-pushed-f86bdc1
https://github.com/lholmquist
squash: add test for optional options optionhttps://github.com/nodejs/node/pull/31402/commits/f86bdc1e7cf476aba6280ba3615e03d4a6f1fd53
f86bdc1https://github.com/nodejs/node/pull/31402/commits/f86bdc1e7cf476aba6280ba3615e03d4a6f1fd53
https://github.com/lholmquist
squash: a little more doc updatehttps://github.com/nodejs/node/pull/31402/commits/a4c3763f2a508981551e3c3b8522c14fb21f35cc
a4c3763https://github.com/nodejs/node/pull/31402/commits/a4c3763f2a508981551e3c3b8522c14fb21f35cc
https://github.com/lholmquist
lholmquisthttps://github.com/lholmquist
Feb 26, 2020https://github.com/nodejs/node/pull/31402#issuecomment-591548488
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/lholmquist
squash: doc lintinghttps://github.com/nodejs/node/pull/31402/commits/e321b8805e2c3bb03b3a48b9536e7a459ed02a4c
e321b88https://github.com/nodejs/node/pull/31402/commits/e321b8805e2c3bb03b3a48b9536e7a459ed02a4c
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 28, 2020 https://github.com/nodejs/node/pull/31402#pullrequestreview-366737967
View reviewed changes https://github.com/nodejs/node/pull/31402/files/e321b8805e2c3bb03b3a48b9536e7a459ed02a4c
doc/api/fs.mdhttps://github.com/nodejs/node/pull/31402/files/e321b8805e2c3bb03b3a48b9536e7a459ed02a4c#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 28, 2020 https://github.com/nodejs/node/pull/31402#pullrequestreview-366738122
View reviewed changes https://github.com/nodejs/node/pull/31402/files/e321b8805e2c3bb03b3a48b9536e7a459ed02a4c
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 28, 2020 https://github.com/nodejs/node/pull/31402#pullrequestreview-366738486
View reviewed changes https://github.com/nodejs/node/pull/31402/files/e321b8805e2c3bb03b3a48b9536e7a459ed02a4c
test/parallel/test-fs-read-optional-params.jshttps://github.com/nodejs/node/pull/31402/files/e321b8805e2c3bb03b3a48b9536e7a459ed02a4c#diff-7112d93b63f8ef0ea089d2c21ef6c392cd03a9d4df568a24a78f72d021326925
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/ronag
ronaghttps://github.com/ronag
Feb 28, 2020 https://github.com/nodejs/node/pull/31402#pullrequestreview-366738699
View reviewed changes https://github.com/nodejs/node/pull/31402/files/e321b8805e2c3bb03b3a48b9536e7a459ed02a4c
ronaghttps://github.com/ronag
https://github.com/nodejs/node/pull/31402#pullrequestreview-366738699
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/lholmquist
lholmquisthttps://github.com/lholmquist
Mar 3, 2020https://github.com/nodejs/node/pull/31402#issuecomment-593956995
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/lholmquist
squash: combine tests and add another test that passes optionshttps://github.com/nodejs/node/pull/31402/commits/cb8c0ef9b80432156a92d58791554c10bf3d147b
cb8c0efhttps://github.com/nodejs/node/pull/31402/commits/cb8c0ef9b80432156a92d58791554c10bf3d147b
https://github.com/lholmquist
lholmquisthttps://github.com/lholmquist
Mar 6, 2020https://github.com/nodejs/node/pull/31402#issuecomment-595802548
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/lholmquist
lholmquisthttps://github.com/lholmquist
ronaghttps://github.com/ronag
March 9, 2020 14:32https://github.com/nodejs/node/pull/31402#event-3110898405
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 10, 2020 https://github.com/nodejs/node/pull/31402#pullrequestreview-372253409
View reviewed changes https://github.com/nodejs/node/pull/31402/files/cb8c0ef9b80432156a92d58791554c10bf3d147b
ronaghttps://github.com/ronag
https://github.com/nodejs/node/pull/31402#pullrequestreview-372253409
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/ronag
ronaghttps://github.com/ronag
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 10, 2020https://github.com/nodejs/node/pull/31402#event-3116119340
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 10, 2020https://github.com/nodejs/node/pull/31402#issuecomment-597268367
https://ci.nodejs.org/job/node-test-pull-request/29706/https://ci.nodejs.org/job/node-test-pull-request/29706/
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Mar 11, 2020https://github.com/nodejs/node/pull/31402#event-3119398797
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 11, 2020 https://github.com/nodejs/node/pull/31402#pullrequestreview-372887341
View reviewed changes https://github.com/nodejs/node/pull/31402/files/cb8c0ef9b80432156a92d58791554c10bf3d147b
addaleaxhttps://github.com/addaleax
Mar 11, 2020 https://github.com/nodejs/node/pull/31402#ref-commit-b6da55f
https://github.com/lholmquist
https://github.com/addaleax
fs: make fs.read params optionalhttps://github.com/nodejs/node/commit/b6da55f0fda60433f8d05539ee8665f66a35ee86
b6da55fhttps://github.com/nodejs/node/commit/b6da55f0fda60433f8d05539ee8665f66a35ee86
#31237https://github.com/nodejs/node/issues/31237
#31402https://github.com/nodejs/node/pull/31402
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 11, 2020https://github.com/nodejs/node/pull/31402#issuecomment-597711831
b6da55fhttps://github.com/nodejs/node/commit/b6da55f0fda60433f8d05539ee8665f66a35ee86
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 11, 2020https://github.com/nodejs/node/pull/31402#event-3119414102
MylesBorinshttps://github.com/MylesBorins
Mar 11, 2020 https://github.com/nodejs/node/pull/31402#ref-commit-94f3eed
https://github.com/lholmquist
https://github.com/MylesBorins
fs: make fs.read params optionalhttps://github.com/nodejs/node/commit/94f3eed22927cbd23de0bf077e567abf65b29338
94f3eedhttps://github.com/nodejs/node/commit/94f3eed22927cbd23de0bf077e567abf65b29338
#31237https://github.com/nodejs/node/issues/31237
#31402https://github.com/nodejs/node/pull/31402
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 12, 2020 https://github.com/nodejs/node/pull/31402#ref-pullrequest-578909658
v13.11.0 proposal #32185 https://github.com/nodejs/node/pull/32185
https://github.com/lholmquist
lholmquisthttps://github.com/lholmquist
Mar 24, 2020 https://github.com/nodejs/node/pull/31402#ref-pullrequest-587049610
feat(fs): Make parameters optional for readSync #32460 https://github.com/nodejs/node/pull/32460
https://github.com/himself65
himself65https://github.com/himself65
Mar 24, 2020 https://github.com/nodejs/node/pull/31402#ref-pullrequest-587081920
test: fix a typo on test-fs-read-optional-params #32461 https://github.com/nodejs/node/pull/32461
https://github.com/himself65
himself65https://github.com/himself65
Mar 25, 2020 https://github.com/nodejs/node/pull/31402#pullrequestreview-380938128
View reviewed changes https://github.com/nodejs/node/pull/31402/files/cb8c0ef9b80432156a92d58791554c10bf3d147b
doc/api/fs.mdhttps://github.com/nodejs/node/pull/31402/files/cb8c0ef9b80432156a92d58791554c10bf3d147b#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
himself65https://github.com/himself65
Mar 25, 2020https://github.com/nodejs/node/pull/31402#discussion_r397679027
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31402
doc/api/fs.mdhttps://github.com/nodejs/node/pull/31402/files/cb8c0ef9b80432156a92d58791554c10bf3d147b#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
himself65https://github.com/himself65
Mar 25, 2020https://github.com/nodejs/node/pull/31402#discussion_r397679105
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/targos
targoshttps://github.com/targos
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 25, 2020https://github.com/nodejs/node/pull/31402#event-3272302191
targoshttps://github.com/targos
Apr 25, 2020 https://github.com/nodejs/node/pull/31402#ref-commit-b546ade
https://github.com/lholmquist
https://github.com/targos
fs: make fs.read params optionalhttps://github.com/targos/node/commit/b546ade0f0612d7a16259d6e92fea304355c4f82
b546adehttps://github.com/targos/node/commit/b546ade0f0612d7a16259d6e92fea304355c4f82
nodejs#31237https://github.com/nodejs/node/issues/31237
nodejs#31402https://github.com/nodejs/node/pull/31402
targoshttps://github.com/targos
Apr 28, 2020 https://github.com/nodejs/node/pull/31402#ref-commit-16a913f
https://github.com/lholmquist
https://github.com/targos
fs: make fs.read params optionalhttps://github.com/nodejs/node/commit/16a913f70281d0e098a96e9d3804d719cd45c798
16a913fhttps://github.com/nodejs/node/commit/16a913f70281d0e098a96e9d3804d719cd45c798
#31237https://github.com/nodejs/node/issues/31237
#31402https://github.com/nodejs/node/pull/31402
https://github.com/targos
targoshttps://github.com/targos
May 2, 2020 https://github.com/nodejs/node/pull/31402#ref-pullrequest-610737650
v12.17.0 release proposal #33197 https://github.com/nodejs/node/pull/33197
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31402
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/31402/files/6433727083e33bd50f7268d5bc5bc6d4b6b4c2a5
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/31402/files/cf320a00a57339e40d6fa4e9fa81298c2e3c7d18
https://github.com/himself65
himself65 https://github.com/himself65
https://github.com/nodejs/node/pull/31402/files/cb8c0ef9b80432156a92d58791554c10bf3d147b
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/31402/files/cb8c0ef9b80432156a92d58791554c10bf3d147b
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/31402/files/cb8c0ef9b80432156a92d58791554c10bf3d147b
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
fs: make read parameters optional https://github.com/nodejs/node/issues/31237
Please reload this pagehttps://github.com/nodejs/node/pull/31402
https://github.com/lholmquist
https://github.com/mscdex
https://github.com/ronag
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/richardlau
https://github.com/himself65
https://github.com/targos
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.