René's URL Explorer Experiment


Title: fs: unset FileHandle fd after close by addaleax · Pull Request #31389 · nodejs/node · GitHub

Open Graph Title: fs: unset FileHandle fd after close by addaleax · Pull Request #31389 · nodejs/node

X Title: fs: unset FileHandle fd after close by addaleax · Pull Request #31389 · nodejs/node

Description: Do not set the fd as a property on the native object. Use the already-existent GetFD() method to pass the fd from C++ to JS. Cache the fd in JS to avoid repeated accesses to the C++ getter. Set the...

Open Graph Description: Do not set the fd as a property on the native object. Use the already-existent GetFD() method to pass the fd from C++ to JS. Cache the fd in JS to avoid repeated accesses to the C++ getter. Set the...

X Description: Do not set the fd as a property on the native object. Use the already-existent GetFD() method to pass the fd from C++ to JS. Cache the fd in JS to avoid repeated accesses to the C++ getter. Set the...

Opengraph URL: https://github.com/nodejs/node/pull/31389

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d41bc62e-1de0-5373-0d91-054ca7d06e6c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2E0:2E5741:A1A5CC:D2A333:696B56E9
html-safe-nonce7d1f4c9a2ab57324aecc0619edefb4c36f240b6ddf5f0f496293328d3b5d9d9e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkUwOjJFNTc0MTpBMUE1Q0M6RDJBMzMzOjY5NkI1NkU5IiwidmlzaXRvcl9pZCI6IjY3NTU5NzI5MTk3NDI2NTAwODkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacba16ba42e27442babd16a69ea6f890531eea1cc38b8a8fc5f5b1df1ca48a7ecc
hovercard-subject-tagpull_request:363848429
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31389/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d723f8fac91784697646d02ad4128a3b25dd4e04376febf70459bf85c1913e36/nodejs/node/pull/31389
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d723f8fac91784697646d02ad4128a3b25dd4e04376febf70459bf85c1913e36/nodejs/node/pull/31389
og:image:altDo not set the fd as a property on the native object. Use the already-existent GetFD() method to pass the fd from C++ to JS. Cache the fd in JS to avoid repeated accesses to the C++ getter. Set the...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31389#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31389
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31389
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31389
Reloadhttps://github.com/nodejs/node/pull/31389
Reloadhttps://github.com/nodejs/node/pull/31389
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/31389
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 690 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/31389
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/31389#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:filehandle-fd-after-closehttps://github.com/addaleax/node/tree/filehandle-fd-after-close
fs: unset FileHandle fd after close https://github.com/nodejs/node/pull/31389#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:filehandle-fd-after-closehttps://github.com/addaleax/node/tree/filehandle-fd-after-close
Conversation 3 https://github.com/nodejs/node/pull/31389
Commits 1 https://github.com/nodejs/node/pull/31389/commits
Checks 0 https://github.com/nodejs/node/pull/31389/checks
Files changed https://github.com/nodejs/node/pull/31389/files
Please reload this pagehttps://github.com/nodejs/node/pull/31389
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 16, 2020https://github.com/nodejs/node/pull/31389#issue-551057722
#31361https://github.com/nodejs/node/issues/31361
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/31389
https://github.com/addaleax
fs: unset FileHandle fd after closehttps://github.com/nodejs/node/pull/31389/commits/707d6fcac5a9f8dee3db46d5a5c91ebc1213bc76
707d6fchttps://github.com/nodejs/node/pull/31389/commits/707d6fcac5a9f8dee3db46d5a5c91ebc1213bc76
nodejs#31361https://github.com/nodejs/node/issues/31361
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Jan 16, 2020https://github.com/nodejs/node/pull/31389#event-2956086680
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jan 16, 2020 https://github.com/nodejs/node/pull/31389#pullrequestreview-344222360
View reviewed changes https://github.com/nodejs/node/pull/31389/files/707d6fcac5a9f8dee3db46d5a5c91ebc1213bc76
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 16, 2020 https://github.com/nodejs/node/pull/31389#pullrequestreview-344288681
View reviewed changes https://github.com/nodejs/node/pull/31389/files/707d6fcac5a9f8dee3db46d5a5c91ebc1213bc76
https://github.com/JungMinu
JungMinuhttps://github.com/JungMinu
Jan 17, 2020 https://github.com/nodejs/node/pull/31389#pullrequestreview-344347580
View reviewed changes https://github.com/nodejs/node/pull/31389/files/707d6fcac5a9f8dee3db46d5a5c91ebc1213bc76
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Jan 17, 2020 https://github.com/nodejs/node/pull/31389#pullrequestreview-344417616
View reviewed changes https://github.com/nodejs/node/pull/31389/files/707d6fcac5a9f8dee3db46d5a5c91ebc1213bc76
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 17, 2020https://github.com/nodejs/node/pull/31389#issuecomment-575722475
https://ci.nodejs.org/job/node-test-pull-request/28465/https://ci.nodejs.org/job/node-test-pull-request/28465/
Please reload this pagehttps://github.com/nodejs/node/pull/31389
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 17, 2020https://github.com/nodejs/node/pull/31389#event-2959770999
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 17, 2020https://github.com/nodejs/node/pull/31389#issuecomment-575832517
https://ci.nodejs.org/job/node-test-pull-request/28468/https://ci.nodejs.org/job/node-test-pull-request/28468/
Please reload this pagehttps://github.com/nodejs/node/pull/31389
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 18, 2020 https://github.com/nodejs/node/pull/31389#pullrequestreview-344943927
View reviewed changes https://github.com/nodejs/node/pull/31389/files/707d6fcac5a9f8dee3db46d5a5c91ebc1213bc76
addaleaxhttps://github.com/addaleax
Jan 18, 2020 https://github.com/nodejs/node/pull/31389#ref-commit-7864c53
https://github.com/addaleax
fs: unset FileHandle fd after closehttps://github.com/nodejs/node/commit/7864c53629b11d69746a4fc1f041900eeb358d31
7864c53https://github.com/nodejs/node/commit/7864c53629b11d69746a4fc1f041900eeb358d31
#31361https://github.com/nodejs/node/issues/31361
#31389https://github.com/nodejs/node/pull/31389
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 18, 2020https://github.com/nodejs/node/pull/31389#issuecomment-575940106
7864c53https://github.com/nodejs/node/commit/7864c53629b11d69746a4fc1f041900eeb358d31
Please reload this pagehttps://github.com/nodejs/node/pull/31389
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 18, 2020https://github.com/nodejs/node/pull/31389#event-2960474507
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
January 18, 2020 21:32https://github.com/nodejs/node/pull/31389#event-2960475413
codebyterehttps://github.com/codebytere
Feb 17, 2020 https://github.com/nodejs/node/pull/31389#ref-commit-32ac1be
https://github.com/addaleax
https://github.com/codebytere
fs: unset FileHandle fd after closehttps://github.com/nodejs/node/commit/32ac1be372b7299316bc6e60a83edd4effbc33fa
32ac1behttps://github.com/nodejs/node/commit/32ac1be372b7299316bc6e60a83edd4effbc33fa
#31361https://github.com/nodejs/node/issues/31361
#31389https://github.com/nodejs/node/pull/31389
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Feb 17, 2020 https://github.com/nodejs/node/pull/31389#ref-pullrequest-566518355
v13.9.0 proposal #31837 https://github.com/nodejs/node/pull/31837
codebyterehttps://github.com/codebytere
Mar 14, 2020 https://github.com/nodejs/node/pull/31389#ref-commit-36b79cd
https://github.com/addaleax
https://github.com/codebytere
fs: unset FileHandle fd after closehttps://github.com/nodejs/node/commit/36b79cdac61996b5e4a5d1d5d013051ad5eee545
36b79cdhttps://github.com/nodejs/node/commit/36b79cdac61996b5e4a5d1d5d013051ad5eee545
#31361https://github.com/nodejs/node/issues/31361
#31389https://github.com/nodejs/node/pull/31389
codebyterehttps://github.com/codebytere
Mar 17, 2020 https://github.com/nodejs/node/pull/31389#ref-commit-ca951e1
https://github.com/addaleax
https://github.com/codebytere
fs: unset FileHandle fd after closehttps://github.com/nodejs/node/commit/ca951e182ec6329d029f4ddb1efaeaf8383d5be4
ca951e1https://github.com/nodejs/node/commit/ca951e182ec6329d029f4ddb1efaeaf8383d5be4
#31361https://github.com/nodejs/node/issues/31361
#31389https://github.com/nodejs/node/pull/31389
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Mar 17, 2020 https://github.com/nodejs/node/pull/31389#ref-pullrequest-582721275
v12.16.2 proposal #32313 https://github.com/nodejs/node/pull/32313
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31389
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/31389/files/707d6fcac5a9f8dee3db46d5a5c91ebc1213bc76
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/31389/files/707d6fcac5a9f8dee3db46d5a5c91ebc1213bc76
https://github.com/JungMinu
JungMinu https://github.com/JungMinu
https://github.com/nodejs/node/pull/31389/files/707d6fcac5a9f8dee3db46d5a5c91ebc1213bc76
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/31389/files/707d6fcac5a9f8dee3db46d5a5c91ebc1213bc76
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/31389/files/707d6fcac5a9f8dee3db46d5a5c91ebc1213bc76
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
fs: async fstat after close does not cause EBADF https://github.com/nodejs/node/issues/31361
Please reload this pagehttps://github.com/nodejs/node/pull/31389
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/cjihrig
https://github.com/devnexen
https://github.com/JungMinu
https://github.com/richardlau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.