| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4565e5e5-4994-fd89-3427-ab3ad257e8e0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 86D2:D7362:226F1D8:2D92034:696B19A7 |
| html-safe-nonce | d880aab8a31fef35819c227b6d6005580c1badc105aa0c211b6db6a841ed7d34 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkQyOkQ3MzYyOjIyNkYxRDg6MkQ5MjAzNDo2OTZCMTlBNyIsInZpc2l0b3JfaWQiOiIzOTM2Njk1ODM2MTk5Mjk1Mzk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | bf6e2194bd91269c3a76dd5ea48e97e8e608b94b84b4908504b908682412074b |
| hovercard-subject-tag | pull_request:363811254 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31385/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/935e8aa018d683c34d23648a6ae86a4d71e0359fc48baf04f785e4b52f5c850f/nodejs/node/pull/31385 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/935e8aa018d683c34d23648a6ae86a4d71e0359fc48baf04f785e4b52f5c850f/nodejs/node/pull/31385 |
| og:image:alt | Declaring and initializing a struct text_region is common to all
three implementations of the large pages mapping code. Let's make it
unconditional.
Checklist
make -j4 test (UNIX), or vcbui... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabrielschulhof |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/31385#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31385 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31385 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/31385 |
| Reload | https://github.com/nodejs/node/pull/31385 |
| Reload | https://github.com/nodejs/node/pull/31385 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/31385 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
691
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/31385 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/31385#issue-comment-box |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gabrielschulhof:reduce-large-pages-duplication | https://github.com/gabrielschulhof/node/tree/reduce-large-pages-duplication |
|
src: reduce large pages code duplication
| https://github.com/nodejs/node/pull/31385#top |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gabrielschulhof:reduce-large-pages-duplication | https://github.com/gabrielschulhof/node/tree/reduce-large-pages-duplication |
|
Conversation
2
| https://github.com/nodejs/node/pull/31385 |
|
Commits
1
| https://github.com/nodejs/node/pull/31385/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/31385/checks |
|
Files changed
| https://github.com/nodejs/node/pull/31385/files |
| Please reload this page | https://github.com/nodejs/node/pull/31385 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jan 16, 2020 | https://github.com/nodejs/node/pull/31385#issue-551012546 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/31385 |
| src: reduce large pages code duplication | https://github.com/nodejs/node/pull/31385/commits/745087f75fc04f304ec8602a1f1cfa737c08625e |
| 745087f | https://github.com/nodejs/node/pull/31385/commits/745087f75fc04f304ec8602a1f1cfa737c08625e |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Jan 16, 2020 | https://github.com/nodejs/node/pull/31385#event-2955810545 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| bnoordhuis | https://github.com/bnoordhuis |
| devnexen | https://github.com/devnexen |
| January 16, 2020 19:38 | https://github.com/nodejs/node/pull/31385#event-2955810886 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jan 16, 2020
| https://github.com/nodejs/node/pull/31385#pullrequestreview-344170040 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
|
Jan 16, 2020
| https://github.com/nodejs/node/pull/31385#pullrequestreview-344176322 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jan 16, 2020
| https://github.com/nodejs/node/pull/31385#pullrequestreview-344237882 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 16, 2020
| https://github.com/nodejs/node/pull/31385#pullrequestreview-344240302 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jan 16, 2020
| https://github.com/nodejs/node/pull/31385#pullrequestreview-344289705 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Jan 17, 2020
| https://github.com/nodejs/node/pull/31385#pullrequestreview-344302574 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Jan 17, 2020
| https://github.com/nodejs/node/pull/31385#pullrequestreview-344337611 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
|
Jan 17, 2020
| https://github.com/nodejs/node/pull/31385#pullrequestreview-344339659 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
| https://github.com/JungMinu |
| JungMinu | https://github.com/JungMinu |
|
Jan 17, 2020
| https://github.com/nodejs/node/pull/31385#pullrequestreview-344347818 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jan 18, 2020
| https://github.com/nodejs/node/pull/31385#pullrequestreview-344944200 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jan 18, 2020
| https://github.com/nodejs/node/pull/31385#pullrequestreview-344957497 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 18, 2020 | https://github.com/nodejs/node/pull/31385#issuecomment-575948827 |
| https://ci.nodejs.org/job/node-test-pull-request/28478/ | https://ci.nodejs.org/job/node-test-pull-request/28478/ |
| Please reload this page | https://github.com/nodejs/node/pull/31385 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jan 19, 2020
| https://github.com/nodejs/node/pull/31385#ref-commit-85592e2 |
| src: reduce large pages code duplication | https://github.com/nodejs/node/commit/85592e281802f82c8e4b211a8e280b481fd65388 |
| 85592e2 | https://github.com/nodejs/node/commit/85592e281802f82c8e4b211a8e280b481fd65388 |
| #31385 | https://github.com/nodejs/node/pull/31385 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jan 19, 2020 | https://github.com/nodejs/node/pull/31385#issuecomment-576022810 |
| 85592e2 | https://github.com/nodejs/node/commit/85592e281802f82c8e4b211a8e280b481fd65388 |
| Please reload this page | https://github.com/nodejs/node/pull/31385 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jan 19, 2020 | https://github.com/nodejs/node/pull/31385#event-2961005351 |
| codebytere | https://github.com/codebytere |
|
Feb 17, 2020
| https://github.com/nodejs/node/pull/31385#ref-commit-b8face2 |
|
| https://github.com/codebytere |
| src: reduce large pages code duplication | https://github.com/nodejs/node/commit/b8face28e79cab9c3324147178ee2250d471d493 |
| b8face2 | https://github.com/nodejs/node/commit/b8face28e79cab9c3324147178ee2250d471d493 |
| #31385 | https://github.com/nodejs/node/pull/31385 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Feb 17, 2020
| https://github.com/nodejs/node/pull/31385#ref-pullrequest-566518355 |
|
v13.9.0 proposal
#31837
| https://github.com/nodejs/node/pull/31837 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| February 21, 2020 16:39 | https://github.com/nodejs/node/pull/31385#event-3061147488 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Mar 6, 2020
| https://github.com/nodejs/node/pull/31385#ref-commit-2693510 |
| src: reduce large pages code duplication | https://github.com/gabrielschulhof/node/commit/269351021e9759d2065e5134fb54be7250b33584 |
| 2693510 | https://github.com/gabrielschulhof/node/commit/269351021e9759d2065e5134fb54be7250b33584 |
| nodejs#31385 | https://github.com/nodejs/node/pull/31385 |
| codebytere | https://github.com/codebytere |
|
Mar 14, 2020
| https://github.com/nodejs/node/pull/31385#ref-commit-4b67bb1 |
|
| https://github.com/codebytere |
| src: reduce large pages code duplication | https://github.com/nodejs/node/commit/4b67bb14601c2d9a76d034c2336a242f51ee717b |
| 4b67bb1 | https://github.com/nodejs/node/commit/4b67bb14601c2d9a76d034c2336a242f51ee717b |
| #31385 | https://github.com/nodejs/node/pull/31385 |
| codebytere | https://github.com/codebytere |
|
Mar 17, 2020
| https://github.com/nodejs/node/pull/31385#ref-commit-8f88d62 |
|
| https://github.com/codebytere |
| src: reduce large pages code duplication | https://github.com/nodejs/node/commit/8f88d62a31f39e195a21a8cc6630cfacbfe99905 |
| 8f88d62 | https://github.com/nodejs/node/commit/8f88d62a31f39e195a21a8cc6630cfacbfe99905 |
| #31385 | https://github.com/nodejs/node/pull/31385 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Mar 17, 2020
| https://github.com/nodejs/node/pull/31385#ref-pullrequest-582721275 |
|
v12.16.2 proposal
#32313
| https://github.com/nodejs/node/pull/32313 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31385 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
|
| https://github.com/gengjiawen |
|
gengjiawen
| https://github.com/gengjiawen |
|
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
|
| https://github.com/JungMinu |
|
JungMinu
| https://github.com/JungMinu |
|
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
|
| https://github.com/devnexen |
|
devnexen
| https://github.com/devnexen |
|
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/nodejs/node/pull/31385/files/745087f75fc04f304ec8602a1f1cfa737c08625e |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Please reload this page | https://github.com/nodejs/node/pull/31385 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/bnoordhuis |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/tniessen |
|
| https://github.com/gengjiawen |
|
| https://github.com/devnexen |
|
| https://github.com/JungMinu |
|
| https://github.com/richardlau |
|
| https://github.com/devsnek |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |