René's URL Explorer Experiment


Title: benchmark: add default type in getstringwidth.js by Trott · Pull Request #31377 · nodejs/node · GitHub

Open Graph Title: benchmark: add default type in getstringwidth.js by Trott · Pull Request #31377 · nodejs/node

X Title: benchmark: add default type in getstringwidth.js by Trott · Pull Request #31377 · nodejs/node

Description: This fixes a benchmark test that was recently broken by a breaking change on the master branch. Fixes: #31372 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message fo...

Open Graph Description: This fixes a benchmark test that was recently broken by a breaking change on the master branch. Fixes: #31372 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message fo...

X Description: This fixes a benchmark test that was recently broken by a breaking change on the master branch. Fixes: #31372 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message fo...

Opengraph URL: https://github.com/nodejs/node/pull/31377

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8f3af7ae-bf3e-30fa-4b18-204222726dc5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBCAA:37ADE8:281C858:34E83CC:696B27B7
html-safe-nonceb6e7794a26c3273bcc5851ff888d6889c98b75c1bbeacdadb7cb76388fe7dbf2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0FBOjM3QURFODoyODFDODU4OjM0RTgzQ0M6Njk2QjI3QjciLCJ2aXNpdG9yX2lkIjoiODE0NjE4MTM1NTg4NDcxODAwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac42c4ea7a3dc468df43c55bbd644fe216b00aeda05790e264310edab7103689fe
hovercard-subject-tagpull_request:363402217
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31377/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dec8c5f121a8d7810d945a705a2ac392cf6db6cc3bbdd286c29350dcf944ed49/nodejs/node/pull/31377
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dec8c5f121a8d7810d945a705a2ac392cf6db6cc3bbdd286c29350dcf944ed49/nodejs/node/pull/31377
og:image:altThis fixes a benchmark test that was recently broken by a breaking change on the master branch. Fixes: #31372 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message fo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31377#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31377
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31377
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31377
Reloadhttps://github.com/nodejs/node/pull/31377
Reloadhttps://github.com/nodejs/node/pull/31377
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/31377
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/31377
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/31377#issue-comment-box
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:fix-getstringwidthhttps://github.com/Trott/io.js/tree/fix-getstringwidth
benchmark: add default type in getstringwidth.js https://github.com/nodejs/node/pull/31377#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:fix-getstringwidthhttps://github.com/Trott/io.js/tree/fix-getstringwidth
Conversation 6 https://github.com/nodejs/node/pull/31377
Commits 0 https://github.com/nodejs/node/pull/31377/commits
Checks 0 https://github.com/nodejs/node/pull/31377/checks
Files changed https://github.com/nodejs/node/pull/31377/files
Please reload this pagehttps://github.com/nodejs/node/pull/31377
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 16, 2020https://github.com/nodejs/node/pull/31377#issue-550507119
#31372https://github.com/nodejs/node/issues/31372
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/31377
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
benchmark https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark
Jan 16, 2020https://github.com/nodejs/node/pull/31377#event-2952795497
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 16, 2020 https://github.com/nodejs/node/pull/31377#ref-issue-550275630
Investigate flaky test-benchmark-misc #31372 https://github.com/nodejs/node/issues/31372
https://github.com/Trott
Trotthttps://github.com/Trott
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Jan 16, 2020https://github.com/nodejs/node/pull/31377#event-2952796539
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 16, 2020https://github.com/nodejs/node/pull/31377#issuecomment-574924374
Please reload this pagehttps://github.com/nodejs/node/pull/31377
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 16, 2020https://github.com/nodejs/node/pull/31377#issuecomment-574924451
@BridgeARhttps://github.com/BridgeAR
@sam-githubhttps://github.com/sam-github
@AshCrippshttps://github.com/AshCripps
Please reload this pagehttps://github.com/nodejs/node/pull/31377
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 16, 2020 https://github.com/nodejs/node/pull/31377#pullrequestreview-343612953
View reviewed changes https://github.com/nodejs/node/pull/31377/files
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 16, 2020https://github.com/nodejs/node/pull/31377#issuecomment-574925100
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/11595/https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/11595/
Please reload this pagehttps://github.com/nodejs/node/pull/31377
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jan 16, 2020 https://github.com/nodejs/node/pull/31377#pullrequestreview-343615197
View reviewed changes https://github.com/nodejs/node/pull/31377/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 16, 2020 https://github.com/nodejs/node/pull/31377#pullrequestreview-343615609
View reviewed changes https://github.com/nodejs/node/pull/31377/files
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jan 16, 2020https://github.com/nodejs/node/pull/31377#issuecomment-574942146
Please reload this pagehttps://github.com/nodejs/node/pull/31377
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jan 16, 2020 https://github.com/nodejs/node/pull/31377#pullrequestreview-343659828
View reviewed changes https://github.com/nodejs/node/pull/31377/files
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 16, 2020https://github.com/nodejs/node/pull/31377#issuecomment-574996973
Investigate flaky test-benchmark-misc  #31372 (comment)https://github.com/nodejs/node/issues/31372#issuecomment-574924704
Please reload this pagehttps://github.com/nodejs/node/pull/31377
https://github.com/Trott
Trotthttps://github.com/Trott
d2683edhttps://github.com/nodejs/node/commit/d2683ede836d3f2449714c6309b47fb469873bb2
Jan 16, 2020https://github.com/nodejs/node/pull/31377#event-2953282008
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/3c7c34049f16bbfd80aac3ca7b0ef59581342225..d2683ede836d3f2449714c6309b47fb469873bb2
3c7c340https://github.com/nodejs/node/commit/3c7c34049f16bbfd80aac3ca7b0ef59581342225
d2683edhttps://github.com/nodejs/node/commit/d2683ede836d3f2449714c6309b47fb469873bb2
Compare https://github.com/nodejs/node/compare/3c7c34049f16bbfd80aac3ca7b0ef59581342225..d2683ede836d3f2449714c6309b47fb469873bb2
January 16, 2020 06:00https://github.com/nodejs/node/pull/31377#event-2953282020
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 16, 2020https://github.com/nodejs/node/pull/31377#issuecomment-574997358
d2683edhttps://github.com/nodejs/node/commit/d2683ede836d3f2449714c6309b47fb469873bb2
Please reload this pagehttps://github.com/nodejs/node/pull/31377
https://github.com/Trott
Trotthttps://github.com/Trott
January 16, 2020 06:00https://github.com/nodejs/node/pull/31377#event-2953282173
MylesBorinshttps://github.com/MylesBorins
Jan 16, 2020 https://github.com/nodejs/node/pull/31377#ref-commit-6e978f7
https://github.com/Trott
https://github.com/MylesBorins
benchmark: add default type in getstringwidth.jshttps://github.com/nodejs/node/commit/6e978f7d73d9c80da88f0d69739239b59d768b89
6e978f7https://github.com/nodejs/node/commit/6e978f7d73d9c80da88f0d69739239b59d768b89
#31372https://github.com/nodejs/node/issues/31372
#31377https://github.com/nodejs/node/pull/31377
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jan 16, 2020 https://github.com/nodejs/node/pull/31377#ref-pullrequest-550944823
v13.7.0 proposal #31382 https://github.com/nodejs/node/pull/31382
codebyterehttps://github.com/codebytere
Mar 14, 2020 https://github.com/nodejs/node/pull/31377#ref-commit-c7c0dfe
https://github.com/Trott
https://github.com/codebytere
benchmark: add default type in getstringwidth.jshttps://github.com/nodejs/node/commit/c7c0dfe238eac6cbe98d303bf1f1e9fb1ed244fe
c7c0dfehttps://github.com/nodejs/node/commit/c7c0dfe238eac6cbe98d303bf1f1e9fb1ed244fe
#31372https://github.com/nodejs/node/issues/31372
#31377https://github.com/nodejs/node/pull/31377
codebyterehttps://github.com/codebytere
Mar 17, 2020 https://github.com/nodejs/node/pull/31377#ref-commit-267a01f
https://github.com/Trott
https://github.com/codebytere
benchmark: add default type in getstringwidth.jshttps://github.com/nodejs/node/commit/267a01f4ebe20bb3b1262e9ec839292af93c942d
267a01fhttps://github.com/nodejs/node/commit/267a01f4ebe20bb3b1262e9ec839292af93c942d
#31372https://github.com/nodejs/node/issues/31372
#31377https://github.com/nodejs/node/pull/31377
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Mar 17, 2020 https://github.com/nodejs/node/pull/31377#ref-pullrequest-582721275
v12.16.2 proposal #32313 https://github.com/nodejs/node/pull/32313
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31377
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/31377/files/3c7c34049f16bbfd80aac3ca7b0ef59581342225
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/31377/files/3c7c34049f16bbfd80aac3ca7b0ef59581342225
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/31377/files/3c7c34049f16bbfd80aac3ca7b0ef59581342225
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/31377/files/3c7c34049f16bbfd80aac3ca7b0ef59581342225
benchmark https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Investigate flaky test-benchmark-misc https://github.com/nodejs/node/issues/31372
Please reload this pagehttps://github.com/nodejs/node/pull/31377
https://github.com/Trott
https://github.com/mscdex
https://github.com/sam-github
https://github.com/cjihrig
https://github.com/richardlau
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.