René's URL Explorer Experiment


Title: src: fix performance regression in node_file.cc by bnoordhuis · Pull Request #31343 · nodejs/node · GitHub

Open Graph Title: src: fix performance regression in node_file.cc by bnoordhuis · Pull Request #31343 · nodejs/node

X Title: src: fix performance regression in node_file.cc by bnoordhuis · Pull Request #31343 · nodejs/node

Description: Commits dcb6929, 4396beb and 8a96d05 turned the O(n) scan in InternalModuleReadJSON() into an O(4n) scan. Fix the performance regression by turning that into a linear scan again.

Open Graph Description: Commits dcb6929, 4396beb and 8a96d05 turned the O(n) scan in InternalModuleReadJSON() into an O(4n) scan. Fix the performance regression by turning that into a linear scan again.

X Description: Commits dcb6929, 4396beb and 8a96d05 turned the O(n) scan in InternalModuleReadJSON() into an O(4n) scan. Fix the performance regression by turning that into a linear scan again.

Opengraph URL: https://github.com/nodejs/node/pull/31343

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9b2583ca-b3b9-6fbf-b70b-b8d2d85288db
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAAFE:231D79:2948DB6:36448F1:696B2B72
html-safe-nonce34aaf83b4d1f648205d0c01c2aad501c6107d2e8814291e2ec2ae4f376580d2a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUZFOjIzMUQ3OToyOTQ4REI2OjM2NDQ4RjE6Njk2QjJCNzIiLCJ2aXNpdG9yX2lkIjoiNzAzMTc5Nzg2Njk3NTQwNjk2MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacba0081b4f6a44a426cd88c828f5df09f693d35cdf389de81aa371e429a63990b
hovercard-subject-tagpull_request:362115901
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31343/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/adbac52f35aae031f7f0826d6e2536ee3d57d286ee6b4d3eeedfe78330e7be39/nodejs/node/pull/31343
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/adbac52f35aae031f7f0826d6e2536ee3d57d286ee6b4d3eeedfe78330e7be39/nodejs/node/pull/31343
og:image:altCommits dcb6929, 4396beb and 8a96d05 turned the O(n) scan in InternalModuleReadJSON() into an O(4n) scan. Fix the performance regression by turning that into a linear scan again.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31343#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31343
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31343
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31343
Reloadhttps://github.com/nodejs/node/pull/31343
Reloadhttps://github.com/nodejs/node/pull/31343
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/31343
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/31343
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/31343#issue-comment-box
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix31340https://github.com/bnoordhuis/io.js/tree/fix31340
src: fix performance regression in node_file.cc https://github.com/nodejs/node/pull/31343#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix31340https://github.com/bnoordhuis/io.js/tree/fix31340
Conversation 12 https://github.com/nodejs/node/pull/31343
Commits 1 https://github.com/nodejs/node/pull/31343/commits
Checks 0 https://github.com/nodejs/node/pull/31343/checks
Files changed https://github.com/nodejs/node/pull/31343/files
Please reload this pagehttps://github.com/nodejs/node/pull/31343
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 13, 2020https://github.com/nodejs/node/pull/31343#issue-548928207
dcb6929https://github.com/nodejs/node/commit/dcb692918348986945cbd4fbce8158b2b97a8418
4396bebhttps://github.com/nodejs/node/commit/4396bebfe1fc024ff6badf2ead40f1b5127d4e67
8a96d05https://github.com/nodejs/node/commit/8a96d05ec7f0c9ef5b8a47ae0a6eac45b475320d
Please reload this pagehttps://github.com/nodejs/node/pull/31343
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Jan 13, 2020https://github.com/nodejs/node/pull/31343#event-2943158691
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 13, 2020https://github.com/nodejs/node/pull/31343#issuecomment-573662304
https://ci.nodejs.org/job/node-test-pull-request/28431/https://ci.nodejs.org/job/node-test-pull-request/28431/
Please reload this pagehttps://github.com/nodejs/node/pull/31343
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 13, 2020 https://github.com/nodejs/node/pull/31343#pullrequestreview-341870153
View reviewed changes https://github.com/nodejs/node/pull/31343/files
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jan 13, 2020 https://github.com/nodejs/node/pull/31343#pullrequestreview-341882781
View reviewed changes https://github.com/nodejs/node/pull/31343/files
guybedfordhttps://github.com/guybedford
https://github.com/nodejs/node/pull/31343#pullrequestreview-341882781
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31343
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Jan 13, 2020 https://github.com/nodejs/node/pull/31343#pullrequestreview-341933126
View reviewed changes https://github.com/nodejs/node/pull/31343/files
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jan 13, 2020 https://github.com/nodejs/node/pull/31343#pullrequestreview-342017695
View reviewed changes https://github.com/nodejs/node/pull/31343/files
src/node_file.cchttps://github.com/nodejs/node/pull/31343/files#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6
devsnekhttps://github.com/devsnek
Jan 13, 2020https://github.com/nodejs/node/pull/31343#discussion_r365934748
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31343
bnoordhuishttps://github.com/bnoordhuis
Jan 14, 2020https://github.com/nodejs/node/pull/31343#discussion_r366270160
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31343
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 13, 2020 https://github.com/nodejs/node/pull/31343#pullrequestreview-342025397
View reviewed changes https://github.com/nodejs/node/pull/31343/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/31343#pullrequestreview-342025397
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31343
https://github.com/ryanmurakami
ryanmurakamihttps://github.com/ryanmurakami
Jan 13, 2020 https://github.com/nodejs/node/pull/31343#pullrequestreview-342182920
View reviewed changes https://github.com/nodejs/node/pull/31343/files
ryanmurakamihttps://github.com/ryanmurakami
https://github.com/nodejs/node/pull/31343#pullrequestreview-342182920
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/31343
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 14, 2020https://github.com/nodejs/node/pull/31343#event-2946496002
https://github.com/bnoordhuis
src: make InternalModuleReadJSON() linear againhttps://github.com/nodejs/node/pull/31343/commits/da6b66a14d4b2d5a577fd8b4141cd1bd0468e0b0
da6b66ahttps://github.com/nodejs/node/pull/31343/commits/da6b66a14d4b2d5a577fd8b4141cd1bd0468e0b0
dcb6929https://github.com/bnoordhuis/io.js/commit/dcb692918348986945cbd4fbce8158b2b97a8418
4396bebhttps://github.com/bnoordhuis/io.js/commit/4396bebfe1fc024ff6badf2ead40f1b5127d4e67
8a96d05https://github.com/bnoordhuis/io.js/commit/8a96d05ec7f0c9ef5b8a47ae0a6eac45b475320d
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/e8ed86bf84498ddac7931ef9a763b6c6eaefc5b2..da6b66a14d4b2d5a577fd8b4141cd1bd0468e0b0
e8ed86bhttps://github.com/nodejs/node/commit/e8ed86bf84498ddac7931ef9a763b6c6eaefc5b2
da6b66ahttps://github.com/nodejs/node/commit/da6b66a14d4b2d5a577fd8b4141cd1bd0468e0b0
Compare https://github.com/nodejs/node/compare/e8ed86bf84498ddac7931ef9a763b6c6eaefc5b2..da6b66a14d4b2d5a577fd8b4141cd1bd0468e0b0
January 14, 2020 10:49https://github.com/nodejs/node/pull/31343#event-2946568270
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
ryanmurakamihttps://github.com/ryanmurakami
stale reviewhttps://github.com/nodejs/node/pull/31343#pullrequestreview-342182920
January 14, 2020 10:49https://github.com/nodejs/node/pull/31343#event-2946568635
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 14, 2020https://github.com/nodejs/node/pull/31343#issuecomment-574116884
Please reload this pagehttps://github.com/nodejs/node/pull/31343
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 15, 2020https://github.com/nodejs/node/pull/31343#issuecomment-574518720
Please reload this pagehttps://github.com/nodejs/node/pull/31343
Please reload this pagehttps://github.com/nodejs/node/pull/31343
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 15, 2020 https://github.com/nodejs/node/pull/31343#pullrequestreview-343012858
View reviewed changes https://github.com/nodejs/node/pull/31343/files/da6b66a14d4b2d5a577fd8b4141cd1bd0468e0b0
https://github.com/hybrist
hybristhttps://github.com/hybrist
Jan 15, 2020 https://github.com/nodejs/node/pull/31343#pullrequestreview-343265692
View reviewed changes https://github.com/nodejs/node/pull/31343/files/da6b66a14d4b2d5a577fd8b4141cd1bd0468e0b0
hybristhttps://github.com/hybrist
https://github.com/nodejs/node/pull/31343#pullrequestreview-343265692
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31343
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31343
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 15, 2020https://github.com/nodejs/node/pull/31343#issuecomment-574859688
https://ci.nodejs.org/job/node-test-pull-request/28447/https://ci.nodejs.org/job/node-test-pull-request/28447/
Please reload this pagehttps://github.com/nodejs/node/pull/31343
Trotthttps://github.com/Trott
Jan 15, 2020 https://github.com/nodejs/node/pull/31343#ref-commit-6623481
https://github.com/bnoordhuis
https://github.com/Trott
src: fix performance regression in node_file.cchttps://github.com/nodejs/node/commit/662348113828891bf7d6f15e9881f163b782a90a
6623481https://github.com/nodejs/node/commit/662348113828891bf7d6f15e9881f163b782a90a
dcb6929https://github.com/nodejs/node/commit/dcb692918348986945cbd4fbce8158b2b97a8418
4396bebhttps://github.com/nodejs/node/commit/4396bebfe1fc024ff6badf2ead40f1b5127d4e67
8a96d05https://github.com/nodejs/node/commit/8a96d05ec7f0c9ef5b8a47ae0a6eac45b475320d
#31343https://github.com/nodejs/node/pull/31343
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 15, 2020https://github.com/nodejs/node/pull/31343#issuecomment-574870795
6623481https://github.com/nodejs/node/commit/662348113828891bf7d6f15e9881f163b782a90a
Please reload this pagehttps://github.com/nodejs/node/pull/31343
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 15, 2020https://github.com/nodejs/node/pull/31343#event-2952429049
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Jan 15, 2020 https://github.com/nodejs/node/pull/31343#ref-issue-548903463
src: fix performance regression in node_file.cc #31340 https://github.com/nodejs/node/issues/31340
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Jan 15, 2020https://github.com/nodejs/node/pull/31343#event-2952561406
MylesBorinshttps://github.com/MylesBorins
Jan 16, 2020 https://github.com/nodejs/node/pull/31343#ref-commit-83f7b5a
https://github.com/bnoordhuis
https://github.com/MylesBorins
src: fix performance regression in node_file.cchttps://github.com/nodejs/node/commit/83f7b5a8a9d0cf8bf3f2cd006275f39d3d3329b8
83f7b5ahttps://github.com/nodejs/node/commit/83f7b5a8a9d0cf8bf3f2cd006275f39d3d3329b8
dcb6929https://github.com/nodejs/node/commit/dcb692918348986945cbd4fbce8158b2b97a8418
4396bebhttps://github.com/nodejs/node/commit/4396bebfe1fc024ff6badf2ead40f1b5127d4e67
8a96d05https://github.com/nodejs/node/commit/8a96d05ec7f0c9ef5b8a47ae0a6eac45b475320d
#31343https://github.com/nodejs/node/pull/31343
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jan 16, 2020 https://github.com/nodejs/node/pull/31343#ref-pullrequest-550944823
v13.7.0 proposal #31382 https://github.com/nodejs/node/pull/31382
codebyterehttps://github.com/codebytere
Mar 14, 2020 https://github.com/nodejs/node/pull/31343#ref-commit-23a5339
https://github.com/bnoordhuis
https://github.com/codebytere
src: fix performance regression in node_file.cchttps://github.com/nodejs/node/commit/23a53394966a26001181fbb91f4e961b8752cedc
23a5339https://github.com/nodejs/node/commit/23a53394966a26001181fbb91f4e961b8752cedc
dcb6929https://github.com/nodejs/node/commit/dcb692918348986945cbd4fbce8158b2b97a8418
4396bebhttps://github.com/nodejs/node/commit/4396bebfe1fc024ff6badf2ead40f1b5127d4e67
8a96d05https://github.com/nodejs/node/commit/8a96d05ec7f0c9ef5b8a47ae0a6eac45b475320d
#31343https://github.com/nodejs/node/pull/31343
codebyterehttps://github.com/codebytere
Mar 17, 2020 https://github.com/nodejs/node/pull/31343#ref-commit-a2f1825
https://github.com/bnoordhuis
https://github.com/codebytere
src: fix performance regression in node_file.cchttps://github.com/nodejs/node/commit/a2f1825cb56e9414addfaf346a8fee541292a709
a2f1825https://github.com/nodejs/node/commit/a2f1825cb56e9414addfaf346a8fee541292a709
dcb6929https://github.com/nodejs/node/commit/dcb692918348986945cbd4fbce8158b2b97a8418
4396bebhttps://github.com/nodejs/node/commit/4396bebfe1fc024ff6badf2ead40f1b5127d4e67
8a96d05https://github.com/nodejs/node/commit/8a96d05ec7f0c9ef5b8a47ae0a6eac45b475320d
#31343https://github.com/nodejs/node/pull/31343
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Mar 17, 2020 https://github.com/nodejs/node/pull/31343#ref-pullrequest-582721275
v12.16.2 proposal #32313 https://github.com/nodejs/node/pull/32313
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31343
https://github.com/hybrist
hybrist https://github.com/hybrist
https://github.com/nodejs/node/pull/31343/files/da6b66a14d4b2d5a577fd8b4141cd1bd0468e0b0
https://github.com/guybedford
guybedford https://github.com/guybedford
https://github.com/nodejs/node/pull/31343/files/e8ed86bf84498ddac7931ef9a763b6c6eaefc5b2
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/31343/files/da6b66a14d4b2d5a577fd8b4141cd1bd0468e0b0
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/31343/files/e8ed86bf84498ddac7931ef9a763b6c6eaefc5b2
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/31343/files/e8ed86bf84498ddac7931ef9a763b6c6eaefc5b2
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/31343/files/e8ed86bf84498ddac7931ef9a763b6c6eaefc5b2
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/31343/files/e8ed86bf84498ddac7931ef9a763b6c6eaefc5b2
https://github.com/ryanmurakami
ryanmurakami https://github.com/ryanmurakami
https://github.com/nodejs/node/pull/31343/files/e8ed86bf84498ddac7931ef9a763b6c6eaefc5b2
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Please reload this pagehttps://github.com/nodejs/node/pull/31343
https://github.com/bnoordhuis
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/hybrist
https://github.com/guybedford
https://github.com/ryanmurakami
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/devnexen
https://github.com/devsnek
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.